mstorsjo added a comment.

In D144509#4349051 <https://reviews.llvm.org/D144509#4349051>, @hans wrote:

> In D144509#4347562 <https://reviews.llvm.org/D144509#4347562>, @glandium 
> wrote:
>
>> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c 
>> <https://reviews.llvm.org/rG65429b9af6a2c99d340ab2dcddd41dab201f399c> is 
>> causing problems on Windows compiler-rt for some reason I haven't identified 
>> yet (with cmake 3.25.1). Which suggests for a same version of cmake, this is 
>> actually altering its behavior, which I wouldn't have expected...
>
> It is indeed unfortunate that this seems to come with such a fundamental 
> behavior change. (we already have 
> https://github.com/llvm/llvm-project/issues/62719) Do you have a repro for 
> the issue you're seeing?
>
> Since the breakages are piling up, perhaps it's time to revert this.

Unfortunately, much of this is hard to sort out without actually trying to 
patch forward on main, since many of these issues don't show up easily in e.g. 
premerge testing or similar (the patch has been tried many times for months 
before in that form), so I'd appreciate if we'd give it a little more time to 
actually try to sort out the issues...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to