[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

tschuett added a comment. I don't believe that there is NativeBFloat16Type. AArch64 learned bf16 with ARMv8.6-A, but very limited operations and only in SIMD. X86 supports bf16 since Cooperlake, but very limited operations and only in SIMD. Maybe GPUs? CHANGES SINCE LAST ACTION https://revi

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs added a comment. In D149573#4309378 , @tschuett wrote: > I don't believe that there is NativeBFloat16Type. AArch64 learned bf16 with > ARMv8.6-A, but very limited operations and only in SIMD. X86 supports bf16 > since Cooperlake, but very limite

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

tschuett added a comment. Agreed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 5e74a3d - [clangd][IncludeCleaner] Use a proper comparator for deduplicating findings

Author: Kadir Cetinkaya Date: 2023-05-01T12:19:33+02:00 New Revision: 5e74a3dc2da879d98204f2360e2e33571b93b91b URL: https://github.com/llvm/llvm-project/commit/5e74a3dc2da879d98204f2360e2e33571b93b91b DIFF: https://github.com/llvm/llvm-project/commit/5e74a3dc2da879d98204f2360e2e33571b93b91b.dif

[PATCH] D149165: [clangd] Deduplicate missing-include findings

kadircet added a comment. Thanks @ArturGainullin ! you're right, i've sent out 5e74a3dc2da879d98204f2360e2e33571b93b91b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149165/new

[clang] ea3a870 - Fix the clang sphinx bot

Author: Aaron Ballman Date: 2023-05-01T07:31:03-04:00 New Revision: ea3a8700328050a4dec29904b2c72d53a3be0660 URL: https://github.com/llvm/llvm-project/commit/ea3a8700328050a4dec29904b2c72d53a3be0660 DIFF: https://github.com/llvm/llvm-project/commit/ea3a8700328050a4dec29904b2c72d53a3be0660.diff

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518425. Ris-Bali marked 2 inline comments as done. Ris-Bali added a comment. Removed redundant code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Se

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL added a comment. In D148458#4309010 , @isuckatcs wrote: > Do we really want to split these two functions apart to different test files? > Is this really NFC? Yes, `throw specifier` is removed in C++17, split allows to support C++17 and above i

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added a comment. In D93031#4308764 , @barannikov88 wrote: > @abhina.sreeskantharajan > What is the status of this patch? Hello, I was waiting for the CharSetConverter patch to land. Now that this patch has landed https://reviews.

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

aaron.ballman added a comment. In D142401#4307493 , @cor3ntin wrote: > I don't think this is actually testable, ultimately we may run out of stack > any way, the warning (when emitted) even say so. Okay, that's a fair point and makes my suggestion invali

[PATCH] D149561: [clang-format] Recognize Verilog edge identifiers

MyDeveloperDay added a comment. Could you add anotator tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149561/new/ https://reviews.llvm.org/D149561 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali marked an inline comment as done. Ris-Bali added a comment. I have made the requested changes. Please do let me know if any other changes are required CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 __

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143334/new/ https://reviews.llvm.org/D143334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D146030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147591/new/ https://reviews.llvm.org/D147591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D147621: [clang][Interp] Start handling mutable record members

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147621/new/ https://reviews.llvm.org/D147621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D147840: [clang][Interp] Handle DiscardResult for DeclRef- and ParenExprs

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147840/new/ https://reviews.llvm.org/D147840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148614: [clang][Interp] Add frame depth checking

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148614/new/ https://reviews.llvm.org/D148614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148689/new/ https://reviews.llvm.org/D148689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148690/new/ https://reviews.llvm.org/D148690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D148982: [clang][Interp] Fix ignoring conditional operators

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148982/new/ https://reviews.llvm.org/D148982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D149133: [clang][Interp] BaseToDerived casts

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149133/new/ https://reviews.llvm.org/D149133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149013/new/ https://reviews.llvm.org/D149013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D149149: [clang][Interp] Check one-past-the-end pointers in GetPtrField

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149149/new/ https://reviews.llvm.org/D149149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs added inline comments. Comment at: libcxxabi/test/test_demangle.pass.cpp:10921 {"_ZNK5clang4Type10isRealTypeEv", "clang::Type::isRealType() const"}, -{"_ZNK5clang4Type16isArithmeticTypeEv", "clang::Type::isArithmeticType() const"}, +{"_ZNK5clang4Type16isArit

[PATCH] D142967: [clangd] Introduce source.organizeImports code action.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1035 } + if (KindAllowed(CodeAction::SOURCE_ORGANIZE_IMPORT)) { +std::lock_guard Lock(FixItsMutex); instead of doing this in here, what about introducing a new "tweak

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

yronglin added reviewers: rsmith, rjmccall. yronglin added a comment. Looks good from my side Comment at: clang/lib/Sema/SemaChecking.cpp:7987 + return true; TheCall->setArg(0, FirstArgResult.get()); } Can we add a comments here that we ignored the

[PATCH] D149585: [clang][dataflow] Optimize case of degenerate `do-while` loops.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. In general, the iteration algorit

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

aaron.ballman added a comment. Generally looks good to me, but there were a few minor things. Do you need someone to commit on your behalf once those are addressed? If so, what name and email address would you like used for patch attribution? Comment at: clang/docs/ReleaseNot

[PATCH] D149548: [IR] Update to use new shufflevector semantics

ManuelJBrito updated this revision to Diff 518434. ManuelJBrito added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change is visible in clang in particular in codegen for the vec_promote builtin. It now produces poison instead of undef for the undefined e

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin marked 2 inline comments as done. yronglin added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7651-7652 + Expr *FirstArg = TheCall->getArg(0); + if (auto *CE = dyn_cast(FirstArg)) +FirstArg = CE->getSubExprAsWritten(); rsmith wrot

[PATCH] D145435: [clang-format] Choose style (file) from within code for use in IDEs

MyDeveloperDay added a comment. if we don't plan on fixing the issues please abandon the review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145435/new/ https://reviews.llvm.org/D145435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:347 +IO.enumCase(Value, "false", FormatStyle::FPBS_Leave); +IO.enumCase(Value, "true", FormatStyle::FPBS_Always); + } yes remove these... this is why you need to mark the comme

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:189 + /// Deprecated. Use *getDataflowAnalysisContext().getOptions().Log instead. Logger &logger() const { return *DACtx->getOptions().Log; } xazax.hu

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:4027 + /// is probably for the port on the following line instead of the parenthesis + /// it follows. /// \code This seems an odd corner case Repository: rG LLVM Githu

[PATCH] D149165: [clangd] Deduplicate missing-include findings

ArturGainullin added a comment. In D149165#4309463 , @kadircet wrote: > Thanks @ArturGainullin ! you're right, i've sent out > 5e74a3dc2da879d98204f2360e2e33571b93b91b > . @kadircet T

[PATCH] D149585: [clang][dataflow] Optimize case of degenerate `do-while` loops.

ymandel abandoned this revision. ymandel added a comment. This approach is buggy. Pulling back until I have a proper fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149585/new/ https://reviews.llvm.org/D149585 __

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM. If you don’t have commit access, please say your preferred git author name for the commit, i.e. `Real Name `. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire updated this revision to Diff 518448. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/ https://reviews.llvm.org/D148997 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/TokenKinds.def

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 518450. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Interp

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:211 +void __clang_Interpreter_SetValueNoAlloc(void*,void*,void*,unsigned long long); +template +void __clang_Interpreter_SetValueCopyArr(T* Src

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7985 return true; TheCall->setArg(0, FirstArgResult.get()); } This looks suspicious to me, but I'm no clang expert. Is it safe to ignore casts inserted by checkBuiltinA

[PATCH] D93031: Enable fexec-charset option

barannikov88 added a comment. In D93031#4309546 , @abhina.sreeskantharajan wrote: > In D93031#4308764 , @barannikov88 > wrote: > >> @abhina.sreeskantharajan >> What is the status of this patch? > > Hello, I was wa

[clang] 99fe4d3 - Set EnableAIXExtendedAltivecABI in BackendUtils from LangOpts

Author: Zarko Todorovski Date: 2023-05-01T10:39:14-04:00 New Revision: 99fe4d38266ec2527266d996ac95e20c08f498f1 URL: https://github.com/llvm/llvm-project/commit/99fe4d38266ec2527266d996ac95e20c08f498f1 DIFF: https://github.com/llvm/llvm-project/commit/99fe4d38266ec2527266d996ac95e20c08f498f1.di

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 518458. junaire added a comment. Fix AutoType sugar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/inc

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added inline comments. Comment at: clang/test/Interpreter/pretty-print.cpp:107 +p2 +// CHECK-NEXT: (std::_MakeUniq::__single_object &) std::unique_ptr -> [[Addr:@0x.*]] + junaire wrote: > Hi @mizvekov, do you have a clue about why it doesn't print the co

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs updated this revision to Diff 518468. codemzs added a comment. Herald added subscribers: mstorsjo, mgrang, fedor.sergeev. Fix Clang format failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573 Files: clang-tools-extra/clang-tidy/

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs added a comment. My change to libcxxabi/test/test_demangle.pass.cpp (last file in the change) is one is only one line i.e {"_ZNK5clang4Type16isArithmeticTypeERNS_10ASTContextE", "clang::Type::isArithmeticType(clang::ASTContext&) const"}, but running clang-format on it changes bunch of

[clang] da0089c - [clang] Fix default initializers being ignored when initializing templated aggregate types

Author: Alan Zhao Date: 2023-05-01T09:27:52-07:00 New Revision: da0089c99ba1507b876cf3d2a205ba108aad65ff URL: https://github.com/llvm/llvm-project/commit/da0089c99ba1507b876cf3d2a205ba108aad65ff DIFF: https://github.com/llvm/llvm-project/commit/da0089c99ba1507b876cf3d2a205ba108aad65ff.diff LOG

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda0089c99ba1: [clang] Fix default initializers being ignored when initializing templated… (authored by ayzhao). Repository: rG LLVM Github Monorep

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Ping (moving my pings from Thursday afternoon to Monday mornings) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko added a comment. Friendly ping @arphaman, @jansvoboda11, I have made the patch buildable on all platforms and have all tests passed. There was also a small fix (temp path for modules artefact) at the test that could fix its run on some platforms. Could you look at it? Does it have

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 518479. ayzhao added a comment. rebase + fix merge conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[clang] 9b4faa1 - [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

Author: Alan Zhao Date: 2023-05-01T10:02:15-07:00 New Revision: 9b4faa11c68be4b45ddf29acd575bb52a3c2fad7 URL: https://github.com/llvm/llvm-project/commit/9b4faa11c68be4b45ddf29acd575bb52a3c2fad7 DIFF: https://github.com/llvm/llvm-project/commit/9b4faa11c68be4b45ddf29acd575bb52a3c2fad7.diff LOG

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b4faa11c68b: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate… (authored by ayzhao). Repository: rG LLVM Github Monorepo

[PATCH] D149596: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

amyk created this revision. amyk added reviewers: PowerPC, stefanp, kamaub, nemanjai. amyk added projects: LLVM, PowerPC, clang. Herald added a reviewer: aaron.ballman. Herald added a project: All. amyk requested review of this revision. Herald added a subscriber: cfe-commits. This patch relaxes t

[clang] f762798 - Fix ReleaseNotes.rst unresolved merge conflict

Author: Alan Zhao Date: 2023-05-01T10:26:15-07:00 New Revision: f762798599171efca03964f4371cc8104d2392f9 URL: https://github.com/llvm/llvm-project/commit/f762798599171efca03964f4371cc8104d2392f9 DIFF: https://github.com/llvm/llvm-project/commit/f762798599171efca03964f4371cc8104d2392f9.diff LOG

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 8f0dd4e - [clang] Canonicalize system headers in dependency file when -canonical-prefixes

Author: Arthur Eubanks Date: 2023-05-01T10:40:18-07:00 New Revision: 8f0dd4ef3ed2137d1e2554204127434fc46ee190 URL: https://github.com/llvm/llvm-project/commit/8f0dd4ef3ed2137d1e2554204127434fc46ee190 DIFF: https://github.com/llvm/llvm-project/commit/8f0dd4ef3ed2137d1e2554204127434fc46ee190.diff

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f0dd4ef3ed2: [clang] Canonicalize system headers in dependency file when -canonical-prefixes (authored by aeubanks). Repository: rG LLVM Github M

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x()) --

[clang] f9fbda7 - Revert "[clang] Canonicalize system headers in dependency file when -canonical-prefixes"

Author: Arthur Eubanks Date: 2023-05-01T10:55:53-07:00 New Revision: f9fbda7102fb6da79dedf9b15694d7a61e8c49b7 URL: https://github.com/llvm/llvm-project/commit/f9fbda7102fb6da79dedf9b15694d7a61e8c49b7 DIFF: https://github.com/llvm/llvm-project/commit/f9fbda7102fb6da79dedf9b15694d7a61e8c49b7.diff

cfe-commits@lists.llvm.org

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149104/new/ https://reviews.llvm.org/D149104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

tejohnson created this revision. tejohnson added reviewers: rsmith, snehasish. Herald added a project: All. tejohnson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow up to LLVM-side change to allow conversion to hot/cold hinted opera

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

snehasish accepted this revision. snehasish added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/CodeGenCXX/new_hot_cold.cpp:16 + +enum class __hot_cold_t : uint8_t; +namespace malloc_namespace { Can we skip the typedef

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

HazardyKnusperkeks added a comment. I don't see the problem, could you elaborate a bit more? (Keep in mind, I have no idea about Verilog.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149562/new/ https://reviews.llvm.org/D149562

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman added a comment. I think you're missing changes in ASTReaderStmt.cpp and ASTWriterStmt.cpp, so serialization through modules or PCH won't work without that. Comment at: clang/include/clang/AST/Expr.h:1996 PredefinedExpr(SourceLocation L, QualType FNTy, IdentKi

[PATCH] D149606: [RISCV] Move RISCV::RVVBitsPerBlock to be a static member of RISCVISAInfo class.

craig.topper created this revision. craig.topper added reviewers: reames, asb, luismarques, frasercrmck, kito-cheng, rogfer01, pcwang-thead. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehou

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/new_hot_cold.cpp:16 + +enum class __hot_cold_t : uint8_t; +namespace malloc_namespace { snehasish wrote: > Can we skip the typedef and just say `enum class __hot_cold_t : unsigned > char;`? > >

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: All. Someone else ultimately fixed this (slightly differently) last month: https://reviews.llvm.org/D146875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

rsmith added a comment. This looks like a nice improvement to me. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:162 + if (P->getCurToken().is(tok::annot_repl_input_end)) { +P->ConsumeAnyToken(); // FIXME: Clang does not call ExitScope on finalizing the regul

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4308840 , @akyrtzi wrote: > `CodeGen` has the same issue: > > $ ninja > tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/TargetInfo.cpp.o > In file included from /llvm-project/clang/lib/CodeGen/TargetIn

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:189 + /// Deprecated. Use *getDataflowAnalysisContext().getOptions().Log instead. Logger &logger() const { return *DACtx->getOptions().Log; } bazuz

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

aaron.ballman added a comment. Thank you for working on this! The Clang changes are mostly all good, but I think we should hold off on changing the value of `__cplusplus` for the moment as it's not set in stone in the standard yet (I thought it was though, so I'm checking with the editor). =

[PATCH] D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations

tejohnson updated this revision to Diff 518526. tejohnson added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149600/new/ https://reviews.llvm.org/D149600 Files: clang/lib/AST/Decl.cpp clang/test/CodeGenCXX/new_hot_c

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM (Do you have commit access? If not, please specify the name/email you want for the "author" field.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://revie

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

aaron.ballman added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x())

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

k-mana added a comment. I don't have commit access. Please commit at KOMATA Manabu . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148944/new/ https://reviews.llvm.org/D148944 ___ cfe-commits mailing lis

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 created this revision. HerrCai0907 added reviewers: aaron.ballman, rjmccall, shafik. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fixed: https://github.com/llvm/llvm-project/issues/624

[clang] 578a471 - Reland [clang] Canonicalize system headers in dependency file when -canonical-prefixes

Author: Arthur Eubanks Date: 2023-05-01T12:44:52-07:00 New Revision: 578a4716f549167165a2ec3bac89c86706136d4e URL: https://github.com/llvm/llvm-project/commit/578a4716f549167165a2ec3bac89c86706136d4e DIFF: https://github.com/llvm/llvm-project/commit/578a4716f549167165a2ec3bac89c86706136d4e.diff

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

philnik added a comment. In D149573#4310009 , @codemzs wrote: > My change to libcxxabi/test/test_demangle.pass.cpp (last file in the change) > is only one line i.e {"_ZNK5clang4Type16isArithmeticTypeERNS_10ASTContextE", > "clang::Type::isArithmeticType(

[clang] fa42e7b - [RISCV] Merge RISCV::parseCPUKind and RISCV::checkCPUKind.

Author: Craig Topper Date: 2023-05-01T13:00:05-07:00 New Revision: fa42e7b6bc430941f42cf50b5c4e55b3c19ccc08 URL: https://github.com/llvm/llvm-project/commit/fa42e7b6bc430941f42cf50b5c4e55b3c19ccc08 DIFF: https://github.com/llvm/llvm-project/commit/fa42e7b6bc430941f42cf50b5c4e55b3c19ccc08.diff

[PATCH] D149606: [RISCV] Move RISCV::RVVBitsPerBlock to be a static member of RISCVISAInfo class.

craig.topper abandoned this revision. craig.topper added a comment. fa42e7b made this unnecessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149606/new/ https://reviews.llvm

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4310464 , @craig.topper wrote: > In D145088#4308840 , @akyrtzi wrote: > >> `CodeGen` has the same issue: >> >> $ ninja >> tools/clang/lib/CodeGen/CMakeFiles/obj.clangCo

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:91 return true; - case tok::annot_cxxscope: // Check if this is a dtor. -if (NextToken().is(tok::tilde)) Are you sure you can remove this? Wouldn't this be u

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518543. Ris-Bali added a comment. Added test for function type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/Sema/buil

[PATCH] D149613: [NFC] fix clang-tidy `prefer-isa-or-dyn-cast-in-conditionals` and `namespace-comment`

HerrCai0907 created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D149613 F

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 518546. void added a comment. Improve error message to use the unknown field's name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/A

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

arsenm added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318 Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE", Twine(WavefrontSize)); + Builder.defineMacro("__AMDGCN_CUMODE", Twine(CUMode)); } Why do we sometimes use __ on both sides, and so

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi updated this revision to Diff 518547. bazuzi added a comment. Use LLVM_DEPRECATED in place of comments indicating deprecation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149464/new/ https://reviews.llvm.org/D149464 Files: clang/include

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 518548. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks marked an inline comment as done. aeubanks added a comment. In D146764#4310398 , @aaron.ballman wrote: > I think you're missing changes in ASTReaderStmt.cpp and ASTWriterStmt.cpp, so > serialization through modules or PCH won't work without tha

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM. It may not be the end step and may be annoying to make further changes from this point, but on its own this isn't worse than before Comment at: llvm/lib/Target/AMDGPU/

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM overall. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" + g

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added a comment. No, I don't have commit access. You could use just `Bolshakov ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://reviews.llvm.org/D146386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

jhuber6 added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:58 +((IsCtor ? "__init_array_object_" : "__fini_array_object_") + + F->getName() + "_" + getHash(M.getName()) + "_" + + std::to_string(Priority)) tr

  1   2   >