aaron.ballman added inline comments.

================
Comment at: clang/lib/Parse/ParseTentative.cpp:91
         return true;
-      case tok::annot_cxxscope: // Check if this is a dtor.
-        if (NextToken().is(tok::tilde))
----------------
Are you sure you can remove this? Wouldn't this be used for a case like:
```
struct Foo {
  struct Bar {
    struct Baz {
      ~Baz();
    };
  };
};

Foo::Bar::Baz::~Baz() {}
```
(I could be reading the code wrong, but I thought we had a reason to check for 
`annot_cxxscope` -- seems we missed test coverage for it!)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148425/new/

https://reviews.llvm.org/D148425

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to