[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav created this revision. chaitanyav added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issue

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

nlopes added a comment. In D143287#4202174 , @ManuelJBrito wrote: > Implementing the 128 to 512 casts by filling the rest of the vector with the > same definition of a nondeterministic_value is not correct because : > > a = freeze poison > v = > > is

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

carlosgalvezp added a comment. Looks good but I fail to understand what exactly the patch fixes, can you point me to an example in the tests? It would be easier to review if the NFC changes had been done in a separate patch. Comment at: clang-tools-extra/test/clang-tidy/chec

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Requesting changes due to lack of support for base class initializes & got some concerns related lambdas used in initializers. Comment at: clang-tools-extra/cl

[clang-tools-extra] 113f019 - [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable

Author: Piotr Zegar Date: 2023-03-18T10:44:13Z New Revision: 113f0190dd386d93b42d781b975aa2cca5c88914 URL: https://github.com/llvm/llvm-project/commit/113f0190dd386d93b42d781b975aa2cca5c88914 DIFF: https://github.com/llvm/llvm-project/commit/113f0190dd386d93b42d781b975aa2cca5c88914.diff LOG: [

[PATCH] D145958: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG113f0190dd38: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145958/new

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch improves the diagnostic on uninitialized subobjects in constexpr variables by modifying t

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson updated this revision to Diff 506295. royjacobson added a comment. Add the test case from the GH issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146168/new/ https://reviews.llvm.org/D146168 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

yaxunl updated this revision to Diff 506296. yaxunl added a comment. fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145721/new/ https://reviews.llvm.org/D145721 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/hip-options.hip Index: clang/test/Driver/hip-op

[clang-tools-extra] 3ed40ac - [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified.

Author: Nathan James Date: 2023-03-18T15:54:25Z New Revision: 3ed40ac90ce8a91f0990fe2d847feb6663606f93 URL: https://github.com/llvm/llvm-project/commit/3ed40ac90ce8a91f0990fe2d847feb6663606f93 DIFF: https://github.com/llvm/llvm-project/commit/3ed40ac90ce8a91f0990fe2d847feb6663606f93.diff LOG:

[PATCH] D129070: [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ed40ac90ce8: [clang-tidy] Fixed an issue in readability-identifier-naming not using options… (authored by njames93, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D129070?vs

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau added a comment. In D144912#4203920 , @carlosgalvezp wrote: > Looks good but I fail to understand what exactly the patch fixes, can you > point me to an example in the tests? The patch fixes these enum tests in C language mode: enum REV_TYP

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

carlosgalvezp added a comment. Looks good, minor comments! Comment at: clang-tools-extra/clang-tidy/readability/AvoidUnconditionalPreprocessorIfCheck.h:16 + +/// Check flags always enabled or disabled code blocks in preprocessor `#if` +/// conditions, such as `#if 0` and `#i

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:16 +To configure the check to enforce the traditional token representation, you can +set the `BinaryOperators` and `OverloadedOperators` options to

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. > Without this patch, the suggested fix in a C file by clang-tidy is iRevValid > instead of rtRevValid. Ah there it was, thanks for the clarification! It was not highlighted in t

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:28-29 + +Alternative Token Representation + + carlosgalvezp wrote: > Personally I find this to be a

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:16 +To configure the check to enforce the traditional token representation, you can +set the `BinaryOperators` and `OverloadedOperators` options to ``&&,

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/avoid-unconditional-preprocessor-if.cpp:67-69 +#if 10 > DDD +// some code +#endif carlosgalvezp wrote: > Add case for if 10 < DDD ? > > Also, add test case for co

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL updated this revision to Diff 506304. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Removed some whitespace & added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617 Fi

[PATCH] D146363: Update reference output in underscored.c

chaitanyav created this revision. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. update reference output in underscored.c, combine re

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AvoidUnconditionalPreprocessorIfCheck.cpp:41 + + bool isStatic(SourceManager &SM, const LangOptions &LangOpts, +SourceRange ConditionRange) { "static" is a

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav updated this revision to Diff 506308. chaitanyav added a comment. - Update reference output in underscored.c - combine return and append semicolon fragment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/ https://reviews.llvm.or

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav updated this revision to Diff 506309. chaitanyav added a comment. - Update reference output in underscored.c - combine return and append semicolon fragment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/ https://reviews.llvm.or

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL updated this revision to Diff 506310. PiotrZSL added a comment. Change name of isStatic* to isImmutable* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617 Files: clang-tools-extra/clang-tidy/rea

[PATCH] D146364: [Driver] Fix naming conflicts of getStatsFileName when using LTO

dtcxzyw created this revision. dtcxzyw added reviewers: liaolucy, StephenFan. Herald added a subscriber: inglorion. Herald added a project: All. dtcxzyw requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When using `clang` with `-flto=

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

shafik added a comment. Thank you for submitting this fix. Comment at: clang/lib/AST/ExprConstant.cpp:2270 + Info, MTE->getExprLoc(), TempType, *V, Kind, + nullptr, CheckedTemps)) return false; ---

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:373 + const FieldDecl *SubObjDecl) { + S.FFDiag(SI, diag::note_constexpr_uninitialized) << SubObjDecl; + S.Note(SubObjDecl->getLocation(), shafik

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects code where a te

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL added a comment. There are 2 issues found in llvm repository: - llvm/lib/Target/AMDGPU/AMDGPULibFunc.cpp:721:22: warning: reference variable 'S' extends the lifetime of a just-constructed temporary object 'const StringRef', consider changing reference to value [readability-reference-t

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau added a comment. In D144912#4204088 , @carlosgalvezp wrote: > Looks great, approved! Thanks for fixing :) Thanks for the review :) I don't have push access, so please can you (or anyone else) land it for me ? (as `Alexis Murzeau ` (phabricator

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers updated this revision to Diff 506336. bersbersbers added a comment. Rebased patch against main branch (previous patch was against 15.0.7 tag) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145435/new/ https://reviews.llvm.org/D145435 Files: clang/docs/ClangFormatStyleOpti

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 506339. ccotter added a comment. Herald added a subscriber: PiotrZSL. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/mod

[PATCH] D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

samuelmaina created this revision. Herald added subscribers: sunshaoce, guansong, kristof.beyls, yaxunl. Herald added a project: All. samuelmaina requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: c

[PATCH] D146371: [Clang][OpenMP]Solved the the always truth condition in Arm64

samuelmaina created this revision. Herald added subscribers: sunshaoce, guansong, kristof.beyls, yaxunl. Herald added a project: All. samuelmaina requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: c

[PATCH] D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

samuelmaina updated this revision to Diff 506345. samuelmaina added a comment. Updating D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64 === Reformatted the file Reformatted the CGOpenMPRuntime.cpp

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

tbaeder added a comment. "subobject named 'foo'" sounds a bit weird to me, I'd expect just "subobject 'foo'", but that's just a suggestion and I'll wait for a native spearker to chime in on this. Comment at: clang/lib/AST/Interp/Interp.cpp:373 +

[clang-tools-extra] d4cb6c2 - [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

Author: Alexis Murzeau Date: 2023-03-19T06:22:16Z New Revision: d4cb6c208231b36ef44871f4f3d0167f8b206a5e URL: https://github.com/llvm/llvm-project/commit/d4cb6c208231b36ef44871f4f3d0167f8b206a5e DIFF: https://github.com/llvm/llvm-project/commit/d4cb6c208231b36ef44871f4f3d0167f8b206a5e.diff LOG

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4cb6c208231: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C (authored by amurzeau, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 2538e55 - [Sanitizer] [Scudo] Add riscv64 support for scudo

Author: Jun Sha (Joshua) Date: 2023-03-18T23:37:46-07:00 New Revision: 2538e550420fed5036d224fd93e9145c845f0ffe URL: https://github.com/llvm/llvm-project/commit/2538e550420fed5036d224fd93e9145c845f0ffe DIFF: https://github.com/llvm/llvm-project/commit/2538e550420fed5036d224fd93e9145c845f0ffe.di

[PATCH] D137397: [Sanitizer] [Scudo] Add riscv64 support for scudo

This revision was automatically updated to reflect the committed changes. Closed by commit rG2538e550420f: [Sanitizer] [Scudo] Add riscv64 support for scudo (authored by joshua-arch1, committed by AdityaK <1894981+hiradi...@users.noreply.github.com>). Herald added projects: clang, Sanitizers. Her

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: tbaeder, cjdb. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are some simple messages where an expansion isn't p

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added a comment. Looks like you're just removing the output altogether, so that won't work. Try running `ninja check-clang-semacxx` and see all the test failures you (should) get. For a proper patch, it would also be good if you add a test case for the case you're fixing. Repository: