carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land.
> Without this patch, the suggested fix in a C file by clang-tidy is iRevValid > instead of rtRevValid. Ah there it was, thanks for the clarification! It was not highlighted in the diff. > Would the new C test file would have been better in a separate patch too > (thus keep only the main change in the checker) ? That would definitely have helped reviewing! Coming into the patch I was expecting the diff to look like either fixing an existing test, or adding a new test (in the same file). You did add a new test, but it happened to be an almost exact copy of another one, so Phabricator only displayed the diff against the copy, not highlighting the issue the patch is fixing. Looks great, approved! Thanks for fixing :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144912/new/ https://reviews.llvm.org/D144912 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
