[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 503251. PiotrZSL added a comment. Rebase due to broken baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files: clang-tools-extra/clang-tidy/misc/CMakeLists

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D124351#4175717 , @sammccall wrote: > We're seeing new clang crashes that bisect to this commit, with modules only. > > I have it mostly-reduced and will post shortly, trying to see if I can > simplify any further (since modu

[clang] 78e4897 - [NFC] [C++20] [Modules] Add a test for pr60085

Author: Chuanqi Xu Date: 2023-03-08T16:40:22+08:00 New Revision: 78e48977a6e67eaf6cea64e955e67edb0a55c993 URL: https://github.com/llvm/llvm-project/commit/78e48977a6e67eaf6cea64e955e67edb0a55c993 DIFF: https://github.com/llvm/llvm-project/commit/78e48977a6e67eaf6cea64e955e67edb0a55c993.diff LO

[PATCH] D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145553 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSym

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet it is obvious that there is something in this diff that causes this hesitancy in accepting it. I'm ready to keep iterating on the solution but I need a clue what needs the improvement. Please comment. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

bolshakov-a added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6842 case TemplateArgument::Integral: return TemplateArgument(Arg, getCanonicalType(Arg.getIntegralType())); @Michael137, hasn't `IsDefaulted` parameter forgotten here? Re

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos added a comment. @erichkeane @aaron.ballman any further comments on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 ___ cfe-commits mailing list cf

[PATCH] D145557: [Tooling/Inclusion] Add atomic family symbols

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145557 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSym

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

asb added a comment. In D141672#4177044 , @craig.topper wrote: > I guess the question is whether we should update to the most recent now or > land this first. I think updating to the most recent would make sense. Review bandwidth is limited, and it do

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This implements support for two new 2022 A-profile exten

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

lenary added a comment. The CHKFEAT instruction here is not exactly as described in https://developer.arm.com/downloads/-/exploration-tools today - but the next release of that description will be updated with the new syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

hans added a reviewer: mstorsjo. hans added a comment. +mstorsjo for thoughts about Windows code, even if this might not apply to mingw. In D145271#4172636 , @wolfgangp wrote: > A customer complained about the following code (I'm obscuring the class >

[PATCH] D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

PiotrZSL updated this revision to Diff 503287. PiotrZSL added a comment. Rebase due to broken baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144206/new/ https://reviews.llvm.org/D144206 Files: clang-tools-extra/clang-tidy/cppcoreguidelin

[PATCH] D143496: [clangd] Add support for missing includes analysis.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:464 + Cfg.Diagnostics.Includes.IgnoreHeader = { + [](llvm::StringRef Header) { return Header == testPath("buzz.h"); }}; + WithContextValue Ctx(Config::Key, std::move(Cfg));

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb created this revision. asb added a reviewer: efriedma. Herald added subscribers: wingo, pmatos, sameer.abuasal. Herald added a project: All. asb requested review of this revision. As noted in #6126 the documentation for `-fexceptions` appear

[clang-tools-extra] 85a5c17 - Re-land [clangd] Add support for missing includes analysis.

Author: Viktoriia Bakalova Date: 2023-03-08T11:02:12Z New Revision: 85a5c17b66768353b7fff717904e42805bb6a547 URL: https://github.com/llvm/llvm-project/commit/85a5c17b66768353b7fff717904e42805bb6a547 DIFF: https://github.com/llvm/llvm-project/commit/85a5c17b66768353b7fff717904e42805bb6a547.diff

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The name "flag" impli

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL updated this revision to Diff 503297. PiotrZSL added a comment. Rebase due to broken baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 Files: clang-tools-extra/clang-tidy/readability/CMa

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 503305. john.brawn added a comment. Add command line test and release note, and run clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPD

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL updated this revision to Diff 503312. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D143496: [clangd] Add support for missing includes analysis.

PiotrZSL added a comment. @VitaNuo Why did you recommit this again without any fix, breaking regression again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496

[PATCH] D145576: Re-land [clangd] Add support for missing includes analysis.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This reverts commit 2eb5ac99a76dbbf8ac68c53

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503315. VitaNuo added a comment. Try to fix windows build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/unittests/IncludeCleanerT

[clang-tools-extra] 7bd56dd - Re-land [clangd] Add support for missing includes analysis.

Author: Viktoriia Bakalova Date: 2023-03-08T12:19:17Z New Revision: 7bd56ddaeeb578331d3dfc0c4a2fe2727d0d1861 URL: https://github.com/llvm/llvm-project/commit/7bd56ddaeeb578331d3dfc0c4a2fe2727d0d1861 DIFF: https://github.com/llvm/llvm-project/commit/7bd56ddaeeb578331d3dfc0c4a2fe2727d0d1861.diff

[clang-tools-extra] 9814b4d - Revert "Re-land [clangd] Add support for missing includes analysis."

Author: Viktoriia Bakalova Date: 2023-03-08T12:24:51Z New Revision: 9814b4d07f614e83e7a244f74fc562f2b5cc9b15 URL: https://github.com/llvm/llvm-project/commit/9814b4d07f614e83e7a244f74fc562f2b5cc9b15 DIFF: https://github.com/llvm/llvm-project/commit/9814b4d07f614e83e7a244f74fc562f2b5cc9b15.diff

[clang-tools-extra] df92d79 - Revert "Re-land [clangd] Add support for missing includes analysis."

Author: Viktoriia Bakalova Date: 2023-03-08T12:29:43Z New Revision: df92d7911b9ce0221ebf60a937da3e9101150bc1 URL: https://github.com/llvm/llvm-project/commit/df92d7911b9ce0221ebf60a937da3e9101150bc1 DIFF: https://github.com/llvm/llvm-project/commit/df92d7911b9ce0221ebf60a937da3e9101150bc1.diff

[clang-tools-extra] 46447e0 - Revert "Revert "Re-land [clangd] Add support for missing includes analysis.""

Author: Viktoriia Bakalova Date: 2023-03-08T12:27:17Z New Revision: 46447e0ba2e31f4da55c59794caa3200c990c535 URL: https://github.com/llvm/llvm-project/commit/46447e0ba2e31f4da55c59794caa3200c990c535 DIFF: https://github.com/llvm/llvm-project/commit/46447e0ba2e31f4da55c59794caa3200c990c535.diff

[PATCH] D143496: [clangd] Add support for missing includes analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46447e0ba2e3: Revert "Revert "Re-land [clangd] Add support for missing includes analysis."" (authored by VitaNuo). Changed prior to commit: https:

[clang-tools-extra] fd8c9ef - Revert "Re-land [clangd] Add support for missing includes analysis."

Author: Viktoriia Bakalova Date: 2023-03-08T12:34:15Z New Revision: fd8c9ef20a9519dccd5b8178b29ed4574285d36f URL: https://github.com/llvm/llvm-project/commit/fd8c9ef20a9519dccd5b8178b29ed4574285d36f DIFF: https://github.com/llvm/llvm-project/commit/fd8c9ef20a9519dccd5b8178b29ed4574285d36f.diff

[PATCH] D145577: Re-land [clangd] Add support for missing includes analysis.

VitaNuo created this revision. Herald added subscribers: ChuanqiXu, kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This reverts commit fd8c9ef20a95

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503322. VitaNuo added a comment. Try another approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/

[PATCH] D145519: [SanitizerBinaryMetadata] Do not add to GPU code

melver updated this revision to Diff 503326. melver marked an inline comment as done. melver added a comment. Simplify assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145519/new/ https://reviews.llvm.org/D145519 Files: clang/lib/Driver/San

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada created this revision. domada added reviewers: jsjodin, agozillon, skatrak, TIFitis, kiranktp, dpalermo, kiranchandramohan, NimishMishra, awarzynski. domada added projects: Flang, OpenMP, MLIR, AMDGPU. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, kosarev, sdasgup3

[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

aaron.ballman added a comment. Generally seems reasonable to me, but I'll give others a chance to comment. Comment at: clang/lib/AST/ASTContext.cpp:13459 if (Target->validateCpuSupports(Feature.str())) + // Use '?' to mark features that came from TargetVersion

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This eliminates

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

aaron.ballman added a comment. In D130303#4176330 , @dexonsmith wrote: > In D130303#4175664 , @collinbaker > wrote: > >> @dexonsmith can you weigh in? > > Introducing `clang_isBitFieldDecl` sounds like a clean/s

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

Szelethus added a comment. We worked on this together, so I waited a bit for others to have a say in this, but this design seems like a no brainer to me. Please fix those comments, otherwise LGTM. Also, while the patch is LGTM (moving code around is okay), the comment says "system headers havi

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503335. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/clangd

[clang-tools-extra] 2e82eb1 - Re-land [clangd] Add support for missing includes analysis.

Author: Viktoriia Bakalova Date: 2023-03-08T13:29:52Z New Revision: 2e82eb1f74aa268473c9eca27c3b8ddc91917a13 URL: https://github.com/llvm/llvm-project/commit/2e82eb1f74aa268473c9eca27c3b8ddc91917a13 DIFF: https://github.com/llvm/llvm-project/commit/2e82eb1f74aa268473c9eca27c3b8ddc91917a13.diff

[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM, thanks for making these changes. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:567-568 + +// For given features returns a mask to check if CPU

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL updated this revision to Diff 503357. PiotrZSL added a comment. Rebase due to broken baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 Files: clang-tools-extra/clang-tidy/readability/CMa

[PATCH] D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:260 +// text, which are not handled by the script. +// N is an implementation-defined number,

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 503360. Leporacanthicus added a comment. Herald added a reviewer: sscalpone. Updates based on review comments: - Add tests. - Enable on -O3 Also changed the name to match gfortran. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL updated this revision to Diff 503362. PiotrZSL added a comment. Rebase due to broken baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 Files: clang-tools-extra/clang-tidy/bugprone/Bugpro

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL updated this revision to Diff 503364. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt cla

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL updated this revision to Diff 503365. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D129951: adds `__disable_adl` attribute

philnik added a comment. I don't think libc++ can adopt this without having to essentially duplicate our code, since GCC doesn't support `__disable_adl` (and AFAICT there is no coordination between GCC and Clang to add it to both). Have you tested what impact making the members `static` has? Bo

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus marked an inline comment as done. Leporacanthicus added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:69 + Arg *loopVersioning = + Args.getLastArg(options::OPT_Ofast, options::OPT_floop_versioning, + options::OPT_fno

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1379 +}; \ No newline at end of file Please add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. Reporting after another round of discussion. I don't have much support from the llvm openmp working group that we should maintain the current divergence from libc++ and the like so I'm backing down. Let's revert this and regress for all users who don't install g

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1296 +// In a function call, the expression that determines the callee is sequenced +// before the arguments. This entire file tests only C++17 a

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan requested changes to this revision. kiranchandramohan added inline comments. This revision now requires changes to proceed. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives.

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

sammccall added a comment. Sorry for the delay, extracting the repro from the build system seems about as much work as minimizing it :-) F26749550: modrepo2.zip - running repro.sh hits an assert for me on the main.cpp compile. (I suspect something much small

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:643 + T __builtin_elementwise_exp(T x)returns the base-e exponential, or e^x, of the specified value floating point types + T __builtin_elementwise_exp2(T x) returns the base-2 exp

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. mhalk requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Adds a warning, issued by the clang sem

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

w2yehia added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:10 +// ROPTR-NOT: "-mroptr" +// ROPTR-NOT: "-bforceimprw" + hubert.reinterpretcast wrote: > Do we pass the option through to the LTO codegen when `-fprofile-generate` is > used? > We may ne

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

hans added a reviewer: aaron.ballman. hans added a comment. +aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145369/new/ https://reviews.llvm.org/D145369 ___ cfe-commits mailing list cfe-comm

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel added a comment. Friendly review ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141008/new/ https://reviews.llvm.org/D141008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D118493: Set rpath on openmp executables

MaskRay added a comment. In D118493#4178250 , @JonChesterfield wrote: > Reporting after another round of discussion. I don't have much support from > the llvm openmp working group that we should maintain the current divergence > from libc++ and the lik

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:1 +// RUN: %clang -### -target powerpc-ibm-aix-xcoff -mroptr %s 2>&1 | FileCheck %s +// RUN: %clang -### -target powerpc-ibm-aix-xcoff -mroptr -mno-roptr %s 2>&1 | \ hubert.reinterpretc

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

jyu2 updated this revision to Diff 503413. jyu2 added a comment. Okay, I add code to get **a to work. Thanks Alexey for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 Files: clang/lib/Code

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 ___

[PATCH] D145600: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS

DiggerLin created this revision. DiggerLin added reviewers: jhenderson, Jake-Egan, daltenty. Herald added a project: All. DiggerLin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In patch https://reviews.llvm.org/D127864. we add a new opti

[clang] 555b572 - Revert D118493 "Set rpath on openmp executables"

Author: Fangrui Song Date: 2023-03-08T10:18:40-08:00 New Revision: 555b572e3f407ac48b5f30fc06760cc4d0549977 URL: https://github.com/llvm/llvm-project/commit/555b572e3f407ac48b5f30fc06760cc4d0549977 DIFF: https://github.com/llvm/llvm-project/commit/555b572e3f407ac48b5f30fc06760cc4d0549977.diff

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503437. qiongsiwu1 added a comment. Addressing review comments - fixing typos, and updating the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: cla

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503440. qiongsiwu1 added a comment. Update `-mroptr` cc1 option help text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

DiggerLin added a comment. In D142484#4080202 , @Jake-Egan wrote: > In D142484#4079909 , @jhuber6 wrote: > >> In D142484#4079869 , @Jake-Egan >> wrote: >> >>> Hi, this ne

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

scchan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145591/new/ https://reviews.llvm.org/D145591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

ilinpv updated this revision to Diff 503446. ilinpv added a comment. Rebasing and addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145538/new/ https://reviews.llvm.org/D145538 Files: clang/include/clang/Basic/TargetInfo.h cla

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

wolfgangp added a comment. > It still seems like the export/import there is an accident since > `Base` can't really be referenced from outside the file anyway. > > Perhaps rather than giving `Base` external linkage to allow it to > be imported/exported, the better fix would be to drop its dllimp

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. In D129951#4178154 , @philnik wrote: > I don't think libc++ can adopt this without having to essentially duplicate > our code, since GCC doesn't support `__disable_adl` (and AFAICT there is no > coordination between GCC and Clang t

[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

ilinpv marked 5 inline comments as done. ilinpv added inline comments. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:567-568 + +// For given features returns a mask to check if CPU support them. The mask is +// used in Function Multi Versioning resolver conditi

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

efriedma added a comment. I'd prefer to focus the documentation more generically on exceptions, not unwind information specifically. -fexceptions makes code generation change in other ways, and "unwind information" doesn't exist on all targets where exception handling is relevant. CHANGES SI

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 503459. Leporacanthicus marked an inline comment as done. Leporacanthicus added a comment. Fix copied comment to reflect the new content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https:

[PATCH] D145600: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS

Jake-Egan accepted this revision. Jake-Egan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145600/new/ https://reviews.llvm.org/D145600 _

[PATCH] D145401: [AMDGPU] Reserve extra SGPR blocks wth XNACK "any" TID Setting

kerbowa updated this revision to Diff 503461. kerbowa added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145401/new/ https://reviews.llvm.org/D145401

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18267-18271 +auto HalfSupport = HasHalfSupport(BuiltinID); +if (!HalfSupport.first) { + CGM.Error(E->getExprLoc(), +HalfSupport.second.append(" requires native half type support."

[PATCH] D129951: adds `__disable_adl` attribute

philnik added a comment. In D129951#4178844 , @cjdb wrote: > In D129951#4178154 , @philnik wrote: > >> I don't think libc++ can adopt this without having to essentially duplicate >> our code, since GCC doesn't su

[PATCH] D144064: [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

malavikasamak added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:156 + // 2. the operand of a cast-to-(Integer or Boolean) operation; or + // 3. the operand of a pointer subtraction operation; or + // 4. the operand of a pointer comparison operation; o

[clang] d2b768b - [C2x] Add test coverage for WG14 N2607

Author: Aaron Ballman Date: 2023-03-08T14:59:53-05:00 New Revision: d2b768bba301aa80e2874d3d935a721eb1148f29 URL: https://github.com/llvm/llvm-project/commit/d2b768bba301aa80e2874d3d935a721eb1148f29 DIFF: https://github.com/llvm/llvm-project/commit/d2b768bba301aa80e2874d3d935a721eb1148f29.diff

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb added a comment. What do you think about e.g. "Allow exceptions to be thrown through Clang compiled stack frames (on many targets, this will enable unwind information for functions that might have an exception thrown through them. This is on by default in x86-64"? Or were you thinking of so

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

hans added a comment. In D145271#4178837 , @wolfgangp wrote: >> It still seems like the export/import there is an accident since >> `Base` can't really be referenced from outside the file anyway. >> >> Perhaps rather than giving `Base` external linkage t

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

aqjune added a comment. H, is D104790 superseded by this patch? I wonder what is the status of this patch as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.org/D143287 _

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

efriedma added a comment. Something like that, sure. Is it actually on by default on x86-64? I don't think the default is target-specific, I think it's just on for default for C++ dialects, and off by default for non-C++ dialects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145564/

[PATCH] D145509: [HIP] Fix temporary files

tra added a comment. In D145509#4176732 , @yaxunl wrote: > However, it seems the previous code using GetTemporaryDirectory was > intentional (https://reviews.llvm.org/D111269). My guess is that lipo using > some hash of input file name in the generated

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb added a comment. I don't see anything x86_64 specific for `OPT_fexceptions` handling in clang/lib/Driver/ToolChains/Clang.cpp. So perhaps "For most targets, this is enabled by default for C++." It's disabled for the ps4/ps5 toolchains and xcore, hence the "most targets" qualifier. CHANGES

[PATCH] D145605: Revert two patches to fix PR58452 regression

erichkeane created this revision. erichkeane added reviewers: tstellar, aaron.ballman. Herald added a project: All. erichkeane requested review of this revision. PR58452 is a regression in the 16.0 release branch caused by both: b8a1b698afb2fc84819c7596090aabf4d826b436

[PATCH] D145605: Revert two patches to fix PR58452 regression

erichkeane added a comment. Going to add 1 more set of test beyond the revert, which is the tests from that regression report. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145605/new/ https://reviews.llvm.org/D145605 ___ cfe-commits mailing

[PATCH] D145605: Revert two patches to fix GH58452 regression

erichkeane updated this revision to Diff 503479. erichkeane added a comment. Add tests from regression bug report. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145605/new/ https://reviews.llvm.org/D145605 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaInternal

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai added inline comments. Comment at: clang/test/Driver/save-stats.c:26 // CHECK-LTO: "-plugin-opt=stats-file=save-stats.stats" +// CHECK-LTO: "-plugin-opt=-stats-file-append" ahatanak wrote: > ahatanak wrote: > > Doesn't this require `stats-file-append`

[clang] 0cfe5ae - [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes.

Author: Alexey Bataev Date: 2023-03-08T13:06:53-08:00 New Revision: 0cfe5ae0b62a54cf76bb2f18eb60acb5e22fcc2d URL: https://github.com/llvm/llvm-project/commit/0cfe5ae0b62a54cf76bb2f18eb60acb5e22fcc2d DIFF: https://github.com/llvm/llvm-project/commit/0cfe5ae0b62a54cf76bb2f18eb60acb5e22fcc2d.diff

[PATCH] D145514: [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cfe5ae0b62a: [OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai updated this revision to Diff 503488. vsapsai added a comment. Don't touch LTO pipeline to avoid breaking existing workflows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144981/new/ https://reviews.llvm.org/D144981 Files: clang/docs/Co

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

tra added a comment. How is this different from compiling a C++ file with opemnp directives in it? AFAICT neither clang nor gcc issue anywarnings: https://godbolt.org/z/5Me3dnTdr What makes the warnings necessary for HIP? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D144179#4166909 , @mgabka wrote: > In D144179#4146599 , @MaskRay wrote: > >> This looks like i

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai added a comment. Adding folks involved with LTO. The problem is that stats emitted during the first round of compilation are likely to be overwritten by stats emitted during [Thin]LTO itself. Not touching it now to preserve the existing behavior. But wanted to inform you about this shor

[PATCH] D145509: [HIP] Fix temporary files

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Driver.h:634 + StringRef BoundArch = {}, + Action::OffloadKind OFK = Action::OFK_None) const; t

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503504. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/

[clang] 7335cd0 - [M68k] Add support for basic memory constraints in inline asm

Author: Min-Yih Hsu Date: 2023-03-08T13:52:34-08:00 New Revision: 7335cd05137076c69ce4716ac8f30a99fc95c406 URL: https://github.com/llvm/llvm-project/commit/7335cd05137076c69ce4716ac8f30a99fc95c406 DIFF: https://github.com/llvm/llvm-project/commit/7335cd05137076c69ce4716ac8f30a99fc95c406.diff L

[PATCH] D143529: [M68k] Add support for basic memory constraints in inline asm

This revision was automatically updated to reflect the committed changes. Closed by commit rG7335cd051370: [M68k] Add support for basic memory constraints in inline asm (authored by myhsu). Changed prior to commit: https://reviews.llvm.org/D143529?vs=495647&id=503509#toc Repository: rG LLVM

  1   2   >