MaskRay added a comment.

In D118493#4178250 <https://reviews.llvm.org/D118493#4178250>, @JonChesterfield 
wrote:

> Reporting after another round of discussion. I don't have much support from 
> the llvm openmp working group that we should maintain the current divergence 
> from libc++ and the like so I'm backing down. Let's revert this and regress 
> for all users who don't install globally.
>
> The intent is to document in the FAQ things users can do themselves to 
> replace the functionality here, where possibly one enumerated option is to 
> pass --fopenmp-implicit-rpath (maybe renamed) though my preference would be 
> to delete this code path from the compiler entirely if it's going to be a 
> minimally-tested, non-default path (as it'll break and we won't notice).
>
> @MaskRay please revert this patch at your leisure. I'm reluctantly consenting 
> to the capability regression but not volunteering to fix any CI fallout from 
> removing it.
>
> @ronlieb I think we should keep this functionality in rocm so that rocm built 
> binaries don't start going looking for llvm libs under /usr instead and fall 
> over

Thank you! I am preparing a commit to remove this then...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118493/new/

https://reviews.llvm.org/D118493

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to