hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:464
+ Cfg.Diagnostics.Includes.IgnoreHeader = {
+ [](llvm::StringRef Header) { return Header == testPath("buzz.h"); }};
+ WithContextValue Ctx(Config::Key, std::move(Cfg));
----------------
Looks like this filter doesn't work on windows (the `/` vs `\` path separator
might be the root cause here), I think a fix can be
- change the check to `return Header.endsWith("buzz.h")`
- or `return Header == testPath("buzz.h", llvm::sys::path::Style::posix)`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143496/new/
https://reviews.llvm.org/D143496
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
