[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

covanam added a comment. In D143725#4127923 , @Esme wrote: > Please include as much context as possible with your diff. > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Thank you. Will read that and will add more contex

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144299: [NFC] Added a lit test for the arithmetic fence builtin.

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144299 Files: clang/test/CodeGen/arithmetic-fence-bu

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:2166 + +If the mode is ``"dynamic"``, the behavior is derived from the +dynamic state of the floating-point environment. Transformations pengfei wrote: > 1. Does it mean users must specify `d

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16806 +bool InTemplateDefinition = +getLangOpts().CPlusPlus && CurContext->isDependentContext(); + shafik wrote: > erichkeane wrote: > > cor3ntin wrote: > > > erichkeane wrot

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. In D142907#4132836 , @jcranmer-intel wrote: > In D142907#4132430 , @arsenm wrote: > >> I was thinking of changing the default in general to dynamic. I was going to >> at least change the

[PATCH] D144011: [clang]Fix warning for signed conversion

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Sema/SemaChecking.cpp:14296 +if (SourceBT && SourceBT->isInteger() && TargetBT && +TargetBT->isInteger() && Con

[PATCH] D144011: [clang]Fix warning for signed conversion

MaskRay added a comment. The description needs to adjusted to say that this confusing warning is for LP64 systems. It makes sense to match -m32 and GCC. If someone thinks a warning is useful, that can be a separate change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144011/new/ http

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 498510. shafik added a comment. - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vaopt_p

[PATCH] D144288: [RISCV] Add missing plumbing and tests for zfa

reames updated this revision to Diff 498512. reames added a comment. Address review comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144288/new/ https://reviews.llvm.org/D144288 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/Support/RISCVISAInfo.cpp llvm/tes

[clang] d6d59e6 - [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

Author: Shafik Yaghmour Date: 2023-02-17T14:57:32-08:00 New Revision: d6d59e660bc75d14f423fb3817834f832bbf4543 URL: https://github.com/llvm/llvm-project/commit/d6d59e660bc75d14f423fb3817834f832bbf4543 DIFF: https://github.com/llvm/llvm-project/commit/d6d59e660bc75d14f423fb3817834f832bbf4543.dif

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6d59e660bc7: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a… (authored by shafik). Herald added a project: clang. R

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498511. elmcdonough marked an inline comment as done. Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/cla

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16824-16841 if (InnerCond && isa(InnerCond)) { // Drill down into concept specialization expressions to see why they // weren't satisfied. Diag(StaticAssertLoc, diag::err_st

[PATCH] D144288: [RISCV] Add missing plumbing and tests for zfa

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144288/new/ https://reviews.llvm.org/D144288 ___ cfe-commits mailing list c

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough added a comment. In D143301#4135301 , @awarzynski wrote: > @elmcdonough , let me rephrase this (should've been clearer before, sorry): > >> One thing that's not clear to me - how come "-Wextra" is not treated as an >> error and "-Wblah" is?

[PATCH] D144304: [WIP][-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For a pointer type expression `e` of the form

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32 and is // guaranteed to be a power

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. In D144181#4133056 , @Michael137 wrote: > In D144181#4133025 , @dblaikie > wrote: > >> Ah, accidentally posted to the lldb part of this stack... instead: >> >> Any chance we can make

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 498520. zhouyizhou added a comment. Add CodeGen Test following MaskRay(Fangrui Song)'s Advice, I learned a lot during this process, to be honest ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157 File

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. @PiotrZSL The last `forward` example you have should match my `does_move_auto_rvalue_ref_param` test, which is not flagged by the tool. Let me know if you have any other forward cases (preferred as full self contained examples) that the tool incorrectly flags, as gettin

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

dblaikie added a comment. In D144181#4133056 , @Michael137 wrote: > In D144181#4133025 , @dblaikie > wrote: > >> Ah, accidentally posted to the lldb part of this stack... instead: >> >> Any chance we can make th

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 498525. ccotter added a comment. - Add StrictMode option, fix const&& bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcor

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 498526. ccotter added a comment. - Add back -fno-delayed-template-parsing to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tid

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added a comment. Rebased as well on top of the latest release notes Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:45 +template +void never_moves_param_template(Ob

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 498528. ccotter marked an inline comment as done. ccotter added a comment. rebase again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/cla

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. @PiotrZSL I added an option to allow disabling the strict behavior. It should address many of your examples (e.g., moving subobjects) . Let me know if you have more feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D144309: add max/min lib fxns

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [HLSL] add max/min library functions

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/min.hlsl:10 +// CHECK: call half @llvm.minnum.f16( +// NO_HALF: define noundef float @"?test_min_half@@YA$halff@$halff@0@Z"( +// NO_HALF: call float @llvm.minnum.f32( I had to add a 0 her

[clang] 495b653 - [RISCV] Add missing plumbing and tests for zfa

Author: Philip Reames Date: 2023-02-17T17:56:30-08:00 New Revision: 495b653480238d692d814dde50469441b83adb4b URL: https://github.com/llvm/llvm-project/commit/495b653480238d692d814dde50469441b83adb4b DIFF: https://github.com/llvm/llvm-project/commit/495b653480238d692d814dde50469441b83adb4b.diff

[PATCH] D144288: [RISCV] Add missing plumbing and tests for zfa

This revision was automatically updated to reflect the committed changes. Closed by commit rG495b65348023: [RISCV] Add missing plumbing and tests for zfa (authored by reames). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144288/new/ https://reviews

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32 and is // guaranteed to be a power

[PATCH] D144317: [clang-format] Fix handling of TypeScript tuples with optional last member

taymonbeal created this revision. taymonbeal added reviewers: MyDeveloperDay, owenpan. Herald added a project: All. taymonbeal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These were previously incorrectly treated as syntax errors. Rep

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

vitalybuka updated this revision to Diff 498550. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/clan

[clang] 890146b - [WebAssembly] Initial support for reference type externref in clang

Author: Paulo Matos Date: 2023-02-17T18:48:48-08:00 New Revision: 890146b19206827bc48ee1ae1dc1534ff2ff18d7 URL: https://github.com/llvm/llvm-project/commit/890146b19206827bc48ee1ae1dc1534ff2ff18d7 DIFF: https://github.com/llvm/llvm-project/commit/890146b19206827bc48ee1ae1dc1534ff2ff18d7.diff L

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG890146b19206: [WebAssembly] Initial support for reference type externref in clang (authored by pmatos, committed by vitalybuka). Repository: rG LL

[PATCH] D144157: Add 128-bit integer support to enum element

MaskRay added inline comments. Comment at: clang/test/CodeGen/enum3.c:1 +// RUN: %clang_cc1 -triple x86_64-linux-gnu %s -debug-info-kind=limited -emit-llvm -o - | FileCheck %s + We don't need a new test file. Reusing can improve test discoverability and readabi

[PATCH] D144011: [clang]Fix warning for signed conversion on LP64

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14296 +if (SourceBT && SourceBT->isInteger() && TargetBT && +TargetBT->isInteger() && MaskRay wrote: > Consider adding an example when

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 498557. zhouyizhou added a comment. make test case even better according to MaskRay's guidance CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CodeGen/e

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough updated this revision to Diff 498561. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

brad created this revision. brad added a reviewer: adalava. brad added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Herald added a project: All. brad requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I not

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

brad added a comment. I noticed this review. I have provided a more complete diff for review at D144321 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144232/new/ https://reviews.llvm.org/D144232 ___

<    1   2