MaskRay added inline comments.

================
Comment at: clang/test/CodeGen/enum3.c:1
+// RUN: %clang_cc1 -triple x86_64-linux-gnu %s -debug-info-kind=limited 
-emit-llvm -o - | FileCheck %s
+
----------------
We don't need a new test file. Reusing can improve test discoverability and 
readability for this test.

I think this test needs to show how the global variable `v`'s value is changed 
by the `__uint128_t` enum, which enum2.c may lack (a problem of many old tests).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144157/new/

https://reviews.llvm.org/D144157

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to