yaxunl marked an inline comment as done.
yaxunl added inline comments.

================
Comment at: clang/lib/Sema/SemaChecking.cpp:14296
 
+    if (SourceBT && SourceBT->isInteger() && TargetBT &&
+        TargetBT->isInteger() &&
----------------
MaskRay wrote:
> Consider adding an example when this condition triggers to help 
> understanding, e.g. `long t2 = 1LL << x;` on LP64 systems.
will do when committing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144011/new/

https://reviews.llvm.org/D144011

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D144011: [clang]Fix warn... Yaxun Liu via Phabricator via cfe-commits

Reply via email to