[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry added a comment. I just came up with a case where the original implementation and this patch behave differently. void foobar(const float &); int main() { foobar(0); ^ } Used to `Passed by value`, now it is `Passed by const reference`. I think the former one is

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

clementval added a comment. Small suggestion Comment at: flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp:41-45 + std::string newName{result.second.name}; + if (appendUnderscore) +newName = newName + "_"; + + return newName; To avoid new copy

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille created this revision. Herald added subscribers: kosarev, kerbowa, jvesely, emaste. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Cuda and rocm toolchain detectors a

[PATCH] D142607: [clang][ASTImporter] Handle UsingType in friend declarations.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492352. VitaNuo added a comment. Sort the C symbol map. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc

[PATCH] D142607: [clang][ASTImporter] Handle UsingType in friend declarations.

balazske added a comment. The test causes this assert if the fix is not applied: Unhandled type of friend class UNREACHABLE executed at /local/clang/llvm2/llvm-project/clang/lib/AST/ASTImporterLookupTable.cpp:71! #0 0x7f4380b90e0a llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /

[clang] 8bb54da - Allow getRawCommentForDecl to find comments in macros

Author: Dana Jansens Date: 2023-01-26T10:12:57+01:00 New Revision: 8bb54da5da3194b71b54f70c6cc55485cf2623b0 URL: https://github.com/llvm/llvm-project/commit/8bb54da5da3194b71b54f70c6cc55485cf2623b0 DIFF: https://github.com/llvm/llvm-project/commit/8bb54da5da3194b71b54f70c6cc55485cf2623b0.diff

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bb54da5da31: Allow getRawCommentForDecl to find comments in macros (authored by danakj, committed by gribozavr). Repository: rG LLVM Github Monor

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

phosek added inline comments. Comment at: clang/CMakeLists.txt:959 ) add_custom_command(OUTPUT ${CLANG_OPTIMIZED} DEPENDS clang-bolt-profile We should consider placing this and all other intermediate outputs in `${CMAKE_CURRENT_BINARY_DIR}`. ===

[PATCH] D140565: [Clang][CMake] Set up distribution target for Clang-BOLT

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140565/new/ https://reviews.llvm.org/D140565 ___

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} v1nh1shungry wrote: > kadircet wrote: > > sorry for showing

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:31 + // Consider functions only in header files. + if (!Result.SourceManager->getFilename(SrcBegin).ends_with(".h")) +return; Probably better would

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:20 +void InlineFunctionDeclCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(decl(functionDecl()).bind("func_decl"), this); +} or mayb

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492362. Fznamznon added a comment. Add more sizes to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1); erichke

cfe-commits@lists.llvm.org

MyDeveloperDay added a comment. > Good to know it worked as expected on your project as well. I have some concerns (mainly because it feels like it could be quite invasive), hence I'm delaying on the LGTM, I really want to run this on a large code base, which I think if we commit post the bra

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

vabridgers added a comment. Thanks @Peter, I will try that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.org/D140059 ___ cfe-commits mailing list cfe-commits@lists.llvm.

cfe-commits@lists.llvm.org

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:116-117 + SmallVector &TrackedScopes) + : Scopes(TrackedScopes), Style(Style), Line(Line), +CurrentToken(Line.First), AutoFound(false), Keywords(Keywords) { Contexts

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Use `omp.canonical_loop` once it is in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://review

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta created this revision. xgupta added reviewers: nickdesaulniers, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fix PR37919 The below code produces -Wconstant-logical-operand f

[clang] e400c63 - Revert "[clang] Build UsingType for elaborated type specifiers."

Author: Haojian Wu Date: 2023-01-26T11:37:41+01:00 New Revision: e400c63cc39680538a3726a7736baf6b7844c3a8 URL: https://github.com/llvm/llvm-project/commit/e400c63cc39680538a3726a7736baf6b7844c3a8 DIFF: https://github.com/llvm/llvm-project/commit/e400c63cc39680538a3726a7736baf6b7844c3a8.diff LO

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492366. VitaNuo added a comment. Fix "atomic" and "div" overloads programmatically. Add a FIXME for future proper handling of overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://review

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:106 -SYMBOL(atomic_exchange_explicit, std::, ) -SYMBOL(atomic_fetch_add, std::, ) -SYMBOL(atomic_fetch_add_explicit, std::, ) -

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 492374. xgupta added a comment. add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/exprs.c clang/t

[clang] 55c9ad9 - [clang] Add test for CWG1960

Author: Vlad Serebrennikov Date: 2023-01-26T14:31:24+03:00 New Revision: 55c9ad99d12d18ee91a4c3e3609a0aacbaa5174e URL: https://github.com/llvm/llvm-project/commit/55c9ad99d12d18ee91a4c3e3609a0aacbaa5174e DIFF: https://github.com/llvm/llvm-project/commit/55c9ad99d12d18ee91a4c3e3609a0aacbaa5174e.

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

mstorsjo added a comment. This change broke the `parallel/bug54082.c` testcase in the OpenMP runtime test set, when running on Windows (both mingw and MSVC configurations, and happening both in i386 and x86_64 builds), see e.g. https://github.com/mstorsjo/llvm-mingw/actions/runs/4011290068/jobs

[clang] 839eae3 - [clang] Add test for CWG1960

Author: Vlad Serebrennikov Date: 2023-01-26T14:40:47+03:00 New Revision: 839eae38a4e4064568e1b3b0ee9538958ead8a40 URL: https://github.com/llvm/llvm-project/commit/839eae38a4e4064568e1b3b0ee9538958ead8a40 DIFF: https://github.com/llvm/llvm-project/commit/839eae38a4e4064568e1b3b0ee9538958ead8a40.

[PATCH] D142381: [clang] Add test for CWG1960

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG839eae38a4e4: [clang] Add test for CWG1960 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D140415: [flang] stack arrays pass

tblah added a comment. In D140415#4080080 , @jdoerfert wrote: > Did you check LLVM's heap2stack and the corresponding tests? > https://github.com/llvm/llvm-project/blob/c68af565ff0c2fdc5537e9ac0c2d7c75df44b035/llvm/lib/Transforms/IPO/AttributorAttributes.

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. WIP && TODO- Fixed test Failed Tests (7): Clang :: C/drs/dr4xx.c Clang :: Modules/explicit-build-extra-files.cpp Clang :: Parser/cxx2a-concept-declaration.cpp Clang :: SemaCXX/expressions.cpp Clang :: SemaCXX/warn-unsequenced.cpp Clang :: SemaObjC/unguarded-av

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. At least a part of the failures is reproducible with `-target aarch64` option. I try to fix the failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 ___

[PATCH] D142065: [SVE] Fix incorrect lowering of predicate permute builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26b79ca3fafc: [SVE] Fix incorrect lowering of predicate permute builtins. (authored by paulwalker-arm). Changed prior to commit: https://reviews.l

[clang] 26b79ca - [SVE] Fix incorrect lowering of predicate permute builtins.

Author: Paul Walker Date: 2023-01-26T12:10:39Z New Revision: 26b79ca3fafc525225090646d42837368b3763c3 URL: https://github.com/llvm/llvm-project/commit/26b79ca3fafc525225090646d42837368b3763c3 DIFF: https://github.com/llvm/llvm-project/commit/26b79ca3fafc525225090646d42837368b3763c3.diff LOG: [

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

DavidSpickett added a comment. I am attempting to reduce the compiler crash on 32 bit, it's a slow process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 ___

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

cor3ntin added a comment. In D142401#4074959 , @shafik wrote: > I could not find any tests that test for this warning. I'm unable to trigger the warning at all. I feel i should but just using that function resolves the crash, probably because it allocat

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added a comment. Thx @efriedma for reminding me of this. I'll update the documentation and try to give a shot at removing `MaybeAlign` from `GlobalObject`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142459/new/ https://reviews.llvm.or

[PATCH] D142315: [clang] Add test for CWG1111

Endill updated this revision to Diff 492395. Endill added a comment. Change status from "6" to "yes" since "ambiguous-member-template" warning is a false-positive now. - Disable "ambiguous-member-template" diagnostic in 98 and 03 modes - Add an example (`struct A`) - Apply clang-format Reposit

[PATCH] D142315: [clang] Add test for CWG1111

Endill added inline comments. Comment at: clang/test/CXX/drs/dr11xx.cpp:1 -// RUN: %clang_cc1 -std=c++98 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors +// RUN: %clang_cc1 -std=c++98 %s -verify=expected,cxx98 -fexceptions -fcxx-exceptions -pedantic-errors // RUN: %c

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492396. VitaNuo marked an inline comment as done. VitaNuo added a comment. Remove special casing from gen_std.py. Re-introduce special handling for std::remove. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492398. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc clang/in

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492400. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc clang/in

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The InterpFrame was only created so early so we c

[clang] ecec44f - AArch64: remove SM4 support from Apple CPUs.

Author: Tim Northover Date: 2023-01-26T13:00:36Z New Revision: ecec44f2ae733b3848d4dd71324f5fdc33adc62e URL: https://github.com/llvm/llvm-project/commit/ecec44f2ae733b3848d4dd71324f5fdc33adc62e DIFF: https://github.com/llvm/llvm-project/commit/ecec44f2ae733b3848d4dd71324f5fdc33adc62e.diff LOG:

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

alkis added a comment. Herald added a project: All. Does this change the semantics of `get_return_value()` such that it is eagerly converted to R the return value of the coro? AFAIU before this change one could return T convertible to R and the conversion would happen late - after `final_suspen

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu added a comment. In D131141#4081778 , @craig.topper wrote: > @VincentWu are you ok with the changes I made? sure, thank you for your work ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/n

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

eopXD added a comment. Hi @dyung and @DavidSpickett, Thank you for checking this out and sorry for the late reply (holiday zone right now in Taiwan). Let me look into it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141796/new/ https://revie

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu added a comment. should I update zcb to v1.0 in this patch? or create a new one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___ cfe-commits mailin

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492408. VitaNuo marked an inline comment as done. VitaNuo added a comment. Rely on alphabetic ordering to determine whether the symbol is new. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://r

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Thank you all for comments! The patch should be ready for the next review now. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:1053 SYMBOL(remainder, std::, ) +SYMBOL(remove, std::, ) SYMBOL(remove_all_extents, std::, ) ---

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam updated this revision to Diff 492410. zahiraam marked 3 inline comments as done. zahiraam edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGen/

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492413. VitaNuo added a comment. Remove extra import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

eopXD reopened this revision. eopXD added a comment. This revision is now accepted and ready to land. Reopening the revision to try land this correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141796/new/ https://reviews.llvm.org/D141796 ___

[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

tmatheson added inline comments. Comment at: llvm/unittests/TargetParser/TargetParserTest.cpp:1456 + std::optional Extension = + AArch64::parseArchExtension(ArchExt); + if (!Extension) I think we still need to test getDefaultExtensions, unless we're deleti

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Ok, thank you! This looks right to me :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 __

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

eopXD updated this revision to Diff 492420. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141796/new/ https://reviews.llvm.org/D141796 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h clan

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. The fixes LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756 ___ cfe-commits

[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: llvm/unittests/TargetParser/TargetParserTest.cpp:1456 + std::optional Extension = + AArch64::parseArchExtension(ArchExt); + if (!Extension) tmatheson wrote: > I think

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

eopXD added a comment. This commit seems to cause `riscv_vector_builtin_cg.inc` to explode into a 630K file, which causes the out-of-memory build fail. Confirmed that this is the commit that is causing the error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

DavidSpickett added a comment. Nice! Glad you spotted that, I have had creduce running and getting nowhere fast for a day or so. Sounds like it would never have found anything minimal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141796/new/ htt

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

eopXD added a comment. In D141796#4082665 , @DavidSpickett wrote: > Nice! > > Glad you spotted that, I have had creduce running and getting nowhere fast > for a day or so. Sounds like it would never have found anything minimal. Indeed! Thank you for yo

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:20 +void InlineFunctionDeclCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(decl(functionDecl()).bind("func_decl"), this); +} Cl

[PATCH] D142627: [analyzer] Fix crash exposed by D140059

vabridgers created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, hiraditya, xazax.hun. Herald added a project: All. vabridgers requested review of this revision. Herald added projects

[PATCH] D142315: [clang] Add test for CWG1111

Endill updated this revision to Diff 492430. Endill edited the summary of this revision. Endill added a comment. Move CWG2385 ("na") from D142316 into this patch. It makes more sense to put it here, because it fixes inconsistent wording introduced by CWG re

[PATCH] D142316: [clang] Add test for CWG2396

Endill updated this revision to Diff 492433. Endill edited the summary of this revision. Endill added a comment. Move CWG2385 out to D142315 , because it's been resolved prior to P1787 , and it's easier to explain it there. Repo

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

tianshilei1992 added a comment. In D142297#4082242 , @mstorsjo wrote: > This change broke the `parallel/bug54082.c` testcase in the OpenMP runtime > test set, when running on Windows (both mingw and MSVC configurations, and > happening both in i386 and

[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. Looks great, thanks Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:338 + + uint64_t getDefaultExtensions() const { +return DefaultExtensions | Ar

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

tstellar added a comment. Does this mean that clang will no longer search for the ROCM and CUDA library paths for every C compile? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142606/new/ https://reviews.llvm.org/D142606

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

eopXD updated this revision to Diff 492437. eopXD added a comment. Update code. The removal of `PolicyAttrs.IsUnspecified = false;` under void RVVIntrinsic::updateNamesAndPolicy(bool IsMasked, bool HasPolicy, std::string &Name,

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

eopXD added a comment. Re-commiting this now that the problem is resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141796/new/ https://reviews.llvm.org/D141796 ___ cfe-commits mailing list cfe-comm

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

erichkeane added a comment. A handful of suggestions as I spot-checked. This looks great, thank you for doing this! I'd like Aaron to take a look though. Comment at: clang/docs/ReleaseNotes.rst:51 +- The ``-fexperimental-new-pass-manager`` and ``-fno-legacy-pass-manager`` +

[clang] 719a728 - [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

Author: eopXD Date: 2023-01-26T07:06:33-08:00 New Revision: 719a728b86a1ce6b7bcf1eb9fd6860c4a88391bd URL: https://github.com/llvm/llvm-project/commit/719a728b86a1ce6b7bcf1eb9fd6860c4a88391bd DIFF: https://github.com/llvm/llvm-project/commit/719a728b86a1ce6b7bcf1eb9fd6860c4a88391bd.diff LOG: [1

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG719a728b86a1: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants (authored by eopXD). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille added a comment. In D142606#4082753 , @tstellar wrote: > Does this mean that clang will no longer search for the ROCM and CUDA library > paths for every C compile? That's the goal, yes. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D142016: [Clang][RISCV] Simplify RVV intrinsic policy suffix

eopXD updated this revision to Diff 492441. eopXD added a comment. Update code upon re-commit of D141796 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142016/new/ https://reviews.llvm.org/D142016 Files: clang/

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

DavidSpickett added a comment. Looks good to me - https://lab.llvm.org/buildbot/#/builders/245/builds/3919 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141796/new/ https://reviews.llvm.org/D141796 ___ c

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

alexfh added a comment. This patch breaks our cuda compilations. The output file isn't created after it: $ echo 'extern "C" __attribute__((global)) void q() {}' >q.cc $ good-clang \ -nocudainc -x cuda \ --cuda-path=somepath/cuda/ \ -Wno-unknown-cuda-version --cuda-device-onl

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:20 +void InlineFunctionDeclCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(decl(functionDecl()).bind("func_decl"), this); +} carlosg

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 added a comment. In D140158#4082789 , @alexfh wrote: > This patch breaks our cuda compilations. The output file isn't created after > it: > > $ echo 'extern "C" __attribute__((global)) void q() {}' >q.cc > $ good-clang \ > -nocudainc -x

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. @aaron.ballman Not sure if this (the added early re

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 created this revision. Michael137 added reviewers: erichkeane, aaron.ballman, aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for `TemplateArgumen

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

Michael137 abandoned this revision. Michael137 added a comment. Abandoning in favour of https://reviews.llvm.org/D141826 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140423/new/ https://reviews.llvm.org/D140423 ___

[PATCH] D142627: [analyzer] Fix crash exposed by D140059

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I would not mind less artificial-looking test code, but I'll let you decide if you want to make action about it. Have you thought about the rest of the callsites of `getBitWidth()`? Are th

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

alexfh added a comment. In D140158#4082804 , @jhuber6 wrote: > In D140158#4082789 , @alexfh wrote: > >> This patch breaks our cuda compilations. The output file isn't created after >> it: >> >> $ echo 'extern "

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added a comment. I'm not overly familiar with HLSL or DirectX here. Most of the changes are purely mechanical, but I don't see anywhere we create the tool. Does that come later? Normally you'd test these with `-ccc-print-bindings`, `-ccc-print-bindings`, and `-###`.

[PATCH] D142637: A more concise AST dump If the modifiedType and the minimally desugared type of an AttributedType are the same, then we do not need to visit both (or show both in an AST dump). Here

merrymeerkat created this revision. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...when it is different from the equivalentType (the minimally desugared type), because the latter is already vis

[clang] d4f4b2f - [clang] Fix sizeof of boolean vector

Author: Mariya Podchishchaeva Date: 2023-01-26T10:44:15-05:00 New Revision: d4f4b2fe21dddff023aeab775dd63b321e23f918 URL: https://github.com/llvm/llvm-project/commit/d4f4b2fe21dddff023aeab775dd63b321e23f918 DIFF: https://github.com/llvm/llvm-project/commit/d4f4b2fe21dddff023aeab775dd63b321e23f9

[PATCH] D142550: Fix sizeof of boolean vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f4b2fe21dd: [clang] Fix sizeof of boolean vector (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D142639: [clang] Warn by default that implicit capture of 'this' is deprecated in C++20 and later.

tahonermann created this revision. tahonermann added reviewers: aaron.ballman, erichkeane, rsmith, shafik. Herald added a project: All. tahonermann requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, a warning that C++20 deprecated

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

beanz added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687 +def warn_drv_dxc_missing_dxv : Warning<"dxv not found." +" Resulting DXIL will not be signed for use in release environments.">; Not all `dxv` binaries can sign

[PATCH] D142639: [clang] Warn by default that implicit capture of 'this' is deprecated in C++20 and later.

erichkeane accepted this revision. erichkeane added a subscriber: royjacobson. erichkeane added a comment. This revision is now accepted and ready to land. You'll need a rebase to get the pre-commit CI to work. Else, looks fine to me. Make sure @royjacobson knows of the change for this (https:

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

erichkeane added a comment. I think this looks correct, but 1 thing I found. Comment at: clang/lib/AST/TypePrinter.cpp:2020 + Expr const *pattern_expr = Pattern.getAsExpr(); + pattern_expr->dump(); + if (pattern_expr->isValueDependent() || this left over fro

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2020 + Expr const *pattern_expr = Pattern.getAsExpr(); + pattern_expr->dump(); + if (pattern_expr->isValueDependent() || erichkeane wrote: > this left over from debugging? Yes! Good ca

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 updated this revision to Diff 492458. Michael137 added a comment. - Remove `dump()` leftover from debugging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142632/new/ https://reviews.llvm.org/D142632 Files: clang/lib/AST/TypePrinter.cp

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvmlibc/inline-function-decl.cpp:18-19 + +// CHECK-MESSAGES: warning: 'addll' must be tagged with the LIBC_INLINE macro +// CHECK-MESSAGES: warning: 'addul' must be tagged with the LIBC_

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

bader added inline comments. Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:73 int subit(float a, float b, float *fp) { - // CHECKFAST: define {{.*}}@subit(float noundef %a, float noundef %b{{.*}} + // CHECKPRECISE: define {{.*}}@subit(float noundef %a, float nounde

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 492463. madanial added a comment. Addressing review comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/i

[PATCH] D142085: [WIP][1/N][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vsetvl, and vsetvlmax

eopXD updated this revision to Diff 492464. eopXD added a comment. Update code. Split the single patch into a patch-set of smaller steps. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142085/new/ https://reviews.llvm.org/D142085 Files: clang/inc

[clang] 98d5509 - Fix assertion failure "PathDiagnosticSpotPiece's must have a valid location." in ReturnPtrRange checker on builtin functions

Author: Arseniy Zaostrovnykh Date: 2023-01-26T17:26:05+01:00 New Revision: 98d55095d85129c2776a9d7a227c5f88e3ce2e01 URL: https://github.com/llvm/llvm-project/commit/98d55095d85129c2776a9d7a227c5f88e3ce2e01 DIFF: https://github.com/llvm/llvm-project/commit/98d55095d85129c2776a9d7a227c5f88e3ce2e0

[clang] 3674421 - [analyzer] Fix assertion failure in SMT conversion for unary operator on floats

Author: Tomasz Kamiński Date: 2023-01-26T17:33:48+01:00 New Revision: 3674421c4bc0cd3b65b8f1feaaf7038ac2d47ca8 URL: https://github.com/llvm/llvm-project/commit/3674421c4bc0cd3b65b8f1feaaf7038ac2d47ca8 DIFF: https://github.com/llvm/llvm-project/commit/3674421c4bc0cd3b65b8f1feaaf7038ac2d47ca8.dif

[PATCH] D142085: [WIP][1/N][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vsetvl, and vsetvlmax

eopXD added a comment. As requested, @jrtc27 @kito-cheng, the patch does not alter the function name now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142085/new/ https://reviews.llvm.org/D142085 ___ c

  1   2   3   >