MyDeveloperDay added a comment.
> Good to know it worked as expected on your project as well.
I have some concerns (mainly because it feels like it could be quite invasive),
hence I'm delaying on the LGTM, I really want to run this on a large code base,
which I think if we commit post the branch (which is now branched) we would
probably see more easily. Historically in the past I think the firefox team
have kindly picked up recent builds (no obligations) and catch any regressions.
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:2766
-void TokenAnnotator::annotate(AnnotatedLine &Line) const {
for (auto &Child : Line.Children)
----------------
was there a reason it could no longer be const?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141959/new/
https://reviews.llvm.org/D141959
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
