[clang] eae8d22 - [PS4] NFC: rewrite a test to use lit's DEFINE feature

Author: Paul Robinson Date: 2023-01-17T11:27:51-08:00 New Revision: eae8d22607027ddc9067ca8fa5fea1f1f6a9fb45 URL: https://github.com/llvm/llvm-project/commit/eae8d22607027ddc9067ca8fa5fea1f1f6a9fb45 DIFF: https://github.com/llvm/llvm-project/commit/eae8d22607027ddc9067ca8fa5fea1f1f6a9fb45.diff

[clang] f1f0a0d - Diagnose extensions in 'offsetof'

Author: Aaron Ballman Date: 2023-01-17T14:30:57-05:00 New Revision: f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee URL: https://github.com/llvm/llvm-project/commit/f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee DIFF: https://github.com/llvm/llvm-project/commit/f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee.diff

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. As reported in https://github.com/llvm/llvm-project/issues/54524, and later in https://github.com/llvm/llvm-project/issues/60038, we were not

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I've relanded this as f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee , changes include: - Removed error in C mode,

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman closed this revision. aaron.ballman added a comment. Closing as completed by f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 226ceeb - [RISCV] Use Zvl*b as a lower bound for VScaleRange.

Author: Craig Topper Date: 2023-01-17T11:32:29-08:00 New Revision: 226ceebfa232492d0c4613cd6c9f8e72b970fe08 URL: https://github.com/llvm/llvm-project/commit/226ceebfa232492d0c4613cd6c9f8e72b970fe08 DIFF: https://github.com/llvm/llvm-project/commit/226ceebfa232492d0c4613cd6c9f8e72b970fe08.diff

[PATCH] D141459: [RISCV] Use Zvl*b as a lower bound for VScaleRange.

This revision was automatically updated to reflect the committed changes. Closed by commit rG226ceebfa232: [RISCV] Use Zvl*b as a lower bound for VScaleRange. (authored by craig.topper). Herald added a subscriber: luke. Changed prior to commit: https://reviews.llvm.org/D141459?vs=488078&id=4899

cfe-commits@lists.llvm.org

dkt01 created this revision. dkt01 added reviewers: MyDeveloperDay, owenpan. dkt01 added a project: clang-format. Herald added a project: All. dkt01 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Token annotator for clang-format incorrectl

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. The code in Mem2Reg (Local.cpp) is wrong in the presence of DIExprs, but by luck we conservatively don't do anything. The function below is roughly doing: "if this store covers the entire size of the `DIVar`, rewrite the dbg declare into a dbg value. This is only corre

[PATCH] D136554: Implement CWG2631

aeubanks added a comment. In D136554#4059723 , @aeubanks wrote: > one more regression bisected to this: > https://bugs.chromium.org/p/chromium/issues/detail?id=1408177 > `incomplete type 'blink::ResourceClient' used in type trait expression` > I'll try t

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. This change appears to have broken the build when crosscompiling to x86-32 on a Linux x86-64 system; on the Halide buildbots, we now fail at link time with FAILED: bin/nvptx-arch : && /usr/bin/g++-7 -m32 -Wno-psabi -fPIC -fno-semantic-interposition -fvisibility-inline

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4060028 , @srj wrote: > This change appears to have broken the build when crosscompiling to x86-32 on > a Linux x86-64 system; on the Halide buildbots, we now fail at link time with > > FAILED: bin/nvptx-arch > :

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 489914. friss added a comment. The pre-commit CI showed some test failures on Windows. Try to address these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: cl

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

jcranmer-intel added a comment. From some of the verifier checks and tests, it looks like `target("x86.amx")` would also require some new type properties, to express its unsuitability for alloca-and-friends, as well as non-intrinsic arguments. The spelling change needs to be release noted, and

[PATCH] D141310: [clang] add -Wcompare-function-pointers

aaron.ballman added a comment. In D141310#4054351 , @dblaikie wrote: > @adriandole do you plan to deploy this in a codebase? Have you tried it on a > codebase already? > > I'd worry this would just be too noisy, and there's probably enough benign > poin

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. Docs still missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 4ce454c - [Clang] Configure definitions for amdgpu/nvptx arch query tools

Author: Joseph Huber Date: 2023-01-17T14:27:12-06:00 New Revision: 4ce454c654bd4e027fbdcd7b1dba9d164cd36463 URL: https://github.com/llvm/llvm-project/commit/4ce454c654bd4e027fbdcd7b1dba9d164cd36463 DIFF: https://github.com/llvm/llvm-project/commit/4ce454c654bd4e027fbdcd7b1dba9d164cd36463.diff

[PATCH] D141961: [clang][lex] Pass hash location to more PPCallbacks methods

KyleFromKitware created this revision. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". Herald added subscribers: kadircet, carlosgalvezp, shchenz, arphaman, kbarton, nemanjai. Herald added a reviewer: ributzka. Herald added a reviewer: njames93. H

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4060028 , @srj wrote: > This change appears to have broken the build when crosscompiling to x86-32 on > a Linux x86-64 system; on the Halide buildbots, we now fail at link time with > > FAILED: bin/nvptx-arch > :

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 updated this revision to Diff 489917. doru1004 marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td clang

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

aaron.ballman added a comment. In D141580#4052496 , @sammccall wrote: > To offer the opposing argument: if DeclResult is just a bad idea, then using > it consistently/right might be worse than using it as little as possible. > > FWIW, I find every piece

[clang] 6a76334 - [Clang] Reject in-class defaulting of previously declared comparison operators

Author: Roy Jacobson Date: 2023-01-17T22:29:51+02:00 New Revision: 6a763343e29f339cf3a9d282a309589174c74f09 URL: https://github.com/llvm/llvm-project/commit/6a763343e29f339cf3a9d282a309589174c74f09 DIFF: https://github.com/llvm/llvm-project/commit/6a763343e29f339cf3a9d282a309589174c74f09.diff

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a763343e29f: [Clang] Reject in-class defaulting of previously declared comparison operators (authored by royjacobson). Changed prior to commit: h

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

tschuett added a comment. Could you please put an X86.rst file into llvm/docs? There is a Sphinx template with instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141899/new/ https://reviews.llvm.org/D141899 __

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:5869-5870 +if (IteratorModifier) { + HasIteratorModifier = true; + getTrailingObjects()[2 * varlist_size()] = IteratorModifier; +} Can we use just a nullptr as a m

[clang] 3925fbc - nullptr returned from ActOnTag() is not a valid result

Author: Aaron Ballman Date: 2023-01-17T16:04:35-05:00 New Revision: 3925fbc80019f72bf3f5174736f348acfb5768b0 URL: https://github.com/llvm/llvm-project/commit/3925fbc80019f72bf3f5174736f348acfb5768b0 DIFF: https://github.com/llvm/llvm-project/commit/3925fbc80019f72bf3f5174736f348acfb5768b0.diff

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3925fbc80019: nullptr returned from ActOnTag() is not a valid result (authored by aaron.ballman). Changed prior to commit

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. Happy new year all-- Is there anything left for me to do before this can be merged? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 _

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added subscribers: Mordante, ldionne. erichkeane added a comment. @ldionne @Mordante The libcxx failure isn't clear what it is complaining about, but I thought this fix might end up breaking a libcxx test, since it would be easy to fall into the trap of having an implicit conversion

cfe-commits@lists.llvm.org

HazardyKnusperkeks added a comment. Could this be added to `Context` instead of a new type? Comment at: clang/lib/Format/TokenAnnotator.cpp:1205 case tok::r_brace: + if (Scopes.size() > 1) +Scopes.pop_back(); How does this happen? The only `pu

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

philnik added a comment. In D141954#4060212 , @erichkeane wrote: > @ldionne @Mordante The libcxx failure isn't clear what it is complaining > about, but I thought this fix might end up breaking a libcxx test, since it > would be easy to fall into the

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added a comment. In D141954#4060244 , @philnik wrote: > In D141954#4060212 , @erichkeane > wrote: > >> @ldionne @Mordante The libcxx failure isn't clear what it is complaining >> about, but I thought

[clang] 574a77a - [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

Author: Volodymyr Sapsai Date: 2023-01-17T15:33:36-06:00 New Revision: 574a77ae85451adc5e2dd9e73652c62bf18eed8d URL: https://github.com/llvm/llvm-project/commit/574a77ae85451adc5e2dd9e73652c62bf18eed8d DIFF: https://github.com/llvm/llvm-project/commit/574a77ae85451adc5e2dd9e73652c62bf18eed8d.di

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

This revision was automatically updated to reflect the committed changes. Closed by commit rG574a77ae8545: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

vsapsai added a comment. Thanks for the review, Florian! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson updated this revision to Diff 489934. royjacobson added a comment. Reject non class types, update doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141775/new/ https://reviews.llvm.org/D141775 Files: clang/docs/LanguageExtensions.rs

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae updated this revision to Diff 489935. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add BinaryAnalyzeJobClass. Add -Vd to disable validation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https:/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae added a comment. In D141705#4059162 , @beanz wrote: > Re-using the `VerifyDebug` action really doesn't make sense. That's not what > the DXIL validator does, and it will be a source of confusion forever. Added BinaryAnalyzeJobClass. Reposi

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5387 + return RD->canPassInRegisters(); +return true; } shafik wrote: > erichkeane wrote: > > Is there good reason to return true for all non-record types? Should we > > i

[PATCH] D141310: [clang] add -Wcompare-function-pointers

dblaikie added a comment. In D141310#4060069 , @aaron.ballman wrote: > In D141310#4054351 , @dblaikie > wrote: > >> @adriandole do you plan to deploy this in a codebase? Have you tried it on a >> codebase alrea

[PATCH] D141310: [clang] add -Wcompare-function-pointers

dblaikie added a comment. But I don't mean to suggest I should be a decider/veto here - it's cheap to maintain/no big deal, so maybe that's fine - but for myself, having at least some large scale customer with existing experience testing the warning and a strong commitment/motivation to keep us

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 489940. isuckatcs added a comment. - Renamed and moved `isMultiLevelConvertiblePointer()` to `ASTContext` - Added a unit test to test the said function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Fil

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

arsenm added inline comments. Comment at: clang/test/CodeGen/complex-strictfp.c:8-9 // Include rounding metadata in the testing. -// FIXME: All cases of "fpexcept.maytrap" in this test are wrong. -// FIXME: All cases of "round.tonearest" in this test are wrong. +// All cases of

[PATCH] D141961: [clang][lex] Pass hash location to more PPCallbacks methods

KyleFromKitware added a comment. WIP - currently updating the tests for `pp-trace` and in the process debugging an issue with the location of the `#endif` hash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141961/new/ https://reviews.llvm.org/D14

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

jansvoboda11 added a comment. In D119708#4059254 , @Hahnfeld wrote: > Hello, sorry for the late heads-up, but this functionality is used by ROOT: > https://github.com/root-project/root/blob/f58cccf5ce7fd67894c7fd9e9e74d3f37bc1acba/core/metacling/src/TCli

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 updated this revision to Diff 489942. doru1004 marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td clang

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/include/clang/Parse/Parser.h:3474-3475 bool parseMapperModifier(Sema::OpenMPVarListDataTy &Data); + /// Parses the iterator modifier in map clause. + bool parseIteratorModifier(Sema::OpenMPVarListDataTy &Data); /// Parses

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: > >

[PATCH] D141550: [CompilerRT] Remove ubsan static runtime on Apple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa44477b1f4b5: [CompilerRT] Remove ubsan static runtime on Apple (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a44477b - [CompilerRT] Remove ubsan static runtime on Apple

Author: usama hameed Date: 2023-01-17T14:33:31-08:00 New Revision: a44477b1f4b5c462474c12144d5f914d04a674cb URL: https://github.com/llvm/llvm-project/commit/a44477b1f4b5c462474c12144d5f914d04a674cb DIFF: https://github.com/llvm/llvm-project/commit/a44477b1f4b5c462474c12144d5f914d04a674cb.diff

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added projects: Flang, All. scott.linder requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, jdoerfert. Herald added projects: clang, OpenMP, LLVM.

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. I wasn't sure whether to include `getID` and unit-test it, or just drop it until it is used. If anyone has a preference let me know and I'll update the review. Repository: rG LLVM Github Mo

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. The error handling inconsistency is kind of annoying too but this is an improvement. I thought traditionally GCC accepted whatever big number you put after -O Repository: rG LLVM Github Mo

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 This is ABI breaking, so maybe we don't want/need to define the underlying type

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

arsenm added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 scott.linder wrote: > This is ABI breaking, so maybe we don't want/need to define the

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

dblaikie added a subscriber: colinl. dblaikie added a comment. In D141625#4059486 , @steven_wu wrote: > @dblaikie Do we have any bots running reverse iteration? Hmm, not that I can see/find at a quick glance, which is unfortunate. @mgrang Are you still

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

barannikov88 added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 arsenm wrote: > scott.linder wrote: > > This is ABI breaking, so maybe we don't

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

hokein updated this revision to Diff 489959. hokein added a comment. rebase and update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140875/new/ https://reviews.llvm.org/D140875 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

barannikov88 added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:67 + inline std::optional getLevel(IDType ID) { +if (ID < 0 || ID > 3) + return std::nullopt; As I can see, clients do not check for nullopt. Either add checks or replac

cfe-commits@lists.llvm.org

dkt01 marked 6 inline comments as done. dkt01 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2490-2491 +// Opeartors at class scope are likely pointer or reference members +if (TokScope == ScopeType::Class) + return TT_PointerOrReference; + --

cfe-commits@lists.llvm.org

dkt01 updated this revision to Diff 489962. dkt01 added a reviewer: HazardyKnusperkeks. dkt01 added a comment. Changes based on HazardyKnusperkeks' review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 Files: clang/lib/Format/TokenAnnotator

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. In D141625#4060460 , @dblaikie wrote: > In D141625#4059486 , @steven_wu > wrote: > >> @dblaikie Do we have any bots running reverse iteration? > > Hmm, not that I can see/find at a quic

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

kpn added inline comments. Comment at: clang/test/CodeGen/complex-strictfp.c:8-9 // Include rounding metadata in the testing. -// FIXME: All cases of "fpexcept.maytrap" in this test are wrong. -// FIXME: All cases of "round.tonearest" in this test are wrong. +// All cases of "fp

cfe-commits@lists.llvm.org

dkt01 updated this revision to Diff 489967. dkt01 added a comment. Further changes based on HazardyKnusperkeks' review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/Format

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 489968. friss added a comment. More Windows fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/

[PATCH] D141450: [Clang][cc1] Make -fno-modules-local-submodule-visibility the default for ObjC++20

Bigcheese updated this revision to Diff 489970. Bigcheese retitled this revision from "[Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default" to "[Clang][cc1] Make -fno-modules-local-submodule-visibility the default for ObjC++20". Bigcheese edited the summary of this r

cfe-commits@lists.llvm.org

dkt01 marked an inline comment as done. dkt01 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1205 case tok::r_brace: + if (Scopes.size() > 1) +Scopes.pop_back(); HazardyKnusperkeks wrote: > How does this happen? The only

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

shafik added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:379 + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), nullptr, + VK_PRValue, FPOptionsOverride());

[PATCH] D141573: [1/15][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

craig.topper accepted this revision. craig.topper added a comment. Herald added a subscriber: luke. LGTM Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:977 +llvm::SmallVector RVVIntrinsic::getSupportedUnMaskedPolicies() { + return { Possible improvem

[PATCH] D141574: [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:96 struct Policy { - bool PolicyNone = false; + bool IsUnspecified = false; enum PolicyType { Maybe this should default to true, and the constructor that want

[PATCH] D140937: [3/7][Clang][RISCV] Remove default tail-undisturbed for vslidedown intrinsics

craig.topper accepted this revision. craig.topper added a comment. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140937/new/ https://reviews.llvm.org/D140937 ___ cfe

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 489975. lebedev.ri added subscribers: Anastasia, arsenm. lebedev.ri added a comment. Ok, if we must not unconditionally emit the memory attributes, then let's not. Please stamp? :) @Anastasia @venvh @arsenm This breaks opencl headers in a way i do not und

[PATCH] D141577: [4/15][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:921 PolicyAttrs.TailPolicy = Policy::PolicyType::Agnostic; // TA

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

philnik added a comment. In D141954#4060246 , @erichkeane wrote: > In D141954#4060244 , @philnik wrote: > >> In D141954#4060212 , @erichkeane >> wrote: >> >>> @ldionne @

[clang] fe93da2 - [-Wunsafe-buffer-usage] Emit warnings about unsafe operations on arrays

Author: Rashmi Mudduluru Date: 2023-01-17T16:30:13-08:00 New Revision: fe93da22aa7bd57e277571cd692c7c0cc51c0478 URL: https://github.com/llvm/llvm-project/commit/fe93da22aa7bd57e277571cd692c7c0cc51c0478 DIFF: https://github.com/llvm/llvm-project/commit/fe93da22aa7bd57e277571cd692c7c0cc51c0478.di

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754 ___

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Oops I didn't mean to approve this with Kito's comments outstanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/n

[PATCH] D141756: [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141756/new/ https://reviews.llvm.org/D141756 ___ cfe-commits mailing list cfe-commits

[PATCH] D141759: [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141759/new/ https://reviews.llvm.org/D141759 ___ cfe-commits mailing list cfe-commits

[PATCH] D141764: [9/15][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

craig.topper added a comment. Description repeats a slightly different version of the same statement. The existing codebase works correctly upon this bug because the default policy for unmasked intrinsics is set to TAMU. The existing code works because the default policy for unmasked

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

craig.topper added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:1032 +if (IsMasked) { + if (PolicyAttrs.isTUMAPolicy() && !HasMaskPolicy) +appendPolicySuffix("_tum"); If you hadn't just removed Omit, it somewhat feels l

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141768/new/ https://reviews.llvm.org/D141768 ___ cfe-commits mailing list cfe-commits

[PATCH] D141789: [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in riscv_vector_builtin_cg.inc

craig.topper added inline comments. Herald added a subscriber: luke. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:428 +// The 0th bit simulates the `vta` of RVV +// The 1st bit simultaes the `vma` of RVV +// constexpr unsigned RVV_VTA = 0x1;

[PATCH] D141792: [13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics-autogenerated

craig.topper added a comment. Herald added a subscriber: luke. Does this really depend on the earlier patches in the series? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141792/new/ https://reviews.llvm.org/D141792 ___

[PATCH] D141792: [13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics-autogenerated

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141792/new/ https://reviews.llvm.org/D141792 ___

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

NoQ added a comment. Looks great! Sounds like you're looking for a more permanent fix, I guess `ConversionFixItGenerator` could try to avoid adding fixits to system header functions? Comment at: clang/lib/Sema/SemaOverload.cpp:10923-10927 +for (std::vector::iterator HI =

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

hzq updated this revision to Diff 489995. hzq marked an inline comment as not done. hzq added a comment. Update the check content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141886/new/ https://reviews.llvm.org/D141886 Files: clang/test/Drive

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

hzq added a comment. @bryanpkc Modified, Thanks for detailed guidance.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141886/new/ https://reviews.llvm.org/D141886 ___ cfe-commits mailing list cfe-commit

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

vsapsai updated this revision to Diff 490003. vsapsai added a comment. Rebase the patch and trigger pre-commit checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141424/new/ https://reviews.llvm.org/D141424 Files: clang/lib/Sema/SemaType.cpp

[clang] 214312e - [-Wunsafe-buffer-usage][NFC] Refactor checkUnsafeBufferUsage

Author: Jan Korous Date: 2023-01-17T18:00:47-08:00 New Revision: 214312ef7ee495e36a9626a0f8955be9d2bc8b78 URL: https://github.com/llvm/llvm-project/commit/214312ef7ee495e36a9626a0f8955be9d2bc8b78 DIFF: https://github.com/llvm/llvm-project/commit/214312ef7ee495e36a9626a0f8955be9d2bc8b78.diff LO

[PATCH] D141333: [-Wunsafe-buffer-usage][NFC] Refactor checkUnsafeBufferUsage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG214312ef7ee4: [-Wunsafe-buffer-usage][NFC] Refactor checkUnsafeBufferUsage (authored by jkorous). Herald added a project: clang. Herald added a subsc

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

LuoYuanke added a comment. We need consider how to be compatible with the existing software if we want the change the IR type. There are some existing software that is based on the existing type. For example the AMX dialect of MLIR and TLX code are based on the x86_amx, it would break them if w

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15258 + // units. Deleted and Defaulted functions are implicitly inline (but the + // inline state is not set at this point, so check the BodyKind explicitly). if (getLangOpts().CPlusPlusModules && cur

[clang] f900742 - [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

Author: Chuanqi Xu Date: 2023-01-18T10:26:53+08:00 New Revision: f900742746734953e8823319d5c8c40d857c10ea URL: https://github.com/llvm/llvm-project/commit/f900742746734953e8823319d5c8c40d857c10ea DIFF: https://github.com/llvm/llvm-project/commit/f900742746734953e8823319d5c8c40d857c10ea.diff LO

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf90074274673: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag (authored by ChuanqiXu). Herald added a project: libc++. Herald added a subscr

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added a comment. In D137058#4058836 , @Jake-Egan wrote: > In D137058#4057424 , @ChuanqiXu > wrote: > >> In D137058#4056647 , @Jake-Egan >> wrote: >> >>> Hi, th

[clang] 98f36ac - [C++20] [Modules] Deprecate `-fmodules-ts` flag

Author: Chuanqi Xu Date: 2023-01-18T10:39:21+08:00 New Revision: 98f36ac4fa86d7f7a3f05b70f792c416fbb23a4a URL: https://github.com/llvm/llvm-project/commit/98f36ac4fa86d7f7a3f05b70f792c416fbb23a4a DIFF: https://github.com/llvm/llvm-project/commit/98f36ac4fa86d7f7a3f05b70f792c416fbb23a4a.diff LO

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

vsapsai added inline comments. Comment at: clang/lib/AST/Decl.cpp:4881-4882 + // For RecordDecl the ODRHash is stored in the remaining 26 + // bit of RecordDeclBits, adjust the hash to accomodate. + setODRHash(Hash.CalculateHash() >> 6); + return RecordDeclBits.ODRHash; -

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

yonghong-song accepted this revision. yonghong-song added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141424/new/ https://reviews.llvm.org/D141424

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added a comment. In D127855#4059776 , @jyu2 wrote: > Hi @sandeepkosuri, do you plan to fix this? Thanks. Jennifer Hi jyu2, sorry for a late reply, and yes I will fix it. Thanks for pointing this out. Repository: rG LLVM Github Monore

<    1   2   3   >