NoQ added a comment. Looks great! Sounds like you're looking for a more permanent fix, I guess `ConversionFixItGenerator` could try to avoid adding fixits to system header functions?
================ Comment at: clang/lib/Sema/SemaOverload.cpp:10923-10927 + for (std::vector<FixItHint>::iterator HI = Cand->Fix.Hints.begin(), + HE = Cand->Fix.Hints.end(); + HI != HE; ++HI) + FDiag << *HI; + } ---------------- Since you're reformatting anyway, maybe use a range-based for-loop? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141868/new/ https://reviews.llvm.org/D141868 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits