LuoYuanke added a comment.

We need consider how to be compatible with the existing software if we want the 
change the IR type. There are some existing software that is based on the 
existing type. For example the AMX dialect of MLIR and TLX code are based on 
the x86_amx, it would break them if we change the type. Some existing bitcode 
or text format IR already have already based on x86_amx. They will also be 
broken if we change the IR type. And I am also concerned about the following 
patch that remove amx cast intrinsics. We've done many optimization based on 
the intrinsics. Removing the intrinsics would break the optimization and all 
the code for the existing software.

Given the current patch is intrusive to current AMX solution, I would suggest 
author to describe the background and roadmap of your work and prototype the 
target extension type and its usage without changing x86_amx. If the prototype 
is good, we can discuss how to switch AMX to the new infrastructure without 
breaking existing software.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141899/new/

https://reviews.llvm.org/D141899

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to