[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. So if I understand completely its so its easier to pick up an option and share as a hyperlink i.e. `<.>/llvm-project/clang/html/ClangFormatStyleOptions.html#allowallconstructorinitializersonnextline` F26159404: image.pn

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik added a comment. In D141572#4047428 , @aaron.ballman wrote: > Thank you for working on this! I think the Debian CI failure is unrelated, > but the libc++ one looks plausibly related: > > > /home/libcxx-builder/.buildkite-agent/builds/e6f11fd2

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

aaron.ballman added a comment. In D138446#4047487 , @MyDeveloperDay wrote: > So if I understand completely its so its easier to pick up an option and > share as a hyperlink i.e. > `<.>/llvm-project/clang/html/ClangFormatStyleOptions.html#allowallc

[clang] 452115e - Reword diagnostic slightly; NFC

Author: Aaron Ballman Date: 2023-01-12T10:12:57-05:00 New Revision: 452115eaec6a493f8c8308b1eb2334100e2b6320 URL: https://github.com/llvm/llvm-project/commit/452115eaec6a493f8c8308b1eb2334100e2b6320 DIFF: https://github.com/llvm/llvm-project/commit/452115eaec6a493f8c8308b1eb2334100e2b6320.diff

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. On my laptop running import os; import multiprocessing def main(): num = len(os.sched_getaffinity(0)) numcpu = multiprocessing.cpu_count()

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

kadircet added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:145 path = os.path.join(root_dir, symbol_page_path) - results.append((symbol_name, + if os.path.isfile(path): +results.append((symbol_name, sor

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

aaron.ballman added a comment. In D140860#4045224 , @dblaikie wrote: > In D140860#4044937 , @aaron.ballman > wrote: > >> In D140860#4031872 , @dblaikie >> wrote: >> >>>

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 488645. pmatos added a comment. @aaron.ballman Added support for externref mangling in Microsoft. This follows the pattern implemented by OpenCL types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos added a comment. In D128440#4047535 , @pmatos wrote: > @aaron.ballman Added support for externref mangling in Microsoft. This > follows the pattern implemented by OpenCL types. Wrong revision - sorry. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

erichkeane added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2481 + case BuiltinType::Id: \ +Out << "PA"; \ +mangleArtificialTagType(TTK_Struct, MangledN

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 488646. pmatos added a comment. Undo last patch. Submitted change to incorrect revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/A

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

VitaNuo created this revision. Herald added a subscriber: arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141611 Files: clang

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 488648. pmatos added a comment. Now under the correct revision: @aaron.ballman Added support for externref mangling in Microsoft. This follows the pattern implemented by OpenCL types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

VitaNuo updated this revision to Diff 488653. VitaNuo added a comment. Change implementation from using "print" to using "sys.stderr.write". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141611/new/ https://reviews.llvm.org/D141611 Files: clang/

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

VitaNuo added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:145 path = os.path.join(root_dir, symbol_page_path) - results.append((symbol_name, + if os.path.isfile(path): +results.append((symbol_name, kadi

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/tools/include-mapping/cppreference_parser.py:149 + else: +sys.stderr.write("Could not parse page: %s. Page does not exist.\n" % pa

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mati865 added a comment. In D141206#4043375 , @mstorsjo wrote: > Updated with some testcases. This does test that the include directory is > omitted when cross compiling, but those kinds of tests, which set up a > simulated toolchain environment with sy

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng updated this revision to Diff 488656. kito-cheng added a comment. Changes: - Address Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140693/new/ https://reviews.llvm.org/D140693 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

carlosgalvezp updated this revision to Diff 488657. carlosgalvezp added a comment. Update clang-tidy formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/new/ https://reviews.llvm.org/D141583 Files: clang-tools-extra/clang-tidy/Clang

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:106 +- Deprecate the global configuration file option `AnalyzeTemporaryDtors`, + which is no longer in use. The option will be fully removed i

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

hazohelet added a comment. In D140860#4047534 , @aaron.ballman wrote: > In D140860#4045224 , @dblaikie > wrote: > >> In D140860#4044937 , >> @aaron.ballman wrote: >> >>

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

VitaNuo updated this revision to Diff 488659. VitaNuo added a comment. Mention symbol name in the error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141611/new/ https://reviews.llvm.org/D141611 Files: clang/tools/include-mapping/cppref

[clang] ed00101 - [include-mapping] Print an error message in case the symbol index points to a non-existent page.

Author: Viktoriia Bakalova Date: 2023-01-12T15:59:32Z New Revision: ed001018a02b3d8da699317cad7f7727d126f01d URL: https://github.com/llvm/llvm-project/commit/ed001018a02b3d8da699317cad7f7727d126f01d DIFF: https://github.com/llvm/llvm-project/commit/ed001018a02b3d8da699317cad7f7727d126f01d.diff

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed001018a02b: [include-mapping] Print an error message in case the symbol index points to a… (authored by VitaNuo). Repository: rG LLVM Github Mon

[clang] a013839 - [Clang] Diagnose undefined behavior in a constant expression while evaluating a compound assignment with remainder as operand

Author: Shafik Yaghmour Date: 2023-01-12T08:04:04-08:00 New Revision: a0138390dd2ac2130c9f76e6778d6e45e4dc5526 URL: https://github.com/llvm/llvm-project/commit/a0138390dd2ac2130c9f76e6778d6e45e4dc5526 DIFF: https://github.com/llvm/llvm-project/commit/a0138390dd2ac2130c9f76e6778d6e45e4dc5526.dif

[PATCH] D140455: [Clang] Diagnose undefined behavior in a constant expression while evaluating a compound assignment with remainder as operand

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0138390dd2a: [Clang] Diagnose undefined behavior in a constant expression while evaluating a… (authored by shafik). Herald added a project: clang.

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:107 + which is no longer in use. The option will be fully removed in + :program:`clang-tidy-18`. + But isn't such naming artifact of packaging? May be ":program:`clang-tid

[PATCH] D141414: [clang] add warning on shifting boolean type

aaron.ballman added a comment. Thank you for working on this! It seems that precommit CI found valid failures that should be addressed: Clang :: AST/Interp/shifts.cpp Clang :: Analysis/svalbuilder-simplify-no-crash.c Clang :: CXX/over/over.built/p18.cpp Clang :: Misc/warning-flags.c Ple

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D136565: [clang] Instantiate alias templates with sugar

erichkeane added a comment. In D136565#4032150 , @erichkeane wrote: > Note that the Clang 16 branch is coming up approximately on January 24, and > this needs to be reverted or perf-regression fixed by then. @mizvekov : If > you or someone else don't

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng marked 3 inline comments as done. kito-cheng added a comment. > (I probably need to update my > https://maskray.me/blog/2022-08-28-march-mcpu-mtune) At least the behavior of RISC-V GCC need to update: Architecture extension: - Take from -march if present. - Take from -mcpu if presen

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

carlosgalvezp updated this revision to Diff 488663. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Fix name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/new/ https://reviews.llvm.org/D141583 Files: clang-t

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

aaron.ballman added a subscriber: rnk. aaron.ballman added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2479-2483 +#define WASM_REF_TYPE(InternalName, MangledName, Id, SingletonId, AS) \ + case BuiltinType::Id:

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

shafik added subscribers: aaron.ballman, shafik. shafik added a comment. I wonder if `ActionResult` needs a overload that takes `std::nullptr_t` the current interface seems easy to use wrong like we have seen here. @aaron.ballman wdyt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. @mizvekov : I'm looking at the revert of this since no work seems to have been done to fix @steven_wu 's problem. Unfortunately, it seems that reverting this requires reverting https://reviews.llvm.org/D134604 plus all of the "Instantiate" patches, which undoes basi

[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. In D131858#4047785 , @erichkeane wrote: > @mizvekov : I'm looking at the revert of this since no work seems to have > been done to fix @steven_wu 's problem. Unfortunately, it seems that > reverting this requires revertin

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4047799 , @v.g.vassilev wrote: > In D131858#4047785 , @erichkeane > wrote: > >> @mizvekov : I'm looking at the revert of this since no work seems to have >> been done to f

[clang] 77c5eac - [LinkerWrapper] Fix errors from missing files during a dry run

Author: Joseph Huber Date: 2023-01-12T10:49:27-06:00 New Revision: 77c5eac2aa9b9b1a12850295abf84d51f87745de URL: https://github.com/llvm/llvm-project/commit/77c5eac2aa9b9b1a12850295abf84d51f87745de DIFF: https://github.com/llvm/llvm-project/commit/77c5eac2aa9b9b1a12850295abf84d51f87745de.diff

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. I am trying this in the wild and getting some false positives where it tries to call std::move inside loop conditions and in the boolean condition for an if statement. Stuff like: if (auto* new_ptr = steal_ptr(std::move(old_ptr))) { ... } else { return

[PATCH] D141620: clang/OpenCL: Make enqueued blocks inherit the parent attributes

arsenm created this revision. arsenm added reviewers: Anastasia, yaxunl. Herald added subscribers: kosarev, jdoerfert, kerbowa, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. This was missing important environment context, like deno

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 updated this revision to Diff 488679. jhuber6 added a comment. Fix test, should be good to go now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 Files: clang/test/Driver/linker-wrapper.c cla

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

arsenm added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:531-537 + CmdArgs.push_back(*ClangPath); + CmdArgs.push_back("-o"); + CmdArgs.push_back(*TempFileOrErr); + CmdArgs.push_back("-fPIC"); + CmdArgs.push_back("-c"); + CmdArgs.push

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 488685. tblah added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added projects: clang, Flang. - Do not move allocations outside of openmp regions - Detect loops in the control flow graph - Attempt to use

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 488686. tblah added a comment. Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Updated to construct StackArrays as a ModuleOp pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4047677 , @inclyc wrote: > ping :) Oh! I missed your pings because this was already marked as accepted, I'm sorry for the delay in answering your question. In D133574#3994050

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

kadircet added inline comments. Comment at: clang/cmake/modules/AddGRPC.cmake:7 generate_proto_sources(ProtoSource ${ProtoFile} ${PROTO_UNPARSED_ARGUMENTS}) + set(LINKED_GRPC_LIBRARIES protobuf gpr grpc grpc++) Hi @sylvestre.ledru this seem to have broken c

[PATCH] D141551: Require input target triples to have Environment field

lamb-j abandoned this revision. lamb-j added a comment. We're ok with env field being blank, so this doesn't accomplish what we need Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141551/new/ https://reviews.llvm.org/D141551 ___

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

sylvestre.ledru added a comment. thanks. reverting is fine :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141047/new/ https://reviews.llvm.org/D141047 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 updated this revision to Diff 488690. jhuber6 added a comment. Changing to initializer list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 Files: clang/test/Driver/linker-wrapper.c clang/too

[clang] 275bca6 - Revert "build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too"

Author: Kadir Cetinkaya Date: 2023-01-12T18:14:41+01:00 New Revision: 275bca657529ac07781c5f84e6485fa9d98a1c44 URL: https://github.com/llvm/llvm-project/commit/275bca657529ac07781c5f84e6485fa9d98a1c44 DIFF: https://github.com/llvm/llvm-project/commit/275bca657529ac07781c5f84e6485fa9d98a1c44.dif

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Thanks, maybe I'll actually be able to comprehend openmp now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/

[clang-tools-extra] edba5d5 - [clangd] Fix tests for CLANGD_TIDY_CHECKS=OFF builds

Author: Kadir Cetinkaya Date: 2023-01-12T18:25:52+01:00 New Revision: edba5d58cd190591516ac8048a1bf4ebd0fb263f URL: https://github.com/llvm/llvm-project/commit/edba5d58cd190591516ac8048a1bf4ebd0fb263f DIFF: https://github.com/llvm/llvm-project/commit/edba5d58cd190591516ac8048a1bf4ebd0fb263f.dif

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5736 + C.getArgs().hasArg(options::OPT_fmodule_output) && + C.getArgs().hasArg(options::OPT_o)) { +SmallString<128> OutputPath; ChuanqiXu wrote: > dblaikie wrote: > > tahonerman

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

carlosgalvezp added a comment. Thanks for reviewing! I can also add that the actual code using the option was removed around 5 years ago, so it's about time :) @njames93 Do you have any concerns with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D139774: [libclang] Add API to set temporary directory location

dblaikie added a comment. In D139774#4046308 , @vedgy wrote: > In D139774#4045361 , @dblaikie > wrote: > >> 1. Should clang be doing something better with these temp files anyway, no >> matter the directory they

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141381/new/ https://reviews.llvm.org/D141381

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

aaron.ballman added a comment. In D141580#4047737 , @shafik wrote: > I wonder if `ActionResult` needs a overload that takes `std::nullptr_t` the > current interface seems easy to use wrong like we have seen here. > > @aaron.ballman wdyt? I don't think t

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

adriandole updated this revision to Diff 488699. adriandole added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139570/new/ https://reviews.llvm.org/D139570 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnos

[PATCH] D138851: [Clang] Permit static constexpr variables in constexpr functions

shafik added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:246 + +constexpr double evaluate_static_constexpr() { + struct Constexpr{ Can we also add the test from the proposal as well for completeness sake: ``` constexpr char tes

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D140860#4047632 , @hazohelet wrote: > In D140860#4047534 , @aaron.ballman > wrote: > >> In D140860#40

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit this on your behalf? If so, what name and email address would you like for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139

[clang] 95a4c0c - [clang] Reland parenthesized aggregate init patches

Author: Alan Zhao Date: 2023-01-12T09:58:15-08:00 New Revision: 95a4c0c83554c025ef709a6805e67233d0dedba0 URL: https://github.com/llvm/llvm-project/commit/95a4c0c83554c025ef709a6805e67233d0dedba0 DIFF: https://github.com/llvm/llvm-project/commit/95a4c0c83554c025ef709a6805e67233d0dedba0.diff LOG

[PATCH] D141546: [clang] Reland parenthesized aggregate init patches

This revision was automatically updated to reflect the committed changes. Closed by commit rG95a4c0c83554: [clang] Reland parenthesized aggregate init patches (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141546/new/ https://re

[clang] edbfc10 - clang: Fix excessively strict test requirements

Author: Matt Arsenault Date: 2023-01-12T13:00:49-05:00 New Revision: edbfc10b48651c94e0c3c774f2a45011b36796e1 URL: https://github.com/llvm/llvm-project/commit/edbfc10b48651c94e0c3c774f2a45011b36796e1 DIFF: https://github.com/llvm/llvm-project/commit/edbfc10b48651c94e0c3c774f2a45011b36796e1.diff

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

aaron.ballman accepted this revision. aaron.ballman added a comment. Code LGTM but please add a release note for the change so folks are aware. Also, do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? CHANGES SINCE LAST A

[PATCH] D141617: OpenMP: Use inbounds in EmitOMPAggregateAssign

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141617/new/ https://reviews.llvm.org/D141617 ___ cfe-commits mailing list cfe-commi

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 488706. seanptmaher added a comment. Add jobs flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files: clang/tools/clang-format/clang-format-diff.py Index:

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 488707. python3kgae added a comment. Fix test fail after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayou

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. Yeah, the jobs flag is a much better implementation. Thanks for the comments. I've implemented that. I was indeed making the assumption that this is all that's running, etc. as you mentioned. The use case I was using this with was running diff formatting of very la

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

alvinhochun added inline comments. Comment at: clang/test/Driver/mingw-sysroot.cpp:25-38 // RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s 2>&1 | FileCheck -check-prefix=CHECK_TESTROOT_GCC

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 488708. seanptmaher added a comment. fix the formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files: clang/tools/clang-format/clang-format-diff.py In

[clang] 753aca0 - [AArch64] Add an error if SVE scalable vector types are used in a context without sve

Author: David Green Date: 2023-01-12T18:21:28Z New Revision: 753aca0a3ab0c1822ab3a95beaf8eaa91d7a157d URL: https://github.com/llvm/llvm-project/commit/753aca0a3ab0c1822ab3a95beaf8eaa91d7a157d DIFF: https://github.com/llvm/llvm-project/commit/753aca0a3ab0c1822ab3a95beaf8eaa91d7a157d.diff LOG: [

[PATCH] D131058: [AArch64] Add an error if SVE scalable vector types are used in a context without sve

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG753aca0a3ab0: [AArch64] Add an error if SVE scalable vector types are used in a context… (authored by dmgreen). Herald added a project: clang. Herald

[clang] 824874c - [AIX][NFC] Unsupport test when running on AIX

Author: Jake Egan Date: 2023-01-12T13:21:59-05:00 New Revision: 824874c8d43383f0e6bdeb8a914c95fb916ecd9d URL: https://github.com/llvm/llvm-project/commit/824874c8d43383f0e6bdeb8a914c95fb916ecd9d DIFF: https://github.com/llvm/llvm-project/commit/824874c8d43383f0e6bdeb8a914c95fb916ecd9d.diff LOG

[clang] 8effeb4 - Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

Author: Adrian Dole Date: 2023-01-12T18:25:12Z New Revision: 8effeb44f4a8ae3da8c594fdc69ac46dd6ab6f1b URL: https://github.com/llvm/llvm-project/commit/8effeb44f4a8ae3da8c594fdc69ac46dd6ab6f1b DIFF: https://github.com/llvm/llvm-project/commit/8effeb44f4a8ae3da8c594fdc69ac46dd6ab6f1b.diff LOG: A

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8effeb44f4a8: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address (authored by adriandole, committed by cjdb). Repository: rG LLVM Githu

[PATCH] D139686: [lsan] Add lsan support for loongarch64

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:140 +const internal::VariadicDynCastAllOfMatcher +dependentNameTypeLoc; // NOLINT(readability-identifier-naming) + ---

[clang] 7f2f6ee - clang/OpenCL: Check calling convention in test

Author: Matt Arsenault Date: 2023-01-12T13:39:23-05:00 New Revision: 7f2f6eec3ead9c5715c86159919d6df182d1cc4d URL: https://github.com/llvm/llvm-project/commit/7f2f6eec3ead9c5715c86159919d6df182d1cc4d DIFF: https://github.com/llvm/llvm-project/commit/7f2f6eec3ead9c5715c86159919d6df182d1cc4d.diff

[PATCH] D141538: [cmake] Fix path to LLVMConfig.cmake for multi-config builds

nhat-nguyen added a comment. The build is failing on debian with these 4 tests timing out: Timed Out Tests (4): Clang :: CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vloxseg.c Clang :: CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vluxseg.c C

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG944f4b280585: [DirectX backend] add support ConstantBuffer to DXILResource.h (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANG

[clang] 9e239fc - [LinkerWrapper] Emit assembly files from LTO with `save-temps`

Author: Joseph Huber Date: 2023-01-12T12:54:53-06:00 New Revision: 9e239fc487d51d6b90ad50f6ffa72203d8df3210 URL: https://github.com/llvm/llvm-project/commit/9e239fc487d51d6b90ad50f6ffa72203d8df3210 DIFF: https://github.com/llvm/llvm-project/commit/9e239fc487d51d6b90ad50f6ffa72203d8df3210.diff

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e239fc487d5: [LinkerWrapper] Emit assembly files from LTO with `save-temps` (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D141596: [Driver] Add crtfastmath.o on Solaris if appropriate

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141596/new/ https://reviews.llvm.org/D141596

[clang] 9cddd7a - [clang-format][docs] Add ability to link to specific config options

Author: Emilia Dreamer Date: 2023-01-12T21:05:38+02:00 New Revision: 9cddd7a2a1d231bf390679b7bc529c260b4a1e07 URL: https://github.com/llvm/llvm-project/commit/9cddd7a2a1d231bf390679b7bc529c260b4a1e07 DIFF: https://github.com/llvm/llvm-project/commit/9cddd7a2a1d231bf390679b7bc529c260b4a1e07.diff

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cddd7a2a1d2: [clang-format][docs] Add ability to link to specific config options (authored by rymiel). Changed prior to commit: https://reviews.llvm.org/D138446?vs=476929&id=488720#toc Repository: r

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488722. paulkirth added a comment. Add target triple to all RUN lines. Seems like the layout is the same on 64-bit windows, but for some reason clang.exe chooses i386 unless the triple is set. So just set the triple uniformly, and avoid any potential proble

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140693/new/ https://reviews.llvm.org/D140693 ___

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

efriedma added a comment. I'm not trying to argue what the `pure`/`const` attribute in C/C++ is supposed to mean. I agree with your interpretation of the gcc documentation/implementation. I'm saying that there's a mismatch between the gcc `pure`/`const` and the LLVM IR `memory(read)`/`memory(

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 updated this revision to Diff 488724. njames93 marked 2 inline comments as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/ https://reviews.llvm.org/D137302 Files: clang-tools-e

[PATCH] D140686: [Clang][RISCV] Update operand order for vmerge and vcompress

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/ https://reviews.llvm.org/D140686 ___

[clang-tools-extra] b616811 - [clang-tidy][NFC] Make CheckFactories::CreateChecks* const

Author: Nathan James Date: 2023-01-12T19:20:54Z New Revision: b616811dde41d851dddf7a5e1b9848e53d2aa10e URL: https://github.com/llvm/llvm-project/commit/b616811dde41d851dddf7a5e1b9848e53d2aa10e DIFF: https://github.com/llvm/llvm-project/commit/b616811dde41d851dddf7a5e1b9848e53d2aa10e.diff LOG:

[PATCH] D141558: [MemProf] Collect access density statistics during profiling

snehasish added a comment. Thanks for updating the tests. Comment at: llvm/include/llvm/ProfileData/MemProfData.inc:35 // The version number of the raw binary format. #define MEMPROF_RAW_VERSION 1ULL Can you increment the version here? Then we won't acciden

[PATCH] D138566: [clang-tidy][NFC] Make CheckFactories::CreateChecks* const

This revision was automatically updated to reflect the committed changes. Closed by commit rGb616811dde41: [clang-tidy][NFC] Make CheckFactories::CreateChecks* const (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138566/new/ h

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

njames93 accepted this revision. njames93 added a comment. In D141583#4047975 , @carlosgalvezp wrote: > Thanks for reviewing! I can also add that the actual code using the option > was removed around 5 years ago, so it's about time :) @njames93 Do you h

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488727. paulkirth added a comment. Make YAML tests less brittle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test/Frontend/stack-layout-remark.c

[PATCH] D141098: [clang-format][NFC] Set DeriveLineEnding to false in config files

owenpan added a comment. Unfortunately, changing the default value of `DeriveLineEnding` to `false` would break too many unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/ https://reviews.llvm.org/D141098 __

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:10277-10281 + AddTemplateOverloadCandidate(TD, FoundDecl, /*ExplicitArgs*/ nullptr, + TmpInits, Candidates, + SuppressUserConversions, +

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu created this revision. steven_wu added reviewers: jansvoboda11, akyrtzi, benlangmuir, vsapsai, rnk, dblaikie. Herald added subscribers: ributzka, mgrang. Herald added a project: All. steven_wu requested review of this revision. Herald added a project: clang. Fix a non-deterministic issu

[PATCH] D140937: [3/7][Clang][RISCV] Remove default tail-undisturbed for vslidedown intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140937/new/ https://reviews.llvm.org/D140937 ___

<    1   2   3   4   >