mati865 added a comment.

In D141206#4043375 <https://reviews.llvm.org/D141206#4043375>, @mstorsjo wrote:

> Updated with some testcases. This does test that the include directory is 
> omitted when cross compiling, but those kinds of tests, which set up a 
> simulated toolchain environment with symlinks, don't run on actual Windows - 
> so it's not quite as easy to test the case that we actually do keep the 
> unprefixed include directory on Windows. As this matches the current testing 
> coverage status quo, I hope this is ok...

Personally I don't mind that, it's unlikely to ever get 100% coverage because 
of known limitations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141206/new/

https://reviews.llvm.org/D141206

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to