kadircet added inline comments.
================
Comment at: clang/cmake/modules/AddGRPC.cmake:7
generate_proto_sources(ProtoSource ${ProtoFile} ${PROTO_UNPARSED_ARGUMENTS})
+ set(LINKED_GRPC_LIBRARIES protobuf gpr grpc grpc++)
----------------
Hi @sylvestre.ledru this seem to have broken clangd bots (also doesn't work for
local dev environment anymore)
https://lab.llvm.org/buildbot/#/builders/131/builds/38935 (buildbot was broken
before that for a different reason).
I believe the issue is because you're looking for gpr/grpc only in the absence
of target grpc++, but in other setups, e.g. the one used by buildbot and the
only one supported in theory, that uses grpc build from sources. You can find a
repro setup in details here
https://github.com/clangd/clangd/blob/master/.github/workflows/autobuild.yaml#L206.
Required configuration for LLVM looks like:
`cmake -G Ninja ../llvm/ -DCMAKE_BUILD_TYPE=RELEASE
-DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" -DCLANGD_ENABLE_REMOTE=1
-DGRPC_INSTALL_PATH=$HOME/.local` (assuming you run grpc installation to
`$HOME/.local`).
I'll revert to unblock development (and to be able to investigate the other
issue on the build bot).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141047/new/
https://reviews.llvm.org/D141047
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
