[PATCH] D140895: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140895/new/ https://reviews.llvm.org/D140895 ___

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 488502. junaire added a comment. Introduce `Value` class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clan

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, ldionne. ChuanqiXu added a project: clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. According to th

[PATCH] D140936: [2/7][Clang][RISCV] Remove default tail-undisturbed for vslideup intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140936/new/ https://reviews.llvm.org/D140936 ___

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

hokein added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:117 def _ReadSymbolPage(path, name): - with open(path) as f: -return _ParseSymbolPage(f.read(), name) + try: +f = open(path) so the input path can be invalid,

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG706881825b24: [cmake] Optionally install clang-tblgen to aid cross-compiling (authored by chewi, committed by nikic). Repository: rG LLVM Github M

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:376 +this->emitLabel(LabelTrue); +this->emitConstBool(true, E); +this->fallthrough(LabelEnd); aaron.ballman wrote: > Am I correct in understanding that the reason we d

[PATCH] D141573: [WIP][1/N][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D141574: [WIP][2/N][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a subscriber: milianw. vedgy added a comment. In D139774#4045361 , @dblaikie wrote: > 1. Should clang be doing something better with these temp files anyway, no > matter the directory they go in? (setting them for cleanup at process exit or

[PATCH] D141575: [WIP][3/N][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic::getSupportedMaskedPolicies for clarity

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D141577: [WIP][4/N][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[clang] 0a11a1b - [OpenMP] Fix a test that fails when 'libgomp' is the default library

Author: Dmitri Gribenko Date: 2023-01-12T09:54:42+01:00 New Revision: 0a11a1b1868dd2ab183c4313ccbfbe126e91ca08 URL: https://github.com/llvm/llvm-project/commit/0a11a1b1868dd2ab183c4313ccbfbe126e91ca08 DIFF: https://github.com/llvm/llvm-project/commit/0a11a1b1868dd2ab183c4313ccbfbe126e91ca08.dif

[PATCH] D140699: [OptTable] Make ValuesCode initialisation of Options constexpr

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140699/new/ https://reviews.llvm.org/D140699 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D141056: [SVE][CGBuiltins] Remove need for instcombine from ACLE tests.

david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. LGTM! Thanks for making the changes @paulwalker-arm. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141056/new/ https://reviews.llvm.org

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

gribozavr2 added a comment. FYI: I fixed the problem in https://github.com/llvm/llvm-project/commit/0a11a1b1868dd2ab183c4313ccbfbe126e91ca08. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141105/new/ https://reviews.llvm.org/D141105 _

[clang] 0285656 - [Clang] Emit noundef metadata next to range metadata

Author: Nikita Popov Date: 2023-01-12T10:03:05+01:00 New Revision: 02856565ac12e21f14f2af64ce1135ecc3c2021f URL: https://github.com/llvm/llvm-project/commit/02856565ac12e21f14f2af64ce1135ecc3c2021f DIFF: https://github.com/llvm/llvm-project/commit/02856565ac12e21f14f2af64ce1135ecc3c2021f.diff

[PATCH] D141494: [Clang] Emit noundef metadata next to range metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02856565ac12: [Clang] Emit noundef metadata next to range metadata (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This is revealed in https://reviews.llvm.org/D141280 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141580 Fi

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

hokein added a comment. I think the diagnostic changes are improvements. Comment at: clang/test/SemaCXX/rdar42746401.cpp:7 -::b<0> struct c::d // expected-error{{incomplete type}} expected-error{{cannot combine}} expected-error{{expected unqualified-id}} The

[clang] d78a7c5 - [ODRHash] Handle `Integral` and `NullPtr` template parameters in `ODRHash`

Author: isuckatcs Date: 2023-01-12T10:24:50+01:00 New Revision: d78a7c5012c7ae6ec9991fb22fcd6d06a42dc1cc URL: https://github.com/llvm/llvm-project/commit/d78a7c5012c7ae6ec9991fb22fcd6d06a42dc1cc DIFF: https://github.com/llvm/llvm-project/commit/d78a7c5012c7ae6ec9991fb22fcd6d06a42dc1cc.diff LOG

[PATCH] D141224: [ODRHash] Handle `Integral` and `NullPtr` template parameters in `ODRHash`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd78a7c5012c7: [ODRHash] Handle `Integral` and `NullPtr` template parameters in `ODRHash` (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

gchatelet closed this revision. gchatelet added a comment. So i've submitted the following patches which remove the usage of `TypeSize::getFixedSize()` and `TypeSize::getKnownMinSize()` - rG6916ebd02650 : [clang][NFC] Use the

[PATCH] D141467: [clang][Driver][CUDA] Get rid of unused LibPath

kadircet added a comment. In D141467#4045190 , @tra wrote: > Given that it's indeed unused, I'm fine with removing it. > > That said, it's somewhat odd that in your setup clang was able to find > everything but the library directory. You generally would

[clang] 4921b0a - [clang][Driver][CUDA] Get rid of unused LibPath

Author: Kadir Cetinkaya Date: 2023-01-12T10:36:43+01:00 New Revision: 4921b0a285ace77b7a3d5b9502b8602134daee0d URL: https://github.com/llvm/llvm-project/commit/4921b0a285ace77b7a3d5b9502b8602134daee0d DIFF: https://github.com/llvm/llvm-project/commit/4921b0a285ace77b7a3d5b9502b8602134daee0d.dif

[PATCH] D141467: [clang][Driver][CUDA] Get rid of unused LibPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG4921b0a285ac: [clang][Driver][CUDA] Get rid of unused LibPath (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141467/new/ https://revi

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

VitaNuo updated this revision to Diff 488539. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141509/new/ https://reviews.llvm.org/D141509 Files: clang/tools/include-mapping/cppreference_parser.py

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the review! Comment at: clang/tools/include-mapping/cppreference_parser.py:117 def _ReadSymbolPage(path, name): - with open(path) as f: -return _ParseSymbolPage(f.read(), name) + try: +f =

[clang] 840edd8 - [analyzer] Don't escape local static memregions on bind

Author: Balazs Benics Date: 2023-01-12T10:42:57+01:00 New Revision: 840edd8ab2620a52e9acbef7de037c9f465dfce7 URL: https://github.com/llvm/llvm-project/commit/840edd8ab2620a52e9acbef7de037c9f465dfce7 DIFF: https://github.com/llvm/llvm-project/commit/840edd8ab2620a52e9acbef7de037c9f465dfce7.diff

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

This revision was automatically updated to reflect the committed changes. Closed by commit rG840edd8ab262: [analyzer] Don't escape local static memregions on bind (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D139534?vs=484600&id=488546#toc Repository: rG LLVM Git

[PATCH] D141280: [clang] Build UsingType for elaborated type specifiers.

hokein added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2134 +// FIXME: !! TagOrTempResult.get() can be a nullptr here, this looks +// suspicious. Result = DS.SetTypeSpecType( Addressing it in https://reviews.llvm.org/D141580. Re

[clang] 301123c - [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), b

Author: Viktoriia Bakalova Date: 2023-01-12T09:48:27Z New Revision: 301123c7a8b5f5dd415e336ff933576279b0e868 URL: https://github.com/llvm/llvm-project/commit/301123c7a8b5f5dd415e336ff933576279b0e868 DIFF: https://github.com/llvm/llvm-project/commit/301123c7a8b5f5dd415e336ff933576279b0e868.diff

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG301123c7a8b5: [include-mapping] Fix parsing of html_book_20190607.zip (https://en. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHA

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli created this revision. fpetrogalli added a reviewer: jrtc27. Herald added subscribers: luismarques, s.egerton, kadircet, PkmX, arphaman, simoncook, arichardson. Herald added a project: All. fpetrogalli requested review of this revision. Herald added subscribers: cfe-commits, pcwang-the

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a subscriber: craig.topper. fpetrogalli added a comment. @jrtc27, @thakis, @craig.topper - is this a better solution to the issue raised in https://reviews.llvm.org/D137517? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/ne

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM In D140800#4044983 , @serge-sans-paille wrote: > In D140800#4043723 , @nikic wrote: > >> Just to check,

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. It's not used anywhere, and

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

owenpan added a comment. Can you add an option e.g. `-j N` where `N` is a positive integer and defaults to 1? Also, can you include a use case in which we can see the ~10x improvement on runtime? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14123

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

sebastian-ne added a comment. FYI, the CMake file should use `PROJECT_SOURCE_DIR` instead of `CMAKE_SOURCE_DIR`, otherwise it breaks builds that use CMake’s add_subdirectory. I put up D141521 to fix that. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141586: [include-mapping] Replace the stdlib symbol maps with the newest official version from https://en.cppreference.com/w/File:html_book_20190607.zip.

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141586 Files: clang/in

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

DavidSpickett added a comment. I will wait until after the 16 branch happens to land this. The release build already has some issues and I won't have time to do the fixups in the next few weeks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140011

[PATCH] D141280: [clang] Build UsingType for elaborated type specifiers.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Sema/DeclSpec.h:510 + // Returns the underlying decl, if any. Decl *getRepAsDecl() const { +auto *D = getRepAsFoundDecl(); -

[PATCH] D140941: [4/7][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics

eopXD updated this revision to Diff 488571. eopXD added a comment. Rebase upon updated version of [3/N] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140941/new/ https://reviews.llvm.org/D140941 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

carlosgalvezp added a comment. If we could get this in before 24th of January (release cut) it would be great, then we don't need to remove it in clang-tidy 19 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/new/ https://reviews.llvm.org/D

[PATCH] D140942: [5/7][Clang][RISCV] Remove default tail-undisturbed for vcompress intrinsics

eopXD updated this revision to Diff 488572. eopXD added a comment. Rebase upon update of [3/N] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140942/new/ https://reviews.llvm.org/D140942 Files: clang/include/clang/Basic/riscv_vector.td clang/t

[PATCH] D140947: [6/7][Clang][RISCV] Remove default tail-undisturbed for vmv_s_x and vfmv_s_f intrinsics

eopXD updated this revision to Diff 488573. eopXD added a comment. Rebase upon update of [3/N] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140947/new/ https://reviews.llvm.org/D140947 Files: clang/include/clang/Basic/riscv_vector.td clang/t

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/include/llvm/TargetParser/CMakeLists.txt:3 +tablegen(LLVM RISCVTargetParserDef.inc -gen-riscv-target-def -I ${CMAKE_SOURCE_DIR}/lib/Target/RISCV/) +add_public_tablegen_target(RISCVT

[PATCH] D140954: [7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD updated this revision to Diff 488574. eopXD added a comment. Rebase upon update of [3/N] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 Files: clang/include/clang/Basic/riscv_vector.td clang/in

[clang] bbe463d - [OptTable] Make ValuesCode initialisation of Options constexpr

Author: serge-sans-paille Date: 2023-01-12T12:08:01+01:00 New Revision: bbe463d6ba268a2bfc45d539314b70cfd72d2360 URL: https://github.com/llvm/llvm-project/commit/bbe463d6ba268a2bfc45d539314b70cfd72d2360 DIFF: https://github.com/llvm/llvm-project/commit/bbe463d6ba268a2bfc45d539314b70cfd72d2360.d

[PATCH] D140699: [OptTable] Make ValuesCode initialisation of Options constexpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbe463d6ba26: [OptTable] Make ValuesCode initialisation of Options constexpr (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[clang] 07bb29d - [OptTable] Precompute OptTable prefixes union table through tablegen

Author: serge-sans-paille Date: 2023-01-12T12:08:06+01:00 New Revision: 07bb29d8ffc3b82d5a7bb1217d93e8fa86e6969a URL: https://github.com/llvm/llvm-project/commit/07bb29d8ffc3b82d5a7bb1217d93e8fa86e6969a DIFF: https://github.com/llvm/llvm-project/commit/07bb29d8ffc3b82d5a7bb1217d93e8fa86e6969a.d

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07bb29d8ffc3: [OptTable] Precompute OptTable prefixes union table through tablegen (authored by serge-sans-paille). Repository: rG LLVM Github Mon

[PATCH] D141573: [WIP][1/N][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

eopXD updated this revision to Diff 488578. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141573/new/ https://reviews.llvm.org/D141573 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h clang/lib/Sema/Sema

[PATCH] D141574: [WIP][2/N][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

eopXD updated this revision to Diff 488579. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141574/new/ https://reviews.llvm.org/D141574 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h clang/lib/Support/R

[PATCH] D141575: [WIP][3/N][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic::getSupportedMaskedPolicies for clarity

eopXD updated this revision to Diff 488580. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141575/new/ https://reviews.llvm.org/D141575 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp Index: clang/lib/Support/RI

[PATCH] D141050: [standalone-build] outsource, simplify and unify repetitive CMake code

kwk updated this revision to Diff 488582. kwk added a comment. - both, build tree and install method support find_package by setting different LLVM_CMAKE_DIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141050/new/ https://reviews.llvm.org/D14105

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since we now handle functions without a body as w

[PATCH] D141592: [include-cleaner] Treat a constructor call as a use of the class type.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Per the discussion in https://github.com/llvm/llvm-project/issues/59916. Repository: rG LLVM Github Monorepo https

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1315 + if (InterpretBuiltin(S, PC, Func->getBuiltinID())) { +NewFrame.release(); +return true; shafik wrote: > We don't have to update `S.C

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

hokein added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1348 bool &Result) { if (const auto *FD1 = dyn_cast(D1)) { auto IsExpectedEntity = [](const FunctionDecl *FD) { cor3ntin wrote: > we still need th

[clang] d0a98ef - [clang] Fix unused variable warning in SemaConcept.cpp

Author: Victor Komarov Date: 2023-01-12T12:55:34+01:00 New Revision: d0a98efb6819182138fab2e4028ab77d30f8b278 URL: https://github.com/llvm/llvm-project/commit/d0a98efb6819182138fab2e4028ab77d30f8b278 DIFF: https://github.com/llvm/llvm-project/commit/d0a98efb6819182138fab2e4028ab77d30f8b278.diff

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a98efb6819: [clang] Fix unused variable warning in SemaConcept.cpp (authored by Victor Komarov , committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

hokein added a comment. > Hey @hokein, thanks for the accept. I don't have commit rights, can you > please land this? Done. Sorry for the late response (I totally missed this). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140711/new/ https://rev

[PATCH] D141596: [Driver] Add crtfastmath.o on Solaris if appropriate

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `Flang :: Driver/fast_math.f90` `FAIL`s on Solaris because `crtfastmath.o` is missing fr

[PATCH] D141598: [clang] Redefine some AVR specific macros

benshi001 created this revision. benshi001 added reviewers: aykevl, Miss_Grape. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG L

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked 2 inline comments as done. pmatos added a comment. Addressed a few comments downstream. Will upload new patch next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 __

[PATCH] D139686: [lsan] Add lsan support for loongarch64

SixWeining added a comment. LGTM. Is there any objection? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D141592: [include-cleaner] Treat a constructor call as a use of the class type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22db1fb10b83: [include-cleaner] Treat a constructor call as a use of the class type. (authored by hokein). Repository: rG LLVM Github Monorepo CH

[clang-tools-extra] 22db1fb - [include-cleaner] Treat a constructor call as a use of the class type.

Author: Haojian Wu Date: 2023-01-12T13:12:14+01:00 New Revision: 22db1fb10b8384907b43408f5d2703f96f806bc2 URL: https://github.com/llvm/llvm-project/commit/22db1fb10b8384907b43408f5d2703f96f806bc2 DIFF: https://github.com/llvm/llvm-project/commit/22db1fb10b8384907b43408f5d2703f96f806bc2.diff LO

[PATCH] D141547: Fix format for `case` in .proto files

krasimir added inline comments. Comment at: clang/test/Format/case.proto:15 +repeated int32 fizz = 1; +} could you please turn this into an unit test here instead > https://github.com/llvm/llvm-project/blob/main/clang/unittests/Format/FormatTestProto.cpp. Rep

[clang-tools-extra] bb1b0e6 - [clangd] Tag clang-tidy diagnostics: modernize-*=deprecated, misc-unused-*=unneccesary

Author: Sam McCall Date: 2023-01-12T13:22:21+01:00 New Revision: bb1b0e61cda66cb9f06bc4f1dc21e03bb1744d22 URL: https://github.com/llvm/llvm-project/commit/bb1b0e61cda66cb9f06bc4f1dc21e03bb1744d22 DIFF: https://github.com/llvm/llvm-project/commit/bb1b0e61cda66cb9f06bc4f1dc21e03bb1744d22.diff LO

[PATCH] D141537: [clangd] Tag clang-tidy diagnostics: modernize-*=deprecated, misc-unused-*=unneccesary

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb1b0e61cda6: [clangd] Tag clang-tidy diagnostics: modernize-*=deprecated, misc-unused… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 488598. pmatos added a comment. Address a couple of comments by @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTCont

[PATCH] D141297: [OpenCL] Allow undefining header-only features

svenvh added a comment. In D141297#4043122 , @Anastasia wrote: > Btw I wonder if in the future we could add some error or warning in case > someone uses the same approach for frontend specific features, i.e. > > #ifdef __undef___opencl_c_generic_addres

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked 5 inline comments as done. pmatos added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:4012-4018 + if (Target->getTriple().isWasm() && Target->hasFeature("reference-types")) { +#define WASM_REF_TYPE(Name, MangledName, Id, SingletonId, AS)

[clang] 0d0dab4 - Fix the Clang sphinx bot again

Author: Aaron Ballman Date: 2023-01-12T07:59:07-05:00 New Revision: 0d0dab4e5fbec4efb31de6b877574d0d278f6809 URL: https://github.com/llvm/llvm-project/commit/0d0dab4e5fbec4efb31de6b877574d0d278f6809 DIFF: https://github.com/llvm/llvm-project/commit/0d0dab4e5fbec4efb31de6b877574d0d278f6809.diff

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

alvinhochun added inline comments. Comment at: clang/test/Driver/mingw-sysroot.cpp:25-38 // RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s 2>&1 | FileCheck -check-prefix=CHECK_TESTROOT_GCC

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 488609. pmatos marked an inline comment as done. pmatos added a comment. Deal with Itanium Mangle and assert false outside Wasm triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.l

[clang] a74bc43 - Add a warning comment that this file is generated

Author: Aaron Ballman Date: 2023-01-12T08:10:57-05:00 New Revision: a74bc436703057ab0f53ad78ab3f84227a45e37f URL: https://github.com/llvm/llvm-project/commit/a74bc436703057ab0f53ad78ab3f84227a45e37f DIFF: https://github.com/llvm/llvm-project/commit/a74bc436703057ab0f53ad78ab3f84227a45e37f.diff

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2480-2481 #include "clang/Basic/RISCVVTypes.def" +#define WASM_TYPE(Name, Id, SingletonId) case BuiltinType::Id: +#include "clang/Basic/WebAssemblyReferenceTypes.def" case BuiltinType::ShortAccum: ---

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve updated this revision to Diff 488611. fdeazeve added a comment. Address review comments: - Remove unncesarry `const` qualifier from function declaration. - Add an item in Clang's release notes. I surveyed Clang's release notes in all major releases from 12.0 and couldn't find anything s

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 added a comment. In D141105#4046400 , @gribozavr2 wrote: > FYI: I fixed the problem in > https://github.com/llvm/llvm-project/commit/0a11a1b1868dd2ab183c4313ccbfbe126e91ca08. Thanks, I forgot to update that test after fixing a similar problem b

[clang] 278d6f0 - [Clang] Clean up some offloading driver tests

Author: Joseph Huber Date: 2023-01-12T07:54:55-06:00 New Revision: 278d6f065a63930d33d10785ec3de03ce6c3bc3c URL: https://github.com/llvm/llvm-project/commit/278d6f065a63930d33d10785ec3de03ce6c3bc3c DIFF: https://github.com/llvm/llvm-project/commit/278d6f065a63930d33d10785ec3de03ce6c3bc3c.diff

[PATCH] D141546: [clang] Reland parenthesized aggregate init patches

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, mostly based on the previous review. I have not noticed any significant changes, so have not looked too cautiously. Let me know if there are any particular places that you s

[PATCH] D141608: [include-cleaner] Don't consider the underlying type of Decltype MemberProvider as a use

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. For this case, the argument of `decltype` is the provider. This fixes the sample in https://github.com/llvm/llvm-proj

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mstorsjo added inline comments. Comment at: clang/test/Driver/mingw-sysroot.cpp:25-38 // RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s 2>&1 | FileCheck -check-prefix=CHECK_TESTROOT_GCC %s

[clang] a5c9a51 - [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I

Author: Brad Smith Date: 2023-01-12T09:08:05-05:00 New Revision: a5c9a51bf456a505386660d9be4c641fc804b7fe URL: https://github.com/llvm/llvm-project/commit/a5c9a51bf456a505386660d9be4c641fc804b7fe DIFF: https://github.com/llvm/llvm-project/commit/a5c9a51bf456a505386660d9be4c641fc804b7fe.diff LO

[PATCH] D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c9a51bf456: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 488632. fahadnayyar marked an inline comment as done. fahadnayyar added a comment. Refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 Files: clang/doc

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

aaron.ballman accepted this revision. aaron.ballman added a comment. In D138446#3942006 , @rymiel wrote: > I consulted a little bit with a friend who has a little bit of experience > with sphinx and they suggested making a simple custom extension for thi

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:4012-4018 + if (Target->getTriple().isWasm() && Target->hasFeature("reference-types")) { +#define WASM_REF_TYPE(Name, MangledName, Id, SingletonId, AS) \ + if (BuiltinType::Id == Bui

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:806-807 + SingletonId = \ + DBuilder.createForwardDecl(llvm::dwarf::DW_TAG_structure_type

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 488634. pmatos marked an inline comment as done. pmatos added a comment. Address all comments except a couple of issues related to ABI and mangling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ http

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

aaron.ballman accepted this revision. aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:376 +this->emitLabel(LabelTrue); +this->emitConstBool(true, E); +this->fallthrough(LabelEnd); tbaeder wrote: > aaron.ballma

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

aaron.ballman added a reviewer: libc++. aaron.ballman added a comment. Thank you for working on this! I think the Debian CI failure is unrelated, but the libc++ one looks plausibly related: /home/libcxx-builder/.buildkite-agent/builds/e6f11fd202bc-1/llvm-project/libcxx-ci/build/generic-cxx03/

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

tmatheson added a comment. I agree the approach in D141518 makes more sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141404/new/ https://reviews.llvm.org/D141404

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked an inline comment as done. pmatos added a comment. @aaron.ballman many thanks for the thorough reviews on the patches. Happy to see this moving in the right direction. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2480-2481 #include "clang/Basic/RISCVVTypes.def"

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

arsenm updated this revision to Diff 488638. arsenm added a comment. Fix patch split. update_cc_test_checks misses the calling convention, so I'm going to precommit a test which verifies those are correct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141447/new/ https://reviews.llvm.or

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 ___ c

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:106 +- Deprecate the global configuration file option `AnalyzeTemporaryDtors`, + which is no longer in use. The option will be fully removed in clang-tidy 18. + `Clang-tidy

  1   2   3   4   >