tbaeder marked 2 inline comments as done.
tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/Interp.h:1315
+ if (InterpretBuiltin(S, PC, Func->getBuiltinID())) {
+ NewFrame.release();
+ return true;
----------------
shafik wrote:
> We don't have to update `S.Current`?
Nope, `Ret` does that.
================
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:20
+template <PrimType Name, class T = typename PrimConv<Name>::T>
+static bool Ret(InterpState &S, CodePtr &PC) {
+ S.CallStackDepth--;
----------------
shafik wrote:
> Why not just factor out `Ret` now?
The two implementations are slightly different now and I wanted to see if they
diverge more int he future. But I've factored them together as part of
https://reviews.llvm.org/D141193
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137487/new/
https://reviews.llvm.org/D137487
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
