[clang-tools-extra] 8d9828e - [clang-tidy] Fix all broken links in the comment.

Author: Haojian Wu Date: 2023-01-03T09:25:38+01:00 New Revision: 8d9828ef5aa9688500657d36cd2aefbe12bbd162 URL: https://github.com/llvm/llvm-project/commit/8d9828ef5aa9688500657d36cd2aefbe12bbd162 DIFF: https://github.com/llvm/llvm-project/commit/8d9828ef5aa9688500657d36cd2aefbe12bbd162.diff LO

[PATCH] D140395: [clang][analyzer] Extend StreamChecker with some new functions.

balazske updated this revision to Diff 485928. balazske marked 2 inline comments as done. balazske added a comment. Removed old commment, updated a test run line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140395/new/ https://reviews.llvm.org/D1

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

awarzynski added a comment. Hi @madanial , thanks for posting this! > This patch adds user option -funderscoring/-fnounderscoring which behaves > similar to the gfortran option be enabling/disabling the > ExternalNameConversionPass I don't quite understand what this option is for and it's hard

[PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille updated this revision to Diff 485929. serge-sans-paille added a comment. Added to versions of OptTable, one that uses a precomputed Table, generated by TableGen, and one that relies on the old, generic approach. Both are tested using the same test bench. Updated benchmark: ht

[PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille added a comment. In D140800#4021282 , @thakis wrote: > I'm guessing on non-empty files this is a negligible win even in clang. As showcased by https://llvm-compile-time-tracker.com/compare.php?from=4da6cb3202817ee2897d6b690e4af950459ca

[PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille updated this revision to Diff 485931. serge-sans-paille added a comment. (rebased on main. Note that this patch is applied on top of https://reviews.llvm.org/D140699) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 Files:

[PATCH] D140699: [OptTable] Make ValuesCode initialisation of Options constexpr

serge-sans-paille updated this revision to Diff 485932. serge-sans-paille retitled this revision from "[clang] Make ValuesCode initialisation of Options constexpr" to "[OptTable] Make ValuesCode initialisation of Options constexpr". serge-sans-paille added a comment. (rebased on main) CHANGES

[PATCH] D140859: [clang][dataflow] Allow analyzing multiple functions in unit tests

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.cpp:89-104 + unsigned FunctionBeginOffset = + SourceManager.getFileOffset(Func->getBeginLoc()); +

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was still missing. Repository: rG LLVM Git

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

hokein created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. A prototype of using include-cleaner library

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Access to members in a non-dependent context would always yield an invalid expression. When it appears in a requires-exp

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

usaxena95 updated this revision to Diff 485939. usaxena95 added a comment. More tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140876/new/ https://reviews.llvm.org/D140876 Files: clang/lib/Parse/ParseExprCXX.cpp clang/test/CXX/expr/expr.

[PATCH] D140685: [LoongArch] Add intrinsics for MOVFCSR2GR and MOVGR2FCSR instructions

xen0n accepted this revision. xen0n added a comment. In D140685#4017381 , @xen0n wrote: >> MOVGR2FCSR modifies the value of the software writable field >> corresponding to the FCSR (floating-point control and status >> register) fcsr according to the valu

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. @craig.topper @lenary @barannikov88 @pcwang-thead - New Year's gentle ping :) Thank you, Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.llvm.org/D137517 __

[PATCH] D140843: [clang-format] fix template closer followed by >

MyDeveloperDay added a comment. I'm good with this but I'd be interesting in @owenpan and @HazardyKnusperkeks opinion. Comment at: clang/lib/Format/TokenAnnotator.cpp:169-171 +CurrentToken->getStartOfNonWhitespace() == +CurrentToken->Next->getStart

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140835/new/ https://reviews.llvm.org/D140835 ___

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thank you for this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140339/new/ https://reviews.llvm.org/D140339 ___ cfe-commits

[PATCH] D140767: [clang-format] Require space before noexcept qualifier

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Nice! Thank you for another great patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140767/new/ https://reviews.llvm.org/D140767 ___

[PATCH] D140859: [clang][dataflow] Allow analyzing multiple functions in unit tests

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.cpp:59 +if (SM.isPointWithin(Loc, BoundingRange.getBegin(), + BoundingRange.getEnd())) { + LineNumberToContent[SM.getP

[PATCH] D123609: [Clang] Remove support for legacy pass manager

lenary added a comment. Herald added a subscriber: pcwang-thead. In D123609#3451334 , @nikic wrote: > In D123609#3451320 , @HaohaiWen > wrote: > >> Hi @nikic, >> We recently noticed legacy PM was removed from man

[PATCH] D140843: [clang-format] fix template closer followed by >

Backl1ght added a comment. In D140843#4022673 , @MyDeveloperDay wrote: > I'm good with this but I'd be interesting in @owenpan and > @HazardyKnusperkeks opinion. Yes, this is what I understand. And I will add an annotator test later. This patch is j

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

ymandel added a comment. In D140696#4020209 , @merrymeerkat wrote: > @ymandel - thank you for pointing all of this out! And no need to apologise > at all :) > > I agree that the changes made here are not ideal. But the alternative is also > not ideal.

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD updated this revision to Diff 485961. eopXD added a comment. Update test cases for vfmerge. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/ https://reviews.llvm.org/D140686 Files: clang/include/clang/Basic/riscv_vector.td clang

[PATCH] D140891: [analyzer] Fix assertion failure in SMT conversion for unary operator on floats.

tomasz-kaminski-sonarsource created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonarsource requ

[PATCH] D140894: [clang-tidy] Don't emit misc-unused-using-decl warnings for header files.

hokein created this revision. hokein added a reviewer: ymandel. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Using decls in header files are s

[clang] 80a7803 - [NFC] Update CXXSTatus to show we implement CWG 2061

Author: Erich Keane Date: 2023-01-03T06:18:08-08:00 New Revision: 80a78033cf5f21c082aa30bfc692df76d296573c URL: https://github.com/llvm/llvm-project/commit/80a78033cf5f21c082aa30bfc692df76d296573c DIFF: https://github.com/llvm/llvm-project/commit/80a78033cf5f21c082aa30bfc692df76d296573c.diff L

[clang] a5ae5af - Revert "[NFC] Update CXXSTatus to show we implement CWG 2061"

Author: Erich Keane Date: 2023-01-03T06:26:29-08:00 New Revision: a5ae5afa521f75e87f9018d8361aa5a1cadc7a86 URL: https://github.com/llvm/llvm-project/commit/a5ae5afa521f75e87f9018d8361aa5a1cadc7a86 DIFF: https://github.com/llvm/llvm-project/commit/a5ae5afa521f75e87f9018d8361aa5a1cadc7a86.diff L

[PATCH] D140828: [WIP][C++] Implement "Deducing this" (P0847R7)

erichkeane added a comment. I did a look through, I'm quite sure I'm not going to be able to accept this, but I'm hoping the little feedback I gave helped. I can't help with the review of the mangling unfortunately, we probably need to wait for the owners of the manglings to make a decision.

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. On second thought, shouldn't we test for removing the braces? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

erichkeane added a comment. I'm pretty far behind on reviews of the interpreter, but this one I noticed while looking th rough it. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:710 + + assert(*LT == PT_Ptr); + This is UB here if LT doesn't contain a va

[PATCH] D140895: [WIP][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[clang] e45c0a9 - Reapply "[NFC] Update CXXSTatus to show we implement CWG 2061""

Author: Erich Keane Date: 2023-01-03T06:58:45-08:00 New Revision: e45c0a919df3f9a8e5c352878fe9beb61cbc559d URL: https://github.com/llvm/llvm-project/commit/e45c0a919df3f9a8e5c352878fe9beb61cbc559d DIFF: https://github.com/llvm/llvm-project/commit/e45c0a919df3f9a8e5c352878fe9beb61cbc559d.diff L

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

erichkeane added a comment. I don't particularly know what the intent here was, so I'm hoping that @mboehme will review when he gets back from whatever vacation he's taking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139935/new/ https://reviews

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

cor3ntin added a comment. @shafik I'm not sure either it's the right direction but I don't think it makes the situation any worse. And given I still don't really know what a proper fix would look like (except that it would probably be pretty involved), I think we might has well do that as an im

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

Szelethus added a comment. In D140387#4021806 , @Szelethus wrote: > Would be possible to test the errno specific changes as well? I suppose the tests are done in the followup patch mostly? Comment at: clang/lib/StaticAnalyzer/Checkers

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

owenpan added a comment. In D140835#4023080 , @HazardyKnusperkeks wrote: > On second thought, shouldn't we test for removing the braces? Hmm. This patch including the added test case //is// for removing braces. Repository: rG LLVM Github Monorepo C

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

erichkeane added a comment. I agree with Corentin here, I've got no idea what the RIGHT solution looks like here, but this looks to be at least an improvement. 1 nit, plus need a release note. Otherwise LGTM. Comment at: clang/test/CodeGenCXX/cxx20-unevaluated-lambda-crash

[PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

serge-sans-paille created this revision. Herald added subscribers: libc-commits, hanchung, kadircet, Moerafaat, kmitropoulou, zero9178, Enna1, bzcheeseman, kosarev, mattd, gchakrabarti, ThomasRaoux, pmatos, asb, ayermolo, awarzynski, arjunp, sdasgup3, asavonic, carlosgalvezp, Groverkss, wenzhicu

[PATCH] D140807: [clang][Interp] Skip calling simple destructors

erichkeane added a comment. This still would have to call the destructors of base and member types, right? And this just means that it isn't user defined AND isn't deleted for some reason, so this doesn't mean 'trivial'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D140828: [WIP][C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/include/clang/AST/Expr.h:1447 + bool Set, const ASTContext &Context) { +DeclRefExprBits.CapturedByCopyInLambdaWithExplicitObjectParameter = Set; +setDependence(computeDependence(this, Context)); erich

[PATCH] D140828: [WIP][C++] Implement "Deducing this" (P0847R7)

erichkeane added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2560 IsInLambda = true; -if (MD->isInstance()) +if (MD->isImplicitObjectMemberFunction()) HasThisQuals = true; cor3ntin wrote: > erichkeane wrote: > > This bit p

[PATCH] D140894: [clang-tidy] Don't emit misc-unused-using-decl warnings for header files.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/unused-using-decls.rst:26 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;hh;hpp;hxx

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:838 + Result += getArgDesc(ArgN); + Result += DK == Violation ? " should not be zero" : " is not zero"; + return Result.c_str(); I don't mean to make

[PATCH] D140828: [WIP][C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2560 IsInLambda = true; -if (MD->isInstance()) +if (MD->isImplicitObjectMemberFunction()) HasThisQuals = true; erichkeane wrote: > cor3ntin wrote: > > erichkeane w

[PATCH] D140617: [clangd] Fix a clangd crash when indexing the standard library.

sammccall added a comment. As I understand, we're crashing if the ignorelist isn't found, and this patch fixes the searching so that we find the file (assuming the compile command is correct). But we'll still crash if the compile command is wrong, which seems pretty bad. Fixing the way the ign

[PATCH] D140395: [clang][analyzer] Extend StreamChecker with some new functions.

Szelethus added a comment. Mostly LGTM, but I see that you have tests for the predecessor patch here as well, so I'll accept both at once. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:89 /// The last file operation called in the stream. + /// Can be null

[PATCH] D140897: [clang][dataflow] Fix handling of `DeclRefExpr`s to `BindingDecl`s.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The invariants around `ReferenceValues` a

[PATCH] D140807: [clang][Interp] Skip calling simple destructors

tbaeder added a comment. What a shame. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140807/new/ https://reviews.llvm.org/D140807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

mehdi_amini added inline comments. Herald added a subscriber: Michael137. Comment at: llvm/include/llvm/ADT/ArrayRef.h:502 + /// Deduction guide to construct an ArrayRef from a C array. + template ArrayRef(const T (&Arr)[N]) -> ArrayRef; Can we keep the make

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:393 // reasonably apply this fallback for dependent nested-name-specifiers. -if (SS.getScopeRep()->getPrefix()) { +if (SS.isSet() && SS.getScopeRep()->getPrefix()) { if (ParsedType T

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139564/new/ https://reviews.llvm.org/D139564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140547: Perform access checking to private members in simple requirement.

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1367 + if (E->getBody()->isDependentContext()) { +Sema::SFINAETrap Trap(SemaRef); +// We recreate the RequiresExpr body, but not by instantiating it.

[PATCH] D140894: [clang-tidy] Don't emit misc-unused-using-decl warnings for header files.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:48 + HeaderFileExtensions, +

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

cor3ntin added a comment. @aaron.ballman I don't think this patch is no longer necessary given that we merged the math profile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132877/new/ https://reviews.llvm.org/D132877

[PATCH] D140894: [clang-tidy] Don't emit misc-unused-using-decl warnings for header files.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/unused-using-decls.rst:26 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;hh;hpp;hxx

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

ilya-biryukov added a comment. Should access checks should happen in the context where `concept` is written or where it's used? Is there a standard wording around it? If access-checking should happen where concept is defined, having a hard error seems fine because of the wording you quoted: > I

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Code changes LGTM. Dead CFoo obviously should be used or deleted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140664/new/ https://rev

[PATCH] D139889: [Clang] Fix a crash when encountering an ill-formed delimited UCN.

cor3ntin added a comment. @tahonermann gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139889/new/ https://reviews.llvm.org/D139889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

tahonermann added a comment. > I don't think this patch is no longer necessary given that we merged the math > profile I agree; we can revisit this if complaints from users due to use of characters not in the math profile materializes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

aaron.ballman abandoned this revision. aaron.ballman added a comment. In D132877#4023269 , @cor3ntin wrote: > @aaron.ballman I don't think this patch is no longer necessary given that we > merged the math profile Agreed, I'm going to abandon this for no

[PATCH] D139889: [Clang] Fix a crash when encountering an ill-formed delimited UCN.

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good! Sorry, Corentin, this review had fallen off my radar! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139889/new/ https://re

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

tahonermann added a comment. I don't know the driver code very well, but as best I can tell, this appears to match the design agreed to at the last Clang Modules WG meeting. Comment at: clang/test/Driver/module-output.cppm:5 +// +// Tests that the .pcm file will be generated i

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

balazske marked 5 inline comments as done. balazske added a comment. > I suppose the tests are done in the followup patch mostly? Yes the tests in the next patch should cover the cases. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:838 + Result

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

aaron.ballman added a reviewer: libc++. aaron.ballman added a comment. It looks like this change breaks libc++ (see the precommit CI failures) by making more changes than expected. I'm now seeing `implicit conversion changes signedness` diagnostics where we didn't previously get them. Is that ex

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

vctr added a comment. Hey @hokein, thanks for the accept. I don't have commit rights, can you please land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140711/new/ https://reviews.llvm.org/D140711 ___

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

hubert.reinterpretcast added a comment. In D137756#4018666 , @MaskRay wrote: > Most targets reject `-p` now. It's unnecessary to have another z/OS specific > diagnostic. So this patch can be abandoned. > > % fclang -p a.cc > clang-16: error: unsuppor

[PATCH] D140894: [clang-tidy] Don't emit misc-unused-using-decl warnings for header files.

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/unused-using-decls.rst:26 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;hh;hpp;hxx"

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

ego added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td:135 + defm VANDN_V : VALU_IV_V_X_I<"vandn", 0b01>; + def VBREV8_V : VALUVs2<0b010010, 0b01000, OPIVV, "vbrev8.v">; + defm VCLMUL_V : VALU_IV_V_X_VCLMUL<"vclmul", 0b001100>; T

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:572 + string default_march = "", + list tunef = []> : ProcessorModel { + string DefaultMarch = default_march; 80 columns

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

royjacobson added a comment. In D140876#4023286 , @ilya-biryukov wrote: > Should access checks should happen in the context where `concept` is written > or where it's used? Is there a standard wording around it? Unfortunately, only a standard wording i

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

erichkeane added a comment. As far as teh fix itself, I think this is fine. BUT i think there is value in waiting for Aaron to see if there is a deeper issue here. Comment at: clang/lib/Sema/SemaInit.cpp:3863 + SourceLocation EndLoc = VD->getEndLoc(); + if (const auto *VT

[clang] d862f66 - [clang][dataflow] Treat unions as structs.

Author: Dani Ferreira Franco Moura Date: 2023-01-03T18:36:24Z New Revision: d862f66221de1463ee7c92fe2e78445edb30a601 URL: https://github.com/llvm/llvm-project/commit/d862f66221de1463ee7c92fe2e78445edb30a601 DIFF: https://github.com/llvm/llvm-project/commit/d862f66221de1463ee7c92fe2e78445edb30a6

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd862f66221de: [clang][dataflow] Treat unions as structs. (authored by merrymeerkat). Changed prior to commit: https://reviews.llvm.org/D140696?vs=

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added a comment. Thanks for clarifying! I've gone ahead and landed the change. At least this should reduce the number of false negatives we get (hopefully without introducing too much complexity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 486030. paulkirth added a comment. Herald added subscribers: kosarev, kerbowa, jvesely, nemanjai. Add missing pipline test updates for PowerPC and AMDGPU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/ne

[clang-tools-extra] dde8a0f - [clangd] show underlying type in type hint for `decltype(expr)`

Author: v1nh1shungry Date: 2023-01-03T13:58:39-05:00 New Revision: dde8a0fe91ccd4b54d5bd0c18043e0dd35652e47 URL: https://github.com/llvm/llvm-project/commit/dde8a0fe91ccd4b54d5bd0c18043e0dd35652e47 DIFF: https://github.com/llvm/llvm-project/commit/dde8a0fe91ccd4b54d5bd0c18043e0dd35652e47.diff

[PATCH] D140814: [clangd] show underlying type in type hint for `decltype(expr)`

This revision was automatically updated to reflect the committed changes. Closed by commit rGdde8a0fe91cc: [clangd] show underlying type in type hint for `decltype(expr)` (authored by v1nh1shungry, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

ego added a comment. FYI, more issues with v0 not being accepted as an operand with unmasked instructions. Comment at: llvm/test/MC/RISCV/rvv/rv64zvkns.s:59 + +vaeskf1.vi v10, v9, 1 +# CHECK-INST: vaeskf1.vi v10, v9, 1 ego wrote: > craig.topper wrote: > > ego

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added a comment. In D127762#3960906 , @rsandifo-arm wrote: > Thanks @aaron.ballman for the feedback about spellings. I've gone with the > lower-case names like `__arm_streaming` in what follows, as a plausible > strawman. > > My main con

[PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

jpienaar added inline comments. Comment at: llvm/include/llvm/ADT/ArrayRef.h:502 + /// Deduction guide to construct an ArrayRef from a C array. + template ArrayRef(const T (&Arr)[N]) -> ArrayRef; mehdi_amini wrote: > Can we keep the makeArrayRef functions fo

[PATCH] D140775: [clangd] Hover: show CalleeArgInfo for literals

tom-anders updated this revision to Diff 486039. tom-anders added a comment. Add test for expression, improve presentation for signature with unnamed parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140775/new/ https://reviews.llvm.org/D140

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. This is great! Any chance we can use `MachineFrameInfo::StackProtectorIdx` to annotate the slot that is reserved for the stack protector? Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:84 +ORE = &getAnalysis().getORE(); +if (!OR

[PATCH] D140857: Fix Fuchsia dyld in asan-ubsan variant

mcgrathr added a comment. I don't think we want this in the generic compiler behavior. It would only make sense if the toolchain runtimes have extra versions, and I don't think we want that many extra versions. It may be worthwhile to change the asan multilib builds to enable ubsan checks too,

[clang] 0d6b26b - [Clang] Fix a crash when encountering an ill-formed delimited UCN.

Author: Corentin Jabot Date: 2023-01-03T20:57:52+01:00 New Revision: 0d6b26b4d3e3991da16f5b7f53e397b0051e8598 URL: https://github.com/llvm/llvm-project/commit/0d6b26b4d3e3991da16f5b7f53e397b0051e8598 DIFF: https://github.com/llvm/llvm-project/commit/0d6b26b4d3e3991da16f5b7f53e397b0051e8598.diff

[PATCH] D139889: [Clang] Fix a crash when encountering an ill-formed delimited UCN.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d6b26b4d3e3: [Clang] Fix a crash when encountering an ill-formed delimited UCN. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139889

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders created this revision. tom-anders added reviewers: nridge, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

beanz added a comment. It is probably worth adding some unit tests to test the `CBufferDataLayout` class. I think the meat of this change is fine. This code mixes `unsigned` and `uint32_t` interchangeably. They aren't required by the language to be the same. I have a general preference toward

[clang] 9ab0d4d - [OpenMP][2/2] Make device functions have hidden visibility

Author: Johannes Doerfert Date: 2023-01-03T12:18:30-08:00 New Revision: 9ab0d4d66fa14a9c57864fea72590886ace6d9ee URL: https://github.com/llvm/llvm-project/commit/9ab0d4d66fa14a9c57864fea72590886ace6d9ee DIFF: https://github.com/llvm/llvm-project/commit/9ab0d4d66fa14a9c57864fea72590886ace6d9ee.d

[PATCH] D139889: [Clang] Fix a crash when encountering an ill-formed delimited UCN.

cor3ntin added a comment. @tahonermann Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139889/new/ https://reviews.llvm.org/D139889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. I'm sympathetic to the problem you're trying to solve (not having to set environment variable for the temp directory), but I'm also not convinced this is the correct way to approach it. This feels like a configuration property of the libclang execution -- so it'd

[PATCH] D140711: [clang] Fix unused variable warning in SemaConcept.cpp

cor3ntin added a comment. nit: I think that's a cleaner fix :) Comment at: clang/lib/Sema/SemaConcept.cpp:1348 bool &Result) { if (const auto *FD1 = dyn_cast(D1)) { auto IsExpectedEntity = [](const FunctionDecl *FD) {

[PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

serge-sans-paille updated this revision to Diff 486049. serge-sans-paille added a comment. + keep deprecated version, flagged appropriately CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140896/new/ https://reviews.llvm.org/D140896 Files: bolt/tools/bat-dump/bat-dump.cpp bolt/tools/

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 486050. paulkirth added a comment. Avoid problems with path separators on windows, and ignore path prefix in diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

dblaikie added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:52 + + enum class TriState : int { kYes, kNo, kUnknown }; + We don't usually use the `k` prefix for enums (the style guide mentions using an acronym like `TS_` - though even tha

[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

rjmccall added a comment. LGTM, but I have a suggested elaboration for the comment. Comment at: clang/lib/AST/ASTContext.cpp:10258 - // FIXME: some uses, e.g. conditional exprs, really want this to be 'both'. - bool NoReturn = lbaseInfo.getNoReturn() || rbaseInfo.getNoRetur

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

jansvoboda11 added a comment. While I was not suggesting using compilation database instead of the approach taken by this patch, I appreciate your explanation. But it still leaves me wondering whether generating one compilation database per file-to-be-scanned would be a reasonable strategy? Tha

[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

MaskRay updated this revision to Diff 486061. MaskRay marked an inline comment as done. MaskRay added a comment. use @rjmccall's comment (thanks a lot!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140868/new/ https://reviews.llvm.org/D140868 Fil

[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

aaron.ballman added a comment. C2x clarified the behavior of *standard* attributes when determining a composite type, and this particular case really straddles that boundary. We support `[[noreturn]]` and `_Noreturn` as standard attributes in C as well as `__attribute__((noreturn))` (as a nonst

[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM % comment. Thanks for taking this! Comment at: llvm/test/CodeGen/WebAssembly/simd-intrinsics.ll:159-160 ; CHECK-NEXT: return $pop[[R]]{{$}} -declare <16 x i8> @llvm.w

[PATCH] D140921: [clang][dataflow] Fix bug in optional-checker's handling of nullopt constructor.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, the checker only recognizes th

  1   2   >