beanz added a comment. It is probably worth adding some unit tests to test the `CBufferDataLayout` class.
I think the meat of this change is fine. This code mixes `unsigned` and `uint32_t` interchangeably. They aren't required by the language to be the same. I have a general preference toward `uint32_t` which is explicitly sized, but we should match existing interfaces where appropriate. For example, we should also probably be using `llvm::TypeSize` where appropriate to match `llvm::DataLayout` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
