tahonermann added inline comments.
================ Comment at: clang/lib/Sema/SemaExprCXX.cpp:393 // reasonably apply this fallback for dependent nested-name-specifiers. - if (SS.getScopeRep()->getPrefix()) { + if (SS.isSet() && SS.getScopeRep()->getPrefix()) { if (ParsedType T = LookupInScope()) { ---------------- `CXXScopeSpec::isSet()` is apparently (intended to be) deprecated. ``` clang/include/clang/Sema/DeclSpec.h: 209 /// Deprecated. Some call sites intend isNotEmpty() while others intend 210 /// isValid(). 211 bool isSet() const { return getScopeRep() != nullptr; } ``` It sounds like this should instead call `.isValid()` or `.isNotEmpty()`, but I'm not sure which. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140598/new/ https://reviews.llvm.org/D140598 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits