[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

jcranmer-intel added a comment. I don't normally handle name mangling, so I can't comment too much here, but I will note that Itanium ABI is planning on using DF16b for `std::bfloat16_t`: https://github.com/itanium-cxx-abi/cxx-abi/pull/147 Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. Domján -- thanks for the detailed explanations -- this has been really helpful. > After this the get<>() calls simply use this unnamed copy to initialize the > elements from first to last, so everything seems to proceed in order in the > CFG. Agreed -- it definitely sh

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1594 + if (VarDecl *VD = dyn_cast(DRE->getDecl())) { +if (VD->isLocalVarDecl()) { + Diag(DRE->getLocation(), So if we look at `CheckDefaultArgumentVisitor::VistDeclRef

[PATCH] D136554: Implement CWG2631

cor3ntin reopened this revision. cor3ntin added a comment. This revision is now accepted and ready to land. In D136554#3982161 , @aeubanks wrote: > the following now produces a link error: > > $ cat /tmp/a.cc > #include > #include > > struct

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 481411. cor3ntin added a comment. Correctly visit array filer when marking default member init as ODR-used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files:

[clang] 100dfe7 - [OpenMP] Clang Support for taskwait nowait clause

Author: Sunil K Date: 2022-12-08T12:40:44-08:00 New Revision: 100dfe7a8ad3789a98df623482b88d9a3a02e176 URL: https://github.com/llvm/llvm-project/commit/100dfe7a8ad3789a98df623482b88d9a3a02e176 DIFF: https://github.com/llvm/llvm-project/commit/100dfe7a8ad3789a98df623482b88d9a3a02e176.diff LOG:

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG100dfe7a8ad3: [OpenMP] Clang Support for taskwait nowait clause (authored by koops, committed by ABataev). Herald added projects: clang, OpenMP. Hera

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:9 + + auto lambda1 = [] {}; // expected-error {{default argument references local variable x of enclosing function}} + auto lambda2 = [] {}; To clarify my commen

[clang] 121a89f - Fix annotations-field.c CHECK lines being ignored

Author: Alex Richardson Date: 2022-12-08T20:44:40Z New Revision: 121a89fc2aedf48ca4aee43288b67e27b71e72ed URL: https://github.com/llvm/llvm-project/commit/121a89fc2aedf48ca4aee43288b67e27b71e72ed DIFF: https://github.com/llvm/llvm-project/commit/121a89fc2aedf48ca4aee43288b67e27b71e72ed.diff LO

[clang] 5131f44 - Simplify clang/test/CodeGen/annotations-global.c CHECK lines

Author: Alex Richardson Date: 2022-12-08T20:44:40Z New Revision: 5131f444ee7045d58f72fc99e2ac69792e8b7158 URL: https://github.com/llvm/llvm-project/commit/5131f444ee7045d58f72fc99e2ac69792e8b7158 DIFF: https://github.com/llvm/llvm-project/commit/5131f444ee7045d58f72fc99e2ac69792e8b7158.diff LO

[PATCH] D139647: [opt] Disincentivize new tests from using old pass syntax

lebedev.ri added a comment. @aeubanks Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139647/new/ https://reviews.llvm.org/D139647 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson updated this revision to Diff 481421. probinson added a comment. Add trailing '{{.*}}' as requested. Have not changed the encoding.ll test, waiting on @uweigand about correct value to test in Python. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.ll

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:11 +#include // massberg #include "TreeTransform.h" Please remove. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://re

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] af781f7 - [OPENMP51]Codegen for error directive.

Author: Jennifer Yu Date: 2022-12-08T13:07:08-08:00 New Revision: af781f7042392910c4cf70106c6a0c2244c69478 URL: https://github.com/llvm/llvm-project/commit/af781f7042392910c4cf70106c6a0c2244c69478 DIFF: https://github.com/llvm/llvm-project/commit/af781f7042392910c4cf70106c6a0c2244c69478.diff L

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf781f704239: [OPENMP51]Codegen for error directive. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

jansvoboda11 accepted this revision. jansvoboda11 added subscribers: vsapsai, Bigcheese. jansvoboda11 added a comment. This revision is now accepted and ready to land. In D139653#3982272 , @kastiglione wrote: >> Also, do you think this should be configur

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

akyrtzi added inline comments. Comment at: clang/include/clang-c/Documentation.h:549 +typedef struct CXAPISetImpl *CXAPISet; + benlangmuir wrote: > @dang please document what this type represents. > > @akyrtzi what's the preferred implementation type name for

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

isuckatcs added a comment. > the temporary's construction should appear before, but the binding decls, > which use the synthetic variables, should appear after I'm confused a bit here. Right now the CFG looks like this: ... Based on what you say I assume you want something to happen

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); I think it would better to fix this function instead of

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks great to me. I added a minor comment regarding the grammar of the added diagnostic, but am accepting the review regardless. Comment at: clang/include/cl

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

tahonermann added a comment. Oh, also, the review summary mentions "UAX32" (twice); those should be "UAX31". Just please make sure the commit message is correct. Also, I'm terribly sorry for being so slow to get this reviewed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 262c303 - Revert "[AMDGPU] Disable bool range metadata to workaround backend issue"

Author: Yaxun (Sam) Liu Date: 2022-12-08T17:35:10-05:00 New Revision: 262c3034bb44cac8b4ed6d4a3bb99ceb60d9e322 URL: https://github.com/llvm/llvm-project/commit/262c3034bb44cac8b4ed6d4a3bb99ceb60d9e322 DIFF: https://github.com/llvm/llvm-project/commit/262c3034bb44cac8b4ed6d4a3bb99ceb60d9e322.dif

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione added a comment. > We could have a separate `-Ruser-module-{build,import}` (and maybe > `-Rsystem-module-{build,import}`) besides the `-Rmodule-{build,import}` (that > would now include both). that sounds good to me. I'll add tests if there are no objections. Repository: rG LLV

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

akyrtzi added inline comments. Comment at: llvm/include/llvm/Support/PGOOptions.h:18 #include "llvm/Support/Error.h" +#include "llvm/Support/VirtualFileSystem.h" steven_wu wrote: > akyrtzi wrote: > > akyrtzi wrote: > > > I'd suggest to consider moving the `PGO

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit resolves the FIXME around the behavior of `Lexer::makeFileCharRange`

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. This looks really good. I added a suggested edit for a comment that I had a hard time understanding and noted an area of code that I'm not sure is working as expected. =

[clang] 500e729 - add floor library function

Author: Joshua Batista Date: 2022-12-08T15:41:54-08:00 New Revision: 500e72924305c4a1fac2ffd45b16114d49c3a7d2 URL: https://github.com/llvm/llvm-project/commit/500e72924305c4a1fac2ffd45b16114d49c3a7d2 DIFF: https://github.com/llvm/llvm-project/commit/500e72924305c4a1fac2ffd45b16114d49c3a7d2.diff

[PATCH] D139137: add floor library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG500e72924305: add floor library function (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139137/new/ https://reviews.llvm.org/D139137

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yln accepted this revision. yln added a subscriber: rsundahl. yln added a comment. Thank you! LGTM, with one nit. @rsundahl: can you keep an eye on this and resolve potential conflicts? Thanks! Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:3280-3286 if ((IsX86_64 || I

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 481475. schittir edited the summary of this revision. schittir added a comment. Add assert at the beginning of blocks pointed out by Coverity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 481481. davidtgoldblatt added a comment. Per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/include/clang/Basic/Builtins.def

[clang] 3b7af27 - Revert "Revert "[-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffers.""

Author: Artem Dergachev Date: 2022-12-08T16:57:59-08:00 New Revision: 3b7af2796b3d1a578b7e256f5e5b60e61108ec8d URL: https://github.com/llvm/llvm-project/commit/3b7af2796b3d1a578b7e256f5e5b60e61108ec8d DIFF: https://github.com/llvm/llvm-project/commit/3b7af2796b3d1a578b7e256f5e5b60e61108ec8d.dif

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

vsapsai added a comment. From my experience, `ShowInSystemHeader` for `-Rmodule-build` is overall useful. I haven't heard from people who want no remarks from system headers and the rest is just hypothetical guesses that can go both ways (some people might like one option while some people migh

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:17 + +#include "clang/ASTMatchers/ASTMatchFinder.h" + Ok so this is what caused the revert (https://lab.llvm.org/buildbot#builders/121/builds/25877): ```lines=10 FAI

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling created this revision. tangyouling added reviewers: Sanitizers, vitalybuka, SixWeining, xen0n, xry111, MaskRay, XiaodongLoong, lixing-star. Herald added subscribers: Enna1, StephenFan, s.egerton, simoncook. Herald added a project: All. tangyouling requested review of this revision. Her

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling added a comment. $ cat memory-leak.c #include void *p; int main() { p = malloc(7); p = 0; // The memory is leaked here. return 0; } $ ./build/bin/clang -fsanitize=address -g memory-leak.c ; ASAN_OPTIONS=detect_leaks=1 ./a.out ===

[PATCH] D139233: [-Wunsafe-buffer-usage] Add an unsafe gadget for pointer-arithmetic operations

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:374-375 + : UnsafeGadget(Kind::PointerArithmetic), +PA(Result.Nodes.getNodeAs("ptrAdd")), +Ptr(Result.Nodes.getNodeAs("ptrAddPtr")) {} + Let's unhardcode the bind

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

owenpan added a comment. I have second thoughts about linking block braces in `UnwrappedLineParser`. Consider the following example: #if A while (a) { // Linked to the r_brace below #else while(b) { // Also linked to the r_brace below #endif foo(); } // Linked to the l_brace of

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. In D138263#3975828 , @owenpan wrote: > Can you rebase (preferably after landing D138402 > )? See D139257#3983332 . If it gets reverted, we have to do s

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. In D139544#3982821 , @isuckatcs wrote: >> the temporary's construction should appear before, but the binding decls, >> which use the synthetic variables, should appear after > > I'm confused a bit here. Right now the CFG looks li

[PATCH] D139686: [lsan] Add lsan support for loongarch64

xen0n added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else Since our VM layout is actually flexible, would it be better to document this, like "Support only the most c

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:90-92 + Loc = Expansion.getExpansionLocStart(); + if (Loc.isFileID()) +return true; -

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else xen0n wrote: > Since our VM layout is actually flexible, would it be better to document > this, like "

[PATCH] D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. This should be good enough (reminiscent of CSR ops) but let's wait for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139612/new/

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 481503. ChuanqiXu marked 2 inline comments as done. ChuanqiXu retitled this revision from "[Driver] [Modules] Support -fsave-std-c++-module-file (1/2)" to "[Driver] [Modules] Support -fmodule-output (1/2)". ChuanqiXu added a comment. Rename the option into

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

ChuanqiXu updated this revision to Diff 481504. ChuanqiXu retitled this revision from "[Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)" to "[Driver] [C++20] [Modules] Support -fmodule-output= (2/2)". ChuanqiXu added a comment. Rename the opti

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

li.zhe.hua updated this revision to Diff 481506. li.zhe.hua added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139676/new/ https://reviews.llvm.org/D139676 Files: clang/include/clang/Tooling/Transformer/SourceCode.h

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

li.zhe.hua marked 2 inline comments as done. li.zhe.hua added inline comments. Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:90-92 + Loc = Expansion.getExpansionLocStart(); + if (Loc.isFileID()) +return true; ymandel wrote: > can you

[clang] a78d4b5 - [libTooling] Add flag to getRangeForEdit to ignore macro expansions

Author: Eric Li Date: 2022-12-08T22:40:10-05:00 New Revision: a78d4b5ba716d88a90b905c261f53e74e67a7367 URL: https://github.com/llvm/llvm-project/commit/a78d4b5ba716d88a90b905c261f53e74e67a7367 DIFF: https://github.com/llvm/llvm-project/commit/a78d4b5ba716d88a90b905c261f53e74e67a7367.diff LOG:

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. li.zhe.hua marked an inline comment as done. Closed by commit rGa78d4b5ba716: [libTooling] Add flag to getRangeForEdit to ignore macro expansions (authored by li.zhe.hu

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 481508. ayzhao added a comment. rebase + (hopefully) fix libc++ c++2b test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rs

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5380 + } + InitExprs.push_back(ER.get()); +} ayzhao wrote: > So the libc++ test compile failures are due to this line. > > One example of a failing unit test is > [r

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/AST/JSONNodeDumper.cpp:852 case VarDecl::ListInit: JOS.attribute("init", "list"); break; +case VarDecl::ParenListInit: + JOS.attribute("init", "paren-list"); ilya-biryukov wrote: > ayzhao wrote: >

[PATCH] D139686: [lsan] Add lsan support for loongarch64

xen0n added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else tangyouling wrote: > xen0n wrote: > > Since our VM layout is actually flexible, would it be better to documen

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else xen0n wrote: > tangyouling wrote: > > xen0n wrote: > > > Since our VM layout is actually flexible, woul

[clang] 1f88fb4 - [clang] Use std::nullopt instead of None in comments (NFC)

Author: Kazu Hirata Date: 2022-12-08T22:43:11-08:00 New Revision: 1f88fb406cc323eb36fc5f18626915b4ba75560e URL: https://github.com/llvm/llvm-project/commit/1f88fb406cc323eb36fc5f18626915b4ba75560e DIFF: https://github.com/llvm/llvm-project/commit/1f88fb406cc323eb36fc5f18626915b4ba75560e.diff L

[PATCH] D139387: [NFC][Clang] Add missing test cases for segment load

4vtomat updated this revision to Diff 481521. 4vtomat added a comment. Update failed test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139387/new/ https://reviews.llvm.org/D139387 Files: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded

[clang] c25cc84 - [clang] Don't including None.h (NFC)

Author: Kazu Hirata Date: 2022-12-08T23:36:50-08:00 New Revision: c25cc84b87935feefea5a93abc16efdbc9d91640 URL: https://github.com/llvm/llvm-project/commit/c25cc84b87935feefea5a93abc16efdbc9d91640 DIFF: https://github.com/llvm/llvm-project/commit/c25cc84b87935feefea5a93abc16efdbc9d91640.diff L

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

owenpan added a comment. See https://github.com/llvm/llvm-project/issues/59417. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139257/new/ https://reviews.llvm.org/D139257 ___ cfe-commits mailing list cfe

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBlock.h:97 void invokeCtor() { -std::memset(data(), 0, getSize()); +std::memset(rawData(), 0, Desc->getAllocSize()); if (Desc->CtorFn) aaron.ballman wrote: > tbaeder wrote: > >

<    1   2