yln accepted this revision.
yln added a subscriber: rsundahl.
yln added a comment.
Thank you! LGTM, with one nit.
@rsundahl: can you keep an eye on this and resolve potential conflicts? Thanks!
================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:3280-3286
if ((IsX86_64 || IsAArch64) && isTargetMacOSBased()) {
Res |= SanitizerKind::Thread;
- } else if (isTargetIOSSimulator() || isTargetTvOSSimulator()) {
+ } else if (isTargetIOSSimulator() || isTargetTvOSSimulator() ||
+ isTargetWatchOSSimulator()) {
if (IsX86_64)
Res |= SanitizerKind::Thread;
}
----------------
Yes, for watchOS simulator. I think we can also drop the constraint on x86_64
and then merge the if. TSan //should// be supported for simulators on Apple
Silicon. Can you add additional tests for these 3 cases? Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139652/new/
https://reviews.llvm.org/D139652
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
