[clang] a1255dc - Use-after-return sanitizer binary metadata

Author: Dmitry Vyukov Date: 2022-11-29T17:37:36+01:00 New Revision: a1255dc467f7ce57a966efa764ee91d9115a URL: https://github.com/llvm/llvm-project/commit/a1255dc467f7ce57a966efa764ee91d9115a DIFF: https://github.com/llvm/llvm-project/commit/a1255dc467f7ce57a966efa764ee91d9115a.diff

[PATCH] D136078: Use-after-return sanitizer binary metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1255dc467f7: Use-after-return sanitizer binary metadata (authored by dvyukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D138930: [RISCV] Add macro to imply compiler availability on RISC-V Vector intrinsics version

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, jrtc27, reames, asb. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMo

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson updated this revision to Diff 478617. tmatheson added a comment. Rename AI -> ArchInfo and delete move constructor/assignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138792/new/ https://reviews.llvm.org/D138792 Files: clang/lib/B

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson marked an inline comment as done. tmatheson added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138792/new/ https://reviews.llvm.org/D138792 ___ cfe-commits ma

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. @aaron.ballman Following example of other DR test, I was reluctant to add relevant comments, e.g. wording. But I can provide it going forward or even update this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

Anastasia added a comment. In D137652#3957233 , @FMarno wrote: > @Anastasia I feel like I am following the guidance you quoted here. The > defines I've deleted in `opencl-c-base.h` are blocking the possibility of > `-cl-ext` working and would also get i

[clang] 91ba8b2 - clang: Fix cast failure when using -fsanitize=undefined for HIP

Author: Matt Arsenault Date: 2022-11-29T11:48:46-05:00 New Revision: 91ba8b2b8dc44355851f2953ea3eeea21c230c53 URL: https://github.com/llvm/llvm-project/commit/91ba8b2b8dc44355851f2953ea3eeea21c230c53 DIFF: https://github.com/llvm/llvm-project/commit/91ba8b2b8dc44355851f2953ea3eeea21c230c53.diff

[PATCH] D138439: clang: Fix cast failure when using -fsanitize=undefined for HIP

arsenm closed this revision. arsenm added a comment. 91ba8b2b8dc44355851f2953ea3eeea21c230c53 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138439/new/ https://reviews.llvm.org/D138439 __

[clang] f19c272 - [PS4] Remove an UNSUPPORTED, this test seems to work now

Author: Paul Robinson Date: 2022-11-29T08:59:09-08:00 New Revision: f19c2720e3f0571d0fb415efa8f4b9fc5ae6eb17 URL: https://github.com/llvm/llvm-project/commit/f19c2720e3f0571d0fb415efa8f4b9fc5ae6eb17 DIFF: https://github.com/llvm/llvm-project/commit/f19c2720e3f0571d0fb415efa8f4b9fc5ae6eb17.diff

[clang] 7b5d525 - Fix Clang sphinx build

Author: Aaron Ballman Date: 2022-11-29T12:01:25-05:00 New Revision: 7b5d5250be3e42d388d85e28ec31656c463f0d34 URL: https://github.com/llvm/llvm-project/commit/7b5d5250be3e42d388d85e28ec31656c463f0d34 DIFF: https://github.com/llvm/llvm-project/commit/7b5d5250be3e42d388d85e28ec31656c463f0d34.diff

[clang] dbb1130 - Revert "Use-after-return sanitizer binary metadata"

Author: Kazu Hirata Date: 2022-11-29T09:04:00-08:00 New Revision: dbb11309665fdf7d411d25cc8f2e6a0c8f658143 URL: https://github.com/llvm/llvm-project/commit/dbb11309665fdf7d411d25cc8f2e6a0c8f658143 DIFF: https://github.com/llvm/llvm-project/commit/dbb11309665fdf7d411d25cc8f2e6a0c8f658143.diff L

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a comment. In D138822#3957395 , @Endill wrote: > @aaron.ballman Following example of other DR tests, I was reluctant to add > relevant comments, e.g. wording. But I can provide it going forward or even > update this patch. No worrie

[clang] dee009d - [lit] UNSUPPORTED ps4/ps5 => target={{.*-ps(4|5)}}

Author: Paul Robinson Date: 2022-11-29T09:07:59-08:00 New Revision: dee009d3b5c71a340eb4ebb3cfb49f6015a789cc URL: https://github.com/llvm/llvm-project/commit/dee009d3b5c71a340eb4ebb3cfb49f6015a789cc DIFF: https://github.com/llvm/llvm-project/commit/dee009d3b5c71a340eb4ebb3cfb49f6015a789cc.diff

[PATCH] D136078: Use-after-return sanitizer binary metadata

melver added inline comments. Comment at: llvm/lib/CodeGen/SanitizerBinaryMetadata.cpp:57 + // Assume it currently only has features. + assert(AuxMDs.size() == 1); + auto *Features = cast(AuxMDs.getOperand(0))->getValue(); Probably should be getNumOperands()?

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138474/new/ https://reviews.llvm.org/D138474 _

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Among the worst parts of this paper are references to mailing list and EDG wiki, which I don't have access to. But I still managed to dig everything up, and ready to explain if requested. No tests were copied blindly from issues. CHANGES SINCE LAST ACTION https://revi

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a comment. In D138822#3957459 , @Endill wrote: > Among the worst parts of this paper are references to mailing list and EDG > wiki, which I don't have access to. But I still managed to dig everything up, > and ready to explain if req

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman accepted this revision as: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. Adding my explicit LG, but just personally instead of for the language wg. If we don't hear from anyone else in the next 1-2 days, I'd say this is safe to land.

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Thank you! > FWIW, if you need help getting references from the mailing list or the wiki, > feel free to mention what you're after and one of us on the committee can see > about tracking down the details. Do you mean creating an incomplete diff and asking here in the co

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

carlo.bertolli added a comment. LGTM but @ABataev should review/approve this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138614/new/ https://reviews.llvm.org/D138614 ___ cfe-commits mailing list cfe-co

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

aaron.ballman added a comment. Don't forget the release note! :-) Comment at: clang/lib/Lex/Lexer.cpp:3338 -if (!isAlphanumeric(C) && C != '_' && C != '-' && C != ' ') +if (C == '\n' || C == '\r') break; `isVerticalWhitespace()`?

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a comment. In D138822#3957503 , @Endill wrote: > Thank you! > >> FWIW, if you need help getting references from the mailing list or the wiki, >> feel free to mention what you're after and one of us on the committee can >> see about t

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

svenvh added a comment. > @svenvh I remember that we have also discussed the addition of a vendor > specific header where such feature/extension macro definition can be added to > avoid the macro pollution but I feel this is somewhat orthogonal i.e. the > fine grained control of macro defines i

[PATCH] D138822: [clang] Add test for CWG36

erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} As a nit, I prefer the 'notes' to

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:243 if (!FD->getType()->isReferenceType()) { - assert(!VD->getType()->isVariablyModifiedType() && + bool isVMT = VD->getType()->isVariablyModifiedType(); + asse

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Discord feels perfect to me for this kind of questions. What's left is to get past a broken bot for agreeing with code of conduct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 ___

[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:552-553 bit LateParsed = 0; + // Set to true for attributes that should participate in ODR hashing. + bit IsODRHashable = 0; // Set to false to prevent an attribute from being propagated fr

[clang] cd5900d - [PCH] Remove useless UNSUPPORTED clause

Author: Paul Robinson Date: 2022-11-29T10:07:38-08:00 New Revision: cd5900dcd1ecea9a5e2ec7b8bc53c61d90b856ed URL: https://github.com/llvm/llvm-project/commit/cd5900dcd1ecea9a5e2ec7b8bc53c61d90b856ed DIFF: https://github.com/llvm/llvm-project/commit/cd5900dcd1ecea9a5e2ec7b8bc53c61d90b856ed.diff

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin added a comment. In D138511#3954143 , @efriedma wrote: > It looks like AArch64ABIInfo::classifyArgumentType does a slightly more > complicated check for "empty"; does that matter here? Thanks for your comments @efriedma. Good catch! Current pa

[PATCH] D138091: [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as NonType when they are brought into scope via using enum

shafik updated this revision to Diff 478630. shafik marked an inline comment as done. shafik added a comment. Add release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138091/new/ https://reviews.llvm.org/D138091 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDecl.cpp

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478631. cor3ntin added a comment. - Add test - Add release notes entry - use isVerticalWhitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137386/new/ https://reviews.llvm.org/D137386 ___ cfe-commits mailing lis

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:243 if (!FD->getType()->isReferenceType()) { - assert(!VD->getType()->isVariablyModifiedType() && + bool isVMT = VD->getType()->isVariablyModifiedType(); + ass

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136920/new/ https://reviews.llvm.org/D136920 ___ cfe-commits mailing lis

[clang] df3f5f7 - [Windows] Convert tests to check 'target='

Author: Paul Robinson Date: 2022-11-29T10:33:21-08:00 New Revision: df3f5f714985a45ed7ad34a60f16a853b6cd40f2 URL: https://github.com/llvm/llvm-project/commit/df3f5f714985a45ed7ad34a60f16a853b6cd40f2 DIFF: https://github.com/llvm/llvm-project/commit/df3f5f714985a45ed7ad34a60f16a853b6cd40f2.diff

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:243 if (!FD->getType()->isReferenceType()) { - assert(!VD->getType()->isVariablyModifiedType() && + bool isVMT = VD->getType()->isVariablyModifiedType(); + ass

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin updated this revision to Diff 478633. yronglin added a comment. Use AArch64ABIInfo::classifyArgumentType().isIgnore() to check empty record vaarg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511

[clang] 54be300 - [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as NonType when they are brought into scope via using enum

Author: Shafik Yaghmour Date: 2022-11-29T10:39:21-08:00 New Revision: 54be300f7e0bc4edaf54e9289b2380bd210a37bc URL: https://github.com/llvm/llvm-project/commit/54be300f7e0bc4edaf54e9289b2380bd210a37bc DIFF: https://github.com/llvm/llvm-project/commit/54be300f7e0bc4edaf54e9289b2380bd210a37bc.dif

[PATCH] D138091: [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as NonType when they are brought into scope via using enum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54be300f7e0b: [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as… (authored by shafik). Herald added a project: clang. Reposit

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr26xx.cpp:41 +#define a z( +int x = a\N{abc}); // expected-error 2{{'abc' is not a valid Unicode character name}} + Why do we get two errors here? Also, can you add this case: ``` int y = a\N{

[PATCH] D131858: [clang] Track the templated entity in type substitution.

arphaman added a comment. Herald added a reviewer: njames93. Hi @mizvekov. This change has caused a failure in Clang's stage 2 CI on the green dragon Darwin CI: https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console. Assertion failed: (lvaluePath->getType() == elemTy && "Une

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:243 if (!FD->getType()->isReferenceType()) { - assert(!VD->getType()->isVariablyModifiedType() && + bool isVMT = VD->getType()->isVariablyModifiedType(); + asse

[clang] 530eb26 - [clang] Add serialization for loop hint annotation tokens

Author: Mike Rice Date: 2022-11-29T10:51:11-08:00 New Revision: 530eb263c0ec02fe8d107cbdb41ac6e482514a00 URL: https://github.com/llvm/llvm-project/commit/530eb263c0ec02fe8d107cbdb41ac6e482514a00 DIFF: https://github.com/llvm/llvm-project/commit/530eb263c0ec02fe8d107cbdb41ac6e482514a00.diff LOG

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

This revision was automatically updated to reflect the committed changes. Closed by commit rG530eb263c0ec: [clang] Add serialization for loop hint annotation tokens (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://re

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff added inline comments. Comment at: clang/test/Parser/recovery.c:105 + unknown_t a; // expected-error {{unknown type name 'unknown_t'}} + unknown_t *b; // expected-error {{unknown type name 'unknown_t'}} + unknown_t const *c; // expected-error {{unknown type name 'unkno

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. In D138597#3957356 , @dblaikie wrote: > In D138597#3954269 , @probinson > wrote: > >> The codes have been allocated but AFAICT the website doesn't have the new >> codes listed (I looke

[PATCH] D136176: Implement support for option 'fexcess-precision'.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:301 + enum Float16ExcessPrecisionKind { FPP_Standard, FPP_Fast, FPP_None }; + rjmccall wrote: > You can leave this named `ExcessPrecisionKind` — if we introduce excess > preci

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 478658. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added tests. Fixed regressions in diagnositcs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org

[PATCH] D138822: [clang] Add test for CWG36

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} erichkeane wrote: > As a nit, I prefer

[clang] 2166d95 - [OpenMP][OMPIRBuilder] Migrate target outlined function registration to OMPIRBuilder from clang

Author: Jan Sjodin Date: 2022-11-29T14:20:34-05:00 New Revision: 2166d9529a60d1cdedb733d2e4134c971f0969ec URL: https://github.com/llvm/llvm-project/commit/2166d9529a60d1cdedb733d2e4134c971f0969ec DIFF: https://github.com/llvm/llvm-project/commit/2166d9529a60d1cdedb733d2e4134c971f0969ec.diff LO

[PATCH] D137587: [OpenMP][OMPIRBuilder] Migrate target outlined function registration to OMPIRBuilder from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG2166d9529a60: [OpenMP][OMPIRBuilder] Migrate target outlined function registration to… (authored by jsjodin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM G

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:428 + : Requirement(RK_Nested, +Constraint && Constraint->isInstantiationDependent(), +Constraint && Constraint->containsUnexpandedParameterPack(), -

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie added a comment. >>> @aprantl do you have an opinion on this? I tend to lean to the pedantic >>> side on this kind of thing, but I'm persuadable. >> >> Yeah, I've certainly got mixed feelings - maybe we don't pick up these >> after-release language codes, and instead produce the new la

[PATCH] D138822: [clang] Add test for CWG36

erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} Endill wrote: > erichkeane wrote:

[PATCH] D138854: [AIX][LTO] Enabling Context Sensitive PGO Options

qiongsiwu1 updated this revision to Diff 478661. qiongsiwu1 added a comment. Fix a clang-format issue in `CommonArgs.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138854/new/ https://reviews.llvm.org/D138854 Files: clang/lib/Driver/ToolCha

[clang] 2fc5a34 - Add test coverage for more C DRs

Author: Aaron Ballman Date: 2022-11-29T14:44:37-05:00 New Revision: 2fc5a3410087c209567c7e4a2c457b6896c127a3 URL: https://github.com/llvm/llvm-project/commit/2fc5a3410087c209567c7e4a2c457b6896c127a3 DIFF: https://github.com/llvm/llvm-project/commit/2fc5a3410087c209567c7e4a2c457b6896c127a3.diff

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff updated this revision to Diff 478667. urazoff added a comment. Reasoning about invalid code is made now in specific parsing path not in general decision-making method. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137020/new/ https://reviews.llvm.org/D137020 Files: clang/lib

[clang] c52053b - [clang] Fix buildbot failure in delayed-template-with-pragma.cpp

Author: Mike Rice Date: 2022-11-29T11:53:37-08:00 New Revision: c52053bd9961cc1854e86958ffb0f89e2cfe4e5f URL: https://github.com/llvm/llvm-project/commit/c52053bd9961cc1854e86958ffb0f89e2cfe4e5f DIFF: https://github.com/llvm/llvm-project/commit/c52053bd9961cc1854e86958ffb0f89e2cfe4e5f.diff LOG

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478673. cor3ntin added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/lib

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:301 + enum Float16ExcessPrecisionKind { FPP_Standard, FPP_Fast, FPP_None }; + rjmccall wrote: > rjmccall wrote: > > You can leave this named `ExcessPrecisionKind` — if we intro

[clang] f2c0c72 - [Windows] Convert clang/test/Modules tests to check 'target='

Author: Paul Robinson Date: 2022-11-29T12:17:36-08:00 New Revision: f2c0c7299b18448ac3ae04891b53fd8cac4af178 URL: https://github.com/llvm/llvm-project/commit/f2c0c7299b18448ac3ae04891b53fd8cac4af178 DIFF: https://github.com/llvm/llvm-project/commit/f2c0c7299b18448ac3ae04891b53fd8cac4af178.diff

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added subscribers: carlosgalvezp, kadircet, arphaman. Herald added a reviewer: njames93. Herald added projects: Flang, All. cjdb requested review of this revision. Herald added subscribers: cfe-commits, libc

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. > They're published on the website too: https://dwarfstd.org/LanguagesV6.php (sigh) sorry, distracted by other things today. Yeah, using the v6 codes with the v6 attributes for the new ones WFM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:243 if (!FD->getType()->isReferenceType()) { - assert(!VD->getType()->isVariablyModifiedType() && + bool isVMT = VD->getType()->isVariablyModifiedType(); + ass

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478679. cor3ntin added a comment. Slightly improve error recovery Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Le

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. @njames93 if you don't have any further concerns, I am going to merge this on Friday afternoon, as it will have been four months since there has been a maintainer's input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 478683. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp clang-

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 updated this revision to Diff 478693. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138614/new/ https://reviews.llvm.org/D138614 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/target_teams_distribute_with_alias.c Index: clang/test/OpenMP/target_teams_dist

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

tom-anders added a comment. In D138028#3957139 , @v1nh1shungry wrote: > A gentle ping? Sorry if it bothers you. Sorry! I thought you’d probably first wanted to address the remaining comments in https://reviews.llvm.org/D137817 because they might also a

[clang] 02b25bd - [clang] [MinGW] Improve/extend the gcc/sysroot detection logic

Author: Martin Storsjö Date: 2022-11-29T23:16:09+02:00 New Revision: 02b25bd904b51184b579b7f0bac816bdd11eb757 URL: https://github.com/llvm/llvm-project/commit/02b25bd904b51184b579b7f0bac816bdd11eb757 DIFF: https://github.com/llvm/llvm-project/commit/02b25bd904b51184b579b7f0bac816bdd11eb757.diff

[clang] 98454e3 - [clang] [MinGW] Improve detection of libstdc++ headers on Fedora

Author: Martin Storsjö Date: 2022-11-29T23:16:09+02:00 New Revision: 98454e388500de2f264c06b555d6009614f8f56e URL: https://github.com/llvm/llvm-project/commit/98454e388500de2f264c06b555d6009614f8f56e DIFF: https://github.com/llvm/llvm-project/commit/98454e388500de2f264c06b555d6009614f8f56e.diff

[PATCH] D138692: [clang] [MinGW] Improve/extend the gcc/sysroot detection logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02b25bd904b5: [clang] [MinGW] Improve/extend the gcc/sysroot detection logic (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138693: [clang] [MinGW] Improve detection of libstdc++ headers on Fedora

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98454e388500: [clang] [MinGW] Improve detection of libstdc++ headers on Fedora (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478706. cor3ntin added a comment. Avoid duplicating errors in macros. Because of that we cannot alays recover nicely with a loose matching. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://rev

[clang] 2a67014 - [clang][driver][darwin] Enforce consistent major version limit for any Darwin OS

Author: Alex Lorenz Date: 2022-11-29T13:18:56-08:00 New Revision: 2a6701444af816f9048c788513abf4d2e9fa785d URL: https://github.com/llvm/llvm-project/commit/2a6701444af816f9048c788513abf4d2e9fa785d DIFF: https://github.com/llvm/llvm-project/commit/2a6701444af816f9048c788513abf4d2e9fa785d.diff L

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

erichkeane added a comment. Herald added subscribers: Michael137, JDevlieghere. A few comments. I don't mind the approach, though I find myself wondering if the "FormatDiagnostic" call should stay the same, and choose the legacy-reason only when a sarif reason doesn't exist? Or for some level

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:243 if (!FD->getType()->isReferenceType()) { - assert(!VD->getType()->isVariablyModifiedType() && + bool isVMTTy = VD->getType()->isVariablyModifiedType(); + as

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:54-55 + bool TraverseDecl(Decl *Node) { +if (!Node) + return true; +if (!match(*Node)) steakhal wrote: > Can `Node` be ever null if the visitor is initiated onl

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. I don't understand why `test_demangle.pass.cpp` was considered too big to upload. Here's the diff: diff --git a/libcxxabi/test/test_demangle.pass.cpp b/libcxxabi/test/test_demangle.pass.cpp index dce8e6c3..9da6fb7d2ad9 100644 --- a/libcxxabi/test/test_demangle.pa

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 updated this revision to Diff 478707. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138614/new/ https://reviews.llvm.org/D138614 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/target_teams_distribute_with_alias.c Index: clang/test/OpenMP/target_teams_dist

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. > The clang-side interface to this seems a touch clunky, and I fear it'll make > continuing its use/generalizing its use less likely. Is this w.r.t. the `FormatDiagnostic` being split up, or is it something else? If it's the former: I'll be changing that to `FormatLegacyDi

[PATCH] D138947: [Clang] Remove invalid assert from Sema::BuildCXXTypeConstructExpr

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, davide, rsmith. Herald added a project: All. shafik requested review of this revision. Currently `Sema::BuildCXXTypeConstructExpr` asserts that list initialization must mean we have an `InitListExpr` as well. We have

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. > though I find myself wondering if the "FormatDiagnostic" call should stay the > same, and choose the legacy-reason only when a sarif reason doesn't exist? Or > for some level of command line control? Hmm... isn't this the point of the diagnostic consumers? Repository:

[clang] 3a37c11 - [clang] [test] Fix recently pushed mingw tests in some environments

Author: Martin Storsjö Date: 2022-11-30T00:01:01+02:00 New Revision: 3a37c112b173b7d66e6562cc12c441e996d895f2 URL: https://github.com/llvm/llvm-project/commit/3a37c112b173b7d66e6562cc12c441e996d895f2 DIFF: https://github.com/llvm/llvm-project/commit/3a37c112b173b7d66e6562cc12c441e996d895f2.diff

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

aprantl added a comment. > @aprantl do you have an opinion on this? I tend to lean to the pedantic side > on this kind of thing, but I'm persuadable. As long as LLDB can deal with it I'm fine either way. Emitting the separated DWARF 6 attribute as an extension sounds fine to me. =

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def:1 +//=- UnsafeBufferUsageGadgets.def - List of ways to use a buffer --*- C++ -*-=// +// aaron.ballman wrote: > Is this file named properly if it is also goi

[clang] 60a33de - [clang][darwin] Use consistent version define stringifying logic for different Darwin OSes

Author: Alex Lorenz Date: 2022-11-29T14:22:34-08:00 New Revision: 60a33ded751c86fff9ac1c4bdd2b341fbe4b0649 URL: https://github.com/llvm/llvm-project/commit/60a33ded751c86fff9ac1c4bdd2b341fbe4b0649 DIFF: https://github.com/llvm/llvm-project/commit/60a33ded751c86fff9ac1c4bdd2b341fbe4b0649.diff L

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:107 +/// out of bounds. +class IncrementGadget : public UnsafeGadget { + const UnaryOperator *Op; xazax.hun wrote: > How deep will the `Gadget` Hierarchy be? Using inheritance only t

[clang-tools-extra] 7b8c7e0 - [clang-doc] Move file layout to the generators.

Author: Brett Wilson Date: 2022-11-29T14:40:58-08:00 New Revision: 7b8c7e02122a2ea392b371e3e39b405bc98146de URL: https://github.com/llvm/llvm-project/commit/7b8c7e02122a2ea392b371e3e39b405bc98146de DIFF: https://github.com/llvm/llvm-project/commit/7b8c7e02122a2ea392b371e3e39b405bc98146de.diff

[PATCH] D138073: [clang-doc] Move file layout to the generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b8c7e02122a: [clang-doc] Move file layout to the generators. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://review

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:54-55 + bool TraverseDecl(Decl *Node) { +if (!Node) + return true; +if (!match(*Node)) ziqingluo-90 wrote: > steakhal wrote: > > Can `Node` be ever null if the visitor i

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 478738. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/L

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 478624. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Sema/SemaDecl.cpp clang/test/CodeGenCXX/PR19955.cpp clan

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3931259 , @efriedma wrote: > There are multiple notions of "constant" here: > > - Whether a value is invariant at runtime. > - Whether a value is legal in a "constexpr" expression. > - Whether we can emit a constant wi

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

tahonermann added a comment. I apologize for the delay Corentin, I hope to get through a number of my outstanding code reviews tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 __

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr26xx.cpp:41 +#define a z( +int x = a\N{abc}); // expected-error 2{{'abc' is not a valid Unicode character name}} + aaron.ballman wrote: > Why do we get two errors here? > > Also, can you add this

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, erichkeane, rjmccall. lebedev.ri added a project: LLVM. Herald added subscribers: carlosgalvezp, jdoerfert. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. Herald added a project: All. lebedev.ri requested

[PATCH] D136176: Implement support for option 'fexcess-precision'.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:301 + enum Float16ExcessPrecisionKind { FPP_Standard, FPP_Fast, FPP_None }; + zahiraam wrote: > rjmccall wrote: > > rjmccall wrote: > > > You can leave this named `ExcessPrecis

[PATCH] D138930: [RISCV] Add macro to imply compiler availability on RISC-V Vector intrinsics version

craig.topper added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:266 // CHECK-ZVE64D-EXT: __riscv_v_elen_fp 64 +// CHECK-ZVE64D-EXT: __riscv_v_intrinsic 1 // CHECK-ZVE64D-EXT: __riscv_v_min_vlen 64 Check to end of line like th

<    1   2   3   >