[clang] 721f975 - Use PassGate from LLVMContext if any otherwise global one

Author: Evgeniy Brevnov Date: 2022-11-25T15:13:04+07:00 New Revision: 721f975d3518403502f770ce11f3f02509b30c5b URL: https://github.com/llvm/llvm-project/commit/721f975d3518403502f770ce11f3f02509b30c5b DIFF: https://github.com/llvm/llvm-project/commit/721f975d3518403502f770ce11f3f02509b30c5b.dif

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG721f975d3518: Use PassGate from LLVMContext if any otherwise global one (authored by Evgeniy Brevnov ). Repository: rG LLVM Git

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh updated this revision to Diff 477871. Pierre-vh added a comment. Fixing condition, adding new test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/ https://reviews.llvm.org/D138651 Files: clang/lib/AST/ASTContext.cpp cl

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

nridge added a comment. In D138546#3946144 , @sammccall wrote: > In D138546#3946046 , @cpsauer wrote: > >> Sam, my read, too, is that the memoizing design isn't safe--also that the >> key bug is preexisting. >>

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477874. VitaNuo added a comment. Herald added a subscriber: kadircet. Improve the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477876. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-include-clea

[PATCH] D138692: [clang] [MinGW] Improve/extend the gcc/sysroot detection logic

mstorsjo created this revision. mstorsjo added reviewers: rnk, mati865, alvinhochun, tstellar. Herald added a subscriber: pengfei. Herald added a project: All. mstorsjo requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. There are three functions t

[PATCH] D138693: [clang] [MinGW] Improve detection of libstdc++ headers on Fedora

mstorsjo created this revision. mstorsjo added reviewers: rnk, mati865, alvinhochun, tstellar. Herald added a subscriber: pengfei. Herald added a project: All. mstorsjo requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. There's some variation in w

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

nridge added a comment. In D136594#3940482 , @sammccall wrote: > An (IMO) useful distinction that can't be found by the lexer is the use of > `*` as a declarator (`int *x`) vs an operator (`return *x`). I failed to appreciate the implication of this the

[PATCH] D138657: [analyzer] Consider single-elem arrays as FAMs by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG36481758390c: [analyzer] Consider single-elem arrays as FAMs by default (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138657/new/ ht

[clang] 097ce76 - [analyzer] Deprecate FAM analyzer-config, recommend -fstrict-flex-arrays instead

Author: Balazs Benics Date: 2022-11-25T10:24:56+01:00 New Revision: 097ce7616527b8948b2a69d1300a44f552959a43 URL: https://github.com/llvm/llvm-project/commit/097ce7616527b8948b2a69d1300a44f552959a43 DIFF: https://github.com/llvm/llvm-project/commit/097ce7616527b8948b2a69d1300a44f552959a43.diff

[clang] 3648175 - [analyzer] Consider single-elem arrays as FAMs by default

Author: Balazs Benics Date: 2022-11-25T10:24:56+01:00 New Revision: 36481758390caa19d54bbab94d2f5e927fbec1c2 URL: https://github.com/llvm/llvm-project/commit/36481758390caa19d54bbab94d2f5e927fbec1c2 DIFF: https://github.com/llvm/llvm-project/commit/36481758390caa19d54bbab94d2f5e927fbec1c2.diff

[PATCH] D138659: [analyzer] Deprecate FAM analyzer-config, recommend -fstrict-flex-arrays instead

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG097ce7616527: [analyzer] Deprecate FAM analyzer-config, recommend -fstrict-flex-arrays instead (authored by steakhal). Repository: rG LLVM Github

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

nridge added a comment. (I envisioned the implementation of `augmentsSyntaxTokens=false` to be "loop over the lexer tokens and turn a subset of them into additional tokens to return over LSP". The fact that that would have meant producing an "operator" token even for `tok::star` which is actual

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3950334 , @nridge wrote: > The current patch will produce an operator token in the operator case but not > the declarator case, thereby achieving an effect that client-side > highlighting couldn't. As such, I guess

[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1932 + + llvm::SmallString<32> FilePath(File.begin(), File.end()); + path::remove_dots(FilePath, /*remove_dot_dot=*/true); kadircet wrote:

[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bed59c7e7da: [Lex] Fix suggested spelling of /usr/bin/../include/foo (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D

[clang] 8bed59c - [Lex] Fix suggested spelling of /usr/bin/../include/foo

Author: Sam McCall Date: 2022-11-25T11:01:22+01:00 New Revision: 8bed59c7e7da2fea41a9167e15c15a8f58a5ede7 URL: https://github.com/llvm/llvm-project/commit/8bed59c7e7da2fea41a9167e15c15a8f58a5ede7 DIFF: https://github.com/llvm/llvm-project/commit/8bed59c7e7da2fea41a9167e15c15a8f58a5ede7.diff LO

[PATCH] D138698: [clang-repl] Add basic documentation about clang-repl

sarabellei created this revision. sarabellei added a reviewer: v.g.vassilev. Herald added a subscriber: arphaman. Herald added a project: All. sarabellei requested review of this revision. https://reviews.llvm.org/D138698 Files: clang/docs/ClangRepl.rst clang/docs/ClangRepl_design.rst clang

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:76 + /// Returns true if the given file is marked with the IWYU private pragma + /// without public mapping. + bool isPrivate(const FileEntry *File) const; -

[PATCH] D138676: [include-cleaner] HTMLReport shows headers that would be inserted

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Herald added a subscriber: kadircet. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138676/new/ https://reviews.llvm.org/D138676 _

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscri

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:97 + /// the IWYU private pragmas with public mapping. + llvm::DenseSet IWYUPrivate; + i'd actually merge this with the previous map, and store

[PATCH] D138489: [tsan] Add tsan support for loongarch64

tangyouling updated this revision to Diff 477901. tangyouling added a comment. - Fixed the ThreadDescriptorSize calculation on loongarch64. - Use `__loongarch_lp64` to distinguish loongarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138489/new

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

kadircet added a comment. Sorry for noticing this so late. Yes the initial reason we left `sysroot` and `std/builtin-inc` related flags were exactly that, in theory they could vary but in practice they were applied to all or none of the project. Regarding this change itself, surely preserving t

[clang] b62c8d3 - Revert: Add version to all LLVM cmake package

Author: Thomas Preud'homme Date: 2022-11-25T10:54:58Z New Revision: b62c8d396f7dbef61122e169ef143276e74eff05 URL: https://github.com/llvm/llvm-project/commit/b62c8d396f7dbef61122e169ef143276e74eff05 DIFF: https://github.com/llvm/llvm-project/commit/b62c8d396f7dbef61122e169ef143276e74eff05.diff

[PATCH] D138489: [tsan] Add tsan support for loongarch64

xry111 added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1543 +"r"(__fn), "r"(__arg), "r"(nr_clone), "i"(__NR_exit) + : "memory"); + return res; SixWeining wrote: > tangyouling wrote: > > SixWeining wrote: > > >

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

sammccall added a comment. Regarding AugmentsSyntaxTokens: - in general this seems like a nice thing to support, though I'm not aware of "big" `!AugmentsSyntaxTokens` clients so it's not urgent - I think the right design for that is to (conditionally) run the lexer and mark only tokens that hav

[PATCH] D138489: [tsan] Add tsan support for loongarch64

xry111 added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1543 +"r"(__fn), "r"(__arg), "r"(nr_clone), "i"(__NR_exit) + : "memory"); + return res; xry111 wrote: > SixWeining wrote: > > tangyouling wrote: > > > Six

[clang-tools-extra] 6a95e67 - [include-cleaner] HTMLReport shows headers that would be inserted

Author: Sam McCall Date: 2022-11-25T11:57:35+01:00 New Revision: 6a95e67323dd64e6023c0b5ea89407cac2dbc01b URL: https://github.com/llvm/llvm-project/commit/6a95e67323dd64e6023c0b5ea89407cac2dbc01b DIFF: https://github.com/llvm/llvm-project/commit/6a95e67323dd64e6023c0b5ea89407cac2dbc01b.diff LO

[PATCH] D138676: [include-cleaner] HTMLReport shows headers that would be inserted

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a95e67323dd: [include-cleaner] HTMLReport shows headers that would be inserted (authored by sammccall). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

lenary updated this revision to Diff 477904. lenary marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137835/new/ https://reviews.llvm.org/D137835 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/A

[PATCH] D138702: support for HIP non hostcall printf

vikramRH created this revision. vikramRH added reviewers: sameerds, b-sumner, yaxunl. vikramRH added a project: LLVM. Herald added subscribers: kosarev, foad, kerbowa, hiraditya, Anastasia, jvesely, arsenm. Herald added a project: All. vikramRH requested review of this revision. Herald added subsc

[clang] 3e9b6ad - [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

Author: Archibald Elliott Date: 2022-11-25T11:33:53Z New Revision: 3e9b6adfc7caa8cc376b78c98069f2c0c6ae3fff URL: https://github.com/llvm/llvm-project/commit/3e9b6adfc7caa8cc376b78c98069f2c0c6ae3fff DIFF: https://github.com/llvm/llvm-project/commit/3e9b6adfc7caa8cc376b78c98069f2c0c6ae3fff.diff

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e9b6adfc7ca: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES

[clang] 54ad4d2 - Drop redundant pipe to opt -instnamer in clang tests

Author: Alex Richardson Date: 2022-11-25T11:34:55Z New Revision: 54ad4d2dd1526c53c3647eee26f8ecc2ff63f30c URL: https://github.com/llvm/llvm-project/commit/54ad4d2dd1526c53c3647eee26f8ecc2ff63f30c DIFF: https://github.com/llvm/llvm-project/commit/54ad4d2dd1526c53c3647eee26f8ecc2ff63f30c.diff LO

[clang-tools-extra] 9d5e82e - [include-cleaner] Make HTMLReport impl simpler/safer. NFC

Author: Sam McCall Date: 2022-11-25T13:12:20+01:00 New Revision: 9d5e82e75c61df1a79e337770c1d54d83b33d96a URL: https://github.com/llvm/llvm-project/commit/9d5e82e75c61df1a79e337770c1d54d83b33d96a DIFF: https://github.com/llvm/llvm-project/commit/9d5e82e75c61df1a79e337770c1d54d83b33d96a.diff LO

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary edited the summary of this revision. lenary updated this revision to Diff 477912. lenary marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 Files: clang-tools-extra/c

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, which i

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fpetrogalli added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, wh

[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/70650/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138677/new/ https://reviews.llvm.org/D138

[PATCH] D138274: Add version to all LLVM cmake package

thopre reopened this revision. thopre added inline comments. This revision is now accepted and ready to land. Comment at: clang/cmake/modules/ClangConfig.cmake.in:6 +set(LLVM_VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}) +find_package(LLVM @LLVM_VERS

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, which i

[PATCH] D138274: Add version to all LLVM cmake package

thopre updated this revision to Diff 477916. thopre added a comment. Use LLVM_VERSION as a CMake variable and LLVM_VERSION_* as substitutions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org/D138274 Files: clang

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fpetrogalli accepted this revision. fpetrogalli added a comment. LGTM. Thank you @lenary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 ___ cfe-commits mailing

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler updated this revision to Diff 477919. ckandeler added a comment. Added template example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files: clang-tools-extra/clangd/SemanticHighlighting.cp

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Initially I thought that traversing with `TK_IgnoreUnlessSpelledInSource` might be appropriate. But that idea does not seem to work as we do need to match implicit

[clang-tools-extra] 5577207 - [Support] Move getHostNumPhysicalCores to Threading.h

Author: Archibald Elliott Date: 2022-11-25T12:51:36Z New Revision: 5577207d6d3e0642ea047a8dfbfcf3ad372a7f25 URL: https://github.com/llvm/llvm-project/commit/5577207d6d3e0642ea047a8dfbfcf3ad372a7f25 DIFF: https://github.com/llvm/llvm-project/commit/5577207d6d3e0642ea047a8dfbfcf3ad372a7f25.diff

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5577207d6d3e: [Support] Move getHostNumPhysicalCores to Threading.h (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > sammccall wrote: > > nridge wrote: > > > ckandeler wrote: > > > > ckandeler wrote: > > > > > sammccall w

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, ckandeler wrote: > sammccall wrote: > > sammccall wrote: > > > nridge wrote: > > > > ckandeler wrote: > > > > > ckandele

[clang] 1dc0a1e - Revert "[Lex] Fix suggested spelling of /usr/bin/../include/foo"

Author: Sam McCall Date: 2022-11-25T14:01:39+01:00 New Revision: 1dc0a1e5d220b83c1074204bd3afd54f3bac4270 URL: https://github.com/llvm/llvm-project/commit/1dc0a1e5d220b83c1074204bd3afd54f3bac4270 DIFF: https://github.com/llvm/llvm-project/commit/1dc0a1e5d220b83c1074204bd3afd54f3bac4270.diff LO

[PATCH] D138489: [tsan] Add tsan support for loongarch64

SixWeining added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1543 +"r"(__fn), "r"(__arg), "r"(nr_clone), "i"(__NR_exit) + : "memory"); + return res; xry111 wrote: > xry111 wrote: > > SixWeining wrote: > > > tang

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > ckandeler wrote: > > sammccall wrote: > > > sammccall wrote: > > > > nridge wrote: > > > > > ckandele

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:215 "-bugprone-use-after-move", + // Using an CFG and might crash on invalid code: + "-performance-unnecessary-copy-on-last-us

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

kadircet added a comment. another thing that i noticed is usage of east consts in the implementation files. no one seem to have brought it up so far (at least none that i can see). in theory there are no explicit guidelines about it in LLVM coding style, but rest of the codebase uses west const

[clang] ca8c615 - Fix test output regression from ee88c0cf09969ba44307068797e12533b94768a6.

Author: Manuel Klimek Date: 2022-11-25T13:53:34Z New Revision: ca8c6156f27003ffa0e24bace2be7c25307f50a3 URL: https://github.com/llvm/llvm-project/commit/ca8c6156f27003ffa0e24bace2be7c25307f50a3 DIFF: https://github.com/llvm/llvm-project/commit/ca8c6156f27003ffa0e24bace2be7c25307f50a3.diff LOG:

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. In D112621#3949400 , @steakhal wrote: > `Analysis/constant-folding.c` seems to fail. > Please run the `check-clang-analysis` build target to see what fails and > investigate it. @steakhal thank you for reviewing this! I investig

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 477934. manas added a comment. Fix test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/

Re: [clang] ee88c0c - [NFCI] Fix unused variable/function warnings in MacroCallReconstructorTest.cpp when asserts are disabled.

Fixed in ca8c6156f27003ffa0e24bace2be7c25307f50a3. On Thu, Jul 21, 2022 at 3:21 PM Manuel Klimek wrote: > Ping :) > > On Mon, Jul 18, 2022 at 1:22 PM Manuel Klimek wrote: > >> Ping :) >> >> On Wed, Jul 13, 2022 at 11:43 AM Manuel Klimek wrote: >> >>> This is a functional change, as it removes

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

alexfh added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto IDAndOffset = SourceMgr.getDecomposedLoc(Loc); -

[PATCH] D138709: Reland "[Lex] Fix suggested spelling of /usr/bin/../include/foo"

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 1dc0a1e5d220b83c1074204bd3afd54f3bac4270

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin updated this revision to Diff 477938. cor3ntin added a comment. Rebase. This is still a bit rough, I have a few tests to fix and some dead code to remove. --- @erichkeanne I wouldn't mind picking your brain on this. Consider: template void dependent_init_capture(T x = 0) { [y

[clang-tools-extra] 07ca9cc - Revert "[Support] Move getHostNumPhysicalCores to Threading.h"

Author: Florian Hahn Date: 2022-11-25T14:11:56Z New Revision: 07ca9cc04bc2d57730507ad5ab444a1fd56cae11 URL: https://github.com/llvm/llvm-project/commit/07ca9cc04bc2d57730507ad5ab444a1fd56cae11 DIFF: https://github.com/llvm/llvm-project/commit/07ca9cc04bc2d57730507ad5ab444a1fd56cae11.diff LOG:

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477940. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-inc

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. Unfortunately it looks like this commit breaks building on ARM64 macOS. I reverted the change for now and added more details on the error in the revert commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo marked 4 inline comments as done. VitaNuo added a comment. The formatting has introduced a bit of unrelated diff. It's not much, so I hope that's fine. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:95 + /// Contains all files ma

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

massberg updated this revision to Diff 477941. massberg added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138701/new/ https://reviews.llvm.org/D138701 Files: clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3950815 , @fhahn wrote: > Unfortunately it looks like this commit breaks building on ARM64 macOS. I > reverted the change for now and added more details on the error in the revert > commit. Thanks for reverting. I had

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138701/new/ https://reviews.llvm.org/D138701 ___ cfe-commits ma

[PATCH] D138709: Reland "[Lex] Fix suggested spelling of /usr/bin/../include/foo"

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/lib/Lex/HeaderSearch.cpp:1936 + path::remove_dots(FilePath, /*remove_dot_dot=*/true); + path::native(FilePath, path::Style::posix); + File =

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950825 , @lenary wrote: > In D137836#3950815 , @fhahn wrote: > >> Unfortunately it looks like this commit breaks building on ARM64 macOS. I >> reverted the change for now and ad

[clang] d65019b - [NFC] Clean up printing of UnwrappedLines.

Author: Manuel Klimek Date: 2022-11-25T14:26:47Z New Revision: d65019bbcb0a33502ebfc3cfc492e4d3cee9c7b7 URL: https://github.com/llvm/llvm-project/commit/d65019bbcb0a33502ebfc3cfc492e4d3cee9c7b7 DIFF: https://github.com/llvm/llvm-project/commit/d65019bbcb0a33502ebfc3cfc492e4d3cee9c7b7.diff LOG:

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. (it looks like this job should have sent an email: https://green.lab.llvm.org/green/job/clang-stage1-RA/32031/console) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 _

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477944. VitaNuo marked an inline comment as done. VitaNuo added a comment. Fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/inclu

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477946. VitaNuo added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:237 + auto *FE = SM.getFileEntryForID(SM.getFileID(Range.getBegin())); + if (!FE) { +return false; nit: you can drop the braces here. LLVM convention is

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3950846 , @fhahn wrote: > (it looks like this job should have sent an email: > https://green.lab.llvm.org/green/job/clang-stage1-RA/32031/console) Yeah, sorry, no email. I'll check with colleagues to see if other peopl

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb335d02a5e7: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in… (authored by massberg, committed by ilya-biryukov). Re

[clang-tools-extra] db335d0 - [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr

Author: Jens Massberg Date: 2022-11-25T15:45:37+01:00 New Revision: db335d02a5e7d98c24f7006e42129856ba1cd695 URL: https://github.com/llvm/llvm-project/commit/db335d02a5e7d98c24f7006e42129856ba1cd695 DIFF: https://github.com/llvm/llvm-project/commit/db335d02a5e7d98c24f7006e42129856ba1cd695.diff

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950883 , @lenary wrote: > In D137836#3950846 , @fhahn wrote: > >> (it looks like this job should have sent an email: >> https://green.lab.llvm.org/green/job/clang-stage1-RA/3203

[PATCH] D138713: Fix assertion failure "PathDiagnosticSpotPiece's must have a valid location." in ReturnPtrRange checker on builtin functions

arseniy-sonar created this revision. arseniy-sonar added reviewers: xazax.hun, martong, NoQ, Szelethus, steakhal. arseniy-sonar added a project: clang. Herald added a subscriber: rnkovacs. Herald added a project: All. arseniy-sonar requested review of this revision. Herald added a subscriber: cfe-c

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477954. VitaNuo added a comment. Small refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-include-c

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:237 + auto *FE = SM.getFileEntryForID(SM.getFileID(Range.getBegin())); + if (!FE) { +return false; kadircet wro

[PATCH] D138713: Fix assertion failure "PathDiagnosticSpotPiece's must have a valid location." in ReturnPtrRange checker on builtin functions

steakhal resigned from this revision. steakhal added a comment. Herald added a subscriber: steakhal. I already reviewed this internally. For me, it looks great. @arseniy-sonar consider adding the `Fixes #55347` marker to the summary, so the commit will auto-reference the fixed issue. Also mentio

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477956. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/inclu

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477958. VitaNuo added a comment. Fix history. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Eugene.Zelenko added a comment. It'll be better to expand existing `init-variables.cpp` test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477960. VitaNuo added a comment. Apply the local changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-inc

[PATCH] D119138: [clang-format] Further improve support for requires expressions

klimek added a comment. Herald added a project: All. Hey ho, sorry for the late comment here, but adding peekNextToken(n) is problematic, as this gets in the way of future changes we want to do to handle macros better. Usually we want to use X = Tokens->getPosition() and FormatTok = Tokens->set

[clang] 38f5ab4 - Revert "[clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation"

Author: Alexander Kornienko Date: 2022-11-25T17:04:31+01:00 New Revision: 38f5ab4d44e3fa826006022aad377bb23ed357ca URL: https://github.com/llvm/llvm-project/commit/38f5ab4d44e3fa826006022aad377bb23ed357ca DIFF: https://github.com/llvm/llvm-project/commit/38f5ab4d44e3fa826006022aad377bb23ed357ca

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

arichardson created this revision. arichardson added reviewers: arsenm, bader, Tyker, nikic. Herald added subscribers: jrtc27, hiraditya. Herald added a project: All. arichardson requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, wdng. Herald added pr

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary edited the summary of this revision. lenary updated this revision to Diff 477975. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 Files: clang-tools-extra/clangd/test/Inputs/BenchmarkHeader.h llv

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a subscriber: MaskRay. lenary added a comment. New version, which changes how the move works a bit. I've updated the description with the caveats, so this is now definitely not NFC. I'm looking for re-review, and maybe input from @MaskRay who has made some minor cleanups in this co

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. I haven't looked at the implementation. I only checked the tests and something is not quite right there. See my comments inline. BTW the line-coverage is good. I found only two branches which I want to have tests for - see inline. Comment at: clang/l

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#3950722 , @kadircet wrote: > another thing that i noticed is usage of east consts in the implementation > files. no one seem to have brought it up so far (at least none that i can > see). > in theory there are no explic

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The zero-as-null-pointer-constant check should not fire if it is inside a defaul

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added inline comments. Comment at: clang/lib/Lex/CMakeLists.txt:3 -set(LLVM_LINK_COMPONENTS support) +set(LLVM_LINK_COMPONENTS + Support fpetrogalli wrote: > I wonder how `support` was not being detected as a linking error... Not sure, but I still think

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. > As for the name TargetParser. @arsenm came up with the name > SubtargetRegistry. I am fine with either names. @fpetrogalli I'm going to stick with TargetParser, because I think this is less confusing, given that TargetRegistry is already a component. Repository: rG

[clang-tools-extra] 9c8a6a1 - [include-cleaner] Fix a warning

Author: Kazu Hirata Date: 2022-11-25T09:51:25-08:00 New Revision: 9c8a6a1627480b30b54b4ffc691beebb8554e124 URL: https://github.com/llvm/llvm-project/commit/9c8a6a1627480b30b54b4ffc691beebb8554e124 DIFF: https://github.com/llvm/llvm-project/commit/9c8a6a1627480b30b54b4ffc691beebb8554e124.diff L

  1   2   >