sammccall marked 2 inline comments as done. sammccall added inline comments.
================ Comment at: clang/lib/Lex/HeaderSearch.cpp:1932 + + llvm::SmallString<32> FilePath(File.begin(), File.end()); + path::remove_dots(FilePath, /*remove_dot_dot=*/true); ---------------- kadircet wrote: > kadircet wrote: > > nit: you can change the method signature to take in a SmallString directly. > > there's an implicit constructor and any caller that already has a copy that > > they're throwing away can pass it here instead. > this is same as `llvm::SmallString<32> FilePath(File);` I don't think this is a good reason to change the signature unless it's actually a hot path. (In fact, no caller has a `SmallString<32>`). I changed CheckDir though because it's internal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138677/new/ https://reviews.llvm.org/D138677 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
