[PATCH] D137885: [modules] Support zstd in .pcm file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa7bc386ec75: [modules] Support zstd in .pcm file (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] fa7bc38 - [modules] Support zstd in .pcm file

Author: Fangrui Song Date: 2022-11-23T11:27:49-08:00 New Revision: fa7bc386ec7565ccfdfa75b272079ee03604e3ba URL: https://github.com/llvm/llvm-project/commit/fa7bc386ec7565ccfdfa75b272079ee03604e3ba DIFF: https://github.com/llvm/llvm-project/commit/fa7bc386ec7565ccfdfa75b272079ee03604e3ba.diff

[PATCH] D138598: [OpenMP] Do not add wrapper headers if using '-nogpuinc'

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield, ye-luo. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald add

[PATCH] D138552: [docs] Document that the modules can improve the linking time

MaskRay added a comment. This seems comparing different things... As mentioned, header files can be refactored to reduce the number of symbols as well. I'd be curious to learn how linking time can be reduced significantly by deploying modules. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

MaskRay added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:218 + explicit NameLookup(std::nullopt_t) : Data(nullptr, true) {} explicit NameLookup(std::nullptr_t) : Data(nullptr, false) {} NameLookup() : NameLookup(nullptr) {} --

[PATCH] D138598: [OpenMP] Do not add wrapper headers if using '-nogpuinc'

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138598/new/ https://reviews.llvm.org/D138598 ___

[PATCH] D137885: [modules] Support zstd in .pcm file

dyung added a comment. @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. Most of the errors look similar to this: error: 'error' diagnostics seen but not expected: (frontend): malformed or corrupted AST file: 'LLVM was not built with LLVM_ENABLE_ZSTD or did not

[PATCH] D137885: [modules] Support zstd in .pcm file

dyung added a comment. In D137885#3947532 , @dyung wrote: > @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. > Most of the errors look similar to this: > > error: 'error' diagnostics seen but not expected: > (frontend):

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. Thanks for the detailed information folks. I'll probably fix it up and re-submit next week (after the US holidays) given that the blast radius seems to be bigger than I expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

steakhal added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:90 + /// returns an empty list if no fixes are necessary. + virtual Optional getFixits(const Strategy &) const { +return None; steakhal wrote: > I wonder if we should prefe

[clang] 8f43b84 - [ASTReader] Fix zlib header detection 0x78 after D137885

Author: Fangrui Song Date: 2022-11-23T13:22:44-08:00 New Revision: 8f43b84322cc255414ad996834dff09e90dc19af URL: https://github.com/llvm/llvm-project/commit/8f43b84322cc255414ad996834dff09e90dc19af DIFF: https://github.com/llvm/llvm-project/commit/8f43b84322cc255414ad996834dff09e90dc19af.diff

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LWG3823 says that arrays of incomplete types are aggregates. Fix the clang builtin to match that. Repository: r

[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay added a comment. In D137885#3947532 , @dyung wrote: > @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. > Most of the errors look similar to this: > > error: 'error' diagnostics seen but not expected: > (frontend

[clang] 0dbc52a - Add MC support of RISCV Zcd Extension

Author: WuXinlong Date: 2022-11-24T05:48:06+08:00 New Revision: 0dbc52a0ab3c2b32f729e985d62401ce9bd9853e URL: https://github.com/llvm/llvm-project/commit/0dbc52a0ab3c2b32f729e985d62401ce9bd9853e DIFF: https://github.com/llvm/llvm-project/commit/0dbc52a0ab3c2b32f729e985d62401ce9bd9853e.diff LOG

[PATCH] D134177: Add MC support of RISCV Zcd Extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG0dbc52a0ab3c: Add MC support of RISCV Zcd Extension (authored by VincentWu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134177/new/ https://reviews.llvm.

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 477600. hctim added a comment. Use new MemtagABI section types, now that it's merged upstream: https://github.com/ARM-software/abi-aa/blob/main/memtagabielf64/memtagabielf64.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34bcadc38c22: Use std::nullopt_t instead of NoneType (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

fmayer added inline comments. Comment at: llvm/lib/MC/ELFObjectWriter.cpp:622 + assert(MemtagRelocs != nullptr && + "Tagged globals are only supported on AArch64"); + Asm.registerSection(*MemtagRelocs); Is the story here that on non-AArch64,

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 created this revision. doru1004 added reviewers: carlo.bertolli, ronl, ABataev, jhuber6. doru1004 added a project: OpenMP. Herald added subscribers: kosarev, jeroen.dobbelaere, guansong, tpr, dstuttard, yaxunl, kzhuravl. Herald added a project: All. doru1004 requested review of this revis

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 477620. hctim marked 2 inline comments as done. hctim added a comment. Move isMemtag below assert(Sym) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128958/new/ https://reviews.llvm.org/D128958 Files: clang/te

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 477622. Prabhuk marked an inline comment as done. Prabhuk added a comment. Herald added a subscriber: pengfei. Introducing a new toolchain for UEFI COFF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 477634. Prabhuk marked an inline comment as done. Prabhuk added a comment. Herald added a subscriber: wenlei. Added tests to the new UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https:

[PATCH] D138626: [Vectorize] Remove legacy passes

aeubanks created this revision. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, ormris, foad, kerbowa, hiraditya, jvesely, arsenm. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a project: All. aeubanks requested review of this revision. Herald

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

MaskRay added a comment. This looks very interesting and I wish that I can help as well (but I'll likely spend very little time in December due to holidays:) ). Hmm, I can't find it in an email archive. Perhaps there hasn't been a discussion so people are unaware of this work... Repository:

[clang] 437ccf5 - [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables

Author: Ben Dunbobbin Date: 2022-11-24T00:23:17Z New Revision: 437ccf5af9c2aec915a68a164a95d506fbac2324 URL: https://github.com/llvm/llvm-project/commit/437ccf5af9c2aec915a68a164a95d506fbac2324 DIFF: https://github.com/llvm/llvm-project/commit/437ccf5af9c2aec915a68a164a95d506fbac2324.diff LOG:

[PATCH] D138463: [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG437ccf5af9c2: [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables (authored by Ben Dunbobbin ). Herald added a project: clang. Repository: rG LLVM Gi

[PATCH] D138547: [X86][AMX] Fix typo of the headerfile.

xiangzhangllvm accepted this revision. xiangzhangllvm added a comment. This revision is now accepted and ready to land. LGTM， thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138547/new/ https://reviews.llvm.org/D138547 ___

[PATCH] D138628: [clang-fuzzer] Use new pass manager for optimizing IR

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138628 Files: clang/tools/clang-fuzzer/ha

[PATCH] D138628: [clang-fuzzer] Use new pass manager for optimizing IR

aeubanks updated this revision to Diff 477658. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138628/new/ https://reviews.llvm.org/D138628 Files: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp Index: clang/

[PATCH] D138630: [modules] Fix marking `ObjCMethodDecl::isOverriding` when there a no overrides.

vsapsai created this revision. vsapsai added reviewers: egorzhdan, akyrtzi. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Incorrect `isOverriding` flag triggers the assertion `!Overridden.empty()` in `Obj

[clang] 55fceef - [X86][AMX] Fix typo of the headerfile.

Author: Luo, Yuanke Date: 2022-11-24T10:33:44+08:00 New Revision: 55fceef61e0d244f2bbfc01c41eab43a77437aec URL: https://github.com/llvm/llvm-project/commit/55fceef61e0d244f2bbfc01c41eab43a77437aec DIFF: https://github.com/llvm/llvm-project/commit/55fceef61e0d244f2bbfc01c41eab43a77437aec.diff L

[PATCH] D138547: [X86][AMX] Fix typo of the headerfile.

This revision was automatically updated to reflect the committed changes. Closed by commit rG55fceef61e0d: [X86][AMX] Fix typo of the headerfile. (authored by LuoYuanke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138547/new/ https://reviews.llvm

[PATCH] D138489: [tsan] Add tsan support for loongarch64

tangyouling added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:269 val = FIRST_32_SECOND_64(1152, 1776); +#elif SANITIZER_LOONGARCH64 + val = 1936; MaskRay wrote: > We should add new code in this fallback function.

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e690a34 - AST: Internalize functions after D111283

Author: Fangrui Song Date: 2022-11-23T22:53:23-08:00 New Revision: e690a346454958372de0ec1c762544864e9f5406 URL: https://github.com/llvm/llvm-project/commit/e690a346454958372de0ec1c762544864e9f5406 DIFF: https://github.com/llvm/llvm-project/commit/e690a346454958372de0ec1c762544864e9f5406.diff

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:166 if constexpr (!std::is_pointer_v) { -const char *Data = reinterpret_cast(&Val); -Code.insert(Code.end(), Data, Data + Size); +if constexpr (std::is_trivially_copyable_v) { +

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

ChuanqiXu updated this revision to Diff 477687. ChuanqiXu added a comment. Use `--` instead `-` for parameters in tests to avoid confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/ https://reviews.llvm.org/D137534 Files: clang/test/ClangScanDeps/P1689.cppm clang/to

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:192 +"p1689-targeted-directory", llvm::cl::Optional, +llvm::cl::desc("Only supported for P1689, the targeted directory of which " +

<    1   2