steakhal added inline comments.
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:90
+ /// returns an empty list if no fixes are necessary.
+ virtual Optional<FixItList> getFixits(const Strategy &) const {
+ return None;
----------------
steakhal wrote:
> I wonder if we should prefer `std::optional` as we are c++17.
> IDK if it was ever covered on the community forum.
> I'm just leaving this here without expecting any action.
Per
https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716/10,
it seems like we should prefer std::optional.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138253/new/
https://reviews.llvm.org/D138253
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
