[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

pcwang-thead added a comment. The test `clang/test/Driver/pic.c` failed when we compiled Clang/LLVM with `-DCLANG_DEFAULT_PIE_ON_LINUX=False`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137044/new/ https://reviews.llvm.org/D137044

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } owenpan

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands updated this revision to Diff 477085. anderslanglands added a comment. Now tested by adding a -print-qualified-type-names flag to c-index-test and creating a (small) dedicated test in print-qualified-type.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation.

steakhal added a comment. As I was reading I'll highlighted some typos. `compile time` -> `compile-time` /g By the looks of it, this document is not referenced anywhere. I believe `clang/docs/index.rst` should refer to this document in some place. Thanks for the huge effort driving this you all!

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } HazardyKnusperkeks wrote: > owenpan wrote: > > ``` > > error: reference

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } owenpan wrote: > HazardyKnusperkeks wrote: > > owenpan wrote: > > > ```

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

dfrib added a comment. In D126818#3941201 , @erichkeane wrote: > [...] particularly since the suggested wording says the opposite of what I > THOUGHT the discussion was doing at the end? > [...] We might find ourselves wanting to hold off until CWG come

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2000 "overridden virtual function is here">; +def err_conflicting_overriding_attributes : Error< + "virtual function %0 has different attributes " aaron.ballman w

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

tbaeder added a comment. Yeah, just removing the `MaybeTypeCast` worked, but switching to `isTypeCast` doens't. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138289/new/ https://reviews.llvm.org/D138289 ___ cfe-commits mailing list cfe-commi

[clang] 0cf2286 - [LoongArch] Fix issue on CMake Xcode build configuration

Author: gonglingqin Date: 2022-11-22T16:49:50+08:00 New Revision: 0cf2286cb8f881e814f3eb42593d1cc7c817b19b URL: https://github.com/llvm/llvm-project/commit/0cf2286cb8f881e814f3eb42593d1cc7c817b19b DIFF: https://github.com/llvm/llvm-project/commit/0cf2286cb8f881e814f3eb42593d1cc7c817b19b.diff L

[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cf2286cb8f8: [LoongArch] Fix issue on CMake Xcode build configuration (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Noisy diff! Getting rid of the openmp special case handling here is nice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138473/new/ https://reviews.llvm.org/D138473

[PATCH] D138391: clang/HIP: Add new header test for math IR gen

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Good call adding this test, thanks. I think some of the skipping is glibc quirk related and some was to avoid clobbering the user's namespace for openmp. The math header defi

[PATCH] D134176: Add MC support of RISCV Zcf Extension

VincentWu updated this revision to Diff 477112. VincentWu added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134176/new/ https://reviews.llvm.org/D134176 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/Suppor

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fpetrogalli added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, wh

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 477116. sdesmalen marked 10 inline comments as done. sdesmalen added a comment. Addressed review comments. These include: - Allow dropping the arm_preserves_za attribute. - Added tests for serializing/deserializing the AST. - Changed descriptions in documen

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + erichkeane wrote: > sdesmalen wrote: > > erichkeane wrote: > > > We seem to be missing all o

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

kwk added inline comments. Comment at: clang/CMakeLists.txt:103 if (LLVM_LIT AND LLVM_UTILS_PROVIDED) - set(UNITTEST_DIR ${LLVM_THIRD_PARTY_DIR}/utils/unittest) - if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h - AND NOT EXISTS ${LLVM_LIBRARY_DI

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair added a comment. In D135273#3942011 , @theraven wrote: > In D135273#3936297 , @al45tair > wrote: > >> @theraven Any chance you could glance over this and reassure us that it >> isn't going to break the

[PATCH] D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a9d636caeea: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push… (authored by sgraenitz). Repository: rG LLVM Github Mo

[clang] 9a9d636 - [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

Author: Stefan Gränitz Date: 2022-11-22T12:02:53+01:00 New Revision: 9a9d636caeea9ca9364b906364ac1aaba0869858 URL: https://github.com/llvm/llvm-project/commit/9a9d636caeea9ca9364b906364ac1aaba0869858 DIFF: https://github.com/llvm/llvm-project/commit/9a9d636caeea9ca9364b906364ac1aaba0869858.diff

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements the 2022 Architecture General Data-P

[PATCH] D138489: [tsan] Add tsan support for loongarch64

tangyouling created this revision. tangyouling added reviewers: vitalybuka, dvyukov, melver, SixWeining, xen0n, xry111, MaskRay, lixing-star, MQ-mengqing, XiaodongLoong. Herald added subscribers: Enna1, StephenFan, s.egerton, simoncook. Herald added a project: All. tangyouling requested review of

[PATCH] D138489: [tsan] Add tsan support for loongarch64

tangyouling added a comment. $ make check-tsan -j4 Testing Time: 78.34s Unsupported : 91 Passed : 345 Expectedly Failed: 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138489/new/ https://reviews.llvm.org/D138489

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138488/new/ https://reviews.llvm.org/D138488 __

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

mstorsjo added a comment. In D137470#3928870 , @jhuber6 wrote: > In D137470#3928828 , @mstorsjo > wrote: > >> Sorry, I'm not quite up to speed with exactly what is being done linker-wise >> here - can you give a

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

lenary added a comment. Oh, actually, I have a few nits. You can fix them on commit though. Comment at: llvm/lib/Target/AArch64/AArch64.td:497 +def FeatureCSSC : SubtargetFeature<"cssc", "HasCSSC", "true", + "Enable Common Short Sequence Compression (CSSC) instructions">; + --

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:79 + AEK_SMEF16F16 = 1ULL << 47, // FEAT_SMEF16F16 + AEK_CSSC =1ULL << 49, // FEAT_CSSC }; 48!? Comment at: llvm/lib/Target/AArch64/AArch64.

[clang] 01023bf - [CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC)

Author: Stefan Gränitz Date: 2022-11-22T13:43:08+01:00 New Revision: 01023bfcd33f922ed8c934ce563e54abe8bfe246 URL: https://github.com/llvm/llvm-project/commit/01023bfcd33f922ed8c934ce563e54abe8bfe246 DIFF: https://github.com/llvm/llvm-project/commit/01023bfcd33f922ed8c934ce563e54abe8bfe246.diff

[PATCH] D137942: [CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01023bfcd33f: [CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC) (authored by sgraenitz). Changed prior to commit: https:/

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

tschuett added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11698 +//--- +// 2022 Architecture Extensions: General Data Processing (FEAT_V94_DP) +//--- FEAT_CSSC or FEAT_V94_DP? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

aaron.ballman added a comment. In D138289#3943090 , @tbaeder wrote: > Yeah, just removing the `MaybeTypeCast` worked, but switching to `isTypeCast` > doens't. I think for now we can remove the `MaybeTypeCast` entirely. We only set `isTypeCast` once we

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij updated this revision to Diff 477143. stuij marked 6 inline comments as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138488/new/ https://reviews.llvm.org/D138488 Files: clang/test/Dri

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11725 +: BaseTwoOperandRegReg, + Sched<[]> { + let Inst{11} = isMin; dmgreen wrote: > Can we make this WriteI, maybe. I think that would probably be the closest > s

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11725 +: BaseTwoOperandRegReg, + Sched<[]> { + let Inst{11} = isMin; stuij wrote: > dmgreen wrote: > > Can we make this WriteI, maybe. I think that would probably

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 ___ cfe-commits mailing lis

[clang] cdfb65e - [Clang][Sema] Added space after ',' in a warning

Author: Fahad Nayyar Date: 2022-11-22T13:26:40Z New Revision: cdfb65e5e7182a02005b3611aa28288890b9e296 URL: https://github.com/llvm/llvm-project/commit/cdfb65e5e7182a02005b3611aa28288890b9e296 DIFF: https://github.com/llvm/llvm-project/commit/cdfb65e5e7182a02005b3611aa28288890b9e296.diff LOG:

[PATCH] D138434: [Clang][Sema] Added space after ',' in a warning

egorzhdan closed this revision. egorzhdan added a comment. Merged: https://reviews.llvm.org/rGcdfb65e5e7182a02005b3611aa28288890b9e296 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138434/new/ https://reviews.llvm.org/D138434 _

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij updated this revision to Diff 477146. stuij added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138488/new/ https://reviews.llvm.org/D138488 Files: clang/test/Driver/aarch64-cssc.c llvm/include/llvm/Su

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11725 +: BaseTwoOperandRegReg, + Sched<[]> { + let Inst{11} = isMin; dmgreen wrote: > stuij wrote: > > dmgreen wrote: > > > C

[PATCH] D138489: [tsan] Add tsan support for loongarch64

SixWeining added a comment. I haven't check the correctness of `tsan_rtl_loongarch64.S`. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1513 + + register int res __asm__("$a0"); + register int __flags __asm__("$a0") = flags; I'm not sure if

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:749-751 + const Descriptor::MetadataSize MDSize{sizeof(InlineDescriptor)}; + Descriptor *D = + P.createDescriptor(Src, Ty, MDSize, IsConst, Src.is()); tbaeder wrote:

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136457/new/ https://reviews.llvm.org/D136457 ___ cfe-commits mailing lis

[PATCH] D137392: [clang][Interp] Explicitly handle RVO Pointer

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137392/new/ https://reviews.llvm.org/D137392

[PATCH] D138491: [clangd] Add script to maintain list of fast clang-tidy checks

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: abrachet, phosek, arphaman. Herald added a reviewer: njames93. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay, ilya-bi

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925-933 +case Intrinsic::loongarch_crc_w_b_w: { + Results.push_back(DAG.getNode( + ISD::TRUNCATE, DL, VT, + DAG.getNode(LoongArchISD::CRC_W_B_W, DL, MVT::i

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij updated this revision to Diff 477156. stuij marked an inline comment as done. stuij added a comment. renamed *v94-dp* to *cssc* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138488/new/ https://reviews.llvm.org/D138488 Files: clang/test/Dr

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11698 +//--- +// 2022 Architecture Extensions: General Data Processing (FEAT_V94_DP) +//--- tschuett wrote: > FEAT_CSSC or FEAT_V94_DP?

[PATCH] D138489: [tsan] Add tsan support for loongarch64

xry111 added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.h:80 void internal_sigdelset(__sanitizer_sigset_t *set, int signum); -#if defined(__x86_64__) || defined(__mips__) || defined(__aarch64__) || \ -defined(__powerpc64__) || defined(__s39

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

dmgreen accepted this revision. dmgreen added a comment. Thanks. I haven't looked though all the details, but thanks for fixing the scheduling info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138488/new/ https://reviews.llvm.org/D138488 __

[PATCH] D137706: [clang][Interp] Implement IntegralToPointer casts

aaron.ballman added a comment. I'd expect more test coverage for these changes. Like a C-style cast and a reinterpret_cast in C++ code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137706/new/ https://reviews.llvm.org/D137706 ___ cfe-commits

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

jonpa added a comment. In D137044#3942990 , @pcwang-thead wrote: > The test `clang/test/Driver/pic.c` failed when we compiled Clang/LLVM with > `-DCLANG_DEFAULT_PIE_ON_LINUX=False`. Ah... I suppose that must be because -mno-pic-data-is-text-relative re

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel added a comment. Does anyone else on this review thread want to review? Gabor's accepted the revision so, if not, I'll go ahead and commit. thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 ___

[clang] ac84798 - [scudo] Add loongarch64 support for scudo

Author: Youling Tang Date: 2022-11-22T22:02:31+08:00 New Revision: ac84798570cd480f431005b1ff943ca7070e541c URL: https://github.com/llvm/llvm-project/commit/ac84798570cd480f431005b1ff943ca7070e541c DIFF: https://github.com/llvm/llvm-project/commit/ac84798570cd480f431005b1ff943ca7070e541c.diff

[PATCH] D138350: [scudo] Add loongarch64 support for scudo

This revision was automatically updated to reflect the committed changes. Closed by commit rGac84798570cd: [scudo] Add loongarch64 support for scudo (authored by tangyouling, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138

[PATCH] D138426: Fix #58958 on github

krsch updated this revision to Diff 477166. krsch added a comment. Check any pointer, not just const. Test for volatile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138426/new/ https://reviews.llvm.org/D138426 Files: clang/lib/Sema/SemaFixItUti

[PATCH] D138426: Fix #58958 on github

krsch added inline comments. Comment at: clang/lib/Sema/SemaFixItUtils.cpp:136-137 +// Do no take address of const pointer to get void* +const PointerType *FromPtrTy = dyn_cast(FromQTy); +const PointerType *ToPtrTy = dyn_cast(ToQTy); +if (FromPtrTy && FromPtrTy->g

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 477168. v.g.vassilev marked 2 inline comments as done. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Address comments, support better C in clang-repl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ h

[clang] cb261e3 - [AArch64][clang] implement 2022 General Data-Processing instructions

Author: Ties Stuij Date: 2022-11-22T14:23:12Z New Revision: cb261e30fbb174085d2eea4f4afc3cef2838b7f7 URL: https://github.com/llvm/llvm-project/commit/cb261e30fbb174085d2eea4f4afc3cef2838b7f7 DIFF: https://github.com/llvm/llvm-project/commit/cb261e30fbb174085d2eea4f4afc3cef2838b7f7.diff LOG: [A

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

cebowleratibm added a comment. Looks good but I just want to confirm that the profiled -L paths are appended in the correct order with respect to the non-profiled paths. Comment at: clang/test/Driver/aix-ld.c:192 // CHECK-LD32-GPROF: "-lc" +// CHECK-LD32-GPROF: "-L[[S

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. stuij marked an inline comment as done. Closed by commit rGcb261e30fbb1: [AArch64][clang] implement 2022 General Data-Processing instructions (authored by stuij). Repo

[clang] 969d787 - [OpenMP][OMPIRBuilder] Add a configuration class that captures flags that affect codegen

Author: Jan Sjodin Date: 2022-11-22T09:25:04-05:00 New Revision: 969d787a470a801ad23be1fd53bcc166f75454a5 URL: https://github.com/llvm/llvm-project/commit/969d787a470a801ad23be1fd53bcc166f75454a5 DIFF: https://github.com/llvm/llvm-project/commit/969d787a470a801ad23be1fd53bcc166f75454a5.diff LO

[PATCH] D138220: [OpenMP][OMPIRBuilder] Add a configuration class to captures flags/attributes that affect codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rG969d787a470a: [OpenMP][OMPIRBuilder] Add a configuration class that captures flags that… (authored by jsjodin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

Fznamznon added a comment. In D137044#3943680 , @jonpa wrote: > In D137044#3942990 , @pcwang-thead > wrote: > >> The test `clang/test/Driver/pic.c` failed when we compiled Clang/LLVM with >> `-DCLANG_DEFAULT_PIE

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler updated this revision to Diff 477178. ckandeler added a comment. Make highlighting of built-in operators conditional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files: clang-tools-extra/cl

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. > Should I perhaps add the augmentsSyntaxTokens option and rebase this patch to > make it its first user? So I went ahead and did this. Opinions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 477179. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.def clang/include/clang/Basic/

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

steakhal added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:40 + + /// Determine if a kind is a safe kind. Slower than calling isSafe(). + static bool isSafeKind(Kind K) { We could have a `GADGET_RANGE(UnsafeGadgets, Increment, Decremen

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added a comment. FYI, I noticed the way the floating values are serialized doesn't work if the `APFloat` heap-allocated anything; those values aren't preserved through (de)serialization of course. Reproducer: constexpr double foo() { return __LDBL_MIN__; } CHANGES SINCE LAST

[PATCH] D138391: clang/HIP: Add new header test for math IR gen

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138391/new/ https://reviews.llvm.org/D138391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

saudi updated this revision to Diff 477182. saudi added a comment. Small update: improve comments, remove empty line modification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137642/new/ https://reviews.llvm.org/D137642 Files: clang/lib/CodeGen

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:467 + + //`DeclContext` of the block being analysed if provided. std::vector CallStack; Comment at: c

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

steakhal added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp:10-13 +void foo(...); + +void * bar(void); +char * baz(void); I would expect this test file to grow quite a bit. As such, I think we should have more self-descriptive name

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti created this revision. 5chmidti added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. 5chmidti requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Add

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

jonpa added a comment. In D137044#3943829 , @Fznamznon wrote: > In D137044#3943680 , @jonpa wrote: > >> In D137044#3942990 , @pcwang-thead >> wrote: >> >>> The test `clan

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti updated this revision to Diff 477184. 5chmidti added a comment. Fixup: rm added includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractF

[clang] 056ebad - [HIP] Fix lld failure when devie object is empty

Author: Yaxun (Sam) Liu Date: 2022-11-22T10:38:42-05:00 New Revision: 056ebadf5c75df6568ea3dda879518e1edc1f48f URL: https://github.com/llvm/llvm-project/commit/056ebadf5c75df6568ea3dda879518e1edc1f48f DIFF: https://github.com/llvm/llvm-project/commit/056ebadf5c75df6568ea3dda879518e1edc1f48f.dif

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG056ebadf5c75: [HIP] Fix lld failure when devie object is empty (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel updated this revision to Diff 477200. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

tstellar added inline comments. Comment at: clang/CMakeLists.txt:103 if (LLVM_LIT AND LLVM_UTILS_PROVIDED) - set(UNITTEST_DIR ${LLVM_THIRD_PARTY_DIR}/utils/unittest) - if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h - AND NOT EXISTS ${LLVM_LIBRA

[PATCH] D138122: Lift EHPersonalities from Analysis to IR (NFC)

compnerd accepted this revision. compnerd added a comment. Additional validation is never a bad thing :). Please do sort the headers before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138122/new/ https://reviews.llvm.org/D138122 __

[PATCH] D138463: [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables

probinson added a subscriber: cfe-commits. probinson added a comment. +cfe-commits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138463/new/ https://reviews.llvm.org/D138463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

awarzynski added a comment. Thanks for implementing this! > Processes target cpu and features in the flang driver. Right now features are > only added for AArch64 because I only did basic testing on AArch64 but it > should generally work for others as well. X86 is a very popular target and we

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM w/ normalization. I suggest trying to land these changes sooner rather than later since this is bound to merge conflict and become stale. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti updated this revision to Diff 477204. 5chmidti added a comment. Fix windows build by setting the c++ standard for the hoisting tests explicitly to c++17. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D

[clang] 84dd12b - [clang][dataflow] Add widening API and implement it for built-in boolean model.

Author: Yitzhak Mandelbaum Date: 2022-11-22T16:09:28Z New Revision: 84dd12b29064095cdef3949e8fd5c91b93f36004 URL: https://github.com/llvm/llvm-project/commit/84dd12b29064095cdef3949e8fd5c91b93f36004 DIFF: https://github.com/llvm/llvm-project/commit/84dd12b29064095cdef3949e8fd5c91b93f36004.diff

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked 2 inline comments as done. Closed by commit rG84dd12b29064: [clang][dataflow] Add widening API and implement it for built-in boolean model. (authored by

[PATCH] D138391: clang/HIP: Add new header test for math IR gen

arsenm closed this revision. arsenm added a comment. 2edafe8393fa7c9ad2e95d691191469adb7bf4b0 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138391/new/ https://reviews.llvm.org/D138391 __

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

NancyWang added a comment. @vsapsai hi Volodymyr Sapsai , test case clang/test/Modules/hidden-duplicates.m is failing on our llvm community AIX box https://lab.llvm.org/buildbot/#/builders/214/builds/4442/steps/6/logs/FAIL__Clang__hidden-duplicates_m , it gives exit code 70 without detail

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Type.h:4008 bool HasTrailingReturn : 1; +unsigned AArch64SMEAttributes : 8; Qualifiers TypeQuals; sdesmalen wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > sdesmalen

[PATCH] D138387: [Clang] Implement static operator[]

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Beside the formatting nitpick this looks good Comment at: clang/test/CodeGenCXX/cxx2b-static-subscript-operator.cpp:14 + f.operator[](201, 202); + Functor{}[301, 302];

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

steakhal added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:30 + /// of primitive fixits (individual insertions/removals/replacements). + using FixItList = llvm::SmallVector; + Unless we have a well-formed idea of how m

[PATCH] D138504: clang/HIP: Remove __llvm_amdgcn_* wrapper hacks

arsenm created this revision. arsenm added reviewers: yaxunl, JonChesterfield, b-sumner. Herald added a subscriber: kosarev. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. These are leftover hacks from using asm declaratios to access intrins

[clang] 2a1c192 - [clang][Parse] Remove constant expression from if condition

Author: Timm Bäder Date: 2022-11-22T17:31:21+01:00 New Revision: 2a1c192bd6bf639bc3f14cfb19c5d7aff5e7794b URL: https://github.com/llvm/llvm-project/commit/2a1c192bd6bf639bc3f14cfb19c5d7aff5e7794b DIFF: https://github.com/llvm/llvm-project/commit/2a1c192bd6bf639bc3f14cfb19c5d7aff5e7794b.diff LO

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a1c192bd6bf: [clang][Parse] Remove constant expression from if co

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a reviewer: njames93. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a proj

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks

sammccall added a comment. Ideas on testing welcome. Does it make sense to rely on the fact that `misc-const-correctness` is always slow? :-D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138505/new/ https://reviews.llvm.org/D138505 _

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii added a comment. In D137375#3943751 , @cebowleratibm wrote: > Looks good but I just want to confirm that the profiled -L paths are appended > in the correct order with respect to the non-profiled paths. The linker gives priority to the librarie

[PATCH] D138394: HIP: Directly call fma builtins

arsenm updated this revision to Diff 477213. arsenm added a comment. Missed one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138394/new/ https://reviews.llvm.org/D138394 Files: clang/lib/Headers/__clang_hip_math.h clang/test/Headers/__clang_hip_math.hip Index: clang/test/Headers/

[PATCH] D138504: clang/HIP: Remove __llvm_amdgcn_* wrapper hacks

arsenm updated this revision to Diff 477219. arsenm added a comment. Remove some of the externally defined ones CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138504/new/ https://reviews.llvm.org/D138504 Files: clang/lib/Headers/__clang_hip_libdevice_declares.h clang/lib/Headers/__c

  1   2   3   >