[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

[Konrad Wilhelm Kleine via Phabricator via cfe-commits]

kwk added inline comments.


================
Comment at: clang/CMakeLists.txt:103
     if (LLVM_LIT AND LLVM_UTILS_PROVIDED)
-      set(UNITTEST_DIR ${LLVM_THIRD_PARTY_DIR}/utils/unittest)
-      if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h
-         AND NOT EXISTS 
${LLVM_LIBRARY_DIR}/${CMAKE_STATIC_LIBRARY_PREFIX}gtest${CMAKE_STATIC_LIBRARY_SUFFIX}
-         AND EXISTS ${UNITTEST_DIR}/CMakeLists.txt)
-        add_subdirectory(${UNITTEST_DIR} third-part/unittest)
+      find_package(LLVMGTest)
+      if (NOT TARGET llvm_gtest)
----------------
I don't see no `FindLLVMGTest.cmake` file anywhere. Is that suppose to exist 
yet or which Patch is suppose to create it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138472/new/

https://reviews.llvm.org/D138472

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits