[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. > This is true, but the cc1 flag isn't inherently non-deterministic. I would > prefer to fix the determinism bugs instead of adding flags and more > divergence. See https://reviews.llvm.org/D136474#3875546 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. (In other words, all known people who care about clang's determinism do not care about having the command recorded in the debug data -- and some (me :) ) mentioned concerns about determinism about the patch adding that feature. It seems weird to put those people on the h

[clang] c4c2a3c - [clang] Implement sugared substitution changes to infrastructure

Author: Matheus Izvekov Date: 2022-10-26T03:21:15+02:00 New Revision: c4c2a3c65684e062efcd101a957c6cae0a304a7a URL: https://github.com/llvm/llvm-project/commit/c4c2a3c65684e062efcd101a957c6cae0a304a7a DIFF: https://github.com/llvm/llvm-project/commit/c4c2a3c65684e062efcd101a957c6cae0a304a7a.dif

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4c2a3c65684: [clang] Implement sugared substitution changes to infrastructure (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/n

[clang] 2560c12 - [clang] Instantiate NTTPs and template default arguments with sugar

Author: Matheus Izvekov Date: 2022-10-26T03:22:22+02:00 New Revision: 2560c1266993af6e6c15900ce673c6db23132f8b URL: https://github.com/llvm/llvm-project/commit/2560c1266993af6e6c15900ce673c6db23132f8b DIFF: https://github.com/llvm/llvm-project/commit/2560c1266993af6e6c15900ce673c6db23132f8b.dif

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2560c1266993: [clang] Instantiate NTTPs and template default arguments with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHA

[clang] 4c44c91 - [clang] Instantiate alias templates with sugar

Author: Matheus Izvekov Date: 2022-10-26T03:23:24+02:00 New Revision: 4c44c91ad980304c5cca3792115349e68cfafd2b URL: https://github.com/llvm/llvm-project/commit/4c44c91ad980304c5cca3792115349e68cfafd2b DIFF: https://github.com/llvm/llvm-project/commit/4c44c91ad980304c5cca3792115349e68cfafd2b.dif

[PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c44c91ad980: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/ https://revie

[clang] d0a6de5 - [clang] Instantiate concepts with sugared template arguments

Author: Matheus Izvekov Date: 2022-10-26T03:24:20+02:00 New Revision: d0a6de59c78010118fea811514e03ed9f400215a URL: https://github.com/llvm/llvm-project/commit/d0a6de59c78010118fea811514e03ed9f400215a DIFF: https://github.com/llvm/llvm-project/commit/d0a6de59c78010118fea811514e03ed9f400215a.dif

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a6de59c780: [clang] Instantiate concepts with sugared template arguments (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org/D136566?vs=470013&id=470671#toc Repository: rG LLV

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 added a subscriber: jdoerfert. jz10 added a comment. hi Johannes and Shilei, is there revision that needs to be done on this patch? please let me know CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 ___

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 added a comment. Generally looks good to me. Can you check all resolved comments to make sure there is no open comments? Comment at: openmp/libomptarget/src/api.cpp:206 +// The helper function that calls omp_target_memcpy or omp_target_memcpy_rect +static int __

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470679. lime added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Update as required. Also, I need the following modification to complete `ninja check-all`. Maybe, I should submit another pa

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

glandium added a comment. > In either case, this seems to be an issue with libc++ that is out there in > the wild. I don't think it is, actually. I think it's doing something legitimate. That is, it's declaring in its headers that some things are only available on some versions of macos, which

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

glandium added a comment. (And specifically, FuzzerFork.cpp doesn't use any of those declared things. Its only sin is to `#include `, which happens to have /some/ methods (std::filesystem-related) only available on macos 10.15+.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 470684. jz10 added a comment. Thanks Shilei 1. "Can you check all resolved comments to make sure there is no open comments?" checked through the comments you and Johannes made, no more issues 2. "Since this function is not part of `libomp` and it's not gonna b

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

pengfei added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2106-2107 +TARGET_BUILTIN(__builtin_ia32_vcvtneoph2ps256, "V8fV16xC*", "nV:256:", "avxneconvert") +TARGET_BUILTIN(__builtin_ia32_vcvtneps2bf16128, "V8sV4f", "nV:128:", "avxneconvert") +TARGET_B

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470686. lime added a comment. Solve the conflicts, and the issue about `CMakeLists.txt` had been solved by upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Fil

[PATCH] D104963: [ODR] Fix using uninitialized FunctionTypeBits.FastTypeQuals in FunctionNoProtoType.

vsapsai abandoned this revision. vsapsai added a comment. Herald added a project: All. The issue is addressed in D133586 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104963/new/ https://reviews.llvm.org/D104963

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. This broke building Firefox with: In file included from Unified_cpp_editor_txmgr0.cpp:2: In file included from /tmp/gecko/editor/txmgr/TransactionItem.cpp:6: In file included from /tmp/gecko/editor/txmgr/TransactionItem.h:9: In file included from /tmp/gecko/obj-

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

glandium added a comment. This broke building Firefox with: In file included from Unified_cpp_dom_canvas0.cpp:65: /tmp/gecko/dom/canvas/ClientWebGLContext.cpp:355:19: error: call to deleted function 'IdByMethod' const auto id = IdByMethod(); ^~

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470702. lime added a comment. Update for the format check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Par

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aqjune created this revision. Herald added subscribers: steakhal, martong, arphaman. Herald added a reviewer: shafik. Herald added a reviewer: NoQ. Herald added a project: All. aqjune requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This pat

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aqjune added a comment. The updates are analogous to how `GNUNullExprClass` is processed because `UnspecifiedValueExprClass` and it is similar (have no operand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136737/new/ https://reviews.llvm.org/D1

[clang] 4a5184f - [clang][driver] Remove dynamic gcc-toolset/devtoolset logic

Author: Timm Bäder Date: 2022-10-26T07:29:32+02:00 New Revision: 4a5184f4c357eeafcced3371cd8539fa0ac9f24d URL: https://github.com/llvm/llvm-project/commit/4a5184f4c357eeafcced3371cd8539fa0ac9f24d DIFF: https://github.com/llvm/llvm-project/commit/4a5184f4c357eeafcced3371cd8539fa0ac9f24d.diff LO

[PATCH] D136435: [clang][Driver] Add gcc-toolset-12 and devtoolset-12 prefixes

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a5184f4c357: [clang][driver] Remove dynamic gcc-toolset/devtoolset logic (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136435/new/ h

[PATCH] D136571: [RISCV] add svinval extension

BeMg updated this revision to Diff 470722. BeMg marked 2 inline comments as done. BeMg added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preprocessor/riscv-target

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support ConstantBuffer by

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:5209 + verifyNoCrash("#if X\n" +"#else\n" +"#else\n" `#elif Y` inste

[clang] f6f02e0 - [clang][Interp] Implement for loops

Author: Timm Bäder Date: 2022-10-26T08:48:36+02:00 New Revision: f6f02e090072002674c85c9d015b42f61c41656e URL: https://github.com/llvm/llvm-project/commit/f6f02e090072002674c85c9d015b42f61c41656e DIFF: https://github.com/llvm/llvm-project/commit/f6f02e090072002674c85c9d015b42f61c41656e.diff LO

[clang] f007c99 - [clang][Interp] Fix InterpFrame::describe() for This pointers

Author: Timm Bäder Date: 2022-10-26T08:48:55+02:00 New Revision: f007c99ed12f15f23e39f02d0fcb71eecead9b97 URL: https://github.com/llvm/llvm-project/commit/f007c99ed12f15f23e39f02d0fcb71eecead9b97 DIFF: https://github.com/llvm/llvm-project/commit/f007c99ed12f15f23e39f02d0fcb71eecead9b97.diff LO

[PATCH] D135764: [clang][Interp] Implement for loops

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6f02e090072: [clang][Interp] Implement for loops (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D135764?vs=467089&id=470727#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] ea25966 - [clang][Interp][NFC] Simplify generated code for references

Author: Timm Bäder Date: 2022-10-26T08:49:11+02:00 New Revision: ea2596692f5f15e911020c0779c7ee0df51382a9 URL: https://github.com/llvm/llvm-project/commit/ea2596692f5f15e911020c0779c7ee0df51382a9 DIFF: https://github.com/llvm/llvm-project/commit/ea2596692f5f15e911020c0779c7ee0df51382a9.diff LO

[clang] 4a9b727 - [clang][Interp][NFC] Make InitMap final

Author: Timm Bäder Date: 2022-10-26T08:49:20+02:00 New Revision: 4a9b7273260d2ed071737e48210159bc47347fed URL: https://github.com/llvm/llvm-project/commit/4a9b7273260d2ed071737e48210159bc47347fed DIFF: https://github.com/llvm/llvm-project/commit/4a9b7273260d2ed071737e48210159bc47347fed.diff LO

[PATCH] D136670: [clang][Interp] Fix InterpFrame::describe() for This pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGf007c99ed12f: [clang][Interp] Fix InterpFrame::describe() for This pointers (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136670/new/

[clang] 751f1bf - [clang][Interp][NFC] Assert we have a valid Record instance

Author: Timm Bäder Date: 2022-10-26T08:49:31+02:00 New Revision: 751f1bfb5f77dfab27456c6964721ed3a4f9f896 URL: https://github.com/llvm/llvm-project/commit/751f1bfb5f77dfab27456c6964721ed3a4f9f896 DIFF: https://github.com/llvm/llvm-project/commit/751f1bfb5f77dfab27456c6964721ed3a4f9f896.diff LO

[clang] caa83d2 - [clang][Interp][NFC] Simplify InterpFrame::describe

Author: Timm Bäder Date: 2022-10-26T08:49:44+02:00 New Revision: caa83d23295ae42334ea692a300e9acc77a30449 URL: https://github.com/llvm/llvm-project/commit/caa83d23295ae42334ea692a300e9acc77a30449 DIFF: https://github.com/llvm/llvm-project/commit/caa83d23295ae42334ea692a300e9acc77a30449.diff LO

<    1   2   3