tianshilei1992 added a comment.
Generally looks good to me. Can you check all resolved comments to make sure
there is no open comments?
================
Comment at: openmp/libomptarget/src/api.cpp:206
+// The helper function that calls omp_target_memcpy or omp_target_memcpy_rect
+static int __kmpc_target_memcpy_async_helper(kmp_int32 Gtid, kmp_task_t *Task)
{
+ if (Task == nullptr)
----------------
same here
================
Comment at: openmp/libomptarget/src/api.cpp:238
+// Allocate and launch helper task
+static int __kmpc_helper_task_creation(TargetMemcpyArgsTy *Args,
+ int DepObjCount,
----------------
Since this function is not part of `libomp` and it's not gonna be an interface
function, no need to name it as `__kmpc`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136103/new/
https://reviews.llvm.org/D136103
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
