[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

steakhal marked an inline comment as done. steakhal added a comment. In D136162#3873392 , @NoQ wrote: > Ok so you're saying that it's not just a wrong Decl but there's like an > entire cast-expression missing in the AST? This fix is probably good enough

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1216 + // Don't crash when there is an #else without an #if. + if (PPBranchLevel <= -1) { +conditionalCompilationStart(/*Unreachable=*/true); Nit. Comment

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This only works on integrals for now. Add four new

[PATCH] D136424: Update links to googletest documentation

DerKasper created this revision. DerKasper added a reviewer: njames93. DerKasper added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. Herald added a project: All. DerKasper requested review of this revision. Herald added a subscriber: cfe-commits. Update links to googletes

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:726 + } else if (const auto *IVIE = dyn_cast(Initializer)) { +const ArrayType *ArrayType = IVIE->getType()->getAsArrayTypeUnsafe(); +assert(Array

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Thanks for carrying about the doc! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424

[clang] 9c422ab - [clang-format] Add option for aligning requires clause body

Author: Danil Sidoruk Date: 2022-10-21T10:42:45+03:00 New Revision: 9c422ab7ce82ec13155629f1e5e4e11d608fe1de URL: https://github.com/llvm/llvm-project/commit/9c422ab7ce82ec13155629f1e5e4e11d608fe1de DIFF: https://github.com/llvm/llvm-project/commit/9c422ab7ce82ec13155629f1e5e4e11d608fe1de.diff

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c422ab7ce82: [clang-format] Add option for aligning requires clau

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining added a comment. > I've formatted the patch summary for you. Please familiarize yourself with > Markdown syntax so next time your rendering would look better. Thanks. Got it. > For minimum churn and hassle, I'm afraid we have to add it for now. I didn't > realize [[ > https://githu

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining updated this revision to Diff 469497. SixWeining added a comment. Define `__loongarch64` which is equal to `__loongarch_grlen == 64`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136413/new/ https://reviews.llvm.org/D136413 Files: cl

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:5643-5653 +case Intrinsic::x86_cmpccxadd32: +case Intrinsic::x86_cmpccxadd64: { + Info.opc = ISD::INTRINSIC_W_CHAIN; + Info.ptrVal = I.getArgOperand(0); + unsigned Size = I.g

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

skan added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:28251 + SDLoc DL(Op); + SDVTList VTs = DAG.getVTList(MVT::i32, MVT::Other); + SDValue Chain = Op.getOperand(0); Unused? Comment at: llvm/lib/Target/X

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

cor3ntin added a comment. It starting to look great. Should we add an extension warning? Note that I'm not suggesting to support that in earlier modes, just an off-by-default warning that says "this is a c++20 feature". but we are a bit inconsistent with those. can you rename `test/SemaCXX/P096

[clang] d6cb1fd - [clang][Interp][NFC] Remove some unused aliases.

Author: Timm Bäder Date: 2022-10-21T10:49:45+02:00 New Revision: d6cb1fd7b366b7e3fa3cbe8129f11298279e72c4 URL: https://github.com/llvm/llvm-project/commit/d6cb1fd7b366b7e3fa3cbe8129f11298279e72c4 DIFF: https://github.com/llvm/llvm-project/commit/d6cb1fd7b366b7e3fa3cbe8129f11298279e72c4.diff LO

[clang] 09bbc90 - [clang][Interp] Array initialization via ImplicitValueInitExpr

Author: Timm Bäder Date: 2022-10-21T10:49:45+02:00 New Revision: 09bbc903a5b454d39d5ce69cf8bf6d5e1b46e3c4 URL: https://github.com/llvm/llvm-project/commit/09bbc903a5b454d39d5ce69cf8bf6d5e1b46e3c4 DIFF: https://github.com/llvm/llvm-project/commit/09bbc903a5b454d39d5ce69cf8bf6d5e1b46e3c4.diff LO

[clang] 9cb4e90 - [clang][Interp] Support base class constructors

Author: Timm Bäder Date: 2022-10-21T10:49:45+02:00 New Revision: 9cb4e90e72602e0974b2eb9e5eb56fd2cc998db7 URL: https://github.com/llvm/llvm-project/commit/9cb4e90e72602e0974b2eb9e5eb56fd2cc998db7 DIFF: https://github.com/llvm/llvm-project/commit/9cb4e90e72602e0974b2eb9e5eb56fd2cc998db7.diff LO

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG09bbc903a5b4: [clang][Interp] Array initialization via ImplicitValueInitExpr (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D135013?vs

[PATCH] D135025: [clang][Interp] Support base class constructors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cb4e90e7260: [clang][Interp] Support base class constructors (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D135025?vs=

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

0x59616e added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6114-6116 +// const ValueDecl *VD = Entity.getDecl(); +// if (const VarDecl *VarD = dyn_cast_or_null(VD); +// VarD && VarD->hasInit() && !VarD->getInit()->containsErrors()) ---

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

skan added inline comments. Comment at: llvm/lib/Target/X86/X86InstrInfo.td:3028 + (ins i32mem:$dstsrc1, GR32:$dstsrc2, GR32:$src3, ccode:$cond), + "cmp${cond}xadd\t{$src3, $dst, $dstsrc1|$dstsrc1, $dst, $src3}", + [(set GR32:$dst, (X86cmpccxadd addr:$d

[PATCH] D135937: [WIP][X86] Support -march=raptorlake, meteorlake

skan added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:111 + ZHAOXIN_FAM7H_LUJIAZUI, + INTEL_COREI7_RAPTORLAKE, + INTEL_COREI7_METEORLAKE, I see. But if possible, could we split "ZHAOXIN_FAM7H_LUJIAZUI" to another patch? Repository:

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

skan added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:781 +Builder.defineMacro("__AVXIFMA__"); + Builder.defineMacro("__AVXIFMA_SUPPORTED__"); if (HasAVXVNNI) Why do we need this line? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

royjacobson added a comment. Thanks for working on it! It looks really good. Please remember to update the feature test macro (__cpp_aggregate_paren_init). Also, I think there's no test coverage for the ASTReader/Writer changes? I would like to see some as well. Comment at:

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead marked an inline comment as done. pcwang-thead added a comment. In D70401#3873347 , @luojia wrote: > Hello! Any further updates to this patch? It seems like all the inline > comments have been resolved. We have done some works in this patch

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

royjacobson added inline comments. Comment at: clang/test/SemaCXX/P0960R3.cpp:54 +} + +void foo() { Could you add test that this works with variadic templates? Something like ``` template T construct(Args... args) { return T(args...); } ``` Similar to the int

[PATCH] D136435: [clang][Driver] Add gcc-toolset-12 and devtoolset-12 prefixes

tbaeder created this revision. tbaeder added reviewers: thieta, MaskRay, tstellar. Herald added a subscriber: StephenFan. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 35aaf548237a4

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling created this revision. tangyouling added reviewers: SixWeining, xen0n, xry111, MaskRay, wangleiat. Herald added subscribers: jeroen.dobbelaere, StephenFan. Herald added a project: All. tangyouling requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xen0n added a comment. Commit message is unclear. You added non-prefixed aliases for all registers, yet only `$a0` is mentioned. I'd like to see what improvement you could come up with before amending it myself, to hopefully make you better at writing those "small compositions".

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. $ cat prefix_regalias.c int main() { register unsigned long a0 asm("a0"); register unsigned long a1 asm("$a1"); register unsigned long a2 asm("r6"); register unsigned long a3 asm("$r7"); register float f0 asm("fa0");

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. How about the asm code in `.s`? Do we need to support `addi.d a0, a1, a2`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/ https://reviews.llvm.org/D136436 ___ cfe-c

[clang] 39d8597 - [clang] Fix typo in error message

Author: Paulo Matos Date: 2022-10-21T12:06:28+02:00 New Revision: 39d8597927a5887bcfde2229491d793f3edcedbd URL: https://github.com/llvm/llvm-project/commit/39d8597927a5887bcfde2229491d793f3edcedbd DIFF: https://github.com/llvm/llvm-project/commit/39d8597927a5887bcfde2229491d793f3edcedbd.diff L

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 469527. tbaeder marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Boolean.h cla

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 469529. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Address comments. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files:

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

tbaeder updated this revision to Diff 469530. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136423/new/ https://reviews.llvm.org/D136423 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp cl

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xen0n added a comment. In D136436#3873949 , @SixWeining wrote: > How about the asm code in `.s`? Do we need to support `addi.d a0, a1, a2`? For the assembler part of this support, I think we need to coordinate with the GNU toolchain maintainers of Loon

[PATCH] D136437: [clang-format] Insert closing braces of unaffected lines

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The closing brac

[PATCH] D136017: [clang][Interp] Materializing primitive temporaries

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:574 +/// 3) Initialized global with index \I with that +template ::T> +bool InitGlobalTemp(InterpState &S, CodePtr OpPC, uint32_t I, shafik wrote: > tbaeder wrote: > > shafik wrote: > > > Is

[PATCH] D136440: Do not hide base member using decls with different template head.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136440 Files: clang/lib/Sema/SemaOverload.cpp clan

[clang] 5b56763 - [Clang] Add __has_constexpr_builtin support

Author: Evgeny Shulgin Date: 2022-10-21T11:23:10Z New Revision: 5b567637e22bfa128514a5a9de7f3296423e8acd URL: https://github.com/llvm/llvm-project/commit/5b567637e22bfa128514a5a9de7f3296423e8acd DIFF: https://github.com/llvm/llvm-project/commit/5b567637e22bfa128514a5a9de7f3296423e8acd.diff LOG

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b567637e22b: [Clang] Add __has_constexpr_builtin support (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 469552. usaxena95 added a comment. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D136440 Files: clang/lib/Sema/SemaOverload.cpp clang/test/CXX/dcl.d

[PATCH] D136424: Update links to googletest documentation

DerKasper added a comment. In D136424#3873635 , @sylvestre.ledru wrote: > Thanks for carrying about the doc! I am so happy about the functionality of clang and all the tools around, that this is a nice form of giving back something. I am not sure, wha

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. np, let me land this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D136424: Update links to googletest documentation

aaron.ballman added a comment. In D136424#3874180 , @DerKasper wrote: > I am not sure, what i have to do now, after this was accepted? > In the documentation i find: > "If you do not have commit access, please let people know during the review > and so

[clang-tools-extra] b814d85 - Update links to googletest documentation

Author: Sylvestre Ledru Date: 2022-10-21T13:55:44+02:00 New Revision: b814d85e5b9d8acd146cef59141b2764107b3df9 URL: https://github.com/llvm/llvm-project/commit/b814d85e5b9d8acd146cef59141b2764107b3df9 DIFF: https://github.com/llvm/llvm-project/commit/b814d85e5b9d8acd146cef59141b2764107b3df9.dif

[PATCH] D136424: Update links to googletest documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb814d85e5b9d: Update links to googletest documentation (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://revi

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. pushed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. oh, crappy, i forgot to update the author of the patch :( really sorry about that... :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 __

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah added inline comments. Comment at: flang/include/flang/Frontend/LangOptions.h:29 + +// Enable the floating point pragma +FPM_On, vzakhari wrote: > tblah wrote: > > vzakhari wrote: > > > tblah wrote: > > > > awarzynski wrote: > > > > > What are these

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 469556. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/inclu

[PATCH] D136424: Update links to googletest documentation

aaron.ballman added a comment. In D136424#3874196 , @sylvestre.ledru wrote: > oh, crappy, i forgot to update the author of the patch :( > really sorry about that... :( No worries, it happens (I've made the same mistake a few times as well)! If @DerKas

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. yeah, happy to do that if the author wants :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:612 + case PT_Float: +assert(false); } I left the implementation of this out since `visitZeroInitializer()` is dead code right now anyway and the patch is already large e

[PATCH] D136416: [AST] Support Bool type in va_arg

aaron.ballman added a comment. > Currently, if the second argument is "Bool", it will be casted to "int". That behavior is required by the standard, which is why we give a warning about it being undefined behavior due to the promotion. For C, see C2x 7.16.1.1p2 ("If //type// is not compatible w

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo updated this revision to Diff 469559. Grillo added a comment. Add test coverage and release note about the fix to `clang/docs/ReleaseNotes.rst` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136355/new/ https://reviews.llvm.org/D136355 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D136343: [Lex] Add compatibility with MSVC

aaron.ballman added a comment. In D136343#3873284 , @Qfrost911 wrote: > I understand you mean, but I can't get function name at macro expedition > stage. Correct! We have a `PredefinedExpr` AST node type (https://github.com/llvm/llvm-project/blob/main/

[PATCH] D136416: [AST] Support Bool type in va_arg

Qfrost911 abandoned this revision. Qfrost911 added a comment. I see, thank you very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136416/new/ https://reviews.llvm.org/D136416 ___ cfe-commits mailin

[PATCH] D136416: [AST] Support Bool type in va_arg

aaron.ballman added a comment. In D136416#3874308 , @Qfrost911 wrote: > I see, thank you very much. Thank you for trying to improve things in Clang! Even if this wasn't the right approach, the effort is still appreciated. :-) BTW, we have been trying to

[PATCH] D136343: [Lex] Add compatibility with MSVC

Qfrost911 added a comment. I understand you mean. I think I can try to solve this problem, if I have enough time. Thank you very much for your response. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136343/new/ https://reviews.llvm.org/D136343 _

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:513-534 + llvm::Optional MLTAL = + SetupConstraintCheckingTemplateArgumentsAndScope( + const_cast(FD), {}, Scope); + Qualifiers ThisQuals; CXXRecordDecl *Record = nullptr; if (aut

[clang-tools-extra] 8b36687 - [clangd] Add highlighting modifier "constructorOrDestructor"

Author: Christian Kandeler Date: 2022-10-21T15:14:38+02:00 New Revision: 8b3668754c889a9412a76035235b6fc581ca9863 URL: https://github.com/llvm/llvm-project/commit/8b3668754c889a9412a76035235b6fc581ca9863 DIFF: https://github.com/llvm/llvm-project/commit/8b3668754c889a9412a76035235b6fc581ca9863.

[PATCH] D134728: [clangd] Add highlighting modifier "constructorOrDestructor"

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b3668754c88: [clangd] Add highlighting modifier "constructorOrDestructor" (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134728/new/

[clang] 3770d2b - [X86] Fix typo of mtamx_int8

Author: Luo, Yuanke Date: 2022-10-21T21:13:07+08:00 New Revision: 3770d2b9cad91e32f33c7cd51c8517e619438218 URL: https://github.com/llvm/llvm-project/commit/3770d2b9cad91e32f33c7cd51c8517e619438218 DIFF: https://github.com/llvm/llvm-project/commit/3770d2b9cad91e32f33c7cd51c8517e619438218.diff L

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo updated this revision to Diff 469571. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136355/new/ https://reviews.llvm.org/D136355 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/Sema/non-null-warning.c Index: clang/test/Sema/non-null-warning.c

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

jamieschmeiser added a comment. In D136284#3869306 , @nlopes wrote: >> However, multiple loads of the same memory must be equal > > This premise is incorrect w.r.t. with current semantics, which say that loads > return undef for uninit memory. > > As Nik

[PATCH] D136090: Handle errors in expansion of response files

rovka added inline comments. Comment at: clang/test/Driver/config-file-errs.c:16 // RUN: not %clang --config somewhere/nonexistent-config-file 2>&1 | FileCheck %s -check-prefix CHECK-NONEXISTENT -// CHECK-NONEXISTENT: configuration file '{{.*}}somewhere/nonexistent-config-file

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

Eugene.Zelenko added a comment. Will be good idea to mention changes in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134588/new/ https://reviews.llvm.org/D134588 ___ cfe-commits mailing l

[PATCH] D136012: [clang][Interp] Fix record members of reference type

tbaeder updated this revision to Diff 469580. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136012/new/ https://reviews.llvm.org/D136012 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/re

[PATCH] D136449: [Clang] Implement P2513

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is applied to C++20 as a defect report. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136449 Fi

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

jamieschmeiser added a comment. In D136284#3869216 , @nikic wrote: > The current behavior here is intentional -- in fact, LLVM will move towards > returning poison for loads from uninitialized memory in the future (though > precisely how this will happe

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

tbaeder updated this revision to Diff 469589. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136423/new/ https://reviews.llvm.org/D136423 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td clang/test/AST/Interp/arrays.cpp

[PATCH] D136450: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a reviewer: ributzka. Herald added a project: All. dang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adds a `--extract-api-ignores=` command l

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

nikic added a comment. At least in C++, working with uninitialized memory is pretty much always immediate undefined behavior, see https://eel.is/c++draft/basic.indet for the relevant wording. The only exception are "copy-like" operations on unsigned character types, which comparisons do not fal

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane created this revision. erichkeane added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. erichkeane requested review of this revision. As that bug reports, the problem here is that the lambda's 'context-decl' was not set to the concept, and th

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

ilya-biryukov added a comment. Thanks for the change. All the behavior changes look reasonable to me, but I'm struggling to understand whether we follow the standard closely here. Left a comment to discuss this in depth. Comment at: clang/lib/Sema/SemaOverload.cpp:1238 bool S

[PATCH] D136449: [Clang] Implement P2513

cor3ntin updated this revision to Diff 469595. cor3ntin added a comment. Remove unused diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136449/new/ https://reviews.llvm.org/D136449 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:513-534 + llvm::Optional MLTAL = + SetupConstraintCheckingTemplateArgumentsAndScope( + const_cast(FD), {}, Scope); + Qualifiers ThisQuals; CXXRecordDecl *Record = nullptr; if (aut

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo updated this revision to Diff 469604. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136355/new/ https://reviews.llvm.org/D136355 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/Sema/non-null-warning.c Index: clang/test/Sema/non-null-warning.c

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo updated this revision to Diff 469605. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136355/new/ https://reviews.llvm.org/D136355 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/Sema/non-null-warning.c Index: clang/test/Sema/non-null-warning.c

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

jamieschmeiser added a comment. In D136284#3874492 , @nikic wrote: > At least in C++, working with uninitialized memory is pretty much always > immediate undefined behavior, see https://eel.is/c++draft/basic.indet for the > relevant wording. The only ex

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:513-534 + llvm::Optional MLTAL = + SetupConstraintCheckingTemplateArgumentsAndScope( + const_cast(FD), {}, Scope); + Qualifiers ThisQuals; CXXRecordDecl *Record = nullptr; if (aut

[clang] a726be3 - [NFC] Make sure we check an optional when checking function constraints

Author: Erich Keane Date: 2022-10-21T07:32:57-07:00 New Revision: a726be38756bf65dbe15912e779f0813fe5af01e URL: https://github.com/llvm/llvm-project/commit/a726be38756bf65dbe15912e779f0813fe5af01e DIFF: https://github.com/llvm/llvm-project/commit/a726be38756bf65dbe15912e779f0813fe5af01e.diff L

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

nlopes added a comment. In D136284#3874596 , @jamieschmeiser wrote: > In D136284#3874492 , @nikic wrote: > >> At least in C++, working with uninitialized memory is pretty much always >> immediate undefined behav

[PATCH] D136454: [clangd] Make file limit for textDocument/rename configurable

ckandeler created this revision. ckandeler added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Without th

[PATCH] D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus, ributzka. Herald added a subscriber: yaxunl. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds a 'targetFallback' field to relati

[PATCH] D136454: [clangd] Make file limit for textDocument/rename configurable

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136454/new/ https://reviews.llvm.org/D136454

[PATCH] D136090: Handle errors in expansion of response files

rovka added a comment. Nice tests! :) I have one microscopic nit and one question (because I don't know an awful lot about config files). Thanks for working on this. Comment at: llvm/lib/Support/CommandLine.cpp:1188 + // macros. + if (!RelativeNames && !InConfigFile) re

[PATCH] D136090: Handle errors in expansion of response files

mgorny added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1205 +if (ArgStr[0] == '@') { + FileName = ArgStr.drop_front(1); + if (!llvm::sys::path::is_relative(FileName)) Also, I think you can use `consume_front()` here. Repository

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

jamieschmeiser abandoned this revision. jamieschmeiser added a comment. I checked with a member of the C++ standards committee and he verified that comparing an uninitialized value against itself is, indeed, undefined behaviour, in the general case. I am abandoning this revision. Repository:

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

jamieschmeiser added a comment. In D136284#3874614 , @nlopes wrote: > In D136284#3874596 , > @jamieschmeiser wrote: > >> In D136284#3874492 , @nikic wrote: >> >>> At leas

[PATCH] D133698: [clang][dataflow] SignAnalysis, edgeTransfer, branchTransfer

martong updated this revision to Diff 469625. martong marked 8 inline comments as done. martong added a comment. - Add comments - Assumption -> ConditionValue - Use CRTP - branchTransfer -> transferBranch - Make just one simple test case for transferBranch Repository: rG LLVM Github Monorepo

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As briefly discussed in https://reviews.llvm.org/D1

[PATCH] D136437: [clang-format] Insert closing braces of unaffected lines

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Does this need a unit test? or are we good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136437/new/ https://reviews.llvm.org/D

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong updated this revision to Diff 469636. martong edited the summary of this revision. martong added a comment. - Rebase to latest llvm/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133698/new/ https://reviews.llvm.org/D133698 Files: cl

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:127 + // Default implementation is a Noop. + virtual void branchTransfer(bool Branch, const Stmt *S, Lattice &L, + Environment &Env) {}

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

rui.zhang added subscribers: mcberg2021, craig.topper. rui.zhang added a comment. In D122573#3872138 , @fhahn wrote: > Rebased on current main > > In D122573#3630767 , @rui.zhang > wrote: > >> I like the directio

[PATCH] D136449: [Clang] Implement P2513

aaron.ballman added a comment. Thanks for this! Can you add more details to the patch summary as to what this paper does? Paper numbers help, but don't convey a whole lot of information at a glance if we need to come back to this review for code archeology. Please also add a test to the correct

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

nlopes added a comment. In D136284#3874755 , @jamieschmeiser wrote: > In D136284#3874614 , @nlopes wrote: > >> In D136284#3874596 , >> @jamieschmeiser wrote: >> >>> In D

[PATCH] D135951: [X86][1/2] SUPPORT RAO-INT

pengfei updated this revision to Diff 469642. pengfei added a comment. Add intrinsic support first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135951/new/ https://reviews.llvm.org/D135951 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the update. Nice Work! Comment at: clang/test/Analysis/region-store.c:66 + // expected-warning@+1 {{passing arguments to 'b' without a prototype is deprecated

  1   2   >