royjacobson added a comment.

Thanks for working on it! It looks really good. Please remember to update the 
feature test macro (__cpp_aggregate_paren_init).

Also, I think there's no test coverage for the ASTReader/Writer changes? I 
would like to see some as well.



================
Comment at: clang/docs/ReleaseNotes.rst:546
   ([temp.func.order]p6.2.1 is not implemented, matching GCC).
+- Implemented `P0634R3: 
<https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p0960r3.html>`_
+  and `P1975R0: 
<https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1975r0.html>`_,
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129531/new/

https://reviews.llvm.org/D129531

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to