[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136259/new/ https://reviews.llvm.org/D136259

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

Arfrever added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:114-117 +target_link_libraries(clangBasic + PRIVATE + ${LLVM_ATOMIC_LIB} +) mgorny wrote: > Is this the right place? Grepping for `std::atomic`, I see lib/Frontend and a > bunch of tool

[clang] 4c87e12 - Fix crash in constraining partial specialization on nested template.

Author: Utkarsh Saxena Date: 2022-10-20T10:46:18+02:00 New Revision: 4c87e12484b39409f4d3c02e2c99042c67a76132 URL: https://github.com/llvm/llvm-project/commit/4c87e12484b39409f4d3c02e2c99042c67a76132 DIFF: https://github.com/llvm/llvm-project/commit/4c87e12484b39409f4d3c02e2c99042c67a76132.diff

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c87e12484b3: Fix crash in constraining partial specialization on nested template. (authored by usaxena95). Repository: rG LLVM Github Monorepo C

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu updated this revision to Diff 469136. ChuanqiXu added a comment. Use `-fc++-module-file-output` to address the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134267/new/ https://reviews.llvm.org/D134267 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle added a comment. Gentle ping :) If there are no objections, I'd like to commit this in a few days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134637/new/ https://reviews.llvm.org/D134637 ___

[PATCH] D97993: [Driver] Suppress GCC detection under -B

malharJ added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. Hi, Has anything been done to address this bug (related to COMPILER_PATH no longer being supported) ? https://bugs.llvm.org/show_bug.cgi?id=52009 Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah added inline comments. Comment at: flang/include/flang/Frontend/LangOptions.h:29 + +// Enable the floating point pragma +FPM_On, vzakhari wrote: > tblah wrote: > > awarzynski wrote: > > > What are these pragmas? Perhaps you can add a test that would

[PATCH] D136022: [clang] Add time profile for constant evaluation

Izaron updated this revision to Diff 469159. Izaron added a comment. Fix optionals with `value_or` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136022/new/ https://reviews.llvm.org/D136022 Files: clang/lib/AST/ExprConstant.cpp clang/unittests

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta created this revision. thieta added reviewers: MyDeveloperDay, curdeius, owenpan. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In our code-base we auto-generate pragma regions the regions look l

[PATCH] D136337: [clang-format] Discard pre-processor statements in parseBracedList()

thieta created this revision. thieta added reviewers: MyDeveloperDay, curdeius, owenpan. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We had some code that looked like this: int foo() { #pragm

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 469166. tbaeder added a comment. Another (and even longer) version. Introduce special opcodes for floating point operations and pass the rounding mode to them. Also create special int->float and float->int casts so we can handle that properly. This makes `

[PATCH] D135060: [HLSL] Add groupshare address space.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/ParserHLSL/group_shared_202x.hlsl:5-6 + +// expected-error@+1 {{return type cannot be qualified with address space}} +auto l = []()

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 469173. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp cl

[clang] ea8aebf - [analyzer] Move unexecuted test block into it's own source file

Author: isuckatcs Date: 2022-10-20T14:14:52+02:00 New Revision: ea8aebf9eb7f0762d357e02524be9f65cfdb4f58 URL: https://github.com/llvm/llvm-project/commit/ea8aebf9eb7f0762d357e02524be9f65cfdb4f58 DIFF: https://github.com/llvm/llvm-project/commit/ea8aebf9eb7f0762d357e02524be9f65cfdb4f58.diff LOG

[PATCH] D135965: [analyzer] Move unexecuted test block into it's own source file

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8aebf9eb7f: [analyzer] Move unexecuted test block into it's own source file (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github M

[PATCH] D109460: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

ldionne abandoned this revision. ldionne added a comment. Abandoning in favor of D136315 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109460/new/ https://reviews.llvm.org/D109460 ___

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

ldionne added a comment. Thanks for picking this up! I looked at my local changes and I had started modifying `inferDeploymentTargetFromSDK`. I had left the comment: /// TODO: We should only infer it if the SDK was provided with SDKROOT or -isysroot. /// If we inferred the SDK with xc

[PATCH] D134453: Disambiguate type names when printing NTTP types

aaron.ballman added a comment. In D134453#3869610 , @dblaikie wrote: > In D134453#3869201 , @aaron.ballman > wrote: > >> In D134453#3868821 , @DoDoENT >> wrote: >> >>> I

[PATCH] D136343: [Lex] Add compatibility with MSVC

Qfrost911 created this revision. Qfrost911 added a reviewer: shafik. Herald added a project: All. Qfrost911 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code below is valid in MSVC, but it is not allowed in clang printf(__FUNCTION

[PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. In D134878#3869947 , @mehdi_amini wrote: > From what I saw when you posted the discourse thread initially, I understand > you're targeting user-visible features, and mostly from the "toolchain" side > of the project. > Ho

[PATCH] D136293: [IncludeCleaner] Add public API

hokein accepted this revision. hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:7 +// +//===--===// + would be nice to have so

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder added a comment. I've moved the tests to `literals.cpp`, is there anything else left? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135366/new/ https://reviews.llvm.org/D135366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder added a comment. @aaron.ballman Do you maybe have a different reproducer or know more about the expected behavior of a `ImplicitValueInitExpr` for array and record types? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135013/new/ https://reviews.llvm.org/D135013 ___

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D135764: [clang][Interp] Implement for loops

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135764/new/ https://reviews.llvm.org/D135764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

hans added a comment. In D135220#3862893 , @dexonsmith wrote: > In D135220#3862058 , @hans wrote: > >> The build system folks replied saying they're not using symlinks, but hard >> links for compiler inputs. Dro

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I suppose it comes indirectly then. I'd prefer that you tested it with git main, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136282/ne

[PATCH] D135764: [clang][Interp] Implement for loops

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor points. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:361 + this->emitLabel(IncLabel); + if (Inc && !this->discard(Inc)) +

[PATCH] D136343: [Lex] Add compatibility with MSVC

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for the patch! It looks like it's missing test coverage for the changes, can you add some to `clang/test/Preprocessor`? One question I have is: if we're going to support `__FUNCTION__`, shouldn't we also sup

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff created this revision. sepavloff added reviewers: aaron.ballman, kadircet, MaskRay, mgorny. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commit

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo created this revision. Grillo added a reviewer: aaron.ballman. Herald added a project: All. Grillo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When checking for non null arguments the wrong SourceLocation was given, this fix to p

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

aaron.ballman added a comment. In D135013#3870894 , @tbaeder wrote: > @aaron.ballman Do you maybe have a different reproducer or know more about > the expected behavior of a `ImplicitValueInitExpr` for array and record types? So here's another reproduce

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

sepavloff added a comment. An alternative implementation is in D136354 . Instead of using new command-line option, it uses `--config` to include file, which is searched for as a configuration file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 updated this revision to Diff 469223. qiongsiwu1 removed a project: All. qiongsiwu1 added a comment. Herald added a project: All. Adding two test cases to match `G_NOTUNING`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136187/new/ http

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/debug-options.c:121 // RUN: %clang -### -c -g %s -target powerpc-ibm-aix-xcoff 2>&1 \ -// RUN: | FileCheck -check-prefix=G_LIMITED -check-prefix=G_DBX %s +//

[PATCH] D135764: [clang][Interp] Implement for loops

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:361 + this->emitLabel(IncLabel); + if (Inc && !this->discard(Inc)) +return false; aaron.ballman wrote: > What does the call to `dis

[PATCH] D135764: [clang][Interp] Implement for loops

tbaeder added inline comments. Comment at: clang/test/AST/Interp/loops.cpp:271 + /// be rejected. + constexpr int f6() { +while(true); aaron.ballman wrote: > Another test to add here: `for (;;);` is just as infinite. Heh, that's what this was supposed to

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wro

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder added a comment. In D135013#3871209 , @aaron.ballman wrote: > In D135013#3870894 , @tbaeder wrote: > >> @aaron.ballman Do you maybe have a different reproducer or know more about >> the expected behavior

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. @aaron.ballman: thanks for tracking down the source of confusion between our perspectives. (& yeah, sorry, could've included less ambiguous examples with the extra nesting so we'd have avoided all that confusion) Do you have particular examples where you find the fully

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

aaron.ballman added a comment. In D135013#3871250 , @tbaeder wrote: > In D135013#3871209 , @aaron.ballman > wrote: > >> In D135013#3870894 , @tbaeder >> wrote: >> >>> @a

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added a comment. In D135938#3867170 , @FreddyYe wrote: > I get your point of "close to each other" and updated. And I merged the > Disasm tests, while I didn't merge the MC tests because it is not so > convenient to do. See latest updated. > > D

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

RKSimon added inline comments. Comment at: clang/test/Driver/x86-march.c:120 +// RUN: | FileCheck %s -check-prefix=meteorlake +// meteorlake: "-target-cpu" "meteorlake" // Move these after alderlake instead of the old atom cores? Repository: rG LLVM Github

[PATCH] D134453: Disambiguate type names when printing NTTP types

aaron.ballman added a comment. In D134453#3871251 , @dblaikie wrote: > @aaron.ballman: thanks for tracking down the source of confusion between our > perspectives. (& yeah, sorry, could've included less ambiguous examples with > the extra nesting so we'

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder updated this revision to Diff 469230. tbaeder added a comment. Thinking about it some more, doesn't make much sense to add all that right now when we don't have a reproducer to test it anyway. I think the patch as it is makes sense and it it's not enough in the future, there's a proper a

[PATCH] D136106: [clang][RISCV] Set vscale_range attribute based on VLEN

reames added a comment. In D136106#3863202 , @reames wrote: > In D136106#3863147 , @craig.topper > wrote: > >>> In the original review, I'd mentioned that MinVLEN was sometimes zero. >>> That's still true, but a

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. > In terms of next steps, I think we should try to see if there's a "clear" > path forward in terms of printing the types vs not printing the types. If we > find one, then great, we go that way. But if we don't seem to have a clear > path forward (relatively quickly;

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton added a comment. I'm not sure I'm following where you're getting at. So far I'm getting the following: - my proposed fix was not ideal, and only "accidentally" fixed our issue - the fix including `Previous.isOneOf(TT_BinaryOperator...` is a better fix - we should write a proper test

[clang] ab8257c - [NFC] Fix a few whitespace inconsistencies.

Author: Paul Walker Date: 2022-10-20T14:52:25Z New Revision: ab8257ca0e9389d39c081d7bb8bd4afceb2215cc URL: https://github.com/llvm/llvm-project/commit/ab8257ca0e9389d39c081d7bb8bd4afceb2215cc DIFF: https://github.com/llvm/llvm-project/commit/ab8257ca0e9389d39c081d7bb8bd4afceb2215cc.diff LOG: [

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

steakhal updated this revision to Diff 469234. steakhal retitled this revision from "[analyzer] Fix assertion failure in RegionStore within bindArray()" to "[analyzer] Fix assertion failure with conflicting prototype calls". steakhal edited the summary of this revision. steakhal added a comment.

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

steakhal added a comment. In D136162#3869645 , @NoQ wrote: >> In this example, we try to store 42 to the Elem{buffer, 0}. > > In this case the natural question is, why does it go through `bindArray()`? > We're not binding an array. Can we try to preserve

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

RKSimon added a comment. Herald added a subscriber: StephenFan. @pengfei Do we still need this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120395/new/ https://reviews.llvm.org/D120395 ___ cfe-commits

[PATCH] D134453: Disambiguate type names when printing NTTP types

aaron.ballman added a comment. In D134453#3871386 , @dblaikie wrote: >> In terms of next steps, I think we should try to see if there's a "clear" >> path forward in terms of printing the types vs not printing the types. If we >> find one, then great, we

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please give @rjmccall a few days to look it over as well before landing. Comment at: clang/include/clang/AST/ASTContext.h:2379 + /// More type predicat

[PATCH] D136013: [clang][Interp] Fix ignoring expression return values

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136013/new/ https://reviews.llvm.org/D136013 ___ cfe-commits mailing lis

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration aaron.ballman wrote: > anderslanglands wro

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:726 + } else if (const auto *IVIE = dyn_cast(Initializer)) { +auto ArrayType = IVIE->getType()->getAsArrayTypeUnsafe(); +assert(ArrayType); Please spell out the typ

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. In D134453#3871414 , @aaron.ballman wrote: > In D134453#3871386 , @dblaikie > wrote: > >>> In terms of next steps, I think we should try to see if there's a "clear" >>> path forward in

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > aaron.ballman wrote

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. In D134453#3871458 , @dblaikie wrote: > In D134453#3871414 , @aaron.ballman > wrote: > >> In D134453#3871386 , @dblaikie >> wrote: >> In t

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny added a comment. I like this more than the alternative solution. The code still has some complexity but the behavior is fairly logical and consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D13635

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. That's a good point, I was a little suspicious about that function. I'm not sure it makes sense to infer the target at all from the SDK (e.g. macOS could be x86_64 or arm64) rather than infer the SDK from the target. Rust, for example, disregards `SYSROOT` and ru

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder updated this revision to Diff 469243. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135013/new/ https://reviews.llvm.org/D135013 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/arrays.cpp Index: clang/test/AST/

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:490 +// edge-cases. +ArgVal = castArgToParamTypeIfNeeded(Call, Idx, ArgVal, SVB); + Previously we didng make bindings if `ArgVal` was unknown, and w

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. If `clang -target arm64-apple-ios -isysroot path/to/MacOSX.sdk` changes the target to `x86_64-apple-macos` to match the SDK, that would be very confusing behavior :) I'll have to investigate that function some more. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added a comment. (pulling this out of inline comments because Phab's reply quoting doesn't work so well there & the threading/ordering gets weird too) >> Well, I'm hoping we can find a way to avoid doing that in the general case >> while still giving users a way to opt into that behavi

[PATCH] D136363: [OpenMP] Remove `-Bsymbolic` flag for device linking in the GNU toolchain

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tianshilei1992. Herald added subscribers: pengfei, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a p

[PATCH] D136248: [Index] consider `delete X` a reference to ~X() if it can be resolved

ilya-biryukov added a comment. Sorry for chiming in, left a comment on GitHub . TLDR; destructors are easy to find and this is not the case for user-defined `operator delete`. Maybe this is a good reason to have `operator delete` references (either

[PATCH] D136363: [OpenMP] Remove `-Bsymbolic` flag for device linking in the GNU toolchain

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136363/new/ https://reviews.llvm.org/D136363 _

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

probinson added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4374 + ? llvm::DebuggerKind::Default + : DebuggerTuning); Seems like you should be able to return `DebuggerKind::Default

[PATCH] D136080: [flang] Add -ffp-contract option processing

awarzynski added inline comments. Comment at: flang/test/Driver/driver-help-hidden.f90:34 ! CHECK-NEXT: Use as character line width in fixed mode +! CHECK-NEXT: -ffp-contract= Form fused FP ops (e.g. FMAs): fast (fuses across statements disregarding pragmas) | on (only fuses i

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

probinson added inline comments. Comment at: clang/test/Driver/as-options.s:121 +// Test that -g is passed through to GAS. +// RUN: %clang -fno-integrated-as -g %s -### 2>&1 | \ +// RUN: FileCheck --check-prefix=CHECK-DEBUG %s Please use an explicit triple here

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/region-store.c:66 + // expected-warning@+1 {{passing arguments to 'b' without a prototype is deprecated in all versions of C and is not supported in C2x}} + b(&buffer); +} tomas

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers updated this revision to Diff 469256. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - add triple, use Arg::AddLastArg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136309/new/ https://reviews.llv

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers added a comment. @MaskRay do you think I should make it so that `-g -g0` disables passing through `-g`? Comment at: clang/test/Driver/as-options.s:120 + +// Test that -g is passed through to GAS. +// RUN: %clang -fno-integrated-as -g %s -### 2>&1 | \ --

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/test/Analysis/region-store.c:66 + // expected-warning@+1 {{passing arguments to 'b' without a prototype is deprecated in all versions of C and is not supported in C2x}} + b(&buffer); +

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. You can remove this line in my view... > Style.BreakBeforeBinaryOperators == FormatStyle::BOS_NonAssignment) { CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 ___ cfe

[clang] 2a9a13d - [OpenMP] Remove `-Bsymbolic` flag for device linking in the GNU toolchain

Author: Joseph Huber Date: 2022-10-20T11:25:16-05:00 New Revision: 2a9a13d9cc5fceeb2cdb293dffeca0bc326c479f URL: https://github.com/llvm/llvm-project/commit/2a9a13d9cc5fceeb2cdb293dffeca0bc326c479f DIFF: https://github.com/llvm/llvm-project/commit/2a9a13d9cc5fceeb2cdb293dffeca0bc326c479f.diff

[PATCH] D136363: [OpenMP] Remove `-Bsymbolic` flag for device linking in the GNU toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a9a13d9cc5f: [OpenMP] Remove `-Bsymbolic` flag for device linking in the GNU toolchain (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D135060: [HLSL] Add groupshare address space.

This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG7e04c0ad6325: [HLSL] Add groupshare address space. (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D135060?vs=469048&id=469259#

[clang] 7e04c0a - [HLSL] Add groupshare address space.

Author: Xiang Li Date: 2022-10-20T09:29:09-07:00 New Revision: 7e04c0ad632527df0a4c4d34a6ac6ec6a3888dfe URL: https://github.com/llvm/llvm-project/commit/7e04c0ad632527df0a4c4d34a6ac6ec6a3888dfe DIFF: https://github.com/llvm/llvm-project/commit/7e04c0ad632527df0a4c4d34a6ac6ec6a3888dfe.diff LOG:

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added a comment. In D135557#3871482 , @dblaikie wrote: > I was hoping the rephrasing (is this really a question about which ctors the > type has, or about how the type can be constructible) might offer us a way > out for this use case, at

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

beanz added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" You need to add FrontendHLSL to the Sema/CMakeLists.txt file too. Repository: rG LLVM Github Mo

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4374 + ? llvm::DebuggerKind::Default + : DebuggerTuning); probinson wrote: > Seems like you should be able to return `D

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT added a comment. > (rabbit hole/tangent: Arguably what might be more useful to the user might be > a name that's not even usable in C++ - using the member variable names, as > well as the type names, though that'd be even more verbose... like > `t1` - which, I guess, if you had user def

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 469270. fhahn added a comment. Rebase on top of current `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/in

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers added a comment. In D136309#3871599 , @nickdesaulniers wrote: > @MaskRay do you think I should make it so that `-g -g0` disables passing > through `-g`? Looks like this pattern can be used: if (const Arg *A = Args.getLastArg(options:

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" beanz wrote: > You need to add FrontendHLSL to

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added a comment. In D135557#3871622 , @aaron.ballman wrote: > In D135557#3871482 , @dblaikie > wrote: > >> I was hoping the rephrasing (is this really a question about which ctors the >> type has, or a

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

MaskRay added a comment. Many -g options unfortunately enable/disable debug info emission: -g, -g[0123], -ggdb[0123], etc. The full rules are very complex. I think it makes sense to support a subset which is mostly likely used, i.e. -g, -g[0123]. So you may check `OPT_g_Group` and possibly reus

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers updated this revision to Diff 469280. nickdesaulniers added a comment. handle -g0 positionally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136309/new/ https://reviews.llvm.org/D136309 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

MaskRay added inline comments. Comment at: clang/test/Driver/as-options.s:120 + +// Test that -g is passed through to GAS. +// RUN: %clang -fno-integrated-as -g %s -### 2>&1 | \ nickdesaulniers wrote: > MaskRay wrote: > > -g can be tested along with other pass-th

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

MaskRay added a comment. (Note that assembler synthesized debug info for assembly files is a very minor feature. I don't know why the Linux kernel is so fond of it..). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136309/new/ https://reviews.llvm.

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers added a comment. In D136309#3871769 , @MaskRay wrote: > (Note that assembler synthesized debug info for assembly files is a very > minor feature. I don't know why the Linux kernel is so fond of it..). This is _required_ for symbolicating

[PATCH] D136090: Handle errors in expansion of response files

sepavloff updated this revision to Diff 469286. sepavloff added a comment. Make UTF-16 string properly aligned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136090/new/ https://reviews.llvm.org/D136090 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added a comment. In D135557#3871716 , @dblaikie wrote: > (I'm still sort of curious how the AST matchers deal with all this - I guess > they must have Sema available, because I'd assume they make all sorts of > queries like "is this constr

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

aaron.ballman added a comment. Thank you for the fix! Can you add test coverage to show the behavioral change? You can either position the problematic null argument on its own line (so you can validate the correct position) or use `-fdiagnostics-print-source-range-info` to check a specific ran

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" python3kgae wrote: > beanz wrote: > > You need

[PATCH] D136022: [clang] Add time profile for constant evaluation

aaron.ballman added inline comments. Comment at: clang/unittests/Support/TimeProfilerTest.cpp:197-198 + + // NOTE: If this test is failing, run this test with + // `llvm::errs() << TraceGraph;` and change the assert above. +} This bit worries me because I suspe

  1   2   >