hel-ableton added a comment.

I'm not sure I'm following where you're getting at. So far I'm getting the 
following:

- my proposed fix was not ideal,  and only "accidentally" fixed our issue
- the fix including `Previous.isOneOf(TT_BinaryOperator...` is a better fix
- we should write a proper test case for that fix, as the one I submitted 
referred to the wrong fix
- the example you gave now (as a model to construct such a better test?) 
doesn't involve `TT_CtorInitializerColon` or any of the like, so...

I'm confused. :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136154/new/

https://reviews.llvm.org/D136154

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to