[PATCH] D134284: [AIX] change "llvm-nm" to "env OBJECT_MODE=any llvm-nm" in clang/test for AIX OS

jhenderson accepted this revision. jhenderson added a comment. LGTM, with nit. Comment at: clang/test/lit.cfg.py:287 + +# llvm-nm tools support an environment variable "OBJECT_MODE" on AIX OS, which +# controls the kind of objects they will support. If there is no "OBJECT_MODE"

[PATCH] D88299: [clang-format] Add MacroUnexpander.

owenpan added subscribers: MyDeveloperDay, owenpan. owenpan added a comment. @sstwcw thanks for pointing it out. See D134329 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D882

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

serge-sans-paille added inline comments. Comment at: clang/test/Sema/unbounded-array-bounds.c:101 + char tail[1]; // addr16-note {{declared here}} addr32-note {{declared here}} +} fam1; + msebor wrote: > msebor wrote: > > There's a difference between the sizes

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, we of all people have to dogfood this stuff.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.ll

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny updated this revision to Diff 461803. mgorny added a comment. Combining `--config` and default configuration files is now explicitly allowed. Adjust the code to load default configs before explicitly specified files. Update tests to cover combining `--config` with defaults. Update the do

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. For the record, I'm working on support for loading defaults from multiple files in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing l

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek added a comment. In D88299#3804910 , @owenpan wrote: > @sstwcw thanks for pointing it out. See D134329 > . Thanks Owen, really appreciate this! And sorry for not getting to it yet myself :( Repository: rG LLV

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

MyDeveloperDay added a comment. In D134325#3804817 , @zzyyyl wrote: > What if `concept c = (bool)(...)` ? > > or `concept c = static_cast(...)` Aren't these handled elsewhere in the case (by the static_cast and l_paren rules)? but possibly worth a test

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

MyDeveloperDay added a comment. given that #57538 manifested itself as a incorrect format (no doubt because of incorrect token annotation), should we add a verifyFormat tests somewhere for the example from the github issue, (it just protects the formatting for being broken by some other change

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134316/new/ https://reviews.llvm.org/D134316 ___ cfe

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added subscribers: StephenFan, pengfei. Herald added a reviewer: sscalpone. Herald added a project: All. mgorny requested review of this revision. Update the rules used to load default configuration files to permit mo

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. @sepavloff, I'd appreciate if you could take a look at the logic before I start updating tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list c

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

phosek added inline comments. Comment at: clang/CMakeLists.txt:912-926 +TABLEGEN +-DLLVM_TABLEGEN=${LLVM_RUNTIME_OUTPUT_INTDIR}/llvm-tblgen +-DCLANG_TABLEGEN=${LLVM_RUNTIME_OUTPUT_INTDIR}/clang-tblgen +LINKER -DCMAKE_LINKER=${LLVM_RUNTIME_OUTPUT_I

[PATCH] D132975: [CMake] Add clang-bolt target

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 ___

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:2185 +addRegisterClass(MVT::v32bf16, &X86::VR512RegClass); +setOperationAction(ISD::BUILD_VECTOR, MVT::bf16, Custom); +setOperationAction(ISD::BUILD_VECTOR, MVT::v8bf16, Custom); --

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/avx512bf16-intrinsics-upgrade.ll:30 ; X64-NEXT:kmovd %edi, %k1 # encoding: [0xc5,0xfb,0x92,0xcf] -; X64-NEXT:vcvtne2ps2bf16 %zmm1, %zmm0, %zmm0 {%k1} {z} # encoding: [0x62,0xf2,0x7f,0xc9,0x72,0xc1] +; X64-

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

J-Camilleri created this revision. J-Camilleri added a reviewer: dexonsmith. Herald added subscribers: jeroen.dobbelaere, hiraditya. Herald added a project: All. J-Camilleri requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D133807: Update Unicode to 15.0

cor3ntin added a comment. @tahonermann ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 461822. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

animeshk-amd updated this revision to Diff 461827. animeshk-amd added a comment. Updated the LIT test for omp_thread_mem_alloc allocator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132855/new/ https://reviews.llvm.org/D132855 Files: clang/test

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added a comment. LGTM. Tested on one little-endian machine with our internal tests (I attached them in the issue https://github.com/llvm/llvm-project/issues/55961) for the priority of `-fconvert=` option and `CONVERT` argument in open statement and all passed. I didn't see the the `GFORT

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

J-Camilleri added a comment. The premerge checks have failed but the only message I can see is `HTTP 28` in the log. I am not sure where to look for more information about the failure, Can someone please point me in the right direction? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1061 return false; + if (ClangNameParts.TargetPrefix.empty()) +return false; Does it mean that executable without prefix won't load implicit config file? For example, execution of

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

h-vetinari added a comment. In D133853#3797598 , @RIscRIpt wrote: > I am afraid it would take me some effort to implement semantics of > `[[msvc::no_unique_address]]`, so I'd like to focus only on > `[[msvc::constexpr]]` in current patch. Just for cont

[clang] 003566c - [clang][dataflow] Remove deprecated overloads of `checkDataflow` in `TestingSupport.h`.

Author: Wei Yi Tee Date: 2022-09-21T10:36:44Z New Revision: 003566cb1faec315f86e69f57da3998ff3f922aa URL: https://github.com/llvm/llvm-project/commit/003566cb1faec315f86e69f57da3998ff3f922aa DIFF: https://github.com/llvm/llvm-project/commit/003566cb1faec315f86e69f57da3998ff3f922aa.diff LOG: [c

[PATCH] D134081: [clang][dataflow] Remove deprecated overloads of `checkDataflow` in `TestingSupport.h`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG003566cb1fae: [clang][dataflow] Remove deprecated overloads of `checkDataflow` in… (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:2185 +addRegisterClass(MVT::v32bf16, &X86::VR512RegClass); +setOperationAction(ISD::BUILD_VECTOR, MVT::bf16, Custom); +setOperationAction(ISD::BUILD_VECTOR, MVT::v8bf16, Custom); --

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1061 return false; + if (ClangNameParts.TargetPrefix.empty()) +return false; sepavloff wrote: > Does it mean that executable without prefix won't load implicit config file? > For exa

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

mstorsjo added a comment. I think this looks reasonable to me, but I don't think I'm knowledgeable enough to give this a proper review, sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125418/new/ https://reviews.llvm.org/D125418

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

mstorsjo added a comment. I think this looks reasonable to me - if noone else has time to approve it, I guess I could, but I'd rather have the more authoritative reviewers complete their reviews. Comment at: llvm/utils/UpdateTestChecks/common.py:330 OPT_FUNCTION_RE = re.comp

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. To explain this better, let's take the following example call: x86_64-pc-linux-gnu-clang --driver-mode=g++ -target i386 This maps to: - effective triple: `i386` (from `-target`) - effective mode: `clang++` (from `--driver-mode`) - name prefix: `x86_64-pc-linux-gnu` - "

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing li

[clang] 9474709 - [clang][dataflow] Remove deprecated `transfer(const Stmt *, ...)` API.

Author: Wei Yi Tee Date: 2022-09-21T11:06:21Z New Revision: 94747094c782d8a45b61414717df8308f8a25919 URL: https://github.com/llvm/llvm-project/commit/94747094c782d8a45b61414717df8308f8a25919 DIFF: https://github.com/llvm/llvm-project/commit/94747094c782d8a45b61414717df8308f8a25919.diff LOG: [c

[PATCH] D134318: [clang][dataflow] Remove deprecated `transfer(const Stmt *, ...)` API.

This revision was automatically updated to reflect the committed changes. Closed by commit rG94747094c782: [clang][dataflow] Remove deprecated `transfer(const Stmt *, ...)` API. (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134318/

[clang] 8a774c3 - [clang] [Driver] Support multiple configuration files

Author: Michał Górny Date: 2022-09-21T13:14:36+02:00 New Revision: 8a774c35e9f8c6a200a8f4d00aae909840f5004a URL: https://github.com/llvm/llvm-project/commit/8a774c35e9f8c6a200a8f4d00aae909840f5004a DIFF: https://github.com/llvm/llvm-project/commit/8a774c35e9f8c6a200a8f4d00aae909840f5004a.diff

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a774c35e9f8: [clang] [Driver] Support multiple configuration files (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Githu

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks for the fix. In D134325#3804969 , @MyDeveloperDay wrote: > given that #57538 manifested itself as a incorrect format (

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 461850. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h clang/include/clang/

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov updated this revision to Diff 461851. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td clang/lib/AST/ASTContext.

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 461852. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

bcl5980 added a comment. A question about the mangle and alias part. Should we move the code to create alias to backend also？Sometimes we will emit the alias here but later the function will be inlined or eliminated by DCE. And later we need to emit alias for direct call thunk also, like $origin

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:890-893 + struct { +bool DoIt; +FunctionDecl *Existing = nullptr; + } Merge = {false}; ChuanqiXu wrote: > Is this struct nec

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

t.p.northover created this revision. t.p.northover added a reviewer: ab. Herald added subscribers: hiraditya, kristof.beyls, mcrosier. Herald added a project: All. t.p.northover requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This adds

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

t.p.northover updated this revision to Diff 461858. t.p.northover added a comment. Accidentally clang-formatted the `ampere1` test. Undo that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134351/new/ https://reviews.llvm.org/D134351 Files: clang/test/Misc/target-invalid-cpu-note.c

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm created this revision. david-arm added reviewers: sdesmalen, paulwalker-arm, dmgreen, MarkMurrayARM, CarolineConcatto. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. david-arm requested review of this revision. Herald added projects: clang, LLVM. Herald

[clang] ef4bbfe - [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

Author: Matheus Izvekov Date: 2022-09-21T14:22:19+02:00 New Revision: ef4bbfe338bd85a9938d47c2d65f0eef874a6f7c URL: https://github.com/llvm/llvm-project/commit/ef4bbfe338bd85a9938d47c2d65f0eef874a6f7c DIFF: https://github.com/llvm/llvm-project/commit/ef4bbfe338bd85a9938d47c2d65f0eef874a6f7c.dif

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef4bbfe338bd: [clang] AST: SubstTemplateTypeParmType support for n

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman marked 4 inline comments as done. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Type.h:1902 AutoTypeBitfields AutoTypeBits; +TypeOfBitfields TypeOfBits; BuiltinTypeBitfields BuiltinTypeBits; erichkeane wrote:

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added a comment. In D131465#3804893 , @glandium wrote: > This didn't change the default for msvc targets, was that expected? Can confirm: https://godbolt.org/z/EPxn1T6za I did not expect this (and I'm a bit shocked that we had no test fail

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman updated this revision to Diff 461867. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Herald added a subscriber: arphaman. Updating based on review feedback; I believe this handles all of the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

erichkeane added a comment. I have no real idea what is going on here, the parser isn't an area where I spend much time. Can you ELI5? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134334/new/ https://reviews.llvm.org/D134334 ___ cfe-commit

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane reopened this revision. erichkeane added a comment. This revision is now accepted and ready to land. I have a replacement patch that should fix all of the bugs I'm aware of. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 __

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

mizvekov added inline comments. Comment at: clang/lib/AST/Type.cpp:3504-3507 + // We strip all qualifier-like attributes as well. + if (const auto *AT = dyn_cast(Ret.getTypePtr()); + AT && AT->isQualifier()) +Ret = AT->getModifiedType(); I think this b

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

erichkeane added inline comments. Comment at: clang/include/clang/AST/Type.h:1902 AutoTypeBitfields AutoTypeBits; +TypeOfBitfields TypeOfBits; BuiltinTypeBitfields BuiltinTypeBits; aaron.ballman wrote: > erichkeane wrote: > > So the downside to doin

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

DavidSpickett added a comment. I don't have the expertise to approve, but one question. Why is there more testing in the `.c` than in `.cpp`. Is the same logic being used for both so there's no point checking twice? If so what things is the `.cpp` test looking for specifically? I struggle to s

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/AST/Type.cpp:3504-3507 + // We strip all qualifier-like attributes as well. + if (const auto *AT = dyn_cast(Ret.getTypePtr()); + AT && AT->isQualifier()) +Ret = A

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. I spoke too soon, I found another crash that came out of @wlei s repro from last time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 ___ cfe-commits mailing list cfe-co

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

yaxunl created this revision. yaxunl added reviewers: b-sumner, cfang. Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D134355 Fi

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. I have not looked deep into D126907 , but the rule it referred seems related to something as follows: template concept C = true; template struct S { template U> typename> friend void foo(S) {} }; // Does the rule sa

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3805640 , @erichkeane wrote: > I spoke too soon, I found another crash that came out of @wlei s repro from > last time. Actually, what I found was a reduction that had gone haywire before and generated invalid co

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:941 + "Neoverse V2 ARM processors", [ + FeaturePostRAScheduler]>; + Please add FeatureFuseAES and FeatureLSLFas

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

urnathan added a comment. AFAICT the UsingDecl doesn't capture the NestedNameSpecifier location, is UsingEnumDecl special in some way, or would this information be better placed in BaseUsingDecl? Thanks for spotting the possible mid-air collistion with D134283

[PATCH] D130460: [pseudo] Add recovery for declarations

hokein commandeered this revision. hokein edited reviewers, added: sammccall; removed: hokein. hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:333 + // Walk over tokens at the appropriate bracket nesting level. + for (const Token *T = &P.Token

[PATCH] D130460: [pseudo] Add recovery for declarations

hokein added a comment. I'm going to pick this up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130460/new/ https://reviews.llvm.org/D130460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

sstwcw added a comment. Did you leave out `clang/include/clang/Format` and `clang/unittests/Format`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.llvm.org/D134329 ___ cfe-com

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

arsenm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:590-591 // times 100. -// ToDo: Enable module flag for all code object version when ROCm device -// library is ready. -if (getTarget().getTargetOpts().CodeObjectVersion == TargetOptions

[clang] d47f0be - [AIX] change "llvm-nm" to "env OBJECT_MODE=any llvm-nm" in clang/test for AIX OS

Author: zhijian Date: 2022-09-21T09:38:13-04:00 New Revision: d47f0be0e82b46aed8d23e0dd4b596adefad2448 URL: https://github.com/llvm/llvm-project/commit/d47f0be0e82b46aed8d23e0dd4b596adefad2448 DIFF: https://github.com/llvm/llvm-project/commit/d47f0be0e82b46aed8d23e0dd4b596adefad2448.diff LOG:

[PATCH] D134284: [AIX] change "llvm-nm" to "env OBJECT_MODE=any llvm-nm" in clang/test for AIX OS

This revision was automatically updated to reflect the committed changes. Closed by commit rGd47f0be0e82b: [AIX] change "llvm-nm" to "env OBJECT_MODE=any llvm-nm" in clang/test for AIX OS (authored by zhijian ). Changed prior to commit: https://reviews.llvm.org/D134284?vs=4

[PATCH] D134314: [HIP] stop forcing the lang std in the driver

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134314/new/ https://reviews.llvm.org/D134314 __

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

dmgreen added a comment. The arm_acle.h header is shared across Arm and AArch64 - they use the same builtin names even if they are replicated to a certain degree across the backends. As this is used in both it would be good to fix them at the same time. It doesn't need to change the guards as D

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Whether you do that here or in another patch, the change LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134127/new/ https://reviews.llvm.

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

aaron.ballman added a comment. There are no tests for applying this to a global variable, so those should be added. Comment at: clang/include/clang/Basic/AttrDocs.td:6596-6598 +The ``SV_DispatchThreadID`` semantic, when applied to an input parameter, specifies a +data binding

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added a comment. In D134303#3805687 , @urnathan wrote: > AFAICT the UsingDecl doesn't capture the NestedNameSpecifier location We have `NestedNameSpecifierLoc UsingDecl::QualifierLoc` already, maybe I'm misunderstanding. > is UsingEnumDecl sp

[PATCH] D134326: [HLSL] Allow SV_GroupIndex for lib profile.

aaron.ballman added a comment. This looks reasonable to me, but I leave the final sign-off to @beanz. Comment at: clang/test/CodeGenHLSL/GlobalDestructors.hlsl:1 -// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -std=hlsl202x -S -emit-llvm -disable-llvm-passes %s -o -

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. In D134128#3805675 , @lime wrote: > I have not looked deep into D126907 , but > the rule it referred seems related to something as follows: You shouldn't have to look 'deep' into it, just reb

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Failure I noticed was NOT a regression: https://godbolt.org/z/MnvqP88vv CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. In D134128#3805675 , @lime wrote: > I have not looked deep into D126907 , but > the rule it referred seems related to something as follows: > > template concept C = true; > > template

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman updated this revision to Diff 461886. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Simplifying based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134286/new/ https://reviews.llvm.org/D134286 Files: clang/docs/Releas

[PATCH] D115169: Create a generic ABI document for _BitInt

aaron.ballman edited reviewers, added: efriedma; removed: rsmith. aaron.ballman added a comment. Now that C2x is closer to getting finalized, I would like to get this documentation up somewhere public so that other implementations can see what we do and match our behavior more easily. Changing u

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 abandoned this revision. doru1004 added a comment. The outcome of this discussion resulted in a fix to the original program from use_device_addr(x) to use_device_addr(x[:count]). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133694/new/ https://reviews.llvm.org/D133694 __

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements `ArrayInitLoopExpr`s in initializer

[PATCH] D134054: [clang][Interp] Properly destruct allocated Records

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well (modulo Erich's comments). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134054/new/ https://reviews.llvm.org/D134054 ___

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/avx512bf16-intrinsics-upgrade.ll:30 ; X64-NEXT:kmovd %edi, %k1 # encoding: [0xc5,0xfb,0x92,0xcf] -; X64-NEXT:vcvtne2ps2bf16 %zmm1, %zmm0, %zmm0 {%k1} {z} # encoding: [0x62,0xf2,0x7f,0xc9,0x72,0xc1] +; X64-

[PATCH] D134157: [LoongArch] Add inline asm support for constraints f/l/I/K

xen0n added a comment. I don't know if the clang changes should be split into its own commit (or the title of this commit amended to mention `[Clang]` but I don't know if this is appropriate), but the rest looks reasonable. Comment at: llvm/test/CodeGen/LoongArch/inline-asm-c

[PATCH] D134362: [clang] Fix interaction between asm labels and inline builtins

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, aaron.ballman, nickdesaulniers. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One must pick the same name

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/avx512bf16-intrinsics-upgrade.ll:30 ; X64-NEXT:kmovd %edi, %k1 # encoding: [0xc5,0xfb,0x92,0xcf] -; X64-NEXT:vcvtne2ps2bf16 %zmm1, %zmm0, %zmm0 {%k1} {z} # encoding: [0x62,0xf2,0x7f,0xc9,0x72,0xc1] +; X64-

[PATCH] D134362: [clang] Fix interaction between asm labels and inline builtins

serge-sans-paille updated this revision to Diff 461893. serge-sans-paille added a comment. (rebased on main branch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134362/new/ https://reviews.llvm.org/D134362 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/asm-label-inline-bui

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-commi

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:590-591 // times 100. -// ToDo: Enable module flag for all code object version when ROCm device -// library is ready. -if (getTarget().getTarget

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm updated this revision to Diff 461898. david-arm added a comment. - Changed lists of tuning features. - Removed redundant arch features from list. - Combined neoverse-v2 and neoverse-n2 cases together in AArch64Subtarget. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm marked 3 inline comments as done. david-arm added a comment. Thanks for the quick review @dmgreen! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D115169: Create a generic ABI document for _BitInt

gustedt added a comment. It seems that this has already shipped on some platforms. Since this basically binds others to use the same ABI, it would perhaps be nice if the document could have a table that lists `MaxFundamentalWidth` and `chunk_t`. Also discussing consequences for `va_arg` functio

[clang] bc14ed7 - Add clang_CXXMethod_isDeleted function

Author: Anders Langlands Date: 2022-09-21T11:12:48-04:00 New Revision: bc14ed7de0f1f038c500b5f1d6c7a86a4a2d4527 URL: https://github.com/llvm/llvm-project/commit/bc14ed7de0f1f038c500b5f1d6c7a86a4a2d4527 DIFF: https://github.com/llvm/llvm-project/commit/bc14ed7de0f1f038c500b5f1d6c7a86a4a2d4527.di

[PATCH] D133924: add clang_CXXMethod_isDeleted function

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc14ed7de0f1: Add clang_CXXMethod_isDeleted function (authored by anderslanglands, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D133924?vs=460865&id=461900#toc Reposit

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman added a comment. In D129755#3796799 , @aaronpuchert wrote: > In D129755#3779997 , @aaron.ballman > wrote: > >> Please be sure to add a release note for the changes! > > Any opinion as to what the r

[clang] bc97751 - [NFC] Add GitHub issues to HLSL FIXME comments

Author: Chris Bieneman Date: 2022-09-21T10:31:25-05:00 New Revision: bc97751a236e619dc33f81e9fc9b3fe6bd0ba7b6 URL: https://github.com/llvm/llvm-project/commit/bc97751a236e619dc33f81e9fc9b3fe6bd0ba7b6 DIFF: https://github.com/llvm/llvm-project/commit/bc97751a236e619dc33f81e9fc9b3fe6bd0ba7b6.diff

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

This revision was automatically updated to reflect the committed changes. Closed by commit rG28412d1800e3: [lit] Implement DEFINE and REDEFINE directives (authored by jdenny). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 28412d1 - [lit] Implement DEFINE and REDEFINE directives

Author: Joel E. Denny Date: 2022-09-21T11:32:05-04:00 New Revision: 28412d1800e391c5ba8e7607bb15c74b106d581b URL: https://github.com/llvm/llvm-project/commit/28412d1800e391c5ba8e7607bb15c74b106d581b DIFF: https://github.com/llvm/llvm-project/commit/28412d1800e391c5ba8e7607bb15c74b106d581b.diff

[PATCH] D134326: [HLSL] Allow SV_GroupIndex for lib profile.

beanz added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6901 +// FIXME: it is OK for a compute shader entry and pixel shader entry live in +// same HLSL file. uint32_t Pipeline = I think the underlying issue here is that some attrib

  1   2   3   >