DavidSpickett added a comment.

I don't have the expertise to approve, but one question.

Why is there more testing in the `.c` than in `.cpp`. Is the same logic being 
used for both so there's no point checking twice?

If so what things is the `.cpp` test looking for specifically? I struggle to 
see how the lines it checks for map into the call to the variadic function. Is 
it looking at the mangling, the choice of pointer or not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125419/new/

https://reviews.llvm.org/D125419

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D125419: [Arm64EC ... Martin Storsjö via Phabricator via cfe-commits
    • [PATCH] D125419: [Arm... David Spickett via Phabricator via cfe-commits

Reply via email to