[clang] f65f06d - [NFC] [Coroutines] Add tests for looking up deallocation

Author: Chuanqi Xu Date: 2022-09-06T14:57:01+08:00 New Revision: f65f06d63f6a0e40c33a9d77eeb381f1b2a8a524 URL: https://github.com/llvm/llvm-project/commit/f65f06d63f6a0e40c33a9d77eeb381f1b2a8a524 DIFF: https://github.com/llvm/llvm-project/commit/f65f06d63f6a0e40c33a9d77eeb381f1b2a8a524.diff LO

[PATCH] D130863: [clangd] Make git ignore index directories

kadircet added a comment. In D130863#3696419 , @sums wrote: > Thank you for the reviews and discussion, everyone! > > TIL about `.git/info/exclude`. It'll let me exclude stuff without updating > the checked in `.gitignore`. I was achieving the same effec

[PATCH] D133339: [clangd] Isolate logic for setting LSPServer options

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Moves clangd

[clang] 7179779 - [OpenMP] Mark -fopenmp-implicit-rpath as NoArgumentUnused

Author: Nikita Popov Date: 2022-09-06T09:44:45+02:00 New Revision: 71797797f7a759245cb39b93307e0641c511170c URL: https://github.com/llvm/llvm-project/commit/71797797f7a759245cb39b93307e0641c511170c DIFF: https://github.com/llvm/llvm-project/commit/71797797f7a759245cb39b93307e0641c511170c.diff

[PATCH] D133316: [OpenMP] Mark -fopenmp-implicit-rpath as NoArgumentUnused

This revision was automatically updated to reflect the committed changes. Closed by commit rG71797797f7a7: [OpenMP] Mark -fopenmp-implicit-rpath as NoArgumentUnused (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

animeshk-amd added a comment. Thanks @saiislam. Since I don't have the commit access yet, I request you to kindly commit this on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131763/new/ https://reviews.llvm.org/D131763 ___

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu created this revision. ChuanqiXu added reviewers: erichkeane, ychen, rjmccall. ChuanqiXu added projects: clang, clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. This implements the option2 of htt

[PATCH] D130863: [clangd] Make git ignore index directories

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:58 +if (CreatingNewDirectory) { + llvm::Error error = addGitignore(DiskShardRoot); + if (error) { nit: ``` if(llvm::Error E = addGitignore(..)) {

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu updated this revision to Diff 458116. ChuanqiXu added a comment. Remove invisible character... there are always invisible characters in the paper.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133341/new/ https://reviews.llvm.org/D133341 Files: clang/docs/ClangCommandLine

[clang] f2c17a1 - [OpenCL] Remove argument names from atomic/fence builtins

Author: Sven van Haastregt Date: 2022-09-06T10:50:57+01:00 New Revision: f2c17a130a27cadd9d204bef09fd4ad64518c9da URL: https://github.com/llvm/llvm-project/commit/f2c17a130a27cadd9d204bef09fd4ad64518c9da DIFF: https://github.com/llvm/llvm-project/commit/f2c17a130a27cadd9d204bef09fd4ad64518c9da.

[PATCH] D133339: [clangd] Isolate logic for setting LSPServer options

kadircet updated this revision to Diff 458128. kadircet added a comment. rename helper & add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19/new/ https://reviews.llvm.org/D19 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[clang] 2adf241 - [clang-format] [doc] Fix example of wrapping class definitions

Author: Passw Date: 2022-09-06T12:24:18+02:00 New Revision: 2adf241592b38189994c6c9d2dfbfa391ecbe9fa URL: https://github.com/llvm/llvm-project/commit/2adf241592b38189994c6c9d2dfbfa391ecbe9fa DIFF: https://github.com/llvm/llvm-project/commit/2adf241592b38189994c6c9d2dfbfa391ecbe9fa.diff LOG: [c

[clang] 2476135 - [clang-format] Change heuristic for locating lambda template arguments

Author: Emilia Dreamer Date: 2022-09-06T12:24:19+02:00 New Revision: 247613548bac55b47eed88e83d5c8640fd4b200a URL: https://github.com/llvm/llvm-project/commit/247613548bac55b47eed88e83d5c8640fd4b200a DIFF: https://github.com/llvm/llvm-project/commit/247613548bac55b47eed88e83d5c8640fd4b200a.diff

[PATCH] D133087: [clang-format] [doc] Fix example of wrapping class definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rG2adf241592b3: [clang-format] [doc] Fix example of wrapping class definitions (authored by Passw, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG247613548bac: [clang-format] Change heuristic for locating lambda template arguments (authored by rymiel, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133087: [clang-format] [doc] Fix example of wrapping class definitions

HazardyKnusperkeks added a comment. Just a note, I had to edit your patch. Did you create it with git diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087/new/ https://reviews.llvm.org/D133087 ___

[clang] 0cecc6e - [OpenMP] Add lit test for metadirective device arch inspired

Author: Animesh Kumar Date: 2022-09-06T07:10:15-05:00 New Revision: 0cecc6e8e27c9913cd2d82a77941dc3a6d11318f URL: https://github.com/llvm/llvm-project/commit/0cecc6e8e27c9913cd2d82a77941dc3a6d11318f DIFF: https://github.com/llvm/llvm-project/commit/0cecc6e8e27c9913cd2d82a77941dc3a6d11318f.diff

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cecc6e8e27c: [OpenMP] Add lit test for metadirective device arch inspired (authored by animeshk-amd, committed by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

serge-sans-paille added a comment. @aaron.ballman this is just a patch to start a discussion: We already have the cmake rule to generate this file, so removing it from tree actually doesn't break compilation. So I'm wondering why and if we should keep it checked in? Removing it would make it le

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c604e9f1560: Update the clang and clang-tools-extra code owners files (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D132550?vs=457289&id=458149#toc Repository: rG LL

[clang] 3c604e9 - Update the clang and clang-tools-extra code owners files

Author: Aaron Ballman Date: 2022-09-06T08:28:03-04:00 New Revision: 3c604e9f15606fa395b088ca341a232ffda2bb7d URL: https://github.com/llvm/llvm-project/commit/3c604e9f15606fa395b088ca341a232ffda2bb7d DIFF: https://github.com/llvm/llvm-project/commit/3c604e9f15606fa395b088ca341a232ffda2bb7d.diff

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

kito-cheng added a comment. > I'm not sure how the issues with datalayout in particular end up being an > issue in practice. > > clang shouldn't be writing out object files without a datalayout. > The code to infer alignment on load/store/etc. only exists for compatibility > with old bitcode/IR;

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

erichkeane added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:257 +return true; + case TemplateDecl::BuiltinTemplate: { +const auto *BT = cast(this); This seems strange to me that ONLY this one builtin is what makes a template a 'type ali

[PATCH] D133087: [clang-format] [doc] Fix example of wrapping class definitions

Passw added a comment. In D133087#3771637 , @HazardyKnusperkeks wrote: > Just a note, I had to edit your patch. Did you create it with git diff? Yes, I create this patch with `git diff` according to this guideline Requesting a review via the web interf

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

yaxunl added a comment. LGTM for HIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131465/new/ https://reviews.llvm.org/D131465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch that this was crashing! LGTM aside from the nit pointed out by @tbaeder. Can you also add a release note for the fix? Do you need someone to commit on your behalf? If

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Yoorkin updated this revision to Diff 458155. Yoorkin marked 5 inline comments as done. Yoorkin added a comment. Maybe renamed to bugprone-sprintf-with-fixed-size-buffer would be better. I add another option `FlagAllCalls` to flag all calls to `sprintf` and `vsprintf`. CHANGES SINCE LAST ACTION

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. Can someone take a look please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

erichkeane added a comment. Thanks for your patience, this was a sizable review that it took a while to be able to make time for. A handful of non-functional reviews, but the functionality looks fine. Comment at: clang/lib/AST/ASTContext.cpp:12139 +return X; + assert(de

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

erichkeane accepted this revision. erichkeane added a comment. I've got concerns about the interface not being clear on null-ability, and THIS patch seems to move us toward nulls being disallowed, so I'd like that formalized when possible (either via asserts or, better, by switching to referenc

[clang] e1ebe47 - Fix Clang Sphinx docs build

Author: Aaron Ballman Date: 2022-09-06T09:52:22-04:00 New Revision: e1ebe476e45a677535f8cae3cc9f7fb84f477fdd URL: https://github.com/llvm/llvm-project/commit/e1ebe476e45a677535f8cae3cc9f7fb84f477fdd DIFF: https://github.com/llvm/llvm-project/commit/e1ebe476e45a677535f8cae3cc9f7fb84f477fdd.diff

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

erichkeane added a comment. I'm not a great reviewer for coroutines as I don't quite get them, so a vastly better commit/review message would be GREATLY appreciated. Code seems fine, but I'd love for someone better at coroutines to take a look too. Comment at: clang/lib/Code

[PATCH] D132689: [Object] Refactor code for extracting offload binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dbc7cf7cac4: [Object] Refactor code for extracting offload binaries (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D132689?vs=455659&id=458162#toc Repository: rG LLVM Githu

[clang] 5dbc7cf - [Object] Refactor code for extracting offload binaries

Author: Joseph Huber Date: 2022-09-06T08:55:16-05:00 New Revision: 5dbc7cf7cac4428e0876a94a4fca10fe60af7328 URL: https://github.com/llvm/llvm-project/commit/5dbc7cf7cac4428e0876a94a4fca10fe60af7328 DIFF: https://github.com/llvm/llvm-project/commit/5dbc7cf7cac4428e0876a94a4fca10fe60af7328.diff

[clang] a69404c - [OffloadPackager] Add ability to extract images from other file types

Author: Joseph Huber Date: 2022-09-06T08:55:17-05:00 New Revision: a69404c0a294ce65432ce67d5f3e7dce28106496 URL: https://github.com/llvm/llvm-project/commit/a69404c0a294ce65432ce67d5f3e7dce28106496 DIFF: https://github.com/llvm/llvm-project/commit/a69404c0a294ce65432ce67d5f3e7dce28106496.diff

[PATCH] D132607: [OffloadPackager] Add ability to extract images from other file types

This revision was automatically updated to reflect the committed changes. Closed by commit rGa69404c0a294: [OffloadPackager] Add ability to extract images from other file types (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1326

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Yoorkin added a comment. I want to enable this check in both c and c++, but didn't find option `LangOpt.C`. For c++, we have option `LangOpt.CPlusPlus`. There is only some specific c standard option like `C99` `C11` `C17` and `C2X` defined in `LangOptions.def`. Could you tell me how to do this?

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin created this revision. ningvin added a reviewer: rsmith. ningvin added a project: clang. Herald added a project: All. ningvin requested review of this revision. Herald added a subscriber: cfe-commits. When running in MSVC compatibility mode, previously no deprecated copy operation warning

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

aaron.ballman added a comment. In D133349#3771780 , @serge-sans-paille wrote: > @aaron.ballman this is just a patch to start a discussion: We already have > the cmake rule to generate this file, so removing it from tree actually > doesn't break compila

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

akyrtzi created this revision. Herald added a subscriber: mgorny. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Directive `dependency_directives_scan::tokens_present_before_eof` is introduced to indic

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

akyrtzi updated this revision to Diff 458173. akyrtzi added a comment. Remove a couple of unused local variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133357/new/ https://reviews.llvm.org/D133357 Files: clang/include/clang/Lex/Dependenc

[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

mgorny created this revision. mgorny added reviewers: MaskRay, myhsu, vsk. Herald added subscribers: Enna1, StephenFan, dberris. Herald added a project: All. mgorny requested review of this revision. Fix the is_binutils_lto_supported() function to handle missing executables gracefully. Currently,

[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

mgorny added a comment. After reviewing this, please also approve backport to 15.x in https://github.com/llvm/llvm-project/issues/57580. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133358/new/ https://reviews.llvm.org/D133358 ___ cfe-commi

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki updated this revision to Diff 458176. yusuke-kadowaki marked 7 inline comments as done. yusuke-kadowaki added a comment. - Introduce new struct - Update document This change should be ok for everyone (I hope). BTW, please correct my English if any or create a whole new one for me

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 458177. dongjunduo added a comment. Rewrite test by checking output of -### Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:2930 + Style.ColumnLimit = 15; + EXPECT_EQ("int ab; // line\n" +"int a; // long\n" MyDeveloperDay wrote: > Why not verifyFormat here too and below? To

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ASTConsumer.h:54-59 + /// HandleTopLevelStmts - Handle the specified top-level statements. This is + /// called by the parser to process every top-level Stmt* in incremental + /// compilation mode. + ///

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. @dyung @steven_wu A newer diff has been submitted just now. Agree with @dyung. The test has been changed into checking the output of "-###". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added a comment. Precomit CI found valid failures that seem plausibly related to your changes, but Windows and Debian found different failures which is a bit of a surprise to me. Can you check those? Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_ena

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } inclyc wrote: > aaron.

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: >

[PATCH] D132192: [RISCV] Add '32bit' feature to rv32 only builtins.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, and +1 for the error message improvement, but could be separated patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132192/new/

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a suggestion to also document the command line reference. Thanks! Comment at: clang/include/clang/Driver/Options.td:2290 + MarshallingInfoNegativeFl

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:151 + llvm::Module &M = CGM.getModule(); + const auto *GlobalCtors = M.getNamedGlobal("llvm.global_ctors"); + if (!GlobalCtors) python3kgae wrote: > beanz wrote: > > python3kgae wrote

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 458186. jhuber6 added a comment. Changing to `linkonce` linkage. According to the LLVM spec this should have the expected behaviour where a single definition is kept at link-time for each module. I tested this with a sample `HIP` program and it had the desired

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

efriedma added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: > aaro

[clang] acb767f - [clang] fix profiling of template arguments of template and declaration kind

Author: Matheus Izvekov Date: 2022-09-06T18:27:39+02:00 New Revision: acb767f5cda59302aa9100afcf6133d66779d42c URL: https://github.com/llvm/llvm-project/commit/acb767f5cda59302aa9100afcf6133d66779d42c DIFF: https://github.com/llvm/llvm-project/commit/acb767f5cda59302aa9100afcf6133d66779d42c.dif

[PATCH] D133072: [clang] fix profiling of template arguments of template and declaration kind

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:5817 // fall back to just producing individual arguments. - Converted.insert(Converted.end(), - ArgumentPack.begin(), ArgumentPack.end()); + for (con

[PATCH] D133072: [clang] fix profiling of template arguments of template and declaration kind

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGacb767f5cda5: [clang] fix profiling of template arguments of template and declaration kind (authored by mizvekov). Change

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: > aaro

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

benlangmuir added inline comments. Comment at: clang/include/clang/Lex/DependencyDirectivesScanner.h:131 +/// \p dependency_directives_scan::tokens_present_before_eof, otherwise this +/// directive will be ignored. /// Why would you want to print without this? I

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added a comment. @aaron.ballman I think all of your concerns are addressed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 ___ cfe-commits mailing

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

serge-sans-paille added a comment. That's sounds like an "OK" to me, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133349/new/ https://reviews.llvm.org/D133349 ___ cfe-commits mailing list cfe-com

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

efriedma added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: > efri

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: > aaro

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D133349#3772353 , @serge-sans-paille wrote: > That's sounds like an "OK" to me, right? Yeah, this LGTM, thank you! Repository: r

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 _

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff updated this revision to Diff 458205. sepavloff added a comment. Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132867/new/ https://reviews.llvm.org/D132867 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff added a comment. In D132867#3771004 , @sammccall wrote: >> Strictly speaking this is incorrect behavior because file system object must >> be used for all operations on files, according to documentation. > > I don't think this is a strong argum

[clang] 94c6dfb - [clang] Implement setting crash_diagnostics_dir through env variable

Author: Matheus Izvekov Date: 2022-09-06T19:27:37+02:00 New Revision: 94c6dfbaebbd5b9474794b2437757dfb6aedefc3 URL: https://github.com/llvm/llvm-project/commit/94c6dfbaebbd5b9474794b2437757dfb6aedefc3 DIFF: https://github.com/llvm/llvm-project/commit/94c6dfbaebbd5b9474794b2437757dfb6aedefc3.dif

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG94c6dfbaebbd: [clang] Implement setting crash_diagnostics_dir through env variable (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1330

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

sepavloff updated this revision to Diff 458216. sepavloff added a comment. Change help message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133325/new/ https://reviews.llvm.org/D133325 Files: clang/docs/UsersManual.rst clang/include/clang/Dri

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ronlieb, tra, yaxunl. Herald added subscribers: kosarev, kerbowa, guansong, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, ss

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

ldionne added a comment. This is awesome. I have some comments, but I have not done an in-depth pass at this yet. Comment at: libcxx/docs/Contributing.rst:139 + +.. [#] There's `Dev meeting talk `__ + explaining the benefits of l

[PATCH] D132797: [clangd] Support renaming virtual methods

tom-anders updated this revision to Diff 458221. tom-anders added a comment. Add test case that triggers assertion, limit recursion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132797/new/ https://reviews.llvm.org/D132797 Files: clang-tools-ext

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3906 - (C.isOffloadingHostKind(Action::OFK_OpenMP) && - Args.hasFlag(options::OPT_fopenmp_new_driver, -options::OPT_no_offload_new_driver, true)) || The option still

[PATCH] D132797: [clangd] Support renaming virtual methods

tom-anders marked 6 inline comments as done. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:245 trace::Span Tracer("FindOccurrencesWithinFile"); assert(canonicalRenameDecl(&ND) == &ND && "ND should be already canonicaliz

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3906 - (C.isOffloadingHostKind(Action::OFK_OpenMP) && - Args.hasFlag(options::OPT_fopenmp_new_driver, -options::OPT_no_offload_new_driver, true)) || tra wrote: >

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:3906 - (C.isOffloadingHostKind(Action::OFK_OpenMP) && - Args.hasFlag(options::OPT_fopenmp_new_driver, -op

[clang] 57ef29f - [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

Author: Joseph Huber Date: 2022-09-06T13:40:05-05:00 New Revision: 57ef29f2835eb594bc2ad4793df05188be4c2ef6 URL: https://github.com/llvm/llvm-project/commit/57ef29f2835eb594bc2ad4793df05188be4c2ef6 DIFF: https://github.com/llvm/llvm-project/commit/57ef29f2835eb594bc2ad4793df05188be4c2ef6.diff

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG57ef29f2835e: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133367/new/

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

shafik added a comment. The proposal has several nice tests and I don't they are all covered here e.g.: { double a = 7; double b = 9; { double b = b * b; // undefined, uses uninitialized variable without address Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

aaron.ballman added a comment. Thank you for working on this! Comment at: clang/www/hacking.html:33 Testing on the Command Line +Testing changes affecting libcxx Similar capitalization is used in the file. Comment at:

[PATCH] D133371: [clang-tidy][WIP] create API for extracting option types.

njames93 created this revision. njames93 added reviewers: aaron.ballman, LegalizeAdulthood, gribozavr2, JonasToth. Herald added subscribers: carlosgalvezp, mgrang, kbarton, xazax.hun, nemanjai. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-t

[clang] 3a62399 - [OpenMP] Fix logic error when building offloading applications

Author: Joseph Huber Date: 2022-09-06T13:56:24-05:00 New Revision: 3a623999f3ff96843f97ee300e0c94b8cbc88a9f URL: https://github.com/llvm/llvm-project/commit/3a623999f3ff96843f97ee300e0c94b8cbc88a9f DIFF: https://github.com/llvm/llvm-project/commit/3a623999f3ff96843f97ee300e0c94b8cbc88a9f.diff

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

efriedma added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: > efri

[clang] 28bc410 - [DOC][Clang] Update cxx_status.html after the 15 release and fix a broken link in release notes

Author: Roy Jacobson Date: 2022-09-06T21:59:27+03:00 New Revision: 28bc41099970f5cdab0addc60cc96b115ce657f8 URL: https://github.com/llvm/llvm-project/commit/28bc41099970f5cdab0addc60cc96b115ce657f8 DIFF: https://github.com/llvm/llvm-project/commit/28bc41099970f5cdab0addc60cc96b115ce657f8.diff

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

philnik added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator. + -

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: > aaro

[PATCH] D132977: [HLSL] Call global constructors inside entry

aaron.ballman added inline comments. Comment at: clang/test/CodeGenHLSL/GlobalConstructors.hlsl:3 + +RWBuffer Buffer; + Can you also add a test using `__attribute__((constructor))`? And probably one using `__attribute__((destructor))` at some point as well? htt

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay updated this revision to Diff 458241. MaskRay added a subscriber: sammccall. MaskRay added a comment. Herald added subscribers: kadircet, arphaman. Herald added a project: clang-tools-extra. Rebase. This shall fix a clang/test test. Update clang-tools-extra/clangd/unittests/SelectionTests

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay added a subscriber: mgorny. MaskRay added inline comments. Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_enable_opaque_pointers = @CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL@ +config.clang_default_std_cxx = "@CLANG_DEFAULT_STD_CXX@" config.clang_default_cxx_stdli

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

efriedma added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: > efri

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:2930 + Style.ColumnLimit = 15; + EXPECT_EQ("int ab; // line\n" +"int a; // long\n" yusuke-kadowaki wrote: > MyDeveloperDay wrote: > > Why not verifyForm

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. Is Don'tAlign the same as Leave that other options support (for options i

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added inline comments. Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_enable_opaque_pointers = @CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL@ +config.clang_default_std_cxx = "@CLANG_DEFAULT_STD_CXX@" config.clang_default_cxx_stdlib = "@CLANG_DEFAULT_CXX_STDLIB

[PATCH] D133209: [clang] Document environment variables used by the driver

jansvoboda11 added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2-5 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by han

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but can you add a release note to clang/docs/ReleaseNotes.rst for the fix? Also, do you need someone to commit this on your behalf? If so, what name and email address would

[clang-tools-extra] 4450348 - [clang-tidy] Skip union-like classes in use-equals-default

Author: Alexander Shaposhnikov Date: 2022-09-06T20:19:47Z New Revision: 44503482e0af189d3a7fc57b80238ea4151992b9 URL: https://github.com/llvm/llvm-project/commit/44503482e0af189d3a7fc57b80238ea4151992b9 DIFF: https://github.com/llvm/llvm-project/commit/44503482e0af189d3a7fc57b80238ea4151992b9.d

  1   2   >