tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Driver/Driver.cpp:3906 - (C.isOffloadingHostKind(Action::OFK_OpenMP) && - Args.hasFlag(options::OPT_fopenmp_new_driver, - options::OPT_no_offload_new_driver, true)) || ---------------- jhuber6 wrote: > tra wrote: > > The option still exists in the `Options.td` file. Should it be removed? > Generally we don't remove the options once they've been defined (between > releases), as this would result in some applications failing to compile after > switching from LLVM 15 to LLVM 16 for example. If we just leave it there then > it will exist as a warning saying that the flag was unused. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133367/new/ https://reviews.llvm.org/D133367 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
