ldionne added a comment.

This is awesome. I have some comments, but I have not done an in-depth pass at 
this yet.



================
Comment at: libcxx/docs/Contributing.rst:139
+
+.. [#] There's `Dev meeting talk 
<https://www.youtube.com/watch?v=B7gB6van7Bw>`__
+   explaining the benefits of libc++'s pre-commit CI.
----------------



================
Comment at: libcxx/docs/Contributing.rst:142
+
+Builds
+------
----------------
It feels like this whole section might be prone to becoming out of date. I'm 
not sure how useful it is since the jobs are pretty self-explanatory. Perhaps 
it is sufficient to link to `run-buildbot` and `buildkite-pipeline.yml`?


================
Comment at: libcxx/docs/Contributing.rst:145
+
+Below a short description of the most interesting CI builds [#]_:
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133249/new/

https://reviews.llvm.org/D133249

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to