[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 446842. samestep added a comment. Address Yitzie's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis/FlowSensitive/Dataf

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:220 + assert(Body != nullptr); + initGlobalVars(*Body, Env); + ymandel wrote: > samestep wrote: > > ymandel wrote: > > > I wonder how this will work between cal

[clang] aed1ab8 - [clang][dataflow] Refactor ApplyBuiltinTransfer field out into DataflowAnalysisOptions struct

Author: Sam Estep Date: 2022-07-22T15:16:29Z New Revision: aed1ab8cabac64b59338f5ebadd12a371cb2ee5d URL: https://github.com/llvm/llvm-project/commit/aed1ab8cabac64b59338f5ebadd12a371cb2ee5d DIFF: https://github.com/llvm/llvm-project/commit/aed1ab8cabac64b59338f5ebadd12a371cb2ee5d.diff LOG: [cl

[PATCH] D130305: [clang][dataflow] Refactor ApplyBuiltinTransfer field out into DataflowAnalysisOptions struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaed1ab8cabac: [clang][dataflow] Refactor ApplyBuiltinTransfer field out into… (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES

[clang] effe799 - [CUDA] remove duplicate condition

Author: VitalyR Date: 2022-07-22T11:27:19-04:00 New Revision: effe79993f8e0bd13181fcf660a47ed7044a83c3 URL: https://github.com/llvm/llvm-project/commit/effe79993f8e0bd13181fcf660a47ed7044a83c3 DIFF: https://github.com/llvm/llvm-project/commit/effe79993f8e0bd13181fcf660a47ed7044a83c3.diff LOG:

[PATCH] D130168: [CUDA] remove duplicate condition

This revision was automatically updated to reflect the committed changes. Closed by commit rGeffe79993f8e: [CUDA] remove duplicate condition (authored by VitalyR, committed by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130168/new/ https:

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added a comment. In D90275#3671019 , @nlopes wrote: > Could you please add a description of this attribute to LangRef? > We need the semantics of this. > > Thank you! Sure, I'll do that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedEl

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:35 +template class ArrayRef; + Should be `typename T`. `class T` is archaic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1302

[PATCH] D125529: Revert MSVC compatibility feature that breaks conformant code

thakis resigned from this revision. thakis added a comment. This can be closed, it landed elsewhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125529/new/ https://reviews.llvm.org/D125529 ___ cfe-com

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. @MaskRay Would you please merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 446855. samestep added a comment. Fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnv

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:220 + assert(Body != nullptr); + initGlobalVars(*Body, Env); + samestep wrote: > ymandel wrote: > > samestep wrote: > > > ymandel wrote: > > > > I wonder how thi

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3671568 , @aaron.ballman wrote: > In D129048#3670212 , @ldionne wrote: > >> The libc++ CI runs pre-commit only, and it runs on all commits that touch >> something under `

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:231 + // parameters still need to be given `StorageLocation`s anyway, so this code + // will need to be generalized later. + for (; ArgIt != ArgEnd; ++ParamIt, ++ArgIt) { ---

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3671665 , @erichkeane wrote: > In D129048#3671657 , @ldionne wrote: > >> In D129048#3671568 , >> @aaron.ballman wrote: >> >>> FW

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3671657 , @ldionne wrote: > In D129048#3671568 , @aaron.ballman > wrote: > >> FWIW, I've convinced myself that I agree with you here that the burden >> probably should ha

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org/D118996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D129864: [Flang] Generate documentation for compiler flags

awarzynski added a comment. LGTM, thanks! (feel free to address my [nit] when merging or ignore altogether) Comment at: flang/docs/CMakeLists.txt:128 + set(CLANG_TABLEGEN_EXE clang-tblgen) + gen_rst_file_from_td(FlangCommandLineReference.rst -gen-opt-docs ../incl

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

tahonermann added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2925-2926 for (unsigned I = 0, E = readInt(); I != E; ++I) -Attrs.push_back(readAttr()); +if (auto *Attr = readAttr()) + Attrs.push_back(Attr); } Interesting

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

tejohnson added inline comments. Comment at: llvm/lib/LTO/ThinLTOCodeGenerator.cpp:456 + updatePublicTypeTestCalls(TheModule, +/* WholeProgramVisibilityEnabledInLTO */ false); Add a comment to see note at call to updateVCallVisibili

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov updated this revision to Diff 446883. ilya-biryukov added a comment. - Update diagnostics per Richard's suggestions, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128921/new/ https://reviews.llvm.org/D128921 Files: clang/

[libclc] 44f81df - Remove references to old mailing lists that have moved to discourse. Replace with links to discourse.

Author: tlattner Date: 2022-07-22T09:59:03-07:00 New Revision: 44f81dfba407c82589abbb5867714ad030d1b80c URL: https://github.com/llvm/llvm-project/commit/44f81dfba407c82589abbb5867714ad030d1b80c DIFF: https://github.com/llvm/llvm-project/commit/44f81dfba407c82589abbb5867714ad030d1b80c.diff LOG:

[clang] 846439d - [Flang] Generate documentation for compiler flags

Author: Dylan Fleming Date: 2022-07-22T17:05:04Z New Revision: 846439dd97d45e0e08af14269708511646a9add1 URL: https://github.com/llvm/llvm-project/commit/846439dd97d45e0e08af14269708511646a9add1 DIFF: https://github.com/llvm/llvm-project/commit/846439dd97d45e0e08af14269708511646a9add1.diff LOG:

[PATCH] D129864: [Flang] Generate documentation for compiler flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG846439dd97d4: [Flang] Generate documentation for compiler flags (authored by DylanFleming-arm). Changed prior to commit: https://reviews.llvm.org/D129864?vs=446840&id=446889#toc Repository: rG LLVM G

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. Sorry, was out again due to an emergency. So I wanted to give a chance for any last comments despite having an LGTM I plan to land this on Monday. Comment at: clang/lib/Sema/SemaTemplate.cpp:8694-86

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, NoQ, steakhal, balazske. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a pr

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 added a comment. In D129872#3671847 , @ABataev wrote: > Why does it get truncated if the type must be integer? Probably, something > incorrect in sema. This is only failed with C. But not for C++. So I don't think we have problem for Seam. I ma

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

nhaehnle added a comment. In D130224#3668225 , @aaron.ballman wrote: > I'm in C standards meetings this week and don't have a lot of ability to > thoroughly review this yet, but the most immediate concern which springs to > mind for me is that this is

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

shafik added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18886 + InitVal.getActiveBits() ? InitVal.getActiveBits() : 1; + NumPositiveBits = std::max(NumPositiveBits, ActiveBits); +} else erichkeane wrote: > What about: > > `std::ma

[clang-tools-extra] 30360d8 - [clang-doc] Add check for pointer validity

Author: Paul Kirth Date: 2022-07-22T17:36:30Z New Revision: 30360d88d42214e75215145c4e73a74aaf93ddfd URL: https://github.com/llvm/llvm-project/commit/30360d88d42214e75215145c4e73a74aaf93ddfd DIFF: https://github.com/llvm/llvm-project/commit/30360d88d42214e75215145c4e73a74aaf93ddfd.diff LOG: [c

[PATCH] D130279: [clang-doc] Add check for pointer validity

This revision was automatically updated to reflect the committed changes. Closed by commit rG30360d88d422: [clang-doc] Add check for pointer validity (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130279/new/ https://reviews.

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

MaskRay added a comment. Testing and will push in one minute Comment at: clang/lib/CodeGen/CGObjCRuntime.h:37 namespace CodeGen { + class CGFunctionInfo; class CodeGenFunction; The style is to remove indentation. I'll fix it. Repository: rG LLVM Github

[PATCH] D130168: [CUDA] remove duplicate condition

VitalyR added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130168/new/ https://reviews.llvm.org/D130168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

jdoerfert added a comment. Generating freeze seems an option, just not sure we can easily get all locations with this approach. Anyway, some code comments below. Comment at: clang/lib/CodeGen/CGCall.cpp:2061 +} + } + return ArgHasMayBeUndefAttr; Early ex

[clang] 37502e0 - [clang][CodeGen] Only include ABIInfo.h where required (NFC)

Author: Sergei Barannikov Date: 2022-07-22T10:45:02-07:00 New Revision: 37502e042ff007972db0a03dd8c5e293c3219de3 URL: https://github.com/llvm/llvm-project/commit/37502e042ff007972db0a03dd8c5e293c3219de3 DIFF: https://github.com/llvm/llvm-project/commit/37502e042ff007972db0a03dd8c5e293c3219de3.d

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37502e042ff0: [clang][CodeGen] Only include ABIInfo.h where required (NFC) (authored by barannikov88, committed by MaskRay). Changed prior to commit

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

erichkeane added a comment. My concern with the 'num positive bits' is really that `enum EEmpty{};`, `enum EZero{ A =0 };`, and `enum ENeg {A = -1};` should all have 1 total bit of 'values'. So as long as THAT is true, I would expect this to be ok. I fear that sticking to the 'non-negative' de

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. In D130322#3672362 , @MaskRay wrote: > Testing and will push in one minute Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

ABataev added a comment. In D129872#3672332 , @jyu2 wrote: > In D129872#3671847 , @ABataev wrote: > >> Why does it get truncated if the type must be integer? Probably, something >> incorrect in sema. > > This is

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 446914. samestep added a comment. Don't allow globals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnv

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:220 + assert(Body != nullptr); + initGlobalVars(*Body, Env); + ymandel wrote: > samestep wrote: > > ymandel wrote: > > > samestep wrote: > > > > ymandel wrote:

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 446915. samestep added a comment. Update comment about default parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis/FlowS

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 updated this revision to Diff 446919. skc7 added a comment. Fixes as per review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130224/new/ https://reviews.llvm.org/D130224 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/lib/CodeG

[PATCH] D130299: [clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists

denis-fatkulin updated this revision to Diff 446916. denis-fatkulin added a comment. > Could you please add full git context? I updated the patch with properly git context. Thanks! > Was the problem due to misannotation of auto? If so, could you add an > annotator test? I'm not sure about the

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. I am still seeing the zstdConfig.cmake zstd-config.cmake warning. @ckissane @phosek will you fix it? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 _

[PATCH] D130377: Move "clang/Basic/TokenKinds.h" into a separate top-level module.

vsapsai created this revision. vsapsai added reviewers: sammccall, aprantl, jansvoboda11, iana. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes modular build fo

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

abrachet added a comment. In D128465#3672515 , @MaskRay wrote: > I am still seeing the > > zstdConfig.cmake > zstd-config.cmake > > warning. @ckissane @phosek will you fix it? :) I've quieted the warnings in https://github.com/llvm/llvm-project/comm

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Index/annotate-operator-call-expr.cpp:21 +// CHECK1: Punctuation: "(" [7:6 - 7:7] CallExpr=operator():3:7 +// CHECK1: Punctuation: ")" [7:7 - 7:8]

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

aaron.ballman added a comment. Ping Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129891/new/ https://reviews.llvm.org/D129891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Thanks! This is similar to D123241 Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

vsapsai added a comment. In D126731#3670896 , @sammccall wrote: > Hmm, I also don't know. > The idea here is that we specifically depend only on the TokenKind enum from > TokenKinds.h (which doesn't need any generated headers), not on other headers > fr

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

efriedma accepted this revision as: efriedma. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 ___ cfe-commits mailing l

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

shangwuyao created this revision. shangwuyao added reviewers: jlebar, mkuper, tra, yaxunl. Herald added subscribers: mattd, ThomasRaoux. Herald added a project: All. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch forc

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rT1c09bf48b36b: Update the test suite for changes to -Wint-conversion (authored by aaron.ballman). Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129891/new/ https://rev

[clang-tools-extra] 7068aa9 - Strengthen -Wint-conversion to default to an error

Author: Aaron Ballman Date: 2022-07-22T15:24:54-04:00 New Revision: 7068aa98412ade19a34b7ed126f4669f581b2311 URL: https://github.com/llvm/llvm-project/commit/7068aa98412ade19a34b7ed126f4669f581b2311 DIFF: https://github.com/llvm/llvm-project/commit/7068aa98412ade19a34b7ed126f4669f581b2311.diff

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

This revision was automatically updated to reflect the committed changes. Closed by commit rG7068aa98412a: Strengthen -Wint-conversion to default to an error (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ http

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 446945. lamb-j added a comment. Switching pointers to references, adding namespace comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 446946. lamb-j added a comment. Fixing header typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang/Driver/OffloadBundler.h clang/lib/Dri

[clang] 3ff86f9 - [NFC] Start saving InstantiatedFromDecl in non-template functions

Author: Erich Keane Date: 2022-07-22T12:37:14-07:00 New Revision: 3ff86f961094306d1a3f219a44614e9cfd1dbd6b URL: https://github.com/llvm/llvm-project/commit/3ff86f961094306d1a3f219a44614e9cfd1dbd6b DIFF: https://github.com/llvm/llvm-project/commit/3ff86f961094306d1a3f219a44614e9cfd1dbd6b.diff L

[clang] 70c62f4 - [NFC] give getParentFunctionOrMethod a 'Lexical' parameter

Author: Erich Keane Date: 2022-07-22T12:52:26-07:00 New Revision: 70c62f4cadbec132c4ab5f939648d10ca6338b15 URL: https://github.com/llvm/llvm-project/commit/70c62f4cadbec132c4ab5f939648d10ca6338b15 DIFF: https://github.com/llvm/llvm-project/commit/70c62f4cadbec132c4ab5f939648d10ca6338b15.diff L

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

li.zhe.hua added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:64 TypeErasedDataflowAnalysis(bool ApplyBuiltinTransfer) : Options({ApplyBuiltinTransfer}) {} Nit: `-Wmissing-field-initializers` is

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks

barannikov88 created this revision. Herald added a subscriber: dschuff. Herald added a project: All. barannikov88 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Swift calling conventions stands out in the way that they are lowered

[clang] 0b36a62 - [NFC] Add some additional features to MultiLevelTemplateArgumentList

Author: Erich Keane Date: 2022-07-22T13:05:42-07:00 New Revision: 0b36a62d5f3505e21692ae0abf25ef00836329e3 URL: https://github.com/llvm/llvm-project/commit/0b36a62d5f3505e21692ae0abf25ef00836329e3 DIFF: https://github.com/llvm/llvm-project/commit/0b36a62d5f3505e21692ae0abf25ef00836329e3.diff L

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks

barannikov88 updated this revision to Diff 446953. barannikov88 added a comment. Reword commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/Cod

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:64 TypeErasedDataflowAnalysis(bool ApplyBuiltinTransfer) : Options({ApplyBuiltinTransfer}) {} li.zhe.hua wrote: > Nit: `-Wmissing-fiel

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

mstorsjo added a comment. I don't find any existing instances of `CLANG_TOOLS_INSTALL_DIR` anywhere in the current monorepo - that doesn't seem right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130362/new/ https://reviews.llvm.org/D130362

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 446958. samestep added a comment. Appease -Wmissing-field-initializers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis/FlowSens

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130362/new/ https://reviews.llvm.org/D130362 ___

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10450 + +if (isAggregateTypeForABI(Ty)) { + return getNaturalAlignIndirect(Ty, /* byval */ true);

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

mstorsjo added a comment. In D130362#3672886 , @mstorsjo wrote: > I don't find any existing instances of `CLANG_TOOLS_INSTALL_DIR` anywhere in > the current monorepo - that doesn't seem right? (I looked in a slightly outdated working dir that I hadn't u

[clang] 31d8dbd - [CUDA/SPIR-V] Force passing aggregate type byval

Author: Shangwu Yao Date: 2022-07-22T20:30:15Z New Revision: 31d8dbd1e5b4ee0fd04bfeb3a64d8f9f33260905 URL: https://github.com/llvm/llvm-project/commit/31d8dbd1e5b4ee0fd04bfeb3a64d8f9f33260905 DIFF: https://github.com/llvm/llvm-project/commit/31d8dbd1e5b4ee0fd04bfeb3a64d8f9f33260905.diff LOG: [

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31d8dbd1e5b4: [CUDA/SPIR-V] Force passing aggregate type byval (authored by shangwuyao). Changed prior to commit: https://reviews.llvm.org/D130387

[clang] 6a1ccf6 - Revert "[NFC] Add some additional features to MultiLevelTemplateArgumentList"

Author: Nuno Lopes Date: 2022-07-22T21:33:22+01:00 New Revision: 6a1ccf61cdf80c793f9c699ada33af5d85263b30 URL: https://github.com/llvm/llvm-project/commit/6a1ccf61cdf80c793f9c699ada33af5d85263b30 DIFF: https://github.com/llvm/llvm-project/commit/6a1ccf61cdf80c793f9c699ada33af5d85263b30.diff LO

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

shangwuyao added a comment. Accidentally submitted early... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130387/new/ https://reviews.llvm.org/D130387 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

tra added a comment. In D130387#3672961 , @shangwuyao wrote: > Accidentally submitted early... The landed revision seems to have my comments addressed. Was there something missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

shangwuyao added a comment. In D130387#3672969 , @tra wrote: > In D130387#3672961 , @shangwuyao > wrote: > >> Accidentally submitted early... > > The landed revision seems to have my comments addressed. Was there

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

tra added a comment. It's OK. If something comes up you can address it in a follow-up patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130387/new/ https://reviews.llvm.org/D130387 ___ cfe-commits mai

[PATCH] D130377: Move "clang/Basic/TokenKinds.h" into a separate top-level module.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130377/new/ https://reviews.llvm.org/D130377 ___

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall added a comment. In D126731#3672666 , @vsapsai wrote: > In D126731#3670896 , @sammccall > wrote: > >> Hmm, I also don't know. >> The idea here is that we specifically depend only on the TokenKind enum f

[clang] 475e526 - [Driver][AArch64] Simplify -mtune

Author: Fangrui Song Date: 2022-07-22T14:19:27-07:00 New Revision: 475e526d85003404ba521e15f8acef1b439fb910 URL: https://github.com/llvm/llvm-project/commit/475e526d85003404ba521e15f8acef1b439fb910 DIFF: https://github.com/llvm/llvm-project/commit/475e526d85003404ba521e15f8acef1b439fb910.diff

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Arch/Sparc.cpp:121 +StringRef CPUName = A->getValue(); + +if (CPUName == "native") { delete blank line

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. Thank you for the review! Before I push the change into main I may add an entry to `clang/docs/ReleaseNotes.rst`, right? And do you agree that the test failures are unrelated to my change? It looks like they are all located in `libomptarget` caused by a linker error

[clang] b797834 - [lldb/Fuzzer] Add fuzzer for expression evaluator

Author: Chelsea Cassanova Date: 2022-07-22T17:32:00-04:00 New Revision: b797834748f1954950880bf50fb78abedd4494e6 URL: https://github.com/llvm/llvm-project/commit/b797834748f1954950880bf50fb78abedd4494e6 DIFF: https://github.com/llvm/llvm-project/commit/b797834748f1954950880bf50fb78abedd4494e6.d

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

This revision was automatically updated to reflect the committed changes. Closed by commit rGb797834748f1: [lldb/Fuzzer] Add fuzzer for expression evaluator (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D129377?vs=444761&id=446982#toc Repository: rG LLVM Github M

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

gribozavr created this revision. Herald added subscribers: martong, tschuett, mgrang, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Start by dumping the flow

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

xazax.hun added a comment. In D130306#3671852 , @samestep wrote: > In D130306#3670259 , @xazax.hun > wrote: > >> > > Yes, we considered a summary-based approach, but we decided not to use it > because (as you m

[clang] 12fbd2d - [Driver][test] Clean up and improve some -mtune tests

Author: Fangrui Song Date: 2022-07-22T14:37:58-07:00 New Revision: 12fbd2d377e396ad61bce56d71c98a1eb1bebfa9 URL: https://github.com/llvm/llvm-project/commit/12fbd2d377e396ad61bce56d71c98a1eb1bebfa9 DIFF: https://github.com/llvm/llvm-project/commit/12fbd2d377e396ad61bce56d71c98a1eb1bebfa9.diff

[PATCH] D130399: [clang][dataflow] Expose stringification functions for SAT solver enums

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson updated this revision to Diff 446986. tejohnson marked 3 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128142/new/ https://reviews.llvm.org/D128142 Files: clang/lib/F

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson added inline comments. Comment at: clang/test/CodeGen/memprof.cpp:15 +// # Collect memory profile: +// $ clang++ -fuse-ld=lld -Wl,-no-pie -Wl,--no-rosegment -gmlt \ +// -fdebug-info-for-profiling -mno-omit-leaf-frame-pointer \ snehasish wrote: > Ju

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

gribozavr updated this revision to Diff 446988. gribozavr added a comment. Moved some changes to a different revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130398/new/ https://reviews.llvm.org/D130398 Files: clang/include/clang/Analysis/

[PATCH] D130400: [clang][dataflow] ArrayRef'ize debugString()

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[clang] a4df2da - [Driver][RISCV] Simplify -mtune

Author: Fangrui Song Date: 2022-07-22T14:51:07-07:00 New Revision: a4df2da173ba3907d652d24c9b4d8bb7d2ff447c URL: https://github.com/llvm/llvm-project/commit/a4df2da173ba3907d652d24c9b4d8bb7d2ff447c DIFF: https://github.com/llvm/llvm-project/commit/a4df2da173ba3907d652d24c9b4d8bb7d2ff447c.diff

[PATCH] D130399: [clang][dataflow] Expose stringification functions for SAT solver enums

gribozavr updated this revision to Diff 446991. gribozavr added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130399/new/ https://reviews.llvm.org/D130399 Files: clang/include/clang/Analysis/FlowSensitive/DebugSupport.h

[clang] 1f02ba4 - [Driver][SystemZ] Simplify -mtune

Author: Fangrui Song Date: 2022-07-22T14:54:27-07:00 New Revision: 1f02ba4843a519606a3bdfd7e7a289f3d8c1c14b URL: https://github.com/llvm/llvm-project/commit/1f02ba4843a519606a3bdfd7e7a289f3d8c1c14b DIFF: https://github.com/llvm/llvm-project/commit/1f02ba4843a519606a3bdfd7e7a289f3d8c1c14b.diff

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

gribozavr updated this revision to Diff 446992. gribozavr added a comment. Reverted more changes broken out to separate revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130398/new/ https://reviews.llvm.org/D130398 Files: clang/include/cla

[clang] 8f0c901 - [Driver] Report -Wunused-command-line-argument for unimplemented -mtune=

Author: Fangrui Song Date: 2022-07-22T15:07:28-07:00 New Revision: 8f0c901c1a172313a32bc06a1fcface76cd1220f URL: https://github.com/llvm/llvm-project/commit/8f0c901c1a172313a32bc06a1fcface76cd1220f DIFF: https://github.com/llvm/llvm-project/commit/8f0c901c1a172313a32bc06a1fcface76cd1220f.diff

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:117-120 +for (const std::string &S : ConstraintsStrings) { + Result += S; + Result += '\n';

<    1   2   3   >