tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of nits.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:10450
+
+ if (isAggregateTypeForABI(Ty)) {
+ return getNaturalAlignIndirect(Ty, /* byval */ true);
----------------
I would add a comment that this is a CUDA-specific behavior with the pointer to
the relevant CUDA doc explaining what's going on.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:10450
+
+ if (isAggregateTypeForABI(Ty)) {
+ return getNaturalAlignIndirect(Ty, /* byval */ true);
----------------
tra wrote:
> I would add a comment that this is a CUDA-specific behavior with the pointer
> to the relevant CUDA doc explaining what's going on.
Style nit: LLVM does not use braces for single-statement body.
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130387/new/
https://reviews.llvm.org/D130387
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
