[PATCH] D129640: [clang][ASTImporter] Improved handling of functions with auto return type.

balazske updated this revision to Diff 446057. balazske marked 3 inline comments as done. balazske added a comment. Small code NFC improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129640/new/ https://reviews.llvm.org/D129640 Files: cl

[PATCH] D129640: [clang][ASTImporter] Improved handling of functions with auto return type.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3269-3273 +// Note: It is possible that T can be get as both a RecordType and a +// TemplateSpecializationType. + } + if (const auto *TST = T->getAs()) { +return llvm::count_if(TST->template_a

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added inline comments. Comment at: llvm/cmake/config-ix.cmake:149 + elseif(NOT LLVM_USE_SANITIZER MATCHES "Memory.*") +find_package(zstd) + endif() Since there's no `Findzstd.cmake` module shipped with CMake, and we don't provide in LLVM, we should

[PATCH] D130150: [pseudo] Eliminate multiple-specified-types ambiguities in the grammar.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Motivating case: `foo bar;` is not a declaration of nothing

[PATCH] D130150: [pseudo] Eliminate multiple-specified-types ambiguities in the grammar.

sammccall added a comment. I'm not sure that eliminating this in the grammar is the right technique vs guards, appreciate your thoughts. On clangd/AST.cpp, this reduces ambiguities from 1748->1400 (20%). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1528 } - + auto MainFilePath = + getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM); kadircet wrote: > let's just pass the TUPath from ClangdServer into the reque

[PATCH] D67025: Add .inl as valid C++ header type

nridge added a reviewer: sammccall. nridge added a subscriber: sammccall. nridge added a comment. Adding @sammccall as reviewer This is a simple change that would benefit clangd users (it just came up again recently, on Stack Overflow

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall updated this revision to Diff 446061. sammccall added a comment. rebase on function-declarator guards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130066/new/ https://reviews.llvm.org/D130066 Files: clang-tools-extra/pseudo/gen/Main.c

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc added a comment. Is the build error related to this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129573/new/ https://reviews.llvm.org/D129573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

iains added a subscriber: MaskRay. iains added a comment. makes sense to me... I guess the name looks long at first, but it's specific (I find that easy-to-remember flag names are more important than short-to-type ones, but maybe that's just me) - I wonder if @MaskRay has any comments on the fl

[PATCH] D130150: [pseudo] Eliminate multiple-specified-types ambiguities in the grammar.

sammccall planned changes to this revision. sammccall added a comment. As discussed offline: We agree on the goal of disallowing duplicate types in decl-specifier-seq, but the grammar changes are too intrusive if a guard-based approach can work instead. The concern with guards on `seq` nodes is

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

mizvekov added a comment. In D129573#3664905 , @inclyc wrote: > Is the build error related to this patch? I don't think so, it's not even close to what you are changing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129573/new/ https://reviews

[PATCH] D129640: [clang][ASTImporter] Improved handling of functions with auto return type.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3269-3273 +// Note: It is possible that T can be get as both a RecordType and a +// TemplateSpecializationType. + } + if (const auto *TST = T->getAs()) { +return llvm::count_if(TST->template_ar

[clang] 5a4033c - update-test-checks: safely handle tests with #if's

Author: Nicolai Hähnle Date: 2022-07-20T11:23:49+02:00 New Revision: 5a4033c36716de0cee75eb28b95cce44ae239cd9 URL: https://github.com/llvm/llvm-project/commit/5a4033c36716de0cee75eb28b95cce44ae239cd9 DIFF: https://github.com/llvm/llvm-project/commit/5a4033c36716de0cee75eb28b95cce44ae239cd9.diff

[PATCH] D130089: update-test-checks: safely handle tests with #if's

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. nhaehnle marked an inline comment as done. Closed by commit rG5a4033c36716: update-test-checks: safely handle tests with #if's (authored by nhaehnle). Changed prior to

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle added inline comments. Comment at: llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll:2 ; Check that we accept functions with '$' in the name. ; TODO: This is not handled correcly on 32bit ARM and needs to be fixed.

[PATCH] D130091: [clang][analyzer] Added partial wide character support to CStringChecker

martong added a comment. Nice improvement and the tests are meaningful! > clang/test/Analysis/cstring.c Hadn't we have already a test file for this checker? What about `string.c` and `bstring.c`? You might have added redundant test cases in the new test file. Comment at: cla

[PATCH] D129706: [NFCI][clang-tidy] Reimplement GlobList without relying on Regex.

njames93 updated this revision to Diff 446097. njames93 added a comment. Improve handling of consecutive wild cards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129706/new/ https://reviews.llvm.org/D129706 Files: clang-tools-extra/clang-tidy/G

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. @JDevlieghere @teemperor ping Can you please verify that everything works with LLDB, we just changed how those types are printed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

sammccall added a comment. In D112374#3657640 , @mizvekov wrote: > In general, I would not expect external tools to care about the shape of the > AST. I would expect the type API would be used in a way where we ignore a > type sugar node we have no reas

[PATCH] D129864: [Flang] Generate documentation for compiler flags

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. The change in ClangOptionDocEmitter.cpp is required for Flang as it heavily relies on these "include" flags defined in Options.td

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. Ok, I've made D130158 as an absolutely minimal change that seems to fix it for me. Basically, I'm skipping all the driver-related logic that's not strictly necessary when `LLVM_TOOL_LLVM_DRIVER_BUILD` is off. The driver remains broken w

[PATCH] D67025: Add .inl as valid C++ header type

aaron.ballman added a comment. > This seems to be a common practice. FWIW, I did a search over github repos and this file extension is used, but I would hardly call it a common practice (compared to other extensions we don't support, like `.inc`). It does seem to be used as a header-like file,

[PATCH] D67025: Add .inl as valid C++ header type

abbaswasim added a comment. > FWIW, I did a search over github repos and this file extension is used, but I > would hardly call it a common practice Fair enough. what would be sufficient evidence? I think in general whether its `.inl` or any other extension thats used to separate template impl

[PATCH] D67025: Add .inl as valid C++ header type

abbaswasim added a comment. Also I couldn't make the `-x` option to work with `lsp-mode` but that's not `clangd`s problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67025/new/ https://reviews.llvm.org/D67025 __

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. it looks good. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:102 llvm::StringRef Name = G.table().AttributeValues[EID]; - assert(!Name.empty()); Out.os

[PATCH] D67025: Add .inl as valid C++ header type

aaron.ballman added a comment. In D67025#3665301 , @abbaswasim wrote: >> FWIW, I did a search over github repos and this file extension is used, but >> I would hardly call it a common practice > > Fair enough. what would be sufficient evidence? I'm not c

[PATCH] D67025: Add .inl as valid C++ header type

abbaswasim added a comment. AFAICT Xcode understands and reads it as c++ header file. It highlights it fine and icon is "h+". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67025/new/ https://reviews.llvm.org/D67025 __

[PATCH] D67025: Add .inl as valid C++ header type

sammccall added a comment. (sorry i thought i sent these comments earlier) This is a change to clang rather than clangd, so it affects the behavior of the compiler and other clang-based tools. While it might do something useful in clangd, I'm skeptical of its general applicability because with

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc added a comment. Could you please review the latest patch ? I have removed some redundant test cases mentioned above CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129573/new/ https://reviews.llvm.org/D129573 ___ cfe-commits mailing li

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129635/new/ https://reviews.llvm.org/D129635 ___

[PATCH] D130160: [pseudo] Eliminate the dangling-else syntax ambiguity.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. - the grammar ambiguity is eliminate by a guard; - modify the guard function

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare created this revision. Herald added a project: All. jlegare requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Two options have been added: -finstrument-functions-exclude-function-list and -finstrument-functions-exclude-file-l

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17870 +/// parameter type and the same cv-qualifiers and ref-qualifier, if any. +bool AreSpecialMemberFunctionsSameKind(CXXMethodDecl *M1, CXXMethodDecl *M2, + Sema::CXXSpecialMember CSM

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jhenderson resigned from this revision. jhenderson added a comment. I'm not sure why I've been added as a reviewer, as I don't develop or review things within clang... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new/ https://reviews.llvm.

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added inline comments. Comment at: clang/lib/AST/Decl.cpp:4609 + + if (NumNegativeBits) { +unsigned NumBits = std::max(NumNegativeBits, NumPositiveBits + 1); How does this work if both NumNegativeBits and NumPositiveBits are 0? Based on my readi

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare added a subscriber: jhenderson. jlegare added a comment. @jhenderson Apologies, I'm new to the process here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new/ https://reviews.llvm.org/D130161 ___

[clang] 7169659 - [clang] Small adjustments for -fexperimental-library

Author: Louis Dionne Date: 2022-07-20T09:14:55-04:00 New Revision: 7169659752557aa107e3efe470ba988155ae3bbd URL: https://github.com/llvm/llvm-project/commit/7169659752557aa107e3efe470ba988155ae3bbd DIFF: https://github.com/llvm/llvm-project/commit/7169659752557aa107e3efe470ba988155ae3bbd.diff

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jhenderson added a comment. In D130161#3665527 , @jlegare wrote: > @jhenderson Apologies, I'm new to the process here. Usually, you should look at who has recently modified the touched files, or reviewed those same files, and add them as reviewers. Ofte

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

hans added a comment. Can you share the motivation for this? There's already an attribute to exclude functions from this instrumentation. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:524 /// instrumented with __cyg_profile_func_* calls -bool CodeGenFunction::ShouldInstru

[PATCH] D130130: [clang-tidy] Add an IgnoreMacros option to readability-avoid-const-params-in-decls

Eugene.Zelenko added a comment. Please mention changes in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130130/new/ https://reviews.llvm.org/D130130 ___ cfe-commits mailing list cfe-commit

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare added a comment. @jhenderson Thanks for the information, I appreciate it. @Hans Thank you for the comments. I'll be looking to address them later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new/ https://reviews.llvm.org/D130161

[PATCH] D130168: [CUDA] remove duplicate condition

VitalyR created this revision. Herald added subscribers: mattd, yaxunl. Herald added a project: All. VitalyR requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130168 Files: c

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare added a comment. @Hans However, to answer your question: the user may not be in a position to change the source where the troublesome functions are located, in order to add the attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13016

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. Hi, is there anything else I should do for this patch？ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 ___ cfe-commits mailing l

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446147. quinnp marked 6 inline comments as done. quinnp added a comment. Addressing review comments. Fixing the forwarding for -fno-function-sectons and removing the ObjectFormatType check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 7373497 - UNSUPPORT test on 64-bit AIX too

Author: Jake Egan Date: 2022-07-20T10:05:03-04:00 New Revision: 7373497a4b282e30b07d72fa601265a631f4c5c5 URL: https://github.com/llvm/llvm-project/commit/7373497a4b282e30b07d72fa601265a631f4c5c5 DIFF: https://github.com/llvm/llvm-project/commit/7373497a4b282e30b07d72fa601265a631f4c5c5.diff LOG

[clang] bd519b9 - redo UNSUPPORT test on 64-bit AIX too

Author: Jake Egan Date: 2022-07-20T10:18:28-04:00 New Revision: bd519b9335fe507bc2d2ebbbd3321ba046f038a3 URL: https://github.com/llvm/llvm-project/commit/bd519b9335fe507bc2d2ebbbd3321ba046f038a3 DIFF: https://github.com/llvm/llvm-project/commit/bd519b9335fe507bc2d2ebbbd3321ba046f038a3.diff LOG

[PATCH] D128927: [libc++] Always build c++experimental.a

hans added a comment. In D128927#3662659 , @ldionne wrote: > The weird part here is that you're configuring libc++, but you are building > neither the static nor the shared library. I don't understand why you do > that, and that may hide some other more

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added a comment. @aaron.ballman @erichkeane I think this should be on your radar, it would be great to have it in 15. I did review it and I think it looks good but there are enough dragons here that i'd rather have more eye balls on it. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

erichkeane added a comment. I believe the calculation of the constraints here means this isn't conforming with concepts. I believe this means we have to delay calculating the constraint differences until this property is actually queried, and cannot do it early like this has. ==

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. The more I look at this... the more I question my approach. I now am definitely sure we won't make Clang15, and hope that I can figure something better out for 16 :/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17870 +/// parameter type and the same cv-qualifiers and ref-qualifier, if any. +bool AreSpecialMemberFunctionsSameKind(CXXMethodDecl *M1, CXXMethodDecl *M2, + Sema::CXXSpecialMember

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 446172. royjacobson added a comment. Fixed the tests, fixed the type comparison checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/Releas

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 446173. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[PATCH] D130168: [CUDA] remove duplicate condition

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130168/new/ https://reviews.llvm.org/D130168 __

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3665249 , @sammccall wrote: > I've seen plenty of (useful) out-of-tree tidy checks written by people fuzzy > on the difference between a Type and a TypeLoc, or what sugar is. Clang makes > it (almost) easy to write t

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

mizvekov added a comment. It seems this change broke build on windows for me: clang-tools-extra\pseudo\lib\cxx\CXX.cpp(59): error C2838: 'noptr_declarator_0declarator_id': illegal qualified name in member declaration clang-tools-extra\pseudo\lib\cxx\CXX.cpp(59): error C2065: 'noptr_declarat

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks updated this revision to Diff 446179. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. A

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:595 + updatePublicTypeTestCalls(Mod, Conf.HasWholeProgramVisibility); + aeubanks wrote: > tejohnson wrote: > > aeubanks wrote: > > > I'm not sure where the best place to put these is > > I

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); royjacobson wrote: > erichkeane wr

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

mizvekov added a comment. I confirm reverting just this patch fixes the build for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129222/new/ https://reviews.llvm.org/D129222 ___ cfe-commits mailing li

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); cor3ntin wrote: > royjacobson wr

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); erichkeane wrote: > cor3ntin wrote

[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. This seems to have introduced a test which always fails on windows: $ ":" "RUN: at line 4" $ "cp" "clang\test\utils\update_cc_test_checks/Inputs/ifdef.c" "build\llvm\tools\clang\test\utils\update_cc_test_checks\Output\ifdef.test.tmp.c" $ "C:/Program Files (x86)/Mi

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); cor3ntin wrote: > erichkeane wro

[PATCH] D130130: [clang-tidy] Add an IgnoreMacros option to readability-avoid-const-params-in-decls

njames93 added a comment. Please can you upload your diff with full context(or use arcanist which does it for you). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130130/new/ https://reviews.llvm.org/D130130 ___

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/use-early-exits.rst:52 + many lines. Default value is `10`. \ No newline at end of file Please add newline. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129784: [HIP] Allow the new driver to compile HIP in non-RDC mode

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129784/new/ https://reviews.llvm.org/D129784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added a comment. In D130096#3663411 , @arsenm wrote: > In D130096#3663398 , @jhuber6 wrote: > >> In D130096#3663295 , @yaxunl wrote: >> >>> There is no constant pro

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/thinlto-distributed-type-metadata.cpp:22 // OPT-NOT: @llvm.type.test -// OPT-NOT: call void @llvm.assume // We should have only one @llvm.assume call, the one that was expanded aeubanks wrote: >

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 446197. njames93 added a comment. Add option to wrap early exit in braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-extra/clang-tidy/read

[PATCH] D130186: Addressing review comments.

jlegare created this revision. Herald added a project: All. jlegare requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Eliminated the (newly introduced) llvm::Function argument of ShouldInstrumentFunction() and used CurFuncDecl instead. Added

[PATCH] D130186: Addressing review comments.

jlegare abandoned this revision. jlegare added a comment. This was not supposed to be committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130186/new/ https://reviews.llvm.org/D130186 ___ cfe-commits

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9480 + AddGlobal("__oclc_ISA_version", Minor + Major * 1000, 32); + AddGlobal("__oclc_ABI_version", 400, 32); +} jhuber6 wrote: > yaxunl wrote: > > should be determined by the code objec

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/UseEarlyExitsCheck.cpp:217 + LineCountThreshold(Options.get("LineCountThreshold", 10U)), + WrapInBraces(Options.get("WrapInBraces", false)) {} + I have an idea that we

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 ___ c

[PATCH] D67025: Add .inl as valid C++ header type

nridge added a comment. In D67025#3665293 , @aaron.ballman wrote: > this is why we have the `-x` option so that users can specify a specific > language mode to use. Is there a reason that option does not suffice for > clangd? One reason is that the mos

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare updated this revision to Diff 446210. jlegare added a comment. Addressing review comments. - Dropped argument to ShouldInstrumentFunction(). - Added file name based exclusion, which had accidentally been left out of previous commit. - Added demangler. - Applied git clang-format. Reposi

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

MaskRay added a comment. Mostly looks good, with a nit in the test and some suggestion to the summary. In D129401#3662857 , @quinnp wrote: >> If this is for the legacy LTO interface, please state so. `lld/*/LTO.cpp` >> sets `c.Options.DataSections = tr

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare added a comment. @hans To address your concern about loose matching: I went with this approach because it fit my use-case. Do you think that an exact match would be more appropriate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new

[PATCH] D67025: Add .inl as valid C++ header type

MaskRay added a comment. I agree that this is not suitable in clang, but can be in clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67025/new/ https://reviews.llvm.org/D67025 ___ cfe-commits mailing

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

tra added a comment. In D129536#3663957 , @jdoerfert wrote: > @tra, unsure about the crash. For me this passes fine (no gpu), is anything > missing? The tests in the patch are running with `-emit-llvm`, so they are not actually lowering to NVPTX and th

[clang] 7e77d31 - [test] Remove unnecessary -verify-machineinstrs=0

Author: Arthur Eubanks Date: 2022-07-20T10:55:54-07:00 New Revision: 7e77d31af75e48e2ac7899026040a66fe601961a URL: https://github.com/llvm/llvm-project/commit/7e77d31af75e48e2ac7899026040a66fe601961a DIFF: https://github.com/llvm/llvm-project/commit/7e77d31af75e48e2ac7899026040a66fe601961a.diff

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); Ariel-Burton wrote: > rnk wrote: > > This seems like a good place to use getSingleStepD

[clang] a73a84c - [HLSL] add -I option for dxc mode.

Author: Xiang Li Date: 2022-07-20T11:03:22-07:00 New Revision: a73a84c44753402b33d619035d2c5acec3b04859 URL: https://github.com/llvm/llvm-project/commit/a73a84c44753402b33d619035d2c5acec3b04859 DIFF: https://github.com/llvm/llvm-project/commit/a73a84c44753402b33d619035d2c5acec3b04859.diff LOG:

[PATCH] D128462: [HLSL] add -I option for dxc mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa73a84c44753: [HLSL] add -I option for dxc mode. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.o

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. In D130096#3666155 , @yaxunl wrote: > The current patch does not consider HIP/OpenCL compile options, therefore the > value of these variables are not correct for OpenCL/HIP. They need to be > overridden by the variables with th

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare abandoned this revision. jlegare added a comment. I appear to have butchered something in trying to apply a patch. I will revisit and resubmit later when I've straightened things out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 446219. njames93 added a comment. Added logic to infer WrapInBraces option if unspecified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-extra

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); erichkeane wrote: > cor3ntin wr

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

egorzhdan updated this revision to Diff 446223. egorzhdan added a comment. - Add a test for OpenBSD - Modify existing test file instead of adding a new file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews.llvm.org/D129654

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay created this revision. MaskRay added reviewers: compnerd, jrtc27, kito.cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jone

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); royjacobson wrote: > erichkeane

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a comment. In D112374#3665989 , @mizvekov wrote: > If anyone wants to take a look at the new changes to lldb tests, be my guest. > Otherwise I will try to land this again soon. It might well be that we figure > out some other in-tree

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446228. quinnp marked an inline comment as done. quinnp added a comment. Addressing review comments. Changing test cases to use `llvm-objdump -t` instead of `obj2yaml`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); erichkeane wrote: > royjacobson

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp added a comment. In D129401#3666238 , @MaskRay wrote: > Mostly looks good, with a nit in the test and some suggestion to the summary. > > In D129401#3662857 , @quinnp wrote: > >>> If this is for the legacy

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); royjacobson wrote: > erichkeane

  1   2   >