hans added a comment.

In D128927#3662659 <https://reviews.llvm.org/D128927#3662659>, @ldionne wrote:

> The weird part here is that you're configuring libc++, but you are building 
> neither the static nor the shared library. I don't understand why you do 
> that, and that may hide some other more fundamental issue in your setup.

Yes, I wish we weren't weird.
The reason libc++ is part of our build is that we want the headers so that our 
newly built Clang will be able to build c++ files. 
https://bugs.chromium.org/p/chromium/issues/detail?id=1067216#c7 has the 
background for our current situation.

In https://github.com/llvm/llvm-zorg/pull/28 you mentioned that "for a couple 
of years now, Clang and libc++ are entirely separate projects w.r.t. how they 
are shipped on Apple platforms, and it doesn't make sense to build libc++ at 
the same time as Clang anymore".
Does that mean the libc++ headers have moved to the SDK now, and if so from 
what version? If it's in the SDK version we use (I'd have to check), perhaps 
that would allow us to stop building like this.

> Anyways, I think the issue should be resolved by 
> 1d0f79558ca47f50119fb38c62ff5afd3160d260 
> <https://reviews.llvm.org/rG1d0f79558ca47f50119fb38c62ff5afd3160d260>.

Yes, that fixed it for us. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128927/new/

https://reviews.llvm.org/D128927

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to