sammccall added inline comments.

================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1528
   }
-
+  auto MainFilePath =
+      getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM);
----------------
kadircet wrote:
> let's just pass the TUPath from ClangdServer into the request. (we should do 
> the same for `locateSymbolAt`, but on a separate change)
driveby: @kadircet any reason not to store the TUPath on ParsedAST? We already 
pass it to ParsedAST::build()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130041/new/

https://reviews.llvm.org/D130041

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to