[clang] 5fc6213 - Revert change to clang/test/CodeGen/arm_acle.c

Author: Nicolai Hähnle Date: 2022-07-19T09:11:23+02:00 New Revision: 5fc62135511069086e88f846f9bac2eb40b01e94 URL: https://github.com/llvm/llvm-project/commit/5fc62135511069086e88f846f9bac2eb40b01e94 DIFF: https://github.com/llvm/llvm-project/commit/5fc62135511069086e88f846f9bac2eb40b01e94.diff

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc updated this revision to Diff 445712. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129573/new/ https://reviews.llvm.org/D129573 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/Parse/ParseDecl.cpp clang/test/Parser/while-loop-outside-function.c clang/tes

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein updated this revision to Diff 445714. hokein marked 3 inline comments as done. hokein added a comment. restore the previous and simplified function-declarator test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129222/new/ https://reviews.ll

[clang-tools-extra] d489b38 - [pseudo] Implement a guard to determine function declarator.

Author: Haojian Wu Date: 2022-07-19T09:44:45+02:00 New Revision: d489b3807f096584175c321ce7f20e9dcd49b1da URL: https://github.com/llvm/llvm-project/commit/d489b3807f096584175c321ce7f20e9dcd49b1da DIFF: https://github.com/llvm/llvm-project/commit/d489b3807f096584175c321ce7f20e9dcd49b1da.diff LO

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd489b3807f09: [pseudo] Implement a guard to determine function declarator. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 4bb19de - [X86] Add 64 bit implement for __SSC_MARK

Author: Xiang1 Zhang Date: 2022-07-19T16:13:41+08:00 New Revision: 4bb19de4b6cbe56636a1e7cd9c53aae3dcf4d4b0 URL: https://github.com/llvm/llvm-project/commit/4bb19de4b6cbe56636a1e7cd9c53aae3dcf4d4b0 DIFF: https://github.com/llvm/llvm-project/commit/4bb19de4b6cbe56636a1e7cd9c53aae3dcf4d4b0.diff

[PATCH] D129826: [X86] [BugFix] Add 64 bit implement for __SSC_MARK

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bb19de4b6cb: [X86] Add 64 bit implement for __SSC_MARK (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

kadircet added a comment. thanks, this LG per symboldetails change but as discussed offline i think we actually need a new request or a capability to indicate this (and having a new request is just easier for both clients and clangd) otherwise it can't be reliably used by clients. in addition

[PATCH] D130063: [Driver] Enable sanitizers on FreeBSD AArch64

andrew created this revision. andrew added reviewers: Sanitizers, emaste, dim, arichardson. Herald added a subscriber: kristof.beyls. Herald added a project: All. andrew requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. These sanitize

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu added a comment. In D129748#3660684 , @aaron.ballman wrote: > The argument type is `TypeArgument`, not `TypdefType`. The guts of the > reading code for the preferred name attribute *should* be: Oh, My bad. I didn't mention it in the above res

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. > Personally I really wish that the build system issue can be fixed in the > upcoming 15.0.0 release and encourage distributions to use it to decrease > executable sizes. Me too, not because of multicall but because right now it's impossible to even build clang with mul

[PATCH] D129982: [clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest

owenpan updated this revision to Diff 445725. owenpan added a comment. Uploaded the correct diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129982/new/ https://reviews.llvm.org/D129982 Files: clang/unittests/Format/TokenAnnotatorTest.cpp Index: clang/unittests/Format/TokenAnnota

[PATCH] D130065: [X86] Use Min behavior for cf-protection-{return,branch}/ibt-seal module flags

MaskRay created this revision. MaskRay added reviewers: craig.topper, joaomoreira, pengfei, xiangzhangllvm. Herald added subscribers: jsji, StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The

[PATCH] D130063: [Driver] Enable sanitizers on FreeBSD AArch64

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, are there any tests that need to be enabled explicitly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130063/new/ https://reviews.llvm.org/D1300

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. After this, NUMERIC_CONSTANT and strings should parse only

[PATCH] D130063: [Driver] Enable sanitizers on FreeBSD AArch64

andrew added a comment. No tests, but D125883 , D125758 , and D125873 need to be committed first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. Hmm, I have another idea. Do you have individual LLVM static (or shared) libraries installed? On Gentoo we install only the dylib and a few unavoidable static libs: /usr/lib/llvm/15/lib64/libRemarks.so /usr/lib/llvm/15/lib64/libRemarks.so.15git /usr/lib/llvm/15/lib

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall updated this revision to Diff 445760. sammccall added a comment. reorder a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130066/new/ https://reviews.llvm.org/D130066 Files: clang-tools-extra/pseudo/gen/Main.cpp clang-tools-extra/

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

h-vetinari added a comment. Is it realistic for this to land before LLVM 15 branches? Would be great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 ___ cfe-co

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc updated this revision to Diff 445771. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129573/new/ https://reviews.llvm.org/D129573 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/Parse/ParseDecl.cpp clang/test/Parser/while-loop-outside-function.c clang/tes

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. Unfortunately, that doesn't seem to be it. I think at this point it would be easier for both of us if I tried to figure it out myself on Gentoo rather than trying to make it reproducible elsewhere. If you want, you could try grabbing e.g. a Gentoo stage3 image (e.g. via

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3662123 , @h-vetinari wrote: > Is it realistic for this to land before LLVM 15 branches? Would be great! that is the intention - I just got side-tracked with trying to replicate the test fails that got the commit rever

[PATCH] D130055: Clang extensions yolo, woot & kaboom

Szelethus added a subscriber: balazske. Szelethus added a comment. Yeah, I'm afraid no fun is allowed on this block. On another note, `kaboom` is interesting, shouldn't we assume all functions to be `kaboom` unless proven to be `woot`? @balazske's work on checking the return value of certain fu

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt

mgehre-amd abandoned this revision. mgehre-amd added a comment. Instead of linking to libbitint, I instead created a backend pass to transform div/rem instructions: https://reviews.llvm.org/D130076 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1222

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski created this revision. awarzynski added a reviewer: tarunprabhu. Herald added a reviewer: sscalpone. Herald added a project: All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The updated name better reflects

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 445792. Sockke added a comment. Added test cases where there is a struct with an anonymous union and another field that does need an initializer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: cl

[PATCH] D130004: [pseudo] Add `clang-pseudo -html-forest=`, an HTML forest browser

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Super cool! Can't wait to use it. The code looks good, just nits (feel free to ignore) Comment at: clang-tools-extra/pseudo/tool/CMakeLists.txt:29 +add_custom_target(clang-p

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

tarunprabhu accepted this revision. tarunprabhu added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130078/new/ https://reviews.llvm.org/D130078

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:370 +def note_constexpr_unscoped_enum_out_of_range : Note< + "store of value outside of the range of unscoped enum, valid values %0 to %1">; def err_experimental_clang_interp_failed :

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

quinnp added a comment. In D129855#3657006 , @MaskRay wrote: > This is not right as using `ld.lld` as the default linker isn't the majority > case. If you want to change the default for your distribution, set > `-DCLANG_DEFAULT_LINKER=lld`. > (Alternati

[PATCH] D130081: Add foldings for multi-line comment.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:176 // FIXME(kirillbobyrev): Collect comments, PP conditional regions, includes and // other code regions (e.g. public/private/protected sections of classes, nit: update

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The change looks good to me. > as discussed offline i don't see much value in having an extra flag to choose > between ast-based and pseudo-based implementation, as the pseudo-based one is >

[PATCH] D130055: Clang extensions yolo, woot & kaboom

beanz added a comment. In D130055#3662206 , @Szelethus wrote: > On another note, `kaboom` is interesting, shouldn't we assume all functions > to be `kaboom` unless proven to be `woot`? I won’t claim to have spent a whole lot of time thinking on this. Th

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

erichkeane added a comment. I'll note that I don't "like" the idea, so much as I see this patch as an 'improvement' to unblock efforts with additional value, though not much of one. I suspect as Aaron does that there is a significant problem that needs fixing here with how our serialization wo

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13533 + + if (NumNegativeBits) { +unsigned NumBits = std::max(NumNegativeBits, NumPositiveBits + 1); erichkeane wrote: > So my reading of 'within the range of the en

[PATCH] D129014: rewording static_assert to more generic static assertion

Codesbyusman added a comment. *ERR_CLOSED: This revision has already been closed* @Shivam Gupta https://reviews.llvm.org/D129014>+public+5e9f0937aab6a...@reviews.llvm.org> can not update the patch. it seems it is closed. F23843528: image003.png F23843527: i

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle created this revision. nhaehnle added reviewers: MaskRay, arsenm, aemerson, arichardson. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. nhaehnle requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added projects: clang,

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added a comment. The weird part here is that you're configuring libc++, but you are building neither the static nor the shared library. I don't understand why you do that, and that may hide some other more fundamental issue in your setup. Anyways, I think the issue should be resolved by

[clang] 7300a65 - [libc++] Re-apply "Always build c++experimental.a""

Author: Louis Dionne Date: 2022-07-19T10:44:19-04:00 New Revision: 7300a651f5f3b43f9fa3a2d9927322b0e061fcb2 URL: https://github.com/llvm/llvm-project/commit/7300a651f5f3b43f9fa3a2d9927322b0e061fcb2 DIFF: https://github.com/llvm/llvm-project/commit/7300a651f5f3b43f9fa3a2d9927322b0e061fcb2.diff

[PATCH] D128927: [libc++] Always build c++experimental.a

This revision was automatically updated to reflect the committed changes. Closed by commit rG7300a651f5f3: [libc++] Re-apply "Always build c++experimental.a"" (authored by ldionne). Changed prior to commit: https://reviews.llvm.org/D128927?vs=443344&id=445822#toc Repository: rG LLVM Github M

[PATCH] D130029: [analyzer][NFC] Use `SValVisitor` instead of explicit helper functions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130029/new/ https://reviews.llvm.org/D130029

[PATCH] D130091: [clang][analyzer] Added partial wide character support to CStringChecker

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445835. quinnp marked an inline comment as done. quinnp added a comment. Fixing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files: clang/lib/Driver/To

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp added a comment. > If this is for the legacy LTO interface, please state so. `lld/*/LTO.cpp` > sets `c.Options.DataSections = true;` to enable data sections by default. Hey @MaskRay, I'm not sure what is considered the legacy LTO interface, but this change is to make the `libLTO` codege

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. Ok, I think the key to reproducing it is `-DLLVM_LINK_LLVM_DYLIB=ON`. We pass that while building LLVM, so it gets passed on to clang but I suppose passing it to clang build might be sufficient to reproduce the problem. The actual problem is that you're passing `${USE_SH

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445839. quinnp added a comment. Modifying a test to fix check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files: clang/lib/Driver/ToolChains/CommonArgs.cp

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - C

[clang] a62868a - [libclang][ObjC] Inherit availability attribute from containing decls or

Author: Akira Hatanaka Date: 2022-07-19T09:17:39-07:00 New Revision: a62868aaeaac1c6464a3acbc90209458e4594338 URL: https://github.com/llvm/llvm-project/commit/a62868aaeaac1c6464a3acbc90209458e4594338 DIFF: https://github.com/llvm/llvm-project/commit/a62868aaeaac1c6464a3acbc90209458e4594338.diff

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd updated this revision to Diff 445845. abrahamcd marked 5 inline comments as done. abrahamcd edited the summary of this revision. abrahamcd added a comment. Update test file to check for warning and address other minor comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D129504: [libclang][ObjC] Inherit availability attribute from containing decls or interface decls

This revision was automatically updated to reflect the committed changes. Closed by commit rGa62868aaeaac: [libclang][ObjC] Inherit availability attribute from containing decls or (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

royjacobson added a comment. In D128750#3661576 , @ychen wrote: > ... > There is *no* way to reorder the template parameters list again (to get two > or more reordering) and the resulted template still works, because of the > *positionally correspond* r

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, yaxunl, saiislam, arsenm, carlo.bertolli, MaskRay, jdoerfert, tianshilei1992. Herald added subscribers: kosarev, StephenFan, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. Let me know if I should move this code somewhere else, or if there are problems. One change I made is that the constant is `weak_odr` and `hidden` instead of `linkonce_odr` and `protected`. This is so this constant is alive until link time, AMDGPU pretty much always use

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 445853. pscoro added a comment. formatted comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp Index: llvm/l

[PATCH] D129048: Rewording the "static_assert" to static assertion

xgupta added a comment. In D129048#3662634 , @Codesbyusman wrote: > the libcxx updates but not tested. working on them I just run the check-cxx on local system. It seems to pass all testcases after applying the current patch. Testing Time: 2147.75s

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

ldionne marked 12 inline comments as done. ldionne added a comment. In D121141#3658946 , @phosek wrote: > That's correct, I implemented the support for `-stdlib=libc++` on MSVC > targets in D101479 , but that change caus

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

ldionne updated this revision to Diff 445859. ldionne marked 2 inline comments as done. ldionne added a comment. Address most review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141 Files: clan

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3662972 , @xgupta wrote: > In D129048#3662634 , @Codesbyusman > wrote: > >> the libcxx updates but not tested. working on them > > I just run the check-cxx on local system

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

JonChesterfield added a reviewer: b-sumner. JonChesterfield added a comment. Tagging Brian as the code owner of rocm device libs - emitting these in clang would simplify that library. Currently clang reads these commandline flags and conditionally links in bitcode files to introduce these symbo

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added a comment. I've thought that directly emitting these constants would be better. This will also make it so you can't try to continue using llvm-link for these libraries, which is a plus since it doesn't have the same necessary attribute propagation clang does when linking these Re

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

martong added a comment. In D112621#3660256 , @manas wrote: > Considering @ASDenysPetrov 's example of `LHS = [1, 2] U [8, 9]` and `RHS = > [5, 6]`, I constructed a test case as following: > > `(((u1 >= 1 && u1 <= 2) || (u1 >= 8 && u1 <= 9)) && u2 >= 5 &

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 445863. lamb-j added a comment. Moving classes into clang namespace, more specific name for config class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. In D130096#3663010 , @JonChesterfield wrote: > Tagging Brian as the code owner of rocm device libs - emitting these in clang > would simplify that library. > > Currently clang reads these commandline flags and conditionally link

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9456 +llvm::ConstantInt::get(Type, Value), Name, nullptr, +llvm::GlobalValue::ThreadLocalMode::NotThreadLocal, 4); +GV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Local); --

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

JonChesterfield added a comment. A safer bet is to use the current control flow that links in specific bitcode files, but create the global directly instead of linking in the file. That'll give us zero semantic change and a clang that ignores those bitcode files if present. Repository: rG L

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

jdoerfert updated this revision to Diff 445864. jdoerfert added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129536/new/ https://reviews.llvm.org/D129536 Files: clang/lib/Headers/__clang_cuda_intrinsics.h clang/tes

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. In D130096#3663062 , @JonChesterfield wrote: > A safer bet is to use the current control flow that links in specific bitcode > files, but create the global directly instead of linking in the file. That'll > give us zero semanti

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 445865. lamb-j added a comment. Bug fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang/Driver/OffloadBundler.h clang/lib/Driver/CMakeLi

[PATCH] D129864: [Flang] Generate documentation for compiler flags

DylanFleming-arm updated this revision to Diff 445872. DylanFleming-arm added a comment. Edited summary to be more clear. I've also changed the format of the if(!included) as you suggested (and did the same for the call to isGroupIncluded) I also added the assert you asked for, and then since t

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5128 +// to the function itself; it points to a stub for the compiler. +// FIXME: We also need to emit an entry thunk. +SmallString<256> MangledName; bcl5980 wrote: > A he

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

dgoldman updated this revision to Diff 445873. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130095/new/ https://reviews.llvm.org/D130095 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clan

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3662898 , @royjacobson wrote: > but in your example with T/U/V we have 3 template parameters that we could > reorder in 6 different ways. But, any reordering of the 6 that does not have consecutive U and V is not val

[PATCH] D130055: Clang extensions yolo, woot & kaboom

jkorous added a comment. Hi Chris! This is a very interesting idea! I do have couple thoughts - mostly that this could lead to something great and I would love it to apply to as many relevant cases as possible. It looks like there is a possibility that a free function, static method or a metho

[PATCH] D130055: Clang extensions yolo, woot & kaboom

beanz added a comment. In D130055#3663164 , @jkorous wrote: > It looks like there is a possibility that a free function, static method or a > method of another class (a `friend`?) should be `woot` for a specific > pointer/reference parameter. Oh! That'

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

leonardchan accepted this revision. leonardchan added a comment. LGTM tested on mac on my end Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits ma

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe939bf67e340: [llvm] add zstd to `llvm::compression` namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D130004: [pseudo] Add `clang-pseudo -html-forest=`, an HTML forest browser

sammccall marked 7 inline comments as done. sammccall added a comment. Thanks for the review! Comment at: clang-tools-extra/pseudo/tool/CMakeLists.txt:29 +add_custom_target(clang-pseudo-resources DEPENDS HTMLForestResources.inc) +add_dependencies(clang-pseudo clang-pseudo-resou

[PATCH] D130004: [pseudo] Add `clang-pseudo -html-forest=`, an HTML forest browser

sammccall updated this revision to Diff 445884. sammccall marked 6 inline comments as done. sammccall added a comment. review changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130004/new/ https://reviews.llvm.org/D130004 Files: clang-tools-e

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

ASDenysPetrov added a comment. In D112621#3660256 , @manas wrote: > Is there any other way to formulate the expression so that it constructs `LHS > = [1, 2] U [8, 9]` and doesn't bifurcate? Try this `u1 > 0 && u1 < 10 && u1 != 3 && u1 != 4 && u1 != 5 &&

[PATCH] D109977: LLVM Driver Multicall tool

MaskRay added a comment. In D109977#3662859 , @mgorny wrote: > Ok, I think the key to reproducing it is `-DLLVM_LINK_LLVM_DYLIB=ON`. We pass > that while building LLVM, so it gets passed on to clang but I suppose passing > it to clang build might be suf

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

tejohnson added a comment. Thanks for implementing this! In D71913 , I also modified this code, which might need something similar: https://github.com/llvm/llvm-project/blob/59afc4038b1096bc6fea7b322091f6e5e2dc0b38/clang/lib/CodeGen/ItaniumCXXABI.cpp#L707-L713

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 445890. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-to

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:351 +int c; +[[// A comment +// expanding more than hokein wrote: > For this case, my personal preference would be to have 3 differ

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added a comment. There is no constant propagation for globals with weak linage, right? Otherwise, it won't work. My concern is that there may be optimization passes which do not respect the weak linkage and uses the incorrect default value for OpenCL or HIP. Therefore I am not very confi

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

aaron.ballman added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4009-4011 +if (StringRef(A->getValue()) == "sarif") { + D.Diag(diag::warn_drv_sarif_format_unstable); +} Do we want to be kind to people who spell it SARIF (given

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 445893. usaxena95 added a comment. Do not fill Kind in JSON when it is unspecified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-tools-extra/clang

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

cjdb added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4009-4011 +if (StringRef(A->getValue()) == "sarif") { + D.Diag(diag::warn_drv_sarif_format_unstable); +} aaron.ballman wrote: > Do we want to be kind to people who spell it

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 marked an inline comment as done. jhuber6 added a comment. In D130096#3663295 , @yaxunl wrote: > There is no constant propagation for globals with weak linage, right? > Otherwise, it won't work. My concern is that there may be optimization passes

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. Note I took my range generation code from `CGExpr.cpp` function `getRangeForType(...)` I was considering perhaps making the code common, maybe this could be a helper in `EnumDecl`? Does that makes sense? Comment at: clang/lib/AST/ExprConstant.cpp:13512

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13527 + llvm::APInt Min; + llvm::APInt End; + Why "End" instead of max? Comment at: clang/lib/AST/ExprConstant.cpp:13533 + + if (NumNegative

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. In D130096#3663295 , @yaxunl wrote: > There is no constant propagation for globals with weak linage, right? > Otherwise, it won't work. My concern is that there may be optimization passes > which do not respect the weak linkage

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added a comment. In D130096#3663398 , @jhuber6 wrote: > In D130096#3663295 , @yaxunl wrote: > >> There is no constant propagation for globals with weak linage, right? >> Otherwise, it won't work. My concer

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis created this revision. Maetveis added a project: clang-format. Herald added a subscriber: arphaman. Herald added a project: All. Maetveis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When --staged (or --cached) use the index for

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. In D130096#3663411 , @arsenm wrote: > In D130096#3663398 , @jhuber6 wrote: > >> In D130096#3663295 , @yaxunl wrote: >> >>> There is no constant pr

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

ldionne added a comment. Windows seems to have been "fixed" (a band-aid really), and the Linux failure seems unrelated, so I'll ship this now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. In D130096#3663062 , @JonChesterfield wrote: > A safer bet is to use the current control flow that links in specific bitcode > files, but create the global directly instead of linking in the file. That'll > give us zero semanti

[clang] ca495e3 - [clang] Add a new flag -fexperimental-library to enable experimental library features

Author: Louis Dionne Date: 2022-07-19T15:04:58-04:00 New Revision: ca495e36c1b4d4b8be47c9140647e6e934913cba URL: https://github.com/llvm/llvm-project/commit/ca495e36c1b4d4b8be47c9140647e6e934913cba DIFF: https://github.com/llvm/llvm-project/commit/ca495e36c1b4d4b8be47c9140647e6e934913cba.diff

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd updated this revision to Diff 445904. abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: abrachet, sstefan1, phosek, ormris. Enabled both "sarif" and "SARIF" as flag spellings. Repository: rG LLVM Githu

  1   2   >